[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

[Hristo Hristov via Phabricator via cfe-commits]

Zingam added a comment.

Is this going to land soon? There is a libc++ paper I'm interested in that 
relies on "deducing this" and I wonder if I should wait for "this" first before 
I start working on it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140828/new/

https://reviews.llvm.org/D140828

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

[Hristo Hristov via Phabricator via cfe-commits]

Zingam added a comment.

In D140828#4544438 , @cor3ntin wrote:

> In D140828#4544433 , @Zingam wrote:
>
>> Is this going to land soon? There is a libc++ paper I'm interested in that 
>> relies on "deducing this" and I wonder if I should wait for "this" first 
>> before I start working on it?
>
> Hard to tell. Maybe in the next few weeks depending on reviewers 
> availability. I'm curious, what paper is that?

Sounds great. Thank you. I've been eyeing at this paper - 
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2637r3.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140828/new/

https://reviews.llvm.org/D140828

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

[Hristo Hristov via Phabricator via cfe-commits]

roccoor added a comment.

Microsoft supports:

  [[gsl::suppress(bounds.3)]]

Clang requires:

  [[gsl::suppress("bounds.3")]]

Why is this inconsistency?

Here is an example from  CppCoreGuidelines

  [[suppress(bounds)]] char* raw_find(char* p, int n, char x)// find x in 
p[0]..p[n - 1]
  {
  // ...
  }


Repository:
  rL LLVM

https://reviews.llvm.org/D24886



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151627: [clang][c++20][NFC] `ComparisonCategoryType` - updated comment, removed `std:*_equality`

[Hristo Hristov via Phabricator via cfe-commits]

H-G-Hristov created this revision.
Herald added a project: All.
H-G-Hristov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

`weak_equality` and `strong_equality` are removed from the standard:

- https://wg21.link/P1959R0
- https://eel.is/c++draft/cmp.categories.pre


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151627

Files:
  clang/include/clang/AST/ComparisonCategories.h


Index: clang/include/clang/AST/ComparisonCategories.h
===
--- clang/include/clang/AST/ComparisonCategories.h
+++ clang/include/clang/AST/ComparisonCategories.h
@@ -39,9 +39,8 @@
 /// An enumeration representing the different comparison categories
 /// types.
 ///
-/// C++2a [cmp.categories.pre] The types weak_equality, strong_equality,
-/// partial_ordering, weak_ordering, and strong_ordering are collectively
-/// termed the comparison category types.
+/// C++20 [cmp.categories.pre] The types partial_ordering, weak_ordering, and
+/// strong_ordering are collectively termed the comparison category types.
 enum class ComparisonCategoryType : unsigned char {
   PartialOrdering,
   WeakOrdering,


Index: clang/include/clang/AST/ComparisonCategories.h
===
--- clang/include/clang/AST/ComparisonCategories.h
+++ clang/include/clang/AST/ComparisonCategories.h
@@ -39,9 +39,8 @@
 /// An enumeration representing the different comparison categories
 /// types.
 ///
-/// C++2a [cmp.categories.pre] The types weak_equality, strong_equality,
-/// partial_ordering, weak_ordering, and strong_ordering are collectively
-/// termed the comparison category types.
+/// C++20 [cmp.categories.pre] The types partial_ordering, weak_ordering, and
+/// strong_ordering are collectively termed the comparison category types.
 enum class ComparisonCategoryType : unsigned char {
   PartialOrdering,
   WeakOrdering,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

[Hristo Hristov via Phabricator via cfe-commits]

H-G-Hristov added inline comments.



Comment at: clang/unittests/Format/FormatTest.cpp:25716
+   "int param2,\n"
+   "int param3);\n",
+   Style);

Does this work with `BAS_BlockIndent`? I don't see any related tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125171/new/

https://reviews.llvm.org/D125171

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151627: [clang][c++20][NFC] `ComparisonCategoryType` - updated comment, removed `std:*_equality`

[Hristo Hristov via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGfb250b8295b9: [clang][c++20][NFC] `ComparisonCategoryType` - 
updated comment, removed `std… (authored by Zingam).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151627/new/

https://reviews.llvm.org/D151627

Files:
  clang/include/clang/AST/ComparisonCategories.h


Index: clang/include/clang/AST/ComparisonCategories.h
===
--- clang/include/clang/AST/ComparisonCategories.h
+++ clang/include/clang/AST/ComparisonCategories.h
@@ -39,9 +39,8 @@
 /// An enumeration representing the different comparison categories
 /// types.
 ///
-/// C++2a [cmp.categories.pre] The types weak_equality, strong_equality,
-/// partial_ordering, weak_ordering, and strong_ordering are collectively
-/// termed the comparison category types.
+/// C++20 [cmp.categories.pre] The types partial_ordering, weak_ordering, and
+/// strong_ordering are collectively termed the comparison category types.
 enum class ComparisonCategoryType : unsigned char {
   PartialOrdering,
   WeakOrdering,


Index: clang/include/clang/AST/ComparisonCategories.h
===
--- clang/include/clang/AST/ComparisonCategories.h
+++ clang/include/clang/AST/ComparisonCategories.h
@@ -39,9 +39,8 @@
 /// An enumeration representing the different comparison categories
 /// types.
 ///
-/// C++2a [cmp.categories.pre] The types weak_equality, strong_equality,
-/// partial_ordering, weak_ordering, and strong_ordering are collectively
-/// termed the comparison category types.
+/// C++20 [cmp.categories.pre] The types partial_ordering, weak_ordering, and
+/// strong_ordering are collectively termed the comparison category types.
 enum class ComparisonCategoryType : unsigned char {
   PartialOrdering,
   WeakOrdering,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150321: [clang] Document extensions from later standards

[Hristo Hristov via Phabricator via cfe-commits]

H-G-Hristov added inline comments.



Comment at: clang/docs/LanguageExtensions.rst:1398
+``static operator()``   __cpp_static_call_operator   C++23 
C++03
+Strucuted bindings  __cpp_structured_bindingsC++17 
C++03
+template template arguments __cpp_template_template_args C++17 
C++03




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150321/new/

https://reviews.llvm.org/D150321

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits