[PATCH] D84591: Replace comment by private method

[Hannes Käufler via Phabricator via cfe-commits]

hanneskaeufler created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The comment is better served with a small private
method, helping scannability of the code and
hiding irrelevant details about the private members.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84591

Files:
  clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp


Index: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
===
--- clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
+++ clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
@@ -123,12 +123,7 @@
 
 // Emit warnings for headers that are missing guards.
 checkGuardlessHeaders();
-
-// Clear all state.
-Macros.clear();
-Files.clear();
-Ifndefs.clear();
-EndIfs.clear();
+clearAllState();
   }
 
   bool wouldFixEndifComment(StringRef FileName, SourceLocation EndIf,
@@ -255,6 +250,13 @@
   }
 
 private:
+  clearAllState() {
+Macros.clear();
+Files.clear();
+Ifndefs.clear();
+EndIfs.clear();
+  }
+
   std::vector> Macros;
   llvm::StringMap Files;
   std::map>


Index: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
===
--- clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
+++ clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
@@ -123,12 +123,7 @@
 
 // Emit warnings for headers that are missing guards.
 checkGuardlessHeaders();
-
-// Clear all state.
-Macros.clear();
-Files.clear();
-Ifndefs.clear();
-EndIfs.clear();
+clearAllState();
   }
 
   bool wouldFixEndifComment(StringRef FileName, SourceLocation EndIf,
@@ -255,6 +250,13 @@
   }
 
 private:
+  clearAllState() {
+Macros.clear();
+Files.clear();
+Ifndefs.clear();
+EndIfs.clear();
+  }
+
   std::vector> Macros;
   llvm::StringMap Files;
   std::map>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84591: [clang-tidy] Replace comment by private method

[Hannes Käufler via Phabricator via cfe-commits]

hanneskaeufler updated this revision to Diff 280699.
hanneskaeufler added a comment.

Fix syntax error (add return type)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84591/new/

https://reviews.llvm.org/D84591

Files:
  clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp


Index: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
===
--- clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
+++ clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
@@ -123,12 +123,7 @@
 
 // Emit warnings for headers that are missing guards.
 checkGuardlessHeaders();
-
-// Clear all state.
-Macros.clear();
-Files.clear();
-Ifndefs.clear();
-EndIfs.clear();
+clearAllState();
   }
 
   bool wouldFixEndifComment(StringRef FileName, SourceLocation EndIf,
@@ -255,6 +250,13 @@
   }
 
 private:
+  void clearAllState() {
+Macros.clear();
+Files.clear();
+Ifndefs.clear();
+EndIfs.clear();
+  }
+
   std::vector> Macros;
   llvm::StringMap Files;
   std::map>


Index: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
===
--- clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
+++ clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp
@@ -123,12 +123,7 @@
 
 // Emit warnings for headers that are missing guards.
 checkGuardlessHeaders();
-
-// Clear all state.
-Macros.clear();
-Files.clear();
-Ifndefs.clear();
-EndIfs.clear();
+clearAllState();
   }
 
   bool wouldFixEndifComment(StringRef FileName, SourceLocation EndIf,
@@ -255,6 +250,13 @@
   }
 
 private:
+  void clearAllState() {
+Macros.clear();
+Files.clear();
+Ifndefs.clear();
+EndIfs.clear();
+  }
+
   std::vector> Macros;
   llvm::StringMap Files;
   std::map>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

[Hannes Käufler via Phabricator via cfe-commits]

hanneskaeufler added a comment.

In D84591#2174437 , @aaron.ballman 
wrote:

> LGTM!


Awesome, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84591/new/

https://reviews.llvm.org/D84591



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

[Hannes Käufler via Phabricator via cfe-commits]

hanneskaeufler added a comment.

In D84591#2174447 , @aaron.ballman 
wrote:

> In D84591#2174442 , @hanneskaeufler 
> wrote:
>
> > In D84591#2174437 , @aaron.ballman 
> > wrote:
> >
> > > LGTM!
> >
> >
> > Awesome, thanks!
>
>
> Do you need someone to commit on your behalf? If so, can you give me the name 
> and email address you'd like me to attribute the commit to (I've got `Hannes 
> Käufler `)?


Uh, yeah, I don't suppose I have commit rights. First time contributor here :) 
Name and E-Mail is correct!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84591/new/

https://reviews.llvm.org/D84591



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits