Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.
> > Unfortunately this trips up a variety of buildbots: > Platform REQUIRES added in r351360, please do revert & fix if this test is supposed to work elsewhere. Looks like the test fail just made it into the release-8.0.0 branch by a few commits. I think we'll need Jeremy's fix r351360 or/and any subsequent 'more correct' test updates (if required) to get check-all on the branch into a passing state. -Greg On Wed, 16 Jan 2019 at 17:49, Jeremy Morse via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Platform REQUIRES added in r351360, please do revert & fix if this test is > supposed to work elsewhere. > > -- > Thanks, > Jeremy > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] d4758d4 - Fix a spelling mistake in a couple of intrinsic description comments. NFC
Author: Greg Bedwell Date: 2019-10-27T09:42:14Z New Revision: d4758d4a8d842275f4319ae278808be0bcd2ede3 URL: https://github.com/llvm/llvm-project/commit/d4758d4a8d842275f4319ae278808be0bcd2ede3 DIFF: https://github.com/llvm/llvm-project/commit/d4758d4a8d842275f4319ae278808be0bcd2ede3.diff LOG: Fix a spelling mistake in a couple of intrinsic description comments. NFC Added: Modified: clang/lib/Headers/emmintrin.h Removed: diff --git a/clang/lib/Headers/emmintrin.h b/clang/lib/Headers/emmintrin.h index c8fefdfc792a..f98b7e75c220 100644 --- a/clang/lib/Headers/emmintrin.h +++ b/clang/lib/Headers/emmintrin.h @@ -2288,7 +2288,7 @@ _mm_adds_epu16(__m128i __a, __m128i __b) return (__m128i)__builtin_ia32_paddusw128((__v8hi)__a, (__v8hi)__b); } -/// Computes the rounded avarages of corresponding elements of two +/// Computes the rounded averages of corresponding elements of two ///128-bit unsigned [16 x i8] vectors, saving each result in the ///corresponding element of a 128-bit result vector of [16 x i8]. /// @@ -2308,7 +2308,7 @@ _mm_avg_epu8(__m128i __a, __m128i __b) return (__m128i)__builtin_ia32_pavgb128((__v16qi)__a, (__v16qi)__b); } -/// Computes the rounded avarages of corresponding elements of two +/// Computes the rounded averages of corresponding elements of two ///128-bit unsigned [8 x i16] vectors, saving each result in the ///corresponding element of a 128-bit result vector of [8 x i16]. /// ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [llvm-dev] LLVM buildmaster is back to work now but two builders remain OFF
> Two slaves remain off for now as they produce a lot of warnings and their log files are way too big. I think https://reviews.llvm.org/D40603 will fix this issue. -Greg On 28 November 2017 at 22:13, Galina Kistanova via llvm-dev < llvm-...@lists.llvm.org> wrote: > Hello everyone, > > LLVM buildmaster is back to work. > > Two slaves remain off for now as they produce a lot of warnings and their > log files are way too big. > > The next builds have full logs available. Hope this helps to fix this > issue: > > http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/8716 > http://lab.llvm.org:8011/builders/clang-with-thin-lto-windows/builds/2645 > > Thanks > > Galina > > ___ > LLVM Developers mailing list > llvm-...@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [llvm-dev] LLVM buildmaster is back to work now but two builders remain OFF
Hopefully these two should be good to re-enable as of r319330. -Greg On 29 November 2017 at 16:23, Greg Bedwell wrote: > > Two slaves remain off for now as they produce a lot of warnings and > their log files are way too big. > > I think https://reviews.llvm.org/D40603 will fix this issue. > > -Greg > > > On 28 November 2017 at 22:13, Galina Kistanova via llvm-dev < > llvm-...@lists.llvm.org> wrote: > >> Hello everyone, >> >> LLVM buildmaster is back to work. >> >> Two slaves remain off for now as they produce a lot of warnings and their >> log files are way too big. >> >> The next builds have full logs available. Hope this helps to fix this >> issue: >> >> http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/8716 >> http://lab.llvm.org:8011/builders/clang-with-thin-lto-windows/builds/2645 >> >> Thanks >> >> Galina >> >> ___ >> LLVM Developers mailing list >> llvm-...@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: r300001 - Revert r298824 & r298816, recommit r298742 & r298754
We're seeing the same assertion failing in our internal testing (I've not
bisected to a specific change yet though, but it seems likely it's the same
thing as in the log from the modules bot). Here's a reduced example that
triggers it:
$ cat 2.h
//
template struct Bravo {
void charlie(bool delta = false) {}
};
typedef Bravo echo;
echo foxtrot;
//
$ clang.exe -x c++-header 2.h
Assertion failed: !hasUninstantiatedDefaultArg() && "Default argument is
not yet instantiated!", file C:\llvm\tools\clang\lib\AST\Decl.cpp, line 2424
-Greg
On 12 April 2017 at 02:52, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Either this or your other ODR hash change seems to have broken the modules
> buildbot:
>
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-
> selfhost-modules-2/builds/6274/steps/compile.llvm.stage2/logs/stdio
>
> On 11 April 2017 at 15:32, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Tue Apr 11 17:32:03 2017
>> New Revision: 31
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
>> Log:
>> Revert r298824 & r298816, recommit r298742 & r298754
>>
>> r299989 fixes the underlying issue by waiting long enough to late parsed
>> arguments to be processed before doing an calculating the hash.
>>
>> r298742
>> [ODRHash] Add error messages for mismatched parameters in methods.
>>
>> r298754
>> [ODRHash] Add support for array and decayed types.
>>
>> Modified:
>> cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
>> cfe/trunk/lib/AST/ODRHash.cpp
>> cfe/trunk/lib/Serialization/ASTReader.cpp
>> cfe/trunk/test/Modules/odr_hash.cpp
>>
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/
>> Basic/DiagnosticSerializationKinds.td?rev=31&r1=30&
>> r2=31&view=diff
>>
>> ==
>> --- cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
>> (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td Tue
>> Apr 11 17:32:03 2017
>> @@ -146,7 +146,12 @@ def err_module_odr_violation_mismatch_de
>>"method %4 is %select{not static|static}5|"
>>"method %4 is %select{not volatile|volatile}5|"
>>"method %4 is %select{not const|const}5|"
>> - "method %4 is %select{not inline|inline}5}3">;
>> + "method %4 is %select{not inline|inline}5|"
>> + "method %4 that has %5 parameter%s5|"
>> + "method %4 with %ordinal5 parameter of type %6%select{| decayed from
>> %8}7|"
>> + "method %4 with %ordinal5 parameter named %6|"
>> + "method %4 with %ordinal5 parameter with %select{no |}6default
>> argument|"
>> + "method %4 with %ordinal5 parameter with default argument}3">;
>>
>> def note_module_odr_violation_mismatch_decl_diff : Note<"but in '%0'
>> found "
>>"%select{"
>> @@ -166,7 +171,12 @@ def note_module_odr_violation_mismatch_d
>>"method %2 is %select{not static|static}3|"
>>"method %2 is %select{not volatile|volatile}3|"
>>"method %2 is %select{not const|const}3|"
>> - "method %2 is %select{not inline|inline}3}1">;
>> + "method %2 is %select{not inline|inline}3|"
>> + "method %2 that has %3 parameter%s3|"
>> + "method %2 with %ordinal3 parameter of type %4%select{| decayed from
>> %6}5|"
>> + "method %2 with %ordinal3 parameter named %4|"
>> + "method %2 with %ordinal3 parameter with %select{no |}4default
>> argument|"
>> + "method %2 with %ordinal3 parameter with different default
>> argument}1">;
>>
>> def warn_module_uses_date_time : Warning<
>>"%select{precompiled header|module}0 uses __DATE__ or __TIME__">,
>>
>> Modified: cfe/trunk/lib/AST/ODRHash.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ODRHas
>> h.cpp?rev=31&r1=30&r2=31&view=diff
>>
>> ==
>> --- cfe/trunk/lib/AST/ODRHash.cpp (original)
>> +++ cfe/trunk/lib/AST/ODRHash.cpp Tue Apr 11 17:32:03 2017
>> @@ -169,6 +169,11 @@ public:
>> Inherited::VisitValueDecl(D);
>>}
>>
>> + void VisitParmVarDecl(const ParmVarDecl *D) {
>> +AddStmt(D->getDefaultArg());
>> +Inherited::VisitParmVarDecl(D);
>> + }
>> +
>>void VisitAccessSpecDecl(const AccessSpecDecl *D) {
>> ID.AddInteger(D->getAccess());
>> Inherited::VisitAccessSpecDecl(D);
>> @@ -202,6 +207,12 @@ public:
>> Hash.AddBoolean(D->isPure());
>> Hash.AddBoolean(D->isDeletedAsWritten());
>>
>> +ID.AddInteger(D->param_size());
>> +
>> +for (auto *Param : D->parameters()) {
>> + Hash.AddSubDecl(Param);
>> +}
>> +
>> Inherited::VisitFunctionDecl(D);
>>}
>>
>> @@ -315,6 +326,14 @@ public:
>> }
>>}
>>
>> + void AddQualType(QualType T) {
>> +Hash.AddQualType(T);
>> + }
>> +
>> + void Visi
r248578 - Revert "This patch adds missing pieces to clang, including the PS4 toolchain definition, added warnings, PS4 defaults, and Driver changes needed for our compiler."
Author: gbedwell
Date: Fri Sep 25 11:11:00 2015
New Revision: 248578
URL: http://llvm.org/viewvc/llvm-project?rev=248578&view=rev
Log:
Revert "This patch adds missing pieces to clang, including the PS4 toolchain
definition, added warnings, PS4 defaults, and Driver changes needed for our
compiler."
This reverts commit r248546 to get our bot green again while we discuss the
best way forward.
Removed:
cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include/.keep
cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep
cfe/trunk/test/Driver/ps4-header-search.c
cfe/trunk/test/Driver/ps4-linker-non-win.c
cfe/trunk/test/Driver/ps4-pic.c
cfe/trunk/test/Driver/ps4-sdk-root.c
Modified:
cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/Driver/Tools.h
cfe/trunk/lib/Frontend/InitHeaderSearch.cpp
cfe/trunk/test/Driver/debug-options.c
cfe/trunk/test/Driver/rtti-options.cpp
cfe/trunk/test/Driver/stack-protector.c
Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td?rev=248578&r1=248577&r2=248578&view=diff
==
--- cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td Fri Sep 25 11:11:00
2015
@@ -192,18 +192,4 @@ def warn_target_unsupported_nan2008 : Wa
def warn_target_unsupported_nanlegacy : Warning<
"ignoring '-mnan=legacy' option because the '%0' architecture does not
support it">,
InGroup;
-
-def warn_drv_unable_to_find_directory_expected : Warning<
- "unable to find %0 directory, expected to be in '%1'">,
- InGroup;
-
-def warn_drv_ps4_force_pic : Warning<
- "option '%0' was ignored by the PS4 toolchain, using '-fPIC'">,
- InGroup;
-
-def warn_drv_ps4_sdk_dir : Warning<
- "environment variable SCE_PS4_SDK_DIR is set, but points to invalid or
nonexistent directory '%0'">,
- InGroup;
-
-def err_drv_unsupported_linker : Error<"unsupported value '%0' for -linker
option">;
}
Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=248578&r1=248577&r2=248578&view=diff
==
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Fri Sep 25 11:11:00 2015
@@ -820,7 +820,3 @@ def CudaCompat : DiagGroup<"cuda-compat"
// A warning group for things that will change semantics in the future.
def FutureCompat : DiagGroup<"future-compat">;
-
-def InvalidOrNonExistentDirectory :
DiagGroup<"invalid-or-nonexistent-directory">;
-
-def OptionIgnored : DiagGroup<"option-ignored">;
Modified: cfe/trunk/lib/Driver/Driver.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=248578&r1=248577&r2=248578&view=diff
==
--- cfe/trunk/lib/Driver/Driver.cpp (original)
+++ cfe/trunk/lib/Driver/Driver.cpp Fri Sep 25 11:11:00 2015
@@ -2254,9 +2254,6 @@ const ToolChain &Driver::getToolChain(co
case llvm::Triple::CUDA:
TC = new toolchains::CudaToolChain(*this, Target, Args);
break;
-case llvm::Triple::PS4:
- TC = new toolchains::PS4CPU(*this, Target, Args);
- break;
default:
// Of these targets, Hexagon is the only one that might have
// an OS of Linux, in which case it got handled above already.
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=248578&r1=248577&r2=248578&view=diff
==
--- cfe/trunk/lib/Driver/ToolChains.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains.cpp Fri Sep 25 11:11:00 2015
@@ -4065,69 +4065,3 @@ void WebAssembly::addClangTargetOptions(
options::OPT_fno_use_init_array, true))
CC1Args.push_back("-fuse-init-array");
}
-
-PS4CPU::PS4CPU(const Driver &D, const llvm::Triple &Triple, const ArgList
&Args)
-: Generic_ELF(D, Triple, Args) {
- if (Args.hasArg(options::OPT_static))
-D.Diag(diag::err_drv_unsupported_opt_for_target) << "-static" << "PS4";
-
- // Determine where to find the PS4 libraries. We use SCE_PS4_SDK_DIR
- // if it exists; otherwise use the driver's installation path, which
- // should be /host_tools/bin.
- const char *EnvValue = getenv("SCE_PS4_SDK_DIR");
- if (EnvValue && !llvm::sys::fs::exists(EnvValue))
-getDriver().Diag(clang::diag::warn_drv_ps4_sdk_dir) << EnvValue;
-
-
Re: r248546 - This patch adds missing pieces to clang, including the PS4 toolchain
Temporarily reverted in r248578 until we have implemented a solution for the failure on the llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast bot. On 24 September 2015 at 23:06, Ekaterina Romanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kromanova > Date: Thu Sep 24 17:06:52 2015 > New Revision: 248546 > > URL: http://llvm.org/viewvc/llvm-project?rev=248546&view=rev > Log: > This patch adds missing pieces to clang, including the PS4 toolchain > definition, added warnings, PS4 defaults, and Driver changes needed for > our compiler. > > A patch by Filipe Cabecinhas, Pierre Gousseau and Katya Romanova! > > Differential Revision: http://reviews.llvm.org/D11279 > > > Added: > cfe/trunk/test/Driver/Inputs/scei-ps4_tree/ > cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/ > cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include/ > cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include/.keep > cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include_common/ > cfe/trunk/test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep > cfe/trunk/test/Driver/ps4-header-search.c > cfe/trunk/test/Driver/ps4-linker-non-win.c > cfe/trunk/test/Driver/ps4-linker-win.c > cfe/trunk/test/Driver/ps4-pic.c > cfe/trunk/test/Driver/ps4-sdk-root.c > Modified: > cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td > cfe/trunk/include/clang/Basic/DiagnosticGroups.td > cfe/trunk/lib/Driver/Driver.cpp > cfe/trunk/lib/Driver/ToolChains.cpp > cfe/trunk/lib/Driver/ToolChains.h > cfe/trunk/lib/Driver/Tools.cpp > cfe/trunk/lib/Driver/Tools.h > cfe/trunk/lib/Frontend/InitHeaderSearch.cpp > cfe/trunk/test/Driver/debug-options.c > cfe/trunk/test/Driver/rtti-options.cpp > cfe/trunk/test/Driver/stack-protector.c > > Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td?rev=248546&r1=248545&r2=248546&view=diff > > == > --- cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td (original) > +++ cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td Thu Sep 24 > 17:06:52 2015 > @@ -192,4 +192,18 @@ def warn_target_unsupported_nan2008 : Wa > def warn_target_unsupported_nanlegacy : Warning< >"ignoring '-mnan=legacy' option because the '%0' architecture does not > support it">, >InGroup; > + > +def warn_drv_unable_to_find_directory_expected : Warning< > + "unable to find %0 directory, expected to be in '%1'">, > + InGroup; > + > +def warn_drv_ps4_force_pic : Warning< > + "option '%0' was ignored by the PS4 toolchain, using '-fPIC'">, > + InGroup; > + > +def warn_drv_ps4_sdk_dir : Warning< > + "environment variable SCE_PS4_SDK_DIR is set, but points to invalid or > nonexistent directory '%0'">, > + InGroup; > + > +def err_drv_unsupported_linker : Error<"unsupported value '%0' for > -linker option">; > } > > Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=248546&r1=248545&r2=248546&view=diff > > == > --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original) > +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Thu Sep 24 17:06:52 > 2015 > @@ -820,3 +820,7 @@ def CudaCompat : DiagGroup<"cuda-compat" > > // A warning group for things that will change semantics in the future. > def FutureCompat : DiagGroup<"future-compat">; > + > +def InvalidOrNonExistentDirectory : > DiagGroup<"invalid-or-nonexistent-directory">; > + > +def OptionIgnored : DiagGroup<"option-ignored">; > > Modified: cfe/trunk/lib/Driver/Driver.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=248546&r1=248545&r2=248546&view=diff > > == > --- cfe/trunk/lib/Driver/Driver.cpp (original) > +++ cfe/trunk/lib/Driver/Driver.cpp Thu Sep 24 17:06:52 2015 > @@ -2254,6 +2254,9 @@ const ToolChain &Driver::getToolChain(co > case llvm::Triple::CUDA: >TC = new toolchains::CudaToolChain(*this, Target, Args); >break; > +case llvm::Triple::PS4: > + TC = new toolchains::PS4CPU(*this, Target, Args); > + break; > default: >// Of these targets, Hexagon is the only one that might have >// an OS of Linux, in which case it got handled above already. > > Modified: cfe/trunk/lib/Driver/ToolChains.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=248546&r1=248545&r2=248546&view=diff > > == > --- cfe/trunk/lib/Driver/ToolChains.cpp (original) > +++ cfe/trunk/lib/Driver/ToolChains.cpp Thu Sep 24 17:06:52 2015 > @@ -4065,3 +4065,69 @@ void
[PATCH] D12368: Add a clang release note about raising the minimum Windows version for the next major release
gbedwell created this revision. gbedwell added reviewers: hans, rnk, aaron.ballman. gbedwell added a subscriber: cfe-commits. This is a clang release note to match the LLVM release note in D12367. As we're planning on raising the minimum Windows version to Windows 7 for LLVM 3.8 as per this discussion (there have been no objections I'm aware of so far even after advertising the discussion in LLVM weekly): http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-July/087993.html I'd like to add a release note to mention this fact. http://reviews.llvm.org/D12368 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@ -243,6 +243,12 @@ boolean constants and simplifies them to use the appropriate boolean expression directly (``if (x == true) ... -> if (x)``, etc.) +Last release which will run on Windows XP and Windows Vista +--- + +This is expected to the be the last major release of Clang that will support +running on Windows XP and Windows Vista. For the next major release the +minimum Windows version requirement will be Windows 7. Additional Information == Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@ -243,6 +243,12 @@ boolean constants and simplifies them to use the appropriate boolean expression directly (``if (x == true) ... -> if (x)``, etc.) +Last release which will run on Windows XP and Windows Vista +--- + +This is expected to the be the last major release of Clang that will support +running on Windows XP and Windows Vista. For the next major release the +minimum Windows version requirement will be Windows 7. Additional Information == ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12368: Add a clang release note about raising the minimum Windows version for the next major release
gbedwell added a comment. In http://reviews.llvm.org/D12368#233680, @hans wrote: > Committed in r246090. Thanks! Repository: rL LLVM http://reviews.llvm.org/D12368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D14583: Report Windows error code in a fatal error after a system call
gbedwell added a subscriber: gbedwell. gbedwell added a comment. > > Also, I am really curious to know why CryptAcquireContext fails in those > > cases! > > > Me too. Once is a fluke, twice is a trend. Probably some obscure > system-resource problem but it would be nice to be sure. I'm out of the office this week, so can't test, but I'm pretty sure you can reproduce this by spawning clang in an environment where the SYSTEMROOT environment variable has not been propagated (or by running it from a cmd window after typing "set SYSTEMROOT=". http://reviews.llvm.org/D14583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)
gbedwell added a subscriber: gbedwell. gbedwell added a comment. In http://reviews.llvm.org/D17550#360177, @probinson wrote: > One question I have, which shouldn't block this (as we've done several like > this already): > Is is okay to be using C++ style comments in these headers? > (Is there a C-style comment that Doxygen recognizes?) There are a few various formats that Doxygen supports. Looking at headers from llvm-c the most common convention appears to be JavaDoc style, although there are a few examples of other supported styles floating around the codebase. E.g. from include/llvm-c/lto.h using JavaDoc style: /** - Diagnostic handler type. - \p severity defines the severity. - \p diag is the actual diagnostic. - The diagnostic is not prefixed by any of severity keyword, e.g., 'error: '. - \p ctxt is used to pass the context set with the diagnostic handler. * - \since LTO_API_VERSION=7 */ -Greg Repository: rL LLVM http://reviews.llvm.org/D17550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
