[PATCH] D130822: Fixed loads of typos
GabrielRavier added a comment. Well, I assumed if I split it up per project I would have been told to merge all the patches into a big one to avoid having a bunch of small ones essentially all doing the same thing, but then again this also makes sense, I'll split it up. Comment at: flang/docs/Extensions.md:157 with each other. -* Values for whole anonymous parent components in structure constructors (e.g., `EXTENDEDTYPE(PARENTTYPE(1,2,3))` rather than `EXTENDEDTYPE(1,2,3)` clementval wrote: > This is just wrong I'll correct it in my per-project patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130822/new/ https://reviews.llvm.org/D130822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130826: [clang-tools-extra] Fixed a number of typos
GabrielRavier created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman, javed.absar, kbarton, nemanjai. Herald added a project: All. GabrielRavier requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. I went over the output of the following mess of a command: `(ulimit -m 200; ulimit -v 200; git ls-files -z | parallel --xargs -0 cat | aspell list --mode=none --ignore-case | grep -E '^[A-Za-z][a-z]*$' | sort | uniq -c | sort -n | grep -vE '.{25}' | aspell pipe -W3 | grep : | cut -d' ' -f2 | less)` and proceeded to spend a few days looking at it to find probable typos and fixed a few hundred of them in all of the llvm project (note, the ones I found are not anywhere near all of them, but it seems like a good start). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130826 Files: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.h clang-tools-extra/clangd/CodeComplete.h clang-tools-extra/clangd/ConfigFragment.h clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/HeuristicResolver.cpp clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/SemanticHighlighting.cpp clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp clang-tools-extra/clangd/index/CanonicalIncludes.h clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp clang-tools-extra/clangd/unittests/XRefsTests.cpp clang-tools-extra/pseudo/gen/Main.cpp clang-tools-extra/pseudo/lib/cxx/cxx.bnf clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp Index: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp === --- clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp +++ clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/virtual-class-destructor.cpp @@ -143,7 +143,7 @@ // CHECK-FIXES: virtual ~PublicNonVirtualBaseClass() {} }; -class PublicNonVirtualNonBaseClass { // OK accoring to C.35, since this class does not have any virtual methods. +class PublicNonVirtualNonBaseClass { // OK according to C.35, since this class does not have any virtual methods. void f(); public: Index: clang-tools-extra/pseudo/lib/cxx/cxx.bnf === --- clang-tools-extra/pseudo/lib/cxx/cxx.bnf +++ clang-tools-extra/pseudo/lib/cxx/cxx.bnf @@ -1,7 +1,7 @@ # This is a C++ grammar from the C++ standard [1]. # # The grammar is a superset of the true grammar requring semantic constraints to -# resolve ambiguties. The grammar is context-free and ambiguous (beyond the +# resolve ambiguities. The grammar is context-free and ambiguous (beyond the # limit of LR(k)). We use general parsing algorithm (e.g GLR) to handle the # grammar and generate a transition table which is used to drive the parsing. # Index: clang-tools-extra/pseudo/gen/Main.cpp === --- clang-tools-extra/pseudo/gen/Main.cpp +++ clang-tools-extra/pseudo/gen/Main.cpp @@ -65,7 +65,7 @@ // Mangles a symbol name into a valid identifier. // // These follow names in the grammar fairly closely: -// nonterminal: `ptr-declartor` becomes `ptr_declarator`; +// nonterminal: `ptr-declarator` becomes `ptr_declarator`; // punctuator: `,` becomes `COMMA`; // keyword: `INT` becomes `INT`; // terminal: `IDENTIFIER` becomes `IDENTIFIER`; Index: clang-tools-extra/clangd/unittests/XRefsTests.cpp === --- clang-tools-extra/clangd/unittests/XRefsTests.cpp +++ clang-tools-extra/clangd/unittests/XRefsTests.cpp @@ -1801,7 +1801,7 @@ } } -TEST(FindImplementations, CaptureDefintion) { +TEST(FindImplementations, CaptureDefinition) { llvm::StringRef Test = R"cpp( struct Base { virtual void F^oo(); Index: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp === --- clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp +++ clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp @@ -1035,7 +1035,7 @@ // Starts handling the update action and blocks until the // first preamble is built. ASTAction::RunningAction, - // Afterwqards it builds an AST for that preamble to publish + // Afterwards it builds an AST for that preamble to publish // diagnostics. ASTAction::Building, // Then goes idle. Index: clang-tools-extra/clangd/index/CanonicalIncludes.h ===
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier created this revision. Herald added subscribers: steakhal, martong, arphaman, whisperity, mgorny. Herald added a reviewer: aaron.ballman. Herald added a reviewer: dang. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. GabrielRavier requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. I went over the output of the following mess of a command: `(ulimit -m 200; ulimit -v 200; git ls-files -z | parallel --xargs -0 cat | aspell list --mode=none --ignore-case | grep -E '^[A-Za-z][a-z]*$' | sort | uniq -c | sort -n | grep -vE '.{25}' | aspell pipe -W3 | grep : | cut -d' ' -f2 | less)` and proceeded to spend a few days looking at it to find probable typos and fixed a few hundred of them in all of the llvm project (note, the ones I found are not anywhere near all of them, but it seems like a good start). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130827 Files: clang/CMakeLists.txt clang/bindings/python/clang/cindex.py clang/cmake/caches/MultiDistributionExample.cmake clang/docs/ClangFormat.rst clang/docs/JSONCompilationDatabase.rst clang/docs/LanguageExtensions.rst clang/docs/analyzer/user-docs/CrossTranslationUnit.rst clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/Analysis/ConstructionContext.h clang/include/clang/Analysis/FlowSensitive/DataflowValues.h clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/BuiltinsVE.def clang/include/clang/Basic/JsonSupport.h clang/include/clang/Basic/SourceManager.h clang/include/clang/ExtractAPI/Serialization/SymbolGraphSerializer.h clang/include/clang/Lex/DependencyDirectivesScanner.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/Sema.h clang/include/clang/Serialization/ASTReader.h clang/include/clang/Serialization/SourceLocationEncoding.h clang/include/clang/StaticAnalyzer/Core/CheckerManager.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h clang/include/clang/Tooling/Core/Replacement.h clang/include/clang/Tooling/Syntax/Tree.h clang/lib/AST/ASTContext.cpp clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CrossTU/CrossTranslationUnit.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineParser.h clang/lib/Frontend/Rewrite/RewriteModernObjC.cpp clang/lib/Headers/arm_acle.h clang/lib/Headers/opencl-c.h clang/lib/Lex/Lexer.cpp clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaCodeComplete.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclAttr.cpp clang/lib/Sema/SemaDeclObjC.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/lib/Tooling/AllTUsExecution.cpp clang/lib/Tooling/Core/Replacement.cpp clang/lib/Tooling/Syntax/Tokens.cpp clang/test/CMakeLists.txt clang/test/CodeGen/vectorcall.c clang/test/CodeGenCXX/target-features-error.cpp clang/test/Interpreter/code-undo.cpp clang/test/Interpreter/execute-weak.cpp clang/test/Interpreter/execute.cpp clang/test/Interpreter/global-dtor-win.cpp clang/test/Interpreter/global-dtor.cpp clang/test/Interpreter/lit.local.cfg clang/test/Interpreter/plugins.cpp clang/test/Interpreter/simple-exception.cpp clang/test/SemaCXX/builtin-align-cxx.cpp clang/test/SemaOpenCL/usm-address-spaces-conversions.cl clang/test/lit.cfg.py clang/tools/CMakeLists.txt clang/tools/clang-repl/ClangRepl.cpp clang/tools/clang-shlib/CMakeLists.txt clang/tools/include-mapping/gen_std.py clang/tools/scan-build-py/lib/libear/ear.c clang/unittests/AST/StructuralEquivalenceTest.cpp clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp clang/unittests/CMakeLists.txt clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp clang/unittests/Tooling/SourceCodeTest.cpp clang/utils/TableGen/NeonEmitter.cpp clang/utils/analyzer/SATest.py clang/utils/analyzer/exploded-graph-rewriter.py clang/www/analyzer/installation.html Index: clang/www/analyzer/installation.html === --- clang/www/analyzer/installation.html +++ clang/www/analyzer/installation.html @@ -58,7 +58,7 @@ scan-build: scan-build is the high-level command line utility for running the analyzer -scan-view: scan-view a companion comannd line +scan-view: scan-view a companion command line utility to scan-build, scan-view is used to view analysis results generated by scan-build. There is an option that one can pass to scan-build to cause scan-view to Index: clang/utils/analyzer/exploded-graph-rewriter.py === --- cla
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier added a comment. Ooh yeah looks like there's some damage. Shouldn't have done this at 12:30 AM without looking at what that `git rebase` on the latest pull ended up doing... I'll go fix this asap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier added inline comments. Comment at: clang/lib/Headers/opencl-c.h:17856 +intel_sub_group_avc_sic_payload_t __ovld intel_sub_group_avc_sic_configure_ipe( +uchar luma_intra_partition_mask, uchar intra_neighbour_availability, uchar left_edge_luma_pixels, uchar upper_left_corner_luma_pixel, junaire wrote: > Not sure if we want to format this... Well, it is what clang-format did, so I don't really know... Is it also legacy code as mentioned above ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier updated this revision to Diff 448850. GabrielRavier added a comment. Fixed it so that it doesn't accidentally revert all the changes made since my original diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 Files: clang/bindings/python/clang/cindex.py clang/cmake/caches/MultiDistributionExample.cmake clang/docs/ClangFormat.rst clang/docs/JSONCompilationDatabase.rst clang/docs/LanguageExtensions.rst clang/docs/analyzer/user-docs/CrossTranslationUnit.rst clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/Analysis/ConstructionContext.h clang/include/clang/Analysis/FlowSensitive/DataflowValues.h clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/BuiltinsVE.def clang/include/clang/Basic/SourceManager.h clang/include/clang/ExtractAPI/Serialization/SymbolGraphSerializer.h clang/include/clang/Lex/DependencyDirectivesScanner.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/Sema.h clang/include/clang/Serialization/ASTReader.h clang/include/clang/Serialization/SourceLocationEncoding.h clang/include/clang/StaticAnalyzer/Core/CheckerManager.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h clang/include/clang/Tooling/Core/Replacement.h clang/include/clang/Tooling/Syntax/Tree.h clang/lib/AST/ASTContext.cpp clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CrossTU/CrossTranslationUnit.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp clang/lib/Format/UnwrappedLineParser.h clang/lib/Frontend/Rewrite/RewriteModernObjC.cpp clang/lib/Headers/arm_acle.h clang/lib/Headers/opencl-c.h clang/lib/Lex/Lexer.cpp clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaCodeComplete.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclObjC.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/lib/Tooling/AllTUsExecution.cpp clang/lib/Tooling/Core/Replacement.cpp clang/lib/Tooling/Syntax/Tokens.cpp clang/test/CodeGen/vectorcall.c clang/test/CodeGenCXX/target-features-error.cpp clang/test/SemaCXX/builtin-align-cxx.cpp clang/test/SemaOpenCL/usm-address-spaces-conversions.cl clang/tools/clang-shlib/CMakeLists.txt clang/tools/include-mapping/gen_std.py clang/tools/scan-build-py/lib/libear/ear.c clang/unittests/AST/StructuralEquivalenceTest.cpp clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp clang/unittests/Tooling/SourceCodeTest.cpp clang/utils/TableGen/NeonEmitter.cpp clang/utils/analyzer/SATest.py clang/utils/analyzer/exploded-graph-rewriter.py clang/www/analyzer/installation.html Index: clang/www/analyzer/installation.html === --- clang/www/analyzer/installation.html +++ clang/www/analyzer/installation.html @@ -58,7 +58,7 @@ scan-build: scan-build is the high-level command line utility for running the analyzer -scan-view: scan-view a companion comannd line +scan-view: scan-view a companion command line utility to scan-build, scan-view is used to view analysis results generated by scan-build. There is an option that one can pass to scan-build to cause scan-view to Index: clang/utils/analyzer/exploded-graph-rewriter.py === --- clang/utils/analyzer/exploded-graph-rewriter.py +++ clang/utils/analyzer/exploded-graph-rewriter.py @@ -388,7 +388,7 @@ # Also on Windows macros __FILE__ produces specific delimiters `\` # and a directory or file may starts with the letter `l`. # Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, -# because the literal as a rule containes multiple `\` before `\l`. +# because the literal as a rule contains multiple `\` before `\l`. node_label = re.sub(r'(? 1) Index: clang/unittests/Tooling/SourceCodeTest.cpp === --- clang/unittests/Tooling/SourceCodeTest.cpp +++ clang/unittests/Tooling/SourceCodeTest.cpp @@ -255,7 +255,7 @@ Visitor.runOverAnnotated(R"cpp( #define ATTR __attribute__((deprecated("message"))) $r[[ATTR - // Commment. + // Comment. int x;]])cpp"); } @@ -410,7 +410,7 @@ Visit(R"cpp( #define ATTR __attribute__((deprecated("message"))) $r[[ATTR - // Commment. + // Comment. int x;]])cpp"); } Index: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp === --- clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp +++ clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp @@ -655,7 +65
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult &SrcExpr, bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining = QualType(), junaire wrote: > Normally we don't clang-format legacy code like this, as it's bad for git > blame. I've undone the clang-formatting on this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130841: [clang] Fixed a number of typos
GabrielRavier created this revision. Herald added subscribers: steakhal, martong, arphaman, whisperity, mgorny. Herald added a reviewer: aaron.ballman. Herald added a reviewer: dang. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. GabrielRavier requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. I went over the output of the following mess of a command: `(ulimit -m 200; ulimit -v 200; git ls-files -z | parallel --xargs -0 cat | aspell list --mode=none --ignore-case | grep -E '^[A-Za-z][a-z]*$' | sort | uniq -c | sort -n | grep -vE '.{25}' | aspell pipe -W3 | grep : | cut -d' ' -f2 | less)` and proceeded to spend a few days looking at it to find probable typos and fixed a few hundred of them in all of the llvm project (note, the ones I found are not anywhere near all of them, but it seems like a good start). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130841 Files: clang/bindings/python/clang/cindex.py clang/cmake/caches/MultiDistributionExample.cmake clang/docs/ClangFormat.rst clang/docs/JSONCompilationDatabase.rst clang/docs/LanguageExtensions.rst clang/docs/analyzer/user-docs/CrossTranslationUnit.rst clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/Analysis/ConstructionContext.h clang/include/clang/Analysis/FlowSensitive/DataflowValues.h clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/BuiltinsVE.def clang/include/clang/Basic/SourceManager.h clang/include/clang/ExtractAPI/Serialization/SymbolGraphSerializer.h clang/include/clang/Lex/DependencyDirectivesScanner.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/Sema.h clang/include/clang/Serialization/ASTReader.h clang/include/clang/Serialization/SourceLocationEncoding.h clang/include/clang/StaticAnalyzer/Core/CheckerManager.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h clang/include/clang/Tooling/Core/Replacement.h clang/include/clang/Tooling/Syntax/Tree.h clang/lib/AST/ASTContext.cpp clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CrossTU/CrossTranslationUnit.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp clang/lib/Format/UnwrappedLineParser.h clang/lib/Frontend/Rewrite/RewriteModernObjC.cpp clang/lib/Headers/arm_acle.h clang/lib/Headers/opencl-c.h clang/lib/Lex/Lexer.cpp clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaCodeComplete.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclObjC.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/lib/Tooling/AllTUsExecution.cpp clang/lib/Tooling/Core/Replacement.cpp clang/lib/Tooling/Syntax/Tokens.cpp clang/test/CodeGen/vectorcall.c clang/test/CodeGenCXX/target-features-error.cpp clang/test/SemaCXX/builtin-align-cxx.cpp clang/test/SemaOpenCL/usm-address-spaces-conversions.cl clang/tools/clang-shlib/CMakeLists.txt clang/tools/include-mapping/gen_std.py clang/tools/scan-build-py/lib/libear/ear.c clang/unittests/AST/StructuralEquivalenceTest.cpp clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp clang/unittests/Tooling/SourceCodeTest.cpp clang/utils/TableGen/NeonEmitter.cpp clang/utils/analyzer/SATest.py clang/utils/analyzer/exploded-graph-rewriter.py clang/www/analyzer/installation.html Index: clang/www/analyzer/installation.html === --- clang/www/analyzer/installation.html +++ clang/www/analyzer/installation.html @@ -58,7 +58,7 @@ scan-build: scan-build is the high-level command line utility for running the analyzer -scan-view: scan-view a companion comannd line +scan-view: scan-view a companion command line utility to scan-build, scan-view is used to view analysis results generated by scan-build. There is an option that one can pass to scan-build to cause scan-view to Index: clang/utils/analyzer/exploded-graph-rewriter.py === --- clang/utils/analyzer/exploded-graph-rewriter.py +++ clang/utils/analyzer/exploded-graph-rewriter.py @@ -388,7 +388,7 @@ # Also on Windows macros __FILE__ produces specific delimiters `\` # and a directory or file may starts with the letter `l`. # Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, -# because the literal as a rule containes multiple `\` before `\l`. +# because the literal as a rule contains multiple `\` before `\l`. node_label = re.sub(r'(? 1) Index: clang/unittests/Tooling/SourceCodeTest.cpp === --- clang/unittests/Tool
[PATCH] D130841: [clang] Fixed a number of typos
GabrielRavier abandoned this revision. GabrielRavier added a comment. Nvm I'm an idiot I thought this would update https://reviews.llvm.org/D130827 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130841/new/ https://reviews.llvm.org/D130841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier updated this revision to Diff 448858. GabrielRavier added a comment. Reverted reversion of `git clang-format` on `clang/include/clang/Sema/Sema.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 Files: clang/bindings/python/clang/cindex.py clang/cmake/caches/MultiDistributionExample.cmake clang/docs/ClangFormat.rst clang/docs/JSONCompilationDatabase.rst clang/docs/LanguageExtensions.rst clang/docs/analyzer/user-docs/CrossTranslationUnit.rst clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/Analysis/ConstructionContext.h clang/include/clang/Analysis/FlowSensitive/DataflowValues.h clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/BuiltinsVE.def clang/include/clang/Basic/SourceManager.h clang/include/clang/ExtractAPI/Serialization/SymbolGraphSerializer.h clang/include/clang/Lex/DependencyDirectivesScanner.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/Sema.h clang/include/clang/Serialization/ASTReader.h clang/include/clang/Serialization/SourceLocationEncoding.h clang/include/clang/StaticAnalyzer/Core/CheckerManager.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h clang/include/clang/Tooling/Core/Replacement.h clang/include/clang/Tooling/Syntax/Tree.h clang/lib/AST/ASTContext.cpp clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CrossTU/CrossTranslationUnit.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp clang/lib/Format/UnwrappedLineParser.h clang/lib/Frontend/Rewrite/RewriteModernObjC.cpp clang/lib/Headers/arm_acle.h clang/lib/Headers/opencl-c.h clang/lib/Lex/Lexer.cpp clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaCodeComplete.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclObjC.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/lib/Tooling/AllTUsExecution.cpp clang/lib/Tooling/Core/Replacement.cpp clang/lib/Tooling/Syntax/Tokens.cpp clang/test/CodeGen/vectorcall.c clang/test/CodeGenCXX/target-features-error.cpp clang/test/SemaCXX/builtin-align-cxx.cpp clang/test/SemaOpenCL/usm-address-spaces-conversions.cl clang/tools/clang-shlib/CMakeLists.txt clang/tools/include-mapping/gen_std.py clang/tools/scan-build-py/lib/libear/ear.c clang/unittests/AST/StructuralEquivalenceTest.cpp clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp clang/unittests/Tooling/SourceCodeTest.cpp clang/utils/TableGen/NeonEmitter.cpp clang/utils/analyzer/SATest.py clang/utils/analyzer/exploded-graph-rewriter.py clang/www/analyzer/installation.html Index: clang/www/analyzer/installation.html === --- clang/www/analyzer/installation.html +++ clang/www/analyzer/installation.html @@ -58,7 +58,7 @@ scan-build: scan-build is the high-level command line utility for running the analyzer -scan-view: scan-view a companion comannd line +scan-view: scan-view a companion command line utility to scan-build, scan-view is used to view analysis results generated by scan-build. There is an option that one can pass to scan-build to cause scan-view to Index: clang/utils/analyzer/exploded-graph-rewriter.py === --- clang/utils/analyzer/exploded-graph-rewriter.py +++ clang/utils/analyzer/exploded-graph-rewriter.py @@ -388,7 +388,7 @@ # Also on Windows macros __FILE__ produces specific delimiters `\` # and a directory or file may starts with the letter `l`. # Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, -# because the literal as a rule containes multiple `\` before `\l`. +# because the literal as a rule contains multiple `\` before `\l`. node_label = re.sub(r'(? 1) Index: clang/unittests/Tooling/SourceCodeTest.cpp === --- clang/unittests/Tooling/SourceCodeTest.cpp +++ clang/unittests/Tooling/SourceCodeTest.cpp @@ -255,7 +255,7 @@ Visitor.runOverAnnotated(R"cpp( #define ATTR __attribute__((deprecated("message"))) $r[[ATTR - // Commment. + // Comment. int x;]])cpp"); } @@ -410,7 +410,7 @@ Visit(R"cpp( #define ATTR __attribute__((deprecated("message"))) $r[[ATTR - // Commment. + // Comment. int x;]])cpp"); } Index: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp === --- clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp +++ clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp @@ -655,7 +655,7 @@ CallFunctionF)); } - //
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult &SrcExpr, bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining = QualType(), junaire wrote: > GabrielRavier wrote: > > junaire wrote: > > > Normally we don't clang-format legacy code like this, as it's bad for git > > > blame. > > I've undone the clang-formatting on this > Oh, I'm sorry about it I think I missed something here. So basically if you > touched the code then format it is a good choice. I thought there was nothing > changed here but only formatting, that's something we usually want to avoid. I've un-undone the clang-formatting on this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130826: [clang-tools-extra] Fixed a number of typos
GabrielRavier added a comment. Well I'm pretty sure I don't have commit rights to LLVM and it seems landing means to push the revision onto main, so that would be nice, yes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130826/new/ https://reviews.llvm.org/D130826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D130827: [clang] Fixed a number of typos
GabrielRavier added a comment. > Do you need someone to land this on your behalf? Yes. > If so, what name and email address would you like used for patch attribution? `Gabriel Ravier`, `gabrav...@gmail.com` (By the way, is there any way to make this information part of my Phabricator account so that I don't need to repeat this every time I submit a patch ? The patch I made for `clang-tools-extra` got in with the right name/email pair just fine without me having to say anything, so I was assuming it was there somewhere...) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits