[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

2023-08-17 Thread Dmitry Chernenkov via Phabricator via cfe-commits
steelannelida added inline comments.



Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:16
+// causes a warning.
+// RUN:   %clang --target=x86_64-unknown-linux-gnu -nogpulib -nogpuinc \
+// RUN: --cuda-gpu-arch=sm_70 -x cuda -fsplit-machine-functions -S %s 2>&1 
\

Unfortunately these commands fail in our sandbox due to writing files to 
readonly directories:

 `unable to open output file 'fsplit-machine-functions-with-cuda-nvptx.s': 
'Permission denied'`

Could you please specify the output files via `%t` substitutions? I'm not sure 
how to do this for cuda compilation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157750/new/

https://reviews.llvm.org/D157750

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

2023-08-18 Thread Dmitry Chernenkov via Phabricator via cfe-commits
steelannelida added a comment.

Unfortunately the option -Wno-reserved-user-defined-literal fails after this:

  #define MYTHING "_something_"
  
  const char* f() {
return "ONE"MYTHING"TWO";
  }

  $ clang -Wno-reserved-user-defined-literal repro.cxx
  repro.cxx:4:15: error: no matching literal operator for call to 
'operator""MYTHING' with arguments of types 'const char *' and 'unsigned long', 
and no matching literal operator template
  4 |   return "ONE"MYTHING"TWO";
|   ^
  1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153156/new/

https://reviews.llvm.org/D153156

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits