Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation
dimitry added a subscriber: dimitry. Comment at: src/cxa_thread_atexit.cpp:46 @@ +45,3 @@ + pthread_key_delete(key_); +} + run_dtors() is called when/if libc++.so gets unloaded... but only for the thread calling dlclose()? http://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation
dimitry added inline comments. Comment at: src/cxa_thread_atexit.cpp:46 @@ +45,3 @@ + pthread_key_delete(key_); +} + bcraig wrote: > dimitry wrote: > > run_dtors() is called when/if libc++.so gets unloaded... but only for the > > thread calling dlclose()? > Most of the dtor magic is on the pthread_key_create side. pthreads lets you > register a per-thread destructor. > > This destructor is only run on process termination (I think). I meant the call from ~DtorListHolder() http://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D14858: Support building tsan on android.
dimitry added a subscriber: dimitry. dimitry added a comment. In http://reviews.llvm.org/D14858#294082, @eugenis wrote: > I vaguely recall that android runtime loader had some symbol lookup > differencies with glibc and that prevented interceptors (when statically > linked into the main executable) from working. Maybe it is not the case now. This is no longer the case... There should be no difference in symbol lookup order between glibc and android linker. If you find any - please let me know. :) http://reviews.llvm.org/D14858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D14858: Support building tsan on android.
dimitry added a comment. The only difference is that main executable group is not RTLD_GLOBAL in android (it is RTLD_GLOBAL in glibc) - so the symbols of DT_NEEDED libraries are not visible by default; the way to enforce this for you library on android is to use -z global ld option http://reviews.llvm.org/D14858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
