[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

[Chris Laplante via Phabricator via cfe-commits]

chris.laplante created this revision.
chris.laplante added a reviewer: krememek.
Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, 
dexonsmith, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a project: clang.

Current code assumes flags in CompilerLinkerOptionMap don't use =.


Repository:
  rC Clang

https://reviews.llvm.org/D66569

Files:
  clang/tools/scan-build/libexec/ccc-analyzer


Index: clang/tools/scan-build/libexec/ccc-analyzer
===
--- clang/tools/scan-build/libexec/ccc-analyzer
+++ clang/tools/scan-build/libexec/ccc-analyzer
@@ -498,7 +498,8 @@
 # Process the arguments.
 foreach (my $i = 0; $i < scalar(@ARGV); ++$i) {
   my $Arg = $ARGV[$i];
-  my ($ArgKey) = split /=/,$Arg,2;
+  my @ArgParts = split /=/,$Arg,2;
+  my $ArgKey = @ArgParts[0];
 
   # Be friendly to "" in the argument list.
   if (!defined($ArgKey)) {
@@ -566,10 +567,12 @@
 push @CompileOpts,$Arg;
 push @LinkOpts,$Arg;
 
-while ($Cnt > 0) {
-  ++$i; --$Cnt;
-  push @CompileOpts, $ARGV[$i];
-  push @LinkOpts, $ARGV[$i];
+if (scalar @ArgParts == 1) {
+  while ($Cnt > 0) {
+++$i; --$Cnt;
+push @CompileOpts, $ARGV[$i];
+push @LinkOpts, $ARGV[$i];
+  }
 }
 next;
   }


Index: clang/tools/scan-build/libexec/ccc-analyzer
===
--- clang/tools/scan-build/libexec/ccc-analyzer
+++ clang/tools/scan-build/libexec/ccc-analyzer
@@ -498,7 +498,8 @@
 # Process the arguments.
 foreach (my $i = 0; $i < scalar(@ARGV); ++$i) {
   my $Arg = $ARGV[$i];
-  my ($ArgKey) = split /=/,$Arg,2;
+  my @ArgParts = split /=/,$Arg,2;
+  my $ArgKey = @ArgParts[0];
 
   # Be friendly to "" in the argument list.
   if (!defined($ArgKey)) {
@@ -566,10 +567,12 @@
 push @CompileOpts,$Arg;
 push @LinkOpts,$Arg;
 
-while ($Cnt > 0) {
-  ++$i; --$Cnt;
-  push @CompileOpts, $ARGV[$i];
-  push @LinkOpts, $ARGV[$i];
+if (scalar @ArgParts == 1) {
+  while ($Cnt > 0) {
+++$i; --$Cnt;
+push @CompileOpts, $ARGV[$i];
+push @LinkOpts, $ARGV[$i];
+  }
 }
 next;
   }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

[Chris Laplante via Phabricator via cfe-commits]

chris.laplante added a comment.

I encountered this issue when trying to integrate scan-build with CMake in a 
cross-compiling environment.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66569/new/

https://reviews.llvm.org/D66569



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

[Chris Laplante via Phabricator via cfe-commits]

chris.laplante added a comment.

Ping?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66569/new/

https://reviews.llvm.org/D66569



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

[Chris Laplante via Phabricator via cfe-commits]

chris.laplante added a comment.

In D66569#1658413 , @NoQ wrote:

> I wish i had time to fix D55683  so that i 
> could have you write tests for it :)


I just subscribed to it, so if/when you do, I'll add some tests :)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66569/new/

https://reviews.llvm.org/D66569



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

[Chris Laplante via Phabricator via cfe-commits]

chris.laplante added a comment.

Correct, no access so please commit for me. This is my first contribution.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66569/new/

https://reviews.llvm.org/D66569



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits