[PATCH] D95017: [clang-format] Add case aware include sorting.

[Chris Johnson via Phabricator via cfe-commits]

PragmaNull added a comment.

I find the naming of the case sensitive options confusing here. 
When I read "CaseSensitive" I think of the behavior of strcmp() which sorts 
according to "ASCIIbetical" order. But here "CaseSensitive" throws away case by 
comparing the result of "Filename.lower()" which I would consider 
case-insensitive, or the same behavior as a call to stricmp().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95017/new/

https://reviews.llvm.org/D95017

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D95017: [clang-format] Add case aware include sorting.

[Chris Johnson via Phabricator via cfe-commits]

PragmaNull added a comment.

In D95017#2572238 , @curdeius wrote:

> Do you have an idea for better names?
> I see that e.g. MS documentation uses ascending order and case-sensitive 
> order.

I'm okay with the names, it just seems to me that they are reversed, where 
CaseSensitive should sort using ASCIIbetic order, and CaseInsensitive should 
ignore case entirely in the same way that most case-insensitive string compares 
would.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95017/new/

https://reviews.llvm.org/D95017

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D95017: [clang-format] Add case aware include sorting.

[Chris Johnson via Phabricator via cfe-commits]

PragmaNull added a comment.

In D95017#2595230 , 
@HazardyKnusperkeks wrote:

> 



> Do you make a change? Otherwise I will do, but that will take some time, 
> because I'm rather busy.

Sorry, I have not; unfortunately I've been rather busy myself and haven't had a 
moment to get on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95017/new/

https://reviews.llvm.org/D95017

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97927: [clang-format] Rename case sorting

[Chris Johnson via Phabricator via cfe-commits]

PragmaNull accepted this revision.
PragmaNull added a comment.

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97927/new/

https://reviews.llvm.org/D97927

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits