[flang] [clang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)
everythingfunctional wrote: Not that it's the end of the world if this doesn't get in before the this release, but @sscalpone , exactly what feedback are we wanting before merging? https://github.com/llvm/llvm-project/pull/74377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[flang] [clang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)
everythingfunctional wrote: > > Not that it's the end of the world if this doesn't get in before the this > > release, but @sscalpone , exactly what feedback are we wanting before > > merging? > > IIUC, this: > https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462/55 ok, but is there some threshold of percent that pass, or a specific list that we want to be sure pass? My understanding is that we've been running (at least a subset of) the gfortran test suite for a while now. What makes the current results not sufficient? https://github.com/llvm/llvm-project/pull/74377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From c19e89f7358dc638687be4da8f5a51cb483b3637 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/7] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index f24e25879b96bd..1cde628d3f66c3 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 90f0c4f2df2130..8fb9edd7a2a927 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
@@ -787,6 +787,9 @@ void Flang::ConstructJob(Compilation &C, const JobAction &JA, if (Args.hasArg(options::OPT_fopenmp_force_usm)) CmdArgs.push_back("-fopenmp-force-usm"); + // TODO: OpenMP support isn't "done" yet, so for now we warn that it + // is experimental. + D.Diag(diag::warn_openmp_experimental); everythingfunctional wrote: While I was slightly hesitant to add a test for a temporary warning, I've done so. If anyone else thinks it doesn't belong I'll undo it. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/5] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index 925912df6843e4..6073ebac9e6c2c 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 932cf13edab53d..4a45a825da8fa1 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
@@ -339,11 +335,11 @@ just added using your new frontend option. ## CMake Support As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246) -(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a +(and soon to be released CMake 3.24.0), `cmake` can detect `flang` as a everythingfunctional wrote: So, sounds like support is there in CMake, so I've updated the note and the identified version. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/7] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index 925912df6843e4..6073ebac9e6c2c 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 932cf13edab53d..4a45a825da8fa1 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: @klausler , can you point me specifically at the failure messages? The failures I've seen so far from the merge did not look related to my (admittedly untrained) eye. I ran the tests in the repo and they passed locally. Are there other tests somewhere that need to be updated as well? https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: > @everythingfunctional Following are the steps to run the testsuite. Please > check and confirm if you did not run it before. > > ``` > git clone https://github.com/llvm/llvm-test-suite.git > cd llvm-test-suite > mkdir build > cd build > cmake -DCMAKE_BUILD_TYPE=Release > -DCMAKE_C_COMPILER=$HOME/llvm-project/build_release/bin/clang > -DCMAKE_CXX_COMPILER=$HOME/llvm-project/build_release/bin/clang++ > -DCMAKE_Fortran_COMPILER=$HOME/llvm-project/build_release/bin/flang-new > -DTEST_SUITE_FORTRAN=On -DTEST_SUITE_SUBDIRS=Fortran > -DTEST_SUITE_FORTRAN_ISO_C_HEADER_DIR=$HOME/llvm-project/flang/include/flang > ../ > make -j48 > NO_STOP_MESSAGE=1 $HOME/llvm-project/build_release/bin/llvm-lit -v . > ``` Only failure I got was: ```text Failed Tests (1): test-suite :: Fortran/gfortran/regression/gomp/gfortran-regression-compile-regression__gomp__proc_ptr_1_f90.test ``` Which I don't think the rename is at fault for. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: @kiranchandramohan , I don't have commit access, so could you merge for me? https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/6] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index 925912df6843e4..6073ebac9e6c2c 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 932cf13edab53d..4a45a825da8fa1 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/4] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index 925912df6843e4..6073ebac9e6c2c 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 932cf13edab53d..4a45a825da8fa1 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: > @everythingfunctional with this change and install, we are installing flang > with the -20 in the install dir: `-- Installing: > /build/source/debian/tmp/usr/lib/llvm-20/bin/flang-20` > > it should not be the case, it should be named `/usr/lib/llvm-20/bin/flang` to > match what is done elsewhere Forgive me if I misunderstood or implemented this incorrectly, but I was under the impression (based on [an earlier comment](https://github.com/llvm/llvm-project/pull/110023#issuecomment-2378556647)) that this was the intended behavior. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From f6750a2a1e6710f00a93e11f4c2182dd5377a341 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH] [flang][driver] rename flang-new to flang --- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- 64 files changed, 217 insertions(+), 224 deletions(-) diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 23bd686a85f526..2b8719944cfe88 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -6062,7 +6062,7 @@ def _sysroot_EQ : Joined<["--"], "sysroot=">, Visibility<[ClangOption, FlangOpti def _sysroot : Separate<["--"], "sysroot">, Alias<_sysroot_EQ>; //===--===// -// pie/pic options (clang + flang-new) +// pie/pic options (clang + flang) //===--===// let Visibility = [ClangOption, FlangOption] in { @@ -6078,7 +6078,7 @@ def fno_pie : Flag<["-"], "fno-pie">, Group; } // let Vis = [Default, FlangOption] //===--===// -// Target Options (clang + flang-new) +// Target Options (clang + flang) //===--===// let Flags = [TargetSpecific] in { l
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 1e76b6c130953cbfa519c7a00411d47e089afbc4 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/2] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index 925912df6843e4..6073ebac9e6c2c 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 23bd686a85f526..2b8719944cfe88 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: > I have seen some more matches for flang-new in the tree: Good catch. I'm pretty sure I got them all now > Is there a symbolic link `flang-new` -> `flang`? We would like to have a > transitional period. I wasn't quite sure it was warranted, but seems like it is so I've added it back. > If you want to compare notes, I recently rebased #74377, This was helpful for putting the symlink in, so I gave you co-authorship on that commit. Let me know if you don't actually want it. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/2] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index 925912df6843e4..6073ebac9e6c2c 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 932cf13edab53d..4a45a825da8fa1 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: > That was all @banach-space's work, I only rebased his commit. Don't think > that's worth co-authorship; though ultimately you can decide, You did some of the leg work and pointed me at it. I think that deserves at least some credit, and it's already there, so I don't think it's worth removing now. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: > Since we are making this change now, should this PR be updated to follow > clang's scheme of having `clang` point to `clang-$version`? Sure. I've added what I believe does that. > Having multiple active PR's for one change is IMHO rather confusing. It > creates unnecessary duplication - why do we expect people to review the same > change twice? Apologies. I didn't mean to create a duplicate or hijack this, but I thought any previous PRs were likely stale and would be more difficult to resurrect than to just rerun a simple `find`/`sed` command. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/3] [flang][driver] rename flang-new to flang --- .github/workflows/release-binaries.yml| 2 +- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- openmp/CMakeLists.txt | 4 +- 66 files changed, 220 insertions(+), 227 deletions(-) diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml index 925912df6843e4..6073ebac9e6c2c 100644 --- a/.github/workflows/release-binaries.yml +++ b/.github/workflows/release-binaries.yml @@ -328,7 +328,7 @@ jobs: run: | # Build some of the mlir tools that take a long time to link if [ "${{ needs.prepare.outputs.build-flang }}" = "true" ]; then - ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang-new bbc + ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ -j2 flang bbc fi ninja -C ${{ steps.setup-stage.outputs.build-prefix }}/build/tools/clang/stage2-bins/ \ mlir-bytecode-parser-fuzzer \ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 932cf13edab53d..4a45a825da8fa1 100644 --- a/clang/include/clang/Drive
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: > Shouldn't `-fopenacc` then also emit such a warning? Well, we could get into a philosophical discussion about whether software is ever *not* experimental. But in this case I think it's fine to be a bit proactive and warn users that we know there are still some unfinished aspects. Or we could maybe use the word "incomplete" instead of experimental. Either way I'm happy to add the warning for both, just let me know. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
everythingfunctional wrote: Sounds like I should just add the warning to OpenMP for now. I'll work on getting that added and then figure out why the CI is failing. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 38b43f6c2d90420c775d4658e7c472b323bfc30e Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH] [flang][driver] rename flang-new to flang --- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 3 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- 64 files changed, 217 insertions(+), 224 deletions(-) diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 23bd686a85f526..2b8719944cfe88 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -6062,7 +6062,7 @@ def _sysroot_EQ : Joined<["--"], "sysroot=">, Visibility<[ClangOption, FlangOpti def _sysroot : Separate<["--"], "sysroot">, Alias<_sysroot_EQ>; //===--===// -// pie/pic options (clang + flang-new) +// pie/pic options (clang + flang) //===--===// let Visibility = [ClangOption, FlangOption] in { @@ -6078,7 +6078,7 @@ def fno_pie : Flag<["-"], "fno-pie">, Group; } // let Vis = [Default, FlangOption] //===--===// -// Target Options (clang + flang-new) +// Target Options (clang + flang) //===--===// let Flags = [TargetSpecific] in { l
[clang] [flang] [llvm] [flang][driver] rename flang-new to flang (PR #110023)
https://github.com/everythingfunctional created https://github.com/llvm/llvm-project/pull/110023 This does a global rename from `flang-new` to `flang`. I also removed/changed any TODOs that I found related to making this change. >From cd3960354231edcf3dce4860bc56243b33fc7f01 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH] [flang][driver] rename flang-new to flang --- clang/include/clang/Driver/Options.td | 4 +- clang/lib/Driver/Driver.cpp | 2 +- clang/lib/Driver/ToolChains/Flang.cpp | 6 +- clang/test/Driver/flang/flang.f90 | 2 +- clang/test/Driver/flang/flang_ucase.F90 | 2 +- .../Driver/flang/multiple-inputs-mixed.f90| 2 +- clang/test/Driver/flang/multiple-inputs.f90 | 4 +- flang/docs/FlangDriver.md | 76 +-- flang/docs/ImplementingASemanticCheck.md | 4 +- flang/docs/Overview.md| 26 +++ .../FlangOmpReport/FlangOmpReport.cpp | 2 +- .../flang/Optimizer/Analysis/AliasAnalysis.h | 2 +- flang/include/flang/Tools/CrossToolHelpers.h | 2 +- flang/lib/Frontend/CompilerInvocation.cpp | 6 +- flang/lib/Frontend/FrontendActions.cpp| 2 +- .../ExecuteCompilerInvocation.cpp | 2 +- flang/runtime/CMakeLists.txt | 6 +- flang/test/CMakeLists.txt | 2 +- flang/test/Driver/aarch64-outline-atomics.f90 | 2 +- .../Driver/color-diagnostics-forwarding.f90 | 4 +- flang/test/Driver/compiler-options.f90| 4 +- flang/test/Driver/convert.f90 | 2 +- .../test/Driver/disable-ext-name-interop.f90 | 2 +- flang/test/Driver/driver-version.f90 | 4 +- flang/test/Driver/escaped-backslash.f90 | 4 +- flang/test/Driver/fdefault.f90| 28 +++ flang/test/Driver/flarge-sizes.f90| 20 ++--- .../test/Driver/frame-pointer-forwarding.f90 | 2 +- flang/test/Driver/frontend-forwarding.f90 | 4 +- flang/test/Driver/hlfir-no-hlfir-error.f90| 4 +- flang/test/Driver/intrinsic-module-path.f90 | 2 +- flang/test/Driver/large-data-threshold.f90| 6 +- flang/test/Driver/lto-flags.f90 | 2 +- flang/test/Driver/macro-def-undef.F90 | 4 +- flang/test/Driver/missing-input.f90 | 14 ++-- flang/test/Driver/multiple-input-files.f90| 2 +- flang/test/Driver/omp-driver-offload.f90 | 66 .../predefined-macros-compiler-version.F90| 4 +- flang/test/Driver/std2018-wrong.f90 | 2 +- flang/test/Driver/std2018.f90 | 2 +- .../Driver/supported-suffices/f03-suffix.f03 | 2 +- .../Driver/supported-suffices/f08-suffix.f08 | 2 +- flang/test/Driver/use-module-error.f90| 4 +- flang/test/Driver/use-module.f90 | 4 +- flang/test/Driver/version-loops.f90 | 18 ++--- flang/test/Driver/wextra-ok.f90 | 2 +- flang/test/HLFIR/hlfir-flags.f90 | 2 +- .../Intrinsics/command_argument_count.f90 | 4 +- flang/test/Lower/Intrinsics/exit.f90 | 2 +- .../test/Lower/Intrinsics/ieee_is_normal.f90 | 2 +- flang/test/Lower/Intrinsics/isnan.f90 | 2 +- flang/test/Lower/Intrinsics/modulo.f90| 2 +- .../OpenMP/Todo/omp-declarative-allocate.f90 | 2 +- .../OpenMP/Todo/omp-declare-reduction.f90 | 2 +- .../Lower/OpenMP/Todo/omp-declare-simd.f90| 2 +- .../parallel-lastprivate-clause-scalar.f90| 2 +- .../parallel-wsloop-reduction-byref.f90 | 2 +- .../OpenMP/parallel-wsloop-reduction.f90 | 2 +- flang/test/lit.cfg.py | 4 +- flang/tools/f18/CMakeLists.txt| 10 +-- flang/tools/flang-driver/CMakeLists.txt | 12 +-- flang/tools/flang-driver/driver.cpp | 6 +- llvm/runtimes/CMakeLists.txt | 10 +-- offload/CMakeLists.txt| 4 +- 64 files changed, 217 insertions(+), 223 deletions(-) diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 23bd686a85f526..2b8719944cfe88 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -6062,7 +6062,7 @@ def _sysroot_EQ : Joined<["--"], "sysroot=">, Visibility<[ClangOption, FlangOpti def _sysroot : Separate<["--"], "sysroot">, Alias<_sysroot_EQ>; //===--===// -// pie/pic options (clang + flang-new) +// pie/pic options (clang + flang) //===--===// let Visibility = [ClangOption, FlangOption] in { @@ -6078,7 +6078,7 @@ def fno_pie : Flag<["-"], "fno-pie">, Group; } // let Vis = [Default, FlangOption] //===--===// -// Target Options (clang + flang-new) +// Target Options (c
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
@@ -339,11 +335,11 @@ just added using your new frontend option. ## CMake Support As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246) -(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a +(and soon to be released CMake 3.24.0), `cmake` can detect `flang` as a everythingfunctional wrote: That I am not quite sure of. I will look into it and adjust that comment in the docs as appropriate. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)
@@ -339,11 +335,11 @@ just added using your new frontend option. ## CMake Support As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246) -(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a +(and soon to be released CMake 3.24.0), `cmake` can detect `flang` as a everythingfunctional wrote: @banach-space appears to have been involved in that MR, do you happen to know the answer to the above questions? It looks like it doesn't rely on the `flang-new` name, but I'm not sure. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits