Re: [PATCH] D33708: [test] [libcxx] Disable MSVC++'s compare(a, b) implies !compare(b, a) assertion in predicate application count tests
But I actually want the predicate count assertions turned on -- if a user turns off iterator debugging they need to get exactly what the standard asks for, and that means both predicate assertions like this and the Iterator Debug Array Overloads go away. I need to figure out how to do this with our test harness though, since at the moment we depend on that forceinclude. Billy3 On Mon, Jun 5, 2017 at 9:51 AM, David Blaikie wrote: > Alternatively, you could disable the check (or change the count it checks) > if this is defined. (& if you disable the check when this is defined, you > could change an existing build/test config (or add a new one) to have this > disabled) > > On Tue, May 30, 2017 at 8:19 PM Billy Robert O'Neal III via Phabricator > via cfe-commits wrote: > >> BillyONeal abandoned this revision. >> BillyONeal added a comment. >> >> Stephan pointed out that the force include breaks this. Backing it out >> for now :( >> >> >> https://reviews.llvm.org/D33708 >> >> >> >> ___ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.
OK, I think r318830 fixes the other one here. Thanks! Billy3 On Wed, Nov 22, 2017 at 4:25 AM, Billy O'Neal wrote: > Sorry, I saw one bot fail and I thought I fixed it with > 37332d772480307af423fbea817c29a0832be86e but apparently there were > others I missed. > > On Wed, Nov 22, 2017 at 4:04 AM, Evgeny Astigeevich > wrote: >> Hi Billy, >> >> These changes caused buildbot failures: tuple.by.type.fail.cpp Line 19: >> unknown type name 'TEST_IGNORE_NODISCARD' >> >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14/builds/1109 >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx17/builds/1 >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux/builds/924 >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/972 >> >> Thanks, >> Evgeny Astigeevich >> >> >> -Original Message- >> From: cfe-commits on behalf of Billy >> Robert O'Neal III via Phabricator via cfe-commits >> >> Reply-To: "reviews+d40065+public+cdf4c853d41b4...@reviews.llvm.org" >> , Billy Robert >> O'Neal III via Phabricator >> Date: Tuesday, 21 November 2017 at 21:38 >> To: "billy.on...@gmail.com" , "e...@efcs.ca" >> , "mclow.li...@gmail.com" >> Cc: "cfe-commits@lists.llvm.org" >> Subject: [PATCH] D40065: [libcxx] [test] Change (void)s to >> TEST_IGNORE_NODISCARD as requested by Eric. >> >> BillyONeal closed this revision. >> BillyONeal added a comment. >> >> Committed r318804 >> >> >> https://reviews.llvm.org/D40065 >> >> >> >> ___ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> >> ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.
Sorry, I saw one bot fail and I thought I fixed it with 37332d772480307af423fbea817c29a0832be86e but apparently there were others I missed. On Wed, Nov 22, 2017 at 4:04 AM, Evgeny Astigeevich wrote: > Hi Billy, > > These changes caused buildbot failures: tuple.by.type.fail.cpp Line 19: > unknown type name 'TEST_IGNORE_NODISCARD' > > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14/builds/1109 > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx17/builds/1 > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux/builds/924 > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/972 > > Thanks, > Evgeny Astigeevich > > > -Original Message- > From: cfe-commits on behalf of Billy > Robert O'Neal III via Phabricator via cfe-commits > Reply-To: "reviews+d40065+public+cdf4c853d41b4...@reviews.llvm.org" > , Billy Robert > O'Neal III via Phabricator > Date: Tuesday, 21 November 2017 at 21:38 > To: "billy.on...@gmail.com" , "e...@efcs.ca" > , "mclow.li...@gmail.com" > Cc: "cfe-commits@lists.llvm.org" > Subject: [PATCH] D40065: [libcxx] [test] Change (void)s to > TEST_IGNORE_NODISCARD as requested by Eric. > > BillyONeal closed this revision. > BillyONeal added a comment. > > Committed r318804 > > > https://reviews.llvm.org/D40065 > > > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
