[PATCH] D129570: Add new clang-tidy check to find implicit conversions from enum to integer.

[Artem Tamazov via Phabricator via cfe-commits]

artem.tamazov accepted this revision.
artem.tamazov added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129570/new/

https://reviews.llvm.org/D129570

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129570: Add new clang-tidy check to find implicit conversions from enum to integer.

[Artem Tamazov via Phabricator via cfe-commits]

artem.tamazov requested changes to this revision.
artem.tamazov added a comment.
This revision now requires changes to proceed.

A typo in the doc, but otherwise LGTM.




Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/enum-to-int.rst:8
+integer. In C++11, enums can be defined as ``enum class`` which will prevent
+such implicit conversion, however, ``enum`` provides no such guarantess to
+prevent bugs. There can be many reasons why ``enum`` cannot be replaced with




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129570/new/

https://reviews.llvm.org/D129570

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

[Artem Tamazov via Phabricator via cfe-commits]

artem.tamazov added a comment.

In D129570#3717972 , @pfultz2 wrote:

> I could extend it to support everything except explicit casts if you think 
> that would be better.

If asked, I would vote for extending this warning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129570/new/

https://reviews.llvm.org/D129570

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

[Artem Tamazov via Phabricator via cfe-commits]

artem.tamazov accepted this revision as: artem.tamazov.
artem.tamazov added a comment.
This revision is now accepted and ready to land.

No objections from MIOpen side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145671/new/

https://reviews.llvm.org/D145671

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits