[clang] [clang] Stub out gcc_struct attribute (PR #71148)

[Andrew Kaster via cfe-commits]

ADKaster wrote:

> SerenityOS is an OS, independent from Windows. What does porting it to 
> Windows mean? Build some SerenityOS components on Windows targeting the PE 
> object file format?

In this case, Dan is referring to future plans to port the Ladybird browser to 
x86_64-windows-msvc. The browser and its ports use the system libraries from 
SerenityOS in the implementation.

https://github.com/llvm/llvm-project/pull/71148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Handle placeholders in '.*' expressions (PR #83103)

[Andrew Kaster via cfe-commits]

ADKaster wrote:

@AaronBallman @Sirraide would this patch be reasonable to backport to the 18.x 
release branch? It fixes a problem with our application on the FreeBSD-CURRENT 
branch. https://github.com/SerenityOS/serenity/issues/23365

https://github.com/llvm/llvm-project/pull/83103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

[Andrew Kaster via cfe-commits]

ADKaster wrote:

Yeah seems llvm prefers not to force push PRs, but to keep stacking commits. 
The squashed commit will have the PR description as the final commit 
description. The compare button is a bit useless when it has a bunch of changes 
from main on it 
(https://github.com/llvm/llvm-project/compare/8a2b22e69f82e3f4caa271b57b998d1c03b21d39..67971ca27ef5e2767aba5cfe2cec1021c4de5ec1)

https://github.com/llvm/llvm-project/pull/67749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

[Andrew Kaster via cfe-commits]

ADKaster wrote:

@HighCommander4 @sam-mccall do you have any capacity to review this change? It 
would be nice to get it into the 18 release if the window hasn't closed.

https://github.com/llvm/llvm-project/pull/67749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

[Andrew Kaster via cfe-commits]

@@ -483,6 +483,56 @@ struct FragmentCompiler {
 FullyQualifiedNamespaces.begin(), FullyQualifiedNamespaces.end());
   });
 }
+auto QuotedFilter = compileHeaderRegexes(F.QuotedHeaders);
+if (QuotedFilter.has_value()) {
+  Out.Apply.push_back(
+  [QuotedFilter = *QuotedFilter](const Params &, Config &C) {
+C.Style.QuotedHeaders.emplace_back(QuotedFilter);
+  });
+}
+auto AngledFilter = compileHeaderRegexes(F.AngledHeaders);
+if (AngledFilter.has_value()) {
+  Out.Apply.push_back(
+  [AngledFilter = *AngledFilter](const Params &, Config &C) {
+C.Style.AngledHeaders.emplace_back(AngledFilter);
+  });
+}
+  }
+
+  auto compileHeaderRegexes(llvm::ArrayRef> 
HeaderPatterns)
+  -> std::optional> {
+// TODO: Share this code with Diagnostics.Includes.IgnoreHeader
+#ifdef CLANGD_PATH_CASE_INSENSITIVE
+static llvm::Regex::RegexFlags Flags = llvm::Regex::IgnoreCase;
+#else
+static llvm::Regex::RegexFlags Flags = llvm::Regex::NoFlags;
+#endif
+auto Filters = std::make_shared>();
+for (auto &HeaderPattern : HeaderPatterns) {
+  elog("found angle pattern {0}", *HeaderPattern);

ADKaster wrote:

elog seems a bit high for this debugging output. 

https://github.com/llvm/llvm-project/pull/67749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add an off-by-default warning to complain about MSVC bitfield padding (PR #117428)

[Andrew Kaster via cfe-commits]

ADKaster wrote:

https://github.com/llvm/llvm-project/pull/70978, which split -Wpadded into 
-Wpadded and -Wpadded-bitfield, may be relevant here

https://github.com/llvm/llvm-project/pull/117428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits