Re: r244193 - [ObjC] Circular containers: add support of subclasses
Ping -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 06 Aug 2015, at 18:15, Hans Wennborg wrote: > > Hi Alex, > > What crash is that? I don't see any PR number in the commit. > > Richard, what's your owner's opinion? > > On Wed, Aug 5, 2015 at 9:54 PM, AlexDenisov <1101.deb...@gmail.com> wrote: >> Hi, Hans. >> The patch fixes crash reported by Argyrios. >> Might be a candidate for release_37. >> -- >> AlexDenisov >> Software Engineer, http://lowlevelbits.org >> >>> On 06 Aug 2015, at 06:51, Alex Denisov <1101.deb...@gmail.com> wrote: >>> >>> Author: alexdenisov >>> Date: Wed Aug 5 23:51:14 2015 >>> New Revision: 244193 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=244193&view=rev >>> Log: >>> [ObjC] Circular containers: add support of subclasses signature.asc Description: Message signed with OpenPGP using GPGMail ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: r244193 - [ObjC] Circular containers: add support of subclasses
> Ah, you were referring to > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134471.html Yes, that is correct :) > Sorry, email is hard to keep up with sometimes :-) No worries, I do understand ;) -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 06 Aug 2015, at 18:17, Hans Wennborg wrote: > > Ah, you were referring to > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134471.html > > Sorry, email is hard to keep up with sometimes :-) > > On Thu, Aug 6, 2015 at 9:15 AM, Hans Wennborg wrote: >> Hi Alex, >> >> What crash is that? I don't see any PR number in the commit. >> >> Richard, what's your owner's opinion? >> >> On Wed, Aug 5, 2015 at 9:54 PM, AlexDenisov <1101.deb...@gmail.com> wrote: >>> Hi, Hans. >>> The patch fixes crash reported by Argyrios. >>> Might be a candidate for release_37. >>> -- >>> AlexDenisov >>> Software Engineer, http://lowlevelbits.org >>> On 06 Aug 2015, at 06:51, Alex Denisov <1101.deb...@gmail.com> wrote: Author: alexdenisov Date: Wed Aug 5 23:51:14 2015 New Revision: 244193 URL: http://llvm.org/viewvc/llvm-project?rev=244193&view=rev Log: [ObjC] Circular containers: add support of subclasses signature.asc Description: Message signed with OpenPGP using GPGMail ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] Add ObjCBoxable handling to ObjCMigrator
Extend ObjCMigrator to cover automatic migration from message sending to boxable literals, e.g.: ```before typedef struct __attribute__((objc_boxable)) CGRect CGRect; /// ... CGRect rect; [NSValue valueWithBytes:&rect objCType:@encode(CGRect)]; [NSValue valueWithCGPoint:functionReturningCGPoint()]; ``` ```after typedef struct __attribute__((objc_boxable)) CGRect CGRect; /// ... CGRect rect; @(rect); @(functionReturningCGPoint()); ``` I will appreciate any ideas how to improve it since the implementation is far from beautiful. objc_migrator_objc_boxable.patch Description: Binary data -- AlexDenisov Software Engineer, http://lowlevelbits.org signature.asc Description: Message signed with OpenPGP using GPGMail ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits