[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

[Alex Gatea via Phabricator via cfe-commits]

alexgatea reopened this revision.
alexgatea added a comment.
This revision is now accepted and ready to land.

This test fails because the actual output has <3 x float>* rather than ptr. 
Could you please fix this test case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132913/new/

https://reviews.llvm.org/D132913

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

[Alex Gatea via Phabricator via cfe-commits]

alexgatea added a comment.

> Thanks for reporting the issue.
> But I cannot repro the fail.
> Do you mind sharing your cmake command?

Hmm, I'm just running the command in the test case:
clang --driver-mode=dxc -Tlib_6_7 -fcgl  -Fo - 
clang/test/CodeGenHLSL/float3.hlsl | FileCheck 
clang/test/CodeGenHLSL/float3.hlsl


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132913/new/

https://reviews.llvm.org/D132913

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

[Alex Gatea via Phabricator via cfe-commits]

alexgatea added a comment.

In D132913#3786734 , @python3kgae 
wrote:

> In D132913#3786679 , @alexgatea 
> wrote:
>
>>> Thanks for reporting the issue.
>>> But I cannot repro the fail.
>>> Do you mind sharing your cmake command?
>>
>> Hmm, I'm just running the command in the test case:
>> clang --driver-mode=dxc -Tlib_6_7 -fcgl  -Fo - 
>> clang/test/CodeGenHLSL/float3.hlsl | FileCheck 
>> clang/test/CodeGenHLSL/float3.hlsl
>
> This is the output I got with  clang --driver-mode=dxc -Tlib_6_7 -fcgl  -Fo - 
> clang/test/CodeGenHLSL/float3.hlsl
>
>   target datalayout = 
> "e-m:e-p:32:32-i1:32-i8:8-i16:16-i32:32-i64:64-f16:16-f32:32-f64:64-n8:16:32:64"
>   target triple = "dxil-unknown-shadermodel6.7-library"
>   
>   ; Function Attrs: noinline nounwind optnone
>   define noundef <3 x float> @"?foo@@YAT?$__vector@M$02@__clang@@T12@@Z"(<3 x 
> float> noundef %a) #0 {
>   entry:
> %a.addr = alloca <3 x float>, align 16
> store <3 x float> %a, ptr %a.addr, align 16
> %0 = load <3 x float>, ptr %a.addr, align 16
> ret <3 x float> %0
>   }
>   
>   attributes #0 = { noinline nounwind optnone "frame-pointer"="all" 
> "min-legal-vector-width"="96" "no-trapping-math"="true" 
> "stack-protector-buffer-size"="8" }
>   
>   !llvm.module.flags = !{!0, !1}
>   !dx.valver = !{!2}
>   !llvm.ident = !{!3}
>   
>   !0 = !{i32 1, !"wchar_size", i32 4}
>   !1 = !{i32 7, !"frame-pointer", i32 2}
>   !2 = !{i32 1, i32 7}
>   !3 = !{!"clang version 16.0.0 (https://github.com/llvm/llvm-project 
> c9d2b6b92d6c29d00f6adc0527cf2331dbaae31a)"}
>
> Maybe you build clang with a different setting? What are the CMake options 
> you're using?

Sorry for the delay and thank you for verifying. It turns out this is not due 
to a problem with the test itself, but rather a local problem with my compiler. 
No revision is necessary here, my apologies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132913/new/

https://reviews.llvm.org/D132913

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

[Alex Gatea via Phabricator via cfe-commits]

alexgatea reopened this revision.
alexgatea added a comment.
This revision is now accepted and ready to land.

Hi
This test case is still failing for me due to the lines without -fuse-ld=ldd:

  // RUN: %clang -### -target x86_64-unknown-linux -flto -gdwarf-aranges %s 
2>&1 | FileCheck -check-prefix=LDGARANGE %s
  // RUN: %clang -### -target x86_64-unknown-linux -flto=thin -gdwarf-aranges 
%s 2>&1 | FileCheck -check-prefix=LDGARANGE %s

Can you please fix this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133841/new/

https://reviews.llvm.org/D133841

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

[Alex Gatea via Phabricator via cfe-commits]

alexgatea closed this revision.
alexgatea added a comment.

> It should be fixed in https://reviews.llvm.org/D133847

Ah I didn't see that. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133841/new/

https://reviews.llvm.org/D133841

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits