[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-31 Thread Alex Crichton via Phabricator via cfe-commits
alexcrichton added a comment.

Seems reasonable to me! In my testing though if these existed as custom 
sections they'd still make their way to the final binary through LLD, so could 
LLD skip over these sectiosn by default?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77115/new/

https://reviews.llvm.org/D77115



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

2020-03-31 Thread Alex Crichton via Phabricator via cfe-commits
alexcrichton accepted this revision.
alexcrichton added a comment.
This revision is now accepted and ready to land.

At least from my POV looks good :)

Thanks for the quick patch!

Should this link 

 also be updated to handle the special section names?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77115/new/

https://reviews.llvm.org/D77115



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits