[PATCH] D81422: Change filecheck default to dump input on failure

2020-06-09 Thread Aart Bik via Phabricator via cfe-commits 
aartbik accepted this revision.
aartbik added a comment.
This revision is now accepted and ready to land.

Yes, assuming nobody remembers an adverse side-effect, I think this change will 
help debugging future failures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

2021-11-02 Thread Aart Bik via Phabricator via cfe-commits 
aartbik added a comment.

One last question, I just noticed you started a whole new revision (instead of 
updating https://reviews.llvm.org/D112995).

Was that intentional?

If you use arc, then arc diff  first time creates one, but subsequent 
updates should use arc diff ... --update D to make sure we stay in one 
revision.
It is not a big deal, we can proceed with this one and abandon the other, but 
just making sure you are aware of the procedure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113043/new/

https://reviews.llvm.org/D113043

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

2021-11-02 Thread Aart Bik via Phabricator via cfe-commits 
aartbik accepted this revision.
aartbik added a comment.
This revision is now accepted and ready to land.

I removed the quotes from the title, no need for these. Also, please address 
the last open question (on arc diff --update).

But good to go as revision.

I have approved the revision and will submit this one for you. Congrats on your 
first contribution or sparse compilation!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113043/new/

https://reviews.llvm.org/D113043

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

2021-11-02 Thread Aart Bik via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a91bc7bf436: [mlir][sparse] Rename SparseUtils.cpp file to 
SparseTensorUtils.cpp (authored by HarrietAkot, committed by aartbik).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113043/new/

https://reviews.llvm.org/D113043

Files:
  clang/docs/tools/clang-formatted-files.txt
  mlir/lib/ExecutionEngine/CMakeLists.txt
  mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
  mlir/lib/ExecutionEngine/SparseUtils.cpp


Index: mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
===
--- mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
+++ mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
@@ -1,4 +1,4 @@
-//===- SparseUtils.cpp - Sparse Utils for MLIR execution 
--===//
+//===- SparseTensorUtils.cpp - Sparse Tensor Utils for MLIR execution 
-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM 
Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
Index: mlir/lib/ExecutionEngine/CMakeLists.txt
===
--- mlir/lib/ExecutionEngine/CMakeLists.txt
+++ mlir/lib/ExecutionEngine/CMakeLists.txt
@@ -5,7 +5,7 @@
   AsyncRuntime.cpp
   CRunnerUtils.cpp
   CudaRuntimeWrappers.cpp
-  SparseUtils.cpp
+  SparseTensorUtils.cpp
   ExecutionEngine.cpp
   RocmRuntimeWrappers.cpp
   RunnerUtils.cpp
@@ -79,7 +79,7 @@
 add_mlir_library(mlir_c_runner_utils
   SHARED
   CRunnerUtils.cpp
-  SparseUtils.cpp
+  SparseTensorUtils.cpp
 
   EXCLUDE_FROM_LIBMLIR
   )
Index: clang/docs/tools/clang-formatted-files.txt
===
--- clang/docs/tools/clang-formatted-files.txt
+++ clang/docs/tools/clang-formatted-files.txt
@@ -7406,7 +7406,7 @@
 mlir/lib/ExecutionEngine/OptUtils.cpp
 mlir/lib/ExecutionEngine/RocmRuntimeWrappers.cpp
 mlir/lib/ExecutionEngine/RunnerUtils.cpp
-mlir/lib/ExecutionEngine/SparseUtils.cpp
+mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
 mlir/lib/Interfaces/CallInterfaces.cpp
 mlir/lib/Interfaces/CastInterfaces.cpp
 mlir/lib/Interfaces/ControlFlowInterfaces.cpp


Index: mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
===
--- mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
+++ mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
@@ -1,4 +1,4 @@
-//===- SparseUtils.cpp - Sparse Utils for MLIR execution --===//
+//===- SparseTensorUtils.cpp - Sparse Tensor Utils for MLIR execution -===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
Index: mlir/lib/ExecutionEngine/CMakeLists.txt
===
--- mlir/lib/ExecutionEngine/CMakeLists.txt
+++ mlir/lib/ExecutionEngine/CMakeLists.txt
@@ -5,7 +5,7 @@
   AsyncRuntime.cpp
   CRunnerUtils.cpp
   CudaRuntimeWrappers.cpp
-  SparseUtils.cpp
+  SparseTensorUtils.cpp
   ExecutionEngine.cpp
   RocmRuntimeWrappers.cpp
   RunnerUtils.cpp
@@ -79,7 +79,7 @@
 add_mlir_library(mlir_c_runner_utils
   SHARED
   CRunnerUtils.cpp
-  SparseUtils.cpp
+  SparseTensorUtils.cpp
 
   EXCLUDE_FROM_LIBMLIR
   )
Index: clang/docs/tools/clang-formatted-files.txt
===
--- clang/docs/tools/clang-formatted-files.txt
+++ clang/docs/tools/clang-formatted-files.txt
@@ -7406,7 +7406,7 @@
 mlir/lib/ExecutionEngine/OptUtils.cpp
 mlir/lib/ExecutionEngine/RocmRuntimeWrappers.cpp
 mlir/lib/ExecutionEngine/RunnerUtils.cpp
-mlir/lib/ExecutionEngine/SparseUtils.cpp
+mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
 mlir/lib/Interfaces/CallInterfaces.cpp
 mlir/lib/Interfaces/CastInterfaces.cpp
 mlir/lib/Interfaces/ControlFlowInterfaces.cpp
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137338: Fix dupe word typos

2022-11-03 Thread Aart Bik via Phabricator via cfe-commits 
aartbik added a comment.

LGTM for sparse changes

(note that you could have made your life a bit easier if you had broken this 
revision up at least over different projects, getting a global "LGTM" from 
somebody may be a bit hard now ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137338/new/

https://reviews.llvm.org/D137338

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits