[llvm] [clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-01-30 Thread Aaron Liu via cfe-commits 


@@ -3520,6 +3520,27 @@ def fpass_plugin_EQ : Joined<["-"], "fpass-plugin=">,
   MetaVarName<"">,
   HelpText<"Load pass plugin from a dynamic shared object file (only with new 
pass manager).">,
   MarshallingInfoStringVector>;
+defm tocdata : BoolOption<"m","tocdata",
+  CodeGenOpts<"AllTocData">, DefaultFalse,
+  PosFlag,
+  NegFlag,
+  BothFlags<[], [ClangOption, CLOption]>>, Group;
+def mtocdata_EQ : CommaJoined<["-"], "mtocdata=">,
+  Visibility<[ClangOption, CC1Option]>,
+  Flags<[TargetSpecific]>,
+  HelpText<"Specifies a list of variables to which the TOC data transformation"
+   "will be applied.">,
+  MarshallingInfoStringVector>;
+def mno_tocdata_EQ : CommaJoined<["-"], "mno-tocdata=">,
+  Visibility<[ClangOption, CC1Option]>,
+  Flags<[TargetSpecific]>,

AaronHLiu wrote:

Need to remove all `Flags<[TargetSpecific]>`, otherwise will get errors in link 
step as follows:
```
error: unsupported option '-mtocdata' for target 'powerpc-ibm-aix7.2.0.0'
```

https://github.com/llvm/llvm-project/pull/67999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-01-30 Thread Aaron Liu via cfe-commits 


@@ -3520,6 +3520,27 @@ def fpass_plugin_EQ : Joined<["-"], "fpass-plugin=">,
   MetaVarName<"">,
   HelpText<"Load pass plugin from a dynamic shared object file (only with new 
pass manager).">,
   MarshallingInfoStringVector>;
+defm tocdata : BoolOption<"m","tocdata",
+  CodeGenOpts<"AllTocData">, DefaultFalse,
+  PosFlag,
+  NegFlag,
+  BothFlags<[], [ClangOption, CLOption]>>, Group;
+def mtocdata_EQ : CommaJoined<["-"], "mtocdata=">,
+  Visibility<[ClangOption, CC1Option]>,
+  Flags<[TargetSpecific]>,
+  HelpText<"Specifies a list of variables to which the TOC data transformation"
+   "will be applied.">,
+  MarshallingInfoStringVector>;
+def mno_tocdata_EQ : CommaJoined<["-"], "mno-tocdata=">,
+  Visibility<[ClangOption, CC1Option]>,
+  Flags<[TargetSpecific]>,

AaronHLiu wrote:

Need to remove all `Flags<[TargetSpecific]>`, otherwise will get errors in link 
step as follows:
```
error: unsupported option '-mtocdata' for target 'powerpc-ibm-aix7.2.0.0'
```

https://github.com/llvm/llvm-project/pull/67999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-01-30 Thread Aaron Liu via cfe-commits 


@@ -3520,6 +3520,27 @@ def fpass_plugin_EQ : Joined<["-"], "fpass-plugin=">,
   MetaVarName<"">,
   HelpText<"Load pass plugin from a dynamic shared object file (only with new 
pass manager).">,
   MarshallingInfoStringVector>;
+defm tocdata : BoolOption<"m","tocdata",
+  CodeGenOpts<"AllTocData">, DefaultFalse,
+  PosFlag,
+  NegFlag,
+  BothFlags<[], [ClangOption, CLOption]>>, Group;
+def mtocdata_EQ : CommaJoined<["-"], "mtocdata=">,
+  Visibility<[ClangOption, CC1Option]>,
+  Flags<[TargetSpecific]>,

AaronHLiu wrote:

Need to remove all `Flags<[TargetSpecific]>`, otherwise will get errors in link 
step as follows:
```
error: unsupported option '-mtocdata' for target 'powerpc-ibm-aix7.2.0.0'
```

https://github.com/llvm/llvm-project/pull/67999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Shift relink option implementation away from module cloning (PR #81693)

2024-02-15 Thread Aaron Liu via cfe-commits 


@@ -257,37 +281,19 @@ bool BackendConsumer::LinkInModules(llvm::Module *M, bool 
ShouldLinkFiles) {
 CurLinkModule = LM.Module.get();
 bool Err;

AaronHLiu wrote:

Got error:
```
clang/lib/CodeGen/CodeGenAction.cpp:282:10: error: variable 'Err' set but not 
used [-Werror,-Wunused-but-set-variable]
bool Err;
 ^
1 error generated.
```

https://github.com/llvm/llvm-project/pull/81693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Shift relink option implementation away from module cloning (PR #81693)

2024-02-15 Thread Aaron Liu via cfe-commits 


@@ -257,37 +281,19 @@ bool BackendConsumer::LinkInModules(llvm::Module *M, bool 
ShouldLinkFiles) {
 CurLinkModule = LM.Module.get();
 bool Err;

AaronHLiu wrote:

Thanks!

https://github.com/llvm/llvm-project/pull/81693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-06-10 Thread Aaron Liu via cfe-commits 

aaronliu0130 wrote:

LLVM has 2.5k PRs to review while working on their own changes

https://github.com/llvm/llvm-project/pull/78491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-06-10 Thread Aaron Liu via cfe-commits 

aaronliu0130 wrote:

What's "ping PR"? Do you mean pinging the LLVM organization?

https://github.com/llvm/llvm-project/pull/78491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-05-02 Thread Aaron Liu via cfe-commits 

aaronliu0130 wrote:

Well, the last ready-to-go PR was from September (#65448), so probably a while.

https://github.com/llvm/llvm-project/pull/78491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-05-02 Thread Aaron Liu via cfe-commits 

aaronliu0130 wrote:

As mentioned in 
https://github.com/clangd/clangd/issues/529#issuecomment-1938730781, they're 
[here](https://aur.archlinux.org/cgit/aur.git/tree/hover-doxygen-trunk.patch?h=clangd-opt-git).
 Hopefully you can follow [the build 
instructions](https://github.com/llvm/llvm-project/tree/main/clang-tools-extra/clangd#readme).

https://github.com/llvm/llvm-project/pull/78491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

2024-10-04 Thread Aaron Liu via cfe-commits 

aaronliu0130 wrote:

I'm new to this, but from what I see, this PR could be easily put up simply 
removing the pseudo:: prefixes.

https://github.com/llvm/llvm-project/pull/80592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clangd][WIP] Add doxygen parsing using standalone doxygen parser (PR #128591)

2025-03-18 Thread Aaron Liu via cfe-commits 

aaronliu0130 wrote:

Is this still WIP?

https://github.com/llvm/llvm-project/pull/128591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-06-21 Thread Aaron Liu via cfe-commits 

aaronliu0130 wrote:

@mccakit  It looks like there's currently a reply from @tcottin to 
emaxx-google's last comment needed.

https://github.com/llvm/llvm-project/pull/140498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits