[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

[Aaron H Liu via Phabricator via cfe-commits]

AaronLiu added a comment.

This cause a large amount failures in our testing with errors such as:

  error: ISO C++17 does not allow 'register' storage class specifier 
[-Wregister]

  error: ISO C++17 does not allow dynamic exception specifications 
[-Wdynamic-exception-spec]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131465/new/

https://reviews.llvm.org/D131465

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

[Aaron H Liu via Phabricator via cfe-commits]

AaronLiu added a comment.

In D131465#3780767 , @aaron.ballman 
wrote:

> In D131465#3780717 , @AaronLiu 
> wrote:
>
>> This cause a large amount failures in our testing with errors such as:
>>
>>   error: ISO C++17 does not allow 'register' storage class specifier 
>> [-Wregister]
>>
>>   error: ISO C++17 does not allow dynamic exception specifications 
>> [-Wdynamic-exception-spec]
>
> Sorry to hear that. Who is "our" in this case and do you have a suggestion 
> for how you'd like to proceed?

Some down stream regression tests.
I see the above comments:

> I've reverted this change because it causes major llvm-test-suite breakage.

Probably currently this is the best way.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131465/new/

https://reviews.llvm.org/D131465

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122497: [clang][tests][NFC] Add filescope array initialization test

[Aaron H Liu via Phabricator via cfe-commits]

AaronLiu accepted this revision.
AaronLiu added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122497/new/

https://reviews.llvm.org/D122497

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

[Aaron H Liu via Phabricator via cfe-commits]

AaronLiu added a comment.

When compile the following valid testcase:

  void foo()
  {
  int x = [x](int y[sizeof x]){return sizeof x;}(0);
  }

It will complain:

  error: captured variable 'x' cannot appear here
  int x = [x](int y[sizeof x]){return sizeof x;}(0);
   ^

The issue is also described in: https://cplusplus.github.io/CWG/issues/2569.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119136/new/

https://reviews.llvm.org/D119136

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

[Aaron H Liu via Phabricator via cfe-commits]

AaronLiu added a comment.

In D119136#3465522 , @cor3ntin wrote:

> In D119136#3465361 , @AaronLiu 
> wrote:
>
>> When compile the following valid testcase:
>>
>>   void foo()
>>   {
>>   int x = [x](int y[sizeof x]){return sizeof x;}(0);
>>   }
>>
>> It will complain:
>>
>>   error: captured variable 'x' cannot appear here
>>   int x = [x](int y[sizeof x]){return sizeof x;}(0);
>>^
>>
>> The issue is also described in: 
>> https://cplusplus.github.io/CWG/issues/2569.html
>
> Is that something you encountered in existing code, or where you trying to 
> write test against this change.
> I only implemented the `decltype` part of the proposed resolution, for reason 
> explained in that link (supporting `sizeof(unqual-id)` and 
> `noexcept(unqual-id) seems extremely arbitrary).
> But hopefully WG21 will come up with a more encompassing fix before we 
> attempt to re-land this change

It is reduced from the existing code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119136/new/

https://reviews.llvm.org/D119136

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits