Review Request 123943: Port KoDocumentEntry::name() and mimeTypes() to KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123943/ --- Review request for Calligra. Repository: calligra Description --- Getting the data from QPluginLoader::metaData() which contains the entries from the desktop file. Diffs - libs/main/KoDocumentEntry.cpp f24a7ef Diff: https://git.reviewboard.kde.org/r/123943/diff/ Testing --- Verified name() output the Name entry value from the desktop file and mimeTypes() the MimeType entry value. Thanks, Peter Simonsson ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123977: Make words configure dialog work in KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123977/ --- Review request for Calligra. Repository: calligra Description --- KPageDialog uses QDialogButtonBox for the buttons now so the signals has changed a bit. Diffs - words/part/dialogs/KWConfigureDialog.h 85b7d32 words/part/dialogs/KWConfigureDialog.cpp 6bb4ab3 Diff: https://git.reviewboard.kde.org/r/123977/diff/ Testing --- Thanks, Peter Simonsson ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123981: Port words page settings dialog to KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123981/ --- Review request for Calligra. Repository: calligra Description --- New button settings and signals. Diffs - words/part/KWView.cpp 6647e83 words/part/dialogs/KWPageSettingsDialog.h 79e0d9d words/part/dialogs/KWPageSettingsDialog.cpp 43d1311 Diff: https://git.reviewboard.kde.org/r/123981/diff/ Testing --- Thanks, Peter Simonsson ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123981: Port words page settings dialog to KF5
> On June 2, 2015, 9 a.m., Boudewijn Rempt wrote: > > I sort of suspect that the same change is needed across all Calligra > > applications -- everyone is using kpagedialog for the settings! Yes it's needed all over the place. - Peter --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123981/#review81070 --- On June 1, 2015, 7:28 p.m., Peter Simonsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123981/ > --- > > (Updated June 1, 2015, 7:28 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > --- > > New button settings and signals. > > > Diffs > - > > words/part/KWView.cpp 6647e83 > words/part/dialogs/KWPageSettingsDialog.h 79e0d9d > words/part/dialogs/KWPageSettingsDialog.cpp 43d1311 > > Diff: https://git.reviewboard.kde.org/r/123981/diff/ > > > Testing > --- > > > Thanks, > > Peter Simonsson > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123977: Make words configure dialog work in KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123977/ --- (Updated June 2, 2015, 3:17 p.m.) Status -- This change has been marked as submitted. Review request for Calligra. Changes --- Submitted with commit 2ac99b55495cc49cd732d50ae1f2c27ca3f63ea6 by Peter Simonsson to branch frameworks. Repository: calligra Description --- KPageDialog uses QDialogButtonBox for the buttons now so the signals has changed a bit. Diffs - words/part/dialogs/KWConfigureDialog.h 85b7d32 words/part/dialogs/KWConfigureDialog.cpp 6bb4ab3 Diff: https://git.reviewboard.kde.org/r/123977/diff/ Testing --- Thanks, Peter Simonsson ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123981: Port words page settings dialog to KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123981/ --- (Updated June 2, 2015, 3:17 p.m.) Status -- This change has been marked as submitted. Review request for Calligra. Changes --- Submitted with commit 23681bcdfcd5265dc57165cc4dfbe9b9cc793d13 by Peter Simonsson to branch frameworks. Repository: calligra Description --- New button settings and signals. Diffs - words/part/KWView.cpp 6647e83 words/part/dialogs/KWPageSettingsDialog.h 79e0d9d words/part/dialogs/KWPageSettingsDialog.cpp 43d1311 Diff: https://git.reviewboard.kde.org/r/123981/diff/ Testing --- Thanks, Peter Simonsson ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123985: Port sheets' configure dialog to KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123985/ --- Review request for Calligra. Repository: calligra Description --- Fix buttons and signals. ?eenable the plugin selector. Diffs - CMakeLists.txt a4e3f24 sheets/CMakeLists.txt c7567c4 sheets/part/dialogs/PreferenceDialog.h 543bf45 sheets/part/dialogs/PreferenceDialog.cpp 8b044a8 Diff: https://git.reviewboard.kde.org/r/123985/diff/ Testing --- Thanks, Peter Simonsson ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Styled separators in KoToolBox
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102233/ --- Review request for Calligra. Summary --- Use the style to draw separators in KoToolBox Diffs - libs/main/KoToolBox.cpp b47f9da Diff: http://git.reviewboard.kde.org/r/102233/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Clean up the tool options widgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102234/ --- Review request for Calligra. Summary --- KarbonCalligraphyOptionWidget: KarbonPencilTool: KoZoomToolWidget: TreeShapeConfigWidget: Add stretch to make it look good on big screens KoToolBase: Don't add a generic window title in the default implementation of createOptionWidgets as it only duplicates what the docker header says KoPathTool: DefaultTool: Don't first create snapguide widget and set a window title and then create a new snapguide widget and add that to the list of widgets to return KoToolDocker: Handle empty window titles while creating the layout ReviewTool: Don't try to set a layout on a widget that already has a layout Diffs - karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.cpp 0ce337d karbon/plugins/tools/KarbonPencilTool.cpp 86c8fa5 libs/flake/KoToolBase.cpp 77c039d libs/flake/tools/KoPathTool.cpp 361324e libs/flake/tools/KoZoomToolWidget.ui ed3ba73 libs/main/KoToolDocker.cpp 78c881a plugins/defaultTools/defaulttool/DefaultTool.cpp f54ddd3 plugins/textshape/ReviewTool.cpp 8a1c88c plugins/treeshape/TreeShapeConfigWidget.ui e7e367f Diff: http://git.reviewboard.kde.org/r/102234/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Fix crash on File->New in words
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102240/ --- Review request for Calligra. Summary --- The RDF docker causes a crash on File->New because it doesn't clean up correctly when the canvas disappear. Diffs - words/part/dockers/KWRdfDocker.h 0396d5a Diff: http://git.reviewboard.kde.org/r/102240/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Fix for Words crashes on picking "Blank Document" in template dialog with one document already open.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102242/ --- Review request for Calligra. Summary --- Not one hundred percent sure this is the best way to fix this, but it is that best I could come up with. The crash occurs due to tool options docker trying to access widgets that's already been deleted. To avoid this I reset the widgets in the tool options dialog when a new document is loaded. This addresses bug 272410. http://bugs.kde.org/show_bug.cgi?id=272410 Diffs - libs/main/KoDockerManager.h 6e71db6 libs/main/KoDockerManager.cpp c893980 libs/main/KoMainWindow.cpp c629827 libs/main/KoToolDocker.cpp 425497c libs/main/KoToolDocker_p.h e7c373b Diff: http://git.reviewboard.kde.org/r/102242/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Fix layout of CellToolOptionWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102244/ --- Review request for Calligra. Summary --- Make CellToolOptionWidget use available space better on large screens while in vertical mode Diffs - tables/ui/CellToolOptionWidget.cpp 47f48c5 Diff: http://git.reviewboard.kde.org/r/102244/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Fix crash in slide sorter when one page is bigger than the viewport
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102351/ --- Review request for Calligra. Summary --- The slides sorter crashed on right click outside a page when the page itself is bigger than the viewport. Also fixed so that a page gets selected on right click if none is selected already as the code says it should be. Diffs - stage/part/KPrSlidesManagerView.cpp 1e3d08e Diff: http://git.reviewboard.kde.org/r/102351/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Fix crash in stage's slide sorter when one page is bigger than the viewport
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102351/ --- (Updated Aug. 17, 2011, 2:58 p.m.) Review request for Calligra. Summary (updated) --- The slides sorter crashed on right click outside a page when the page itself is bigger than the viewport. Also fixed so that a page gets selected on right click if none is selected already as the code says it should be. Diffs - stage/part/KPrSlidesManagerView.cpp 1e3d08e Diff: http://git.reviewboard.kde.org/r/102351/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Fix crash in stage's slide sorter when one page is bigger than the viewport
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102351/ --- (Updated Aug. 17, 2011, 7:25 p.m.) Review request for Calligra. Changes --- Less crapy debug Summary --- The slides sorter crashed on right click outside a page when the page itself is bigger than the viewport. Also fixed so that a page gets selected on right click if none is selected already as the code says it should be. Diffs (updated) - stage/part/KPrSlidesManagerView.cpp 1e3d08e Diff: http://git.reviewboard.kde.org/r/102351/diff Testing --- Thanks, Peter ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
