D18963: Improve KoModeBox display in horizontal Mode

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  Certainly a visual improvement! +1!
  
  Wait for code review before landing, of course.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg
Cc: ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

[Nathaniel Graham]

ngraham added a comment.


  The first image is the new version, not the old version. :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg
Cc: abetts, ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Nathaniel Graham]

ngraham added a comment.


  I'm always in favor of moving shared content into frameworks, but just to be 
a miserable contrarian here (so feel free to ignore me), is the size of a git 
repo really an impediment to new contributors? In my experience, the opposite 
is true, that the more git repos one needs to check out to be productive, the 
more opportunities there are for failures due to missing dependencies, code 
compiled out of order, etc. I mean, with a huge repo, you just clone it once 
and it's done. If it takes 30 seconds or a minute or two, is that really a big 
deal?

TASK DETAIL
  https://phabricator.kde.org/T12815

To: ngraham
Cc: ngraham, ognarb, Calligra-Devel-list, #calligra:_3.0, leinir, 
davidllewellynjones, dcaliste, cochise, vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Nathaniel Graham]

ngraham added a comment.


  In T12815#223428 , @rempt wrote:
  
  > As an aside, I think splitting up kdepim into so many repositories was a 
huge mistake. Listening to David Faure at the onboarding sprint only confirmed 
that opinion. Having to work on half a dozen repos to add a single feature to 
kmail sounds like hell to me. I think it would be a mistake for Calligra, too, 
but don't pay attention to me :-)
  
  
  I sometimes find myself feeling this way about Frameworks too. A recent 
experience at a hackathon where I helped 8 students set up complete development 
environments from scratch reinforced this viewpoint. Not that I'm seriously 
recommending re-merging the frameworks, but I would like to challenge the 
notion that splitting a monolithic codebase across multiple repos is a boon to 
onboarding; I don't think it is. It may have other benefits, but I don't think 
onboarding is one of them.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: ngraham
Cc: rempt, anthonyfieroni, dcaliste, boemann, pino, rjvbb, ngraham, ognarb, 
Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, cochise, 
vandenoever