Re: Autocorrect functionality
Le mercredi 19 octobre 2022, 01:05:19 CEST Albert Astals Cid a écrit : > Sorry for the cross-posting. > Please CC me, i'm on none of the two lists > > > Both pimcommon and calligra have Autocorrect functionality, but PIM one > broke at some point and I guess no one realized? Indeed I saw that it didn’t load default file long time ago but didn’t have time to investigate it. > > PIM is looking for files in > GenericDataDir/autocorrect > > https://invent.kde.org/pim/pimcommon/-/blob/master/src/pimcommon/autocorrec > tion/autocorrection.cpp#L1063 > > PIM does not install nor contain any autocorrect.xml file > > > > Calligra is looking for files both in > GenericDataDir/autocorrect and GenericDataDir/calligra/autocorrect > > https://invent.kde.org/office/calligra/-/blob/master/plugins/textediting/au > tocorrection/Autocorrect.cpp#L727 > > Calligra does contains an autocorrect.xml file that gets installed into > GenericDataDir/calligra/autocorrect/autocorrect.xml > > > So unless there's something wrong in my assessment, PIM autocorrect is > broken, and if it was not broken it would depend on calligra for the files > to exist since it does not ship its own autocorrect files (that's good, > since duplication is bad) > > > Solutions: > A) Make PIM look for files also in GenericDataDir/calligra and live with > the dependency to calligra for the feature Not a good solution as even me I don’t install it. > B) Accept that the feature in > PIM was broken for a long time and just remove it Not acceptable for sure. > C) Make a library that both PIM and Calligra use If you have time ok :) D) duplicate files, it’s the easy solution. > > Ideally we would go with C but we all know it's not like we have lots of > people with time available to jump and work on this... > > Comments? Opinions? > > Sorry for the cross-posting. > Please CC me, i'm on none of the two lists > > Cheers, > Albert -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel: France +33 (0)4 90 84 08 53, http://www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts
Re: Autocorrect functionality
Le mercredi 19 octobre 2022, 18:02:58 CEST Albert Astals Cid a écrit : > > > > D) duplicate files, it’s the easy solution. > > I don't think that's a good idea, counting language files it's 15 files, > copying them means they will definitely diverge at some point > Or we need to move them in a repo which is a dependancy for pim* and calligra => in a framework module. Otherwise kmail autocorrect will be always broken. After that is calligra word is still in development ? Is still release ? Regards.
Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml
> On juil. 6, 2014, 2:10 après-midi, Friedrich W. H. Kossebau wrote: > > Was this ever committed? > > Camilla Boemann wrote: > Don't think so but I also don't think it belongs to calligra anymore. > Laurent, what do you think? > > Inge Wallin wrote: > Hmm, why not? What would be a better place? > I agree that if all word processors could share one autocorrect database > it would be best but is there a way to do that? > > Camilla Boemann wrote: > because it is shared right now in kdelibs somewhere - or I could be wrong > - why I asked laurent Hi, it's stored now in l10n//data/kdelibs/autocorrect so if you commit in this file it's shared for calligra/kmail Regards - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108924/#review61717 --- On fév. 18, 2013, 6:30 matin, Heena Mahour wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/108924/ > --- > > (Updated fév. 18, 2013, 6:30 matin) > > > Review request for Calligra, Camilla Boemann and Laurent Montel. > > > Repository: calligra > > > Description > --- > > added some more autocorrection and grammer correction > > > Diffs > - > > usr/share/kde4/apps/calligra/autocorrect/autocorrect.xml PRE-CREATION > usr/share/kde4/apps/calligra/autocorrect/en_US.xml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/108924/diff/ > > > Testing > --- > > No crashing. > > > Thanks, > > Heena Mahour > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Autocorrect
Hi, Sorry for cross-posting. In kmail (4.10) I implemented auto-correction for kmcomposer. So now we can autocorrect text when we wrote as in calligraword for example. There is a autocorrect.xml file in each language. And I looked at in fr directory and there is the same file in l10n/fr/data/calligra/autocorrect and l10n/fr/data/koffice/autocorrect So it’s already duplicated. Now I would like to use the same file. So I would like that we move this file in l10n/fr/data/kdelibs/autocorrect and install it in /share/apps/autocorrect/ for example. Same for other language :) What do you think about it ? I don’t want to download all l10n :) I can create a patch for calligra/koffice if necessary to fix path for the future (and keep compatibility) Regards: PS: I looked at calligra code and fixed some code, because there is a lot of bugs into and it’s not totally implemented... -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le vendredi 14 septembre 2012 13:18:51 laurent Montel a écrit : > Hi, > Sorry for cross-posting. > > In kmail (4.10) I implemented auto-correction for kmcomposer. So now we can > autocorrect text when we wrote as in calligraword for example. > > There is a autocorrect.xml file in each language. > > And I looked at in fr directory and there is the same file in > l10n/fr/data/calligra/autocorrect and l10n/fr/data/koffice/autocorrect > So it’s already duplicated. > > Now I would like to use the same file. > > So I would like that we move this file in l10n/fr/data/kdelibs/autocorrect > and install it in /share/apps/autocorrect/ for example. > > Same for other language :) > > What do you think about it ? > > > I don’t want to download all l10n :) > > I can create a patch for calligra/koffice if necessary to fix path for the > future (and keep compatibility) > > > Regards: > > PS: I looked at calligra code and fixed some code, because there is a lot of > bugs into and it’s not totally implemented... CC me please because I am not subscribe to calligra-devel/koffice-devel thanks > -- > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer > KDAB (France) S.A.S., a KDAB Group company > Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 > KDAB - Qt Experts - Platform-independent software solutions -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le vendredi 14 septembre 2012 13:23:42 Boudewijn Rempt a écrit : > On Fri, 14 Sep 2012, laurent Montel wrote: > > > Hi, > > Sorry for cross-posting. > > > > In kmail (4.10) I implemented auto-correction for kmcomposer. So now we can > > autocorrect text when we wrote as in calligraword for example. > > > > There is a autocorrect.xml file in each language. > > > > And I looked at in fr directory and there is the same file in > > l10n/fr/data/calligra/autocorrect and l10n/fr/data/koffice/autocorrect > > So it’s already duplicated. > > > > Now I would like to use the same file. > > > > So I would like that we move this file in l10n/fr/data/kdelibs/autocorrect > > and install it in /share/apps/autocorrect/ for example. > > > > Same for other language :) > > > > What do you think about it ? > > > > > > I don’t want to download all l10n :) > > > > I can create a patch for calligra/koffice if necessary to fix path for the > > future (and keep compatibility) > > > > > > Regards: > > > > PS: I looked at calligra code and fixed some code, because there is a lot > > of bugs into and it’s not totally implemented... > > > > I wouldn't object. I think there's not much reason to actually code > patches for KOffice, though: it's vanishingly unlikely that there will > ever be a release and the koffice.org website has been replaced with a > placeholder. Ah ? Oki it’s dead ? Regards > Boudewijn -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le vendredi 14 septembre 2012 15:24:15 Yuri Chornoivan a écrit :
> написане Fri, 14 Sep 2012 14:18:51 +0300, laurent Montel :
>
> > Hi,
> > Sorry for cross-posting.
> >
> > In kmail (4.10) I implemented auto-correction for kmcomposer. So now we
> > can autocorrect text when we wrote as in calligraword for example.
> >
> > There is a autocorrect.xml file in each language.
> >
> > And I looked at in fr directory and there is the same file in
> > l10n/fr/data/calligra/autocorrect and l10n/fr/data/koffice/autocorrect
> > So it’s already duplicated.
> >
> > Now I would like to use the same file.
> >
> > So I would like that we move this file in
> > l10n/fr/data/kdelibs/autocorrect and install it in
> > /share/apps/autocorrect/ for example.
> >
> > Same for other language :)
> >
> > What do you think about it ?
> >
> >
> > I don’t want to download all l10n :)
> >
> > I can create a patch for calligra/koffice if necessary to fix path for
> > the future (and keep compatibility)
> >
> >
> > Regards:
> >
> > PS: I looked at calligra code and fixed some code, because there is a
> > lot of bugs into and it’s not totally implemented...
> >
>
> Hi,
>
> Just two questions:
>
> 1. The previous naming scheme was _.xml with
> installation into ${DATA_INSTALL_DIR}/calligra/autocorrect [1]. How to
> adopt CMakeLists.txt to the new location (if it's needed)?
Just install into ${DATA_INSTALL_DIR}/autocorrect/_.xml no ?
For me it’s good no ?
> 2. Will this change be ported into stable (should we change the names and
> CMakeLists.txt in stable branch)?
For 4.10 not for 4.9.x.
I created code for 4.10
>
> Thanks in advance for your answers.
>
> Best regards,
> Yuri
>
> [1] http://lists.kde.org/?l=calligra-devel&m=133208596016809&w=2
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le vendredi 14 septembre 2012 14:35:23 C. Boemann a écrit :
> On Friday 14 September 2012 14:24:15 Yuri Chornoivan wrote:
> > написане Fri, 14 Sep 2012 14:18:51 +0300, laurent Montel
> :
> > > Hi,
> > > Sorry for cross-posting.
> > >
> > > In kmail (4.10) I implemented auto-correction for kmcomposer. So now we
> > > can autocorrect text when we wrote as in calligraword for example.
> > >
> > > There is a autocorrect.xml file in each language.
> > >
> > > And I looked at in fr directory and there is the same file in
> > > l10n/fr/data/calligra/autocorrect and l10n/fr/data/koffice/autocorrect
> > > So it’s already duplicated.
> > >
> > > Now I would like to use the same file.
> > >
> > > So I would like that we move this file in
> > > l10n/fr/data/kdelibs/autocorrect and install it in
> > > /share/apps/autocorrect/ for example.
> > >
> > > Same for other language :)
> > >
> > > What do you think about it ?
> > >
> > >
> > > I don’t want to download all l10n :)
> > >
> > > I can create a patch for calligra/koffice if necessary to fix path for
> > > the future (and keep compatibility)
> > >
> > >
> > > Regards:
> > >
> > > PS: I looked at calligra code and fixed some code, because there is a
> > > lot of bugs into and it’s not totally implemented...
> >
> > Hi,
> >
> > Just two questions:
> >
> > 1. The previous naming scheme was _.xml with
> > installation into ${DATA_INSTALL_DIR}/calligra/autocorrect [1]. How to
> > adopt CMakeLists.txt to the new location (if it's needed)?
> >
> > 2. Will this change be ported into stable (should we change the names and
> > CMakeLists.txt in stable branch)?
> >
> > Thanks in advance for your answers.
> >
> > Best regards,
> > Yuri
> >
> > [1] http://lists.kde.org/?l=calligra-devel&m=133208596016809&w=2
> > ___
> > calligra-devel mailing list
> > calligra-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/calligra-devel
> Uhm are we sure that the set of corrections applied in KMail should be the
> same in Words etc.
For me if we make autocorrection in calligra you want the same in kmail :)
> I have no big objection, but I think some kind of user investigation is
> warranted. So whatever you decide, please make sure it doesn't conflict with
> user's needs
When we modify file we don’t want to modify it for calligra and after kmail.
So an uniq file is good.
> And how about the fact that the user can edit this in Words, and how will
> installation work. Each app will have to install it's own version possibly
> overlapping
If you want to keep local file for calligra in .kde/share/apps/calligra/* it’s
not a problem for me.
But I think that it’s better to have an uniq file for it.
But for reading global file it’s better to have it in global position. (in
/share/apps/autocorrect)
And it’s not a good idea to duplicate yet in l10n.
Better to have .xml in specific position which can release with kdelibs (kdepim
can’t depend against calligra :) )
>
> all questions to be answered.
>
> I'm going to leave it in your capable hands now
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le dimanche 16 septembre 2012 09:25:45 Cyrille Berger Skott a écrit : > On Saturday 15 Sep 2012, Albert Astals Cid wrote: > > I can move all the files to the correct location (and fix their > > CMakeLists.txt) if that is what is decided. > > > > Cheers, > > Albert > > > > P.S: Before promoting autocorrect much I suggest you have a look at the > > (probably fake) site of http://www.damnyouautocorrect.com/ > > To be honnest, they either have a very broken autocorrect system on thoses > phones, or a lot of dyslexic people are blamming their phones, for > autocorrect > to go from swimming to sem**, there is something very very wrong. It is also > true that when using a phone in T9 mode can lead to such words mistakes, but > that is also something that does not affect autocorrect. > > In fact, autocorrect (and it usually is) should be limited to very obvious > spelling mistakes ie, "conection" -> "connection", and so on. That is also > why > I don't see why there would be a different dataset for kmail or calligra. Exact. We must have the same dataset. Otherwise users will not understand why we have 2 datasets. > -- > Cyrille Berger Skott -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090 KDAB - Qt Experts - Platform-independent software solutions ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le dimanche 16 septembre 2012 13:01:38 Albert Astals Cid a écrit :
> El Diumenge, 16 de setembre de 2012, a les 09:58:23, laurent Montel va
> escriure:
> > Le dimanche 16 septembre 2012 09:25:45 Cyrille Berger Skott a écrit :
> > > On Saturday 15 Sep 2012, Albert Astals Cid wrote:
> > > > I can move all the files to the correct location (and fix their
> > > > CMakeLists.txt) if that is what is decided.
> > > >
> > > > Cheers,
> > > >
> > > > Albert
> > > >
> > > > P.S: Before promoting autocorrect much I suggest you have a look at the
> > > > (probably fake) site of http://www.damnyouautocorrect.com/
> > >
> > > To be honnest, they either have a very broken autocorrect system on thoses
> > > phones, or a lot of dyslexic people are blamming their phones, for
> > > autocorrect to go from swimming to sem**, there is something very very
> > > wrong. It is also true that when using a phone in T9 mode can lead to
> > > such words mistakes, but that is also something that does not affect
> > > autocorrect.
> > >
> > > In fact, autocorrect (and it usually is) should be limited to very obvious
> > > spelling mistakes ie, "conection" -> "connection", and so on. That is also
> > > why I don't see why there would be a different dataset for kmail or
> > > calligra.
> > Exact.
> > We must have the same dataset.
> > Otherwise users will not understand why we have 2 datasets.
>
> Sure, I never said anything against that ;-)
>
> As said, once you've done the code change in
> kdelibs/kdepim/calligra/koffice/wathever just tell me and i'll adapt all the
> l10n-kde4 languages in trunk (I understand we are not touching stable, right?)
Sorry was in training last Week (so not time to create this patch).
Now I think that you can move all in kdelibs/data/autocorrect
And install them in ${DATA_INSTALL_DIR}/autocorrect
Thanks a lot.
Regards
> Cheers,
> Albert
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
diff --git a/plugins/textediting/autocorrection/Autocorrect.cpp b/plugins/textediting/autocorrection/Autocorrect.cpp
index cef9beb..53fdee6 100644
--- a/plugins/textediting/autocorrection/Autocorrect.cpp
+++ b/plugins/textediting/autocorrection/Autocorrect.cpp
@@ -684,18 +684,26 @@ void Autocorrect::readAutocorrectXmlEntry()
QString kdelang = locale->languageList().first();
kdelang.remove(QRegExp("@.*"));
+QStringList folders;
+folders<findResource("data", "calligra/autocorrect/" + m_autocorrectLang + ".xml");
-if (m_autocorrectLang != "all_languages") {
-if (fname.isEmpty() && !kdelang.isEmpty())
-fname = KGlobal::dirs()->findResource("data", "calligra/autocorrect/" + kdelang + ".xml");
-if (fname.isEmpty() && kdelang.contains("_")) {
-kdelang.remove( QRegExp( "_.*" ) );
-fname = KGlobal::dirs()->findResource("data", "calligra/autocorrect/" + kdelang + ".xml");
+Q_FOREACH(const QString& path, folders)
+{
+if (!m_autocorrectLang.isEmpty())
+fname = KGlobal::dirs()->findResource("data", path + "autocorrect/" + m_autocorrectLang + ".xml");
+if (m_autocorrectLang != "all_languages") {
+if (fname.isEmpty() && !kdelang.isEmpty())
+fname = KGlobal::dirs()->findResource("data", path + "autocorrect/" + kdelang + ".xml");
+if (fname.isEmpty() && kdelang.contains("_")) {
+kdelang.remove( QRegExp( "_.*" ) );
+fname = KGlobal::dirs()->findResource("data", path + "autocorrect/" + kdelang + ".xml");
+}
+if (fname.isEmpty())
+fname = KGlobal::dirs()->findResource("data", path + "autocorrect/autocorrect.xml");
+}
+if(!fname.isEmpty()) {
+break;
}
-if (fname.isEmpty())
-fname = KGlobal::dirs()->findResource("data", "calligra/autocorrect/autocorrect.xml");
}
if (m_autocorrectLang.isEmpty())
m_autocorrectLang = kdelang;
@@ -795,7 +803,7 @@ void Autocorrect::readAutocorrectXmlEntry()
void Autocorrect::writeAutocorrectXmlEntry()
{
-const QString fname = KGlobal::dirs()->locateLocal("data", QLatin1String("calligra/autocorrect/autocorrect.xml"));
+const QString fname = KGlobal::dirs()->locateLocal("data", QLatin1String("autocorrect/autocorrect.xml"));
QFile file(fname);
if( !file.open( QIODevice::WriteOnly | QIODevice::Text ) ) {
qDebug()<<"We can't save in file :"<___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le lundi 24 septembre 2012 08:55:03 C. Boemann a écrit :
> On Monday 24 September 2012 08:18:26 laurent Montel wrote:
> > Le dimanche 16 septembre 2012 13:01:38 Albert Astals Cid a écrit :
> > > El Diumenge, 16 de setembre de 2012, a les 09:58:23, laurent Montel va
> > >
> > > escriure:
> > > > Le dimanche 16 septembre 2012 09:25:45 Cyrille Berger Skott a écrit :
> > > > > On Saturday 15 Sep 2012, Albert Astals Cid wrote:
> > > > > > I can move all the files to the correct location (and fix their
> > > > > > CMakeLists.txt) if that is what is decided.
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Albert
> > > > > >
> > > > > > P.S: Before promoting autocorrect much I suggest you have a look at
> > > > > > the (probably fake) site of http://www.damnyouautocorrect.com/
> > > > >
> > > > > To be honnest, they either have a very broken autocorrect system on
> > > > > thoses phones, or a lot of dyslexic people are blamming their
> > > > > phones, for autocorrect to go from swimming to sem**, there is
> > > > > something very very wrong. It is also true that when using a phone
> > > > > in T9 mode can lead to such words mistakes, but that is also
> > > > > something that does not affect autocorrect.
> > > > >
> > > > > In fact, autocorrect (and it usually is) should be limited to very
> > > > > obvious spelling mistakes ie, "conection" -> "connection", and so
> > > > > on. That is also why I don't see why there would be a different
> > > > > dataset for kmail or calligra.
> > > >
> > > > Exact.
> > > > We must have the same dataset.
> > > > Otherwise users will not understand why we have 2 datasets.
> > >
> > > Sure, I never said anything against that ;-)
> > >
> > > As said, once you've done the code change in
> > > kdelibs/kdepim/calligra/koffice/wathever just tell me and i'll adapt all
> > > the l10n-kde4 languages in trunk (I understand we are not touching
> > > stable, right?)
> >
> > Sorry was in training last Week (so not time to create this patch).
> > Now I think that you can move all in kdelibs/data/autocorrect
> >
> > And install them in ${DATA_INSTALL_DIR}/autocorrect
> >
> > Thanks a lot.
> > Regards
> >
> > > Cheers,
> > >
> > > Albert
> Ship it!
>
> And thanks a lot :)
Done :)
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Autocorrect
Le lundi 24 septembre 2012 10:39:16 Albert Astals Cid a écrit :
> El Dilluns, 24 de setembre de 2012, a les 08:18:26, laurent Montel va
> escriure:
> > Le dimanche 16 septembre 2012 13:01:38 Albert Astals Cid a écrit :
> > > El Diumenge, 16 de setembre de 2012, a les 09:58:23, laurent Montel va
> > >
> > > escriure:
> > > > Le dimanche 16 septembre 2012 09:25:45 Cyrille Berger Skott a écrit :
> > > > > On Saturday 15 Sep 2012, Albert Astals Cid wrote:
> > > > > > I can move all the files to the correct location (and fix their
> > > > > > CMakeLists.txt) if that is what is decided.
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Albert
> > > > > >
> > > > > > P.S: Before promoting autocorrect much I suggest you have a look at
> > > > > > the
> > > > > > (probably fake) site of http://www.damnyouautocorrect.com/
> > > > >
> > > > > To be honnest, they either have a very broken autocorrect system on
> > > > > thoses
> > > > > phones, or a lot of dyslexic people are blamming their phones, for
> > > > > autocorrect to go from swimming to sem**, there is something very very
> > > > > wrong. It is also true that when using a phone in T9 mode can lead to
> > > > > such words mistakes, but that is also something that does not affect
> > > > > autocorrect.
> > > > >
> > > > > In fact, autocorrect (and it usually is) should be limited to very
> > > > > obvious
> > > > > spelling mistakes ie, "conection" -> "connection", and so on. That is
> > > > > also
> > > > > why I don't see why there would be a different dataset for kmail or
> > > > > calligra.
> > > >
> > > > Exact.
> > > > We must have the same dataset.
> > > > Otherwise users will not understand why we have 2 datasets.
> > >
> > > Sure, I never said anything against that ;-)
> > >
> > > As said, once you've done the code change in
> > > kdelibs/kdepim/calligra/koffice/wathever just tell me and i'll adapt all
> > > the l10n-kde4 languages in trunk (I understand we are not touching
> > > stable, right?)
> > Sorry was in training last Week (so not time to create this patch).
> > Now I think that you can move all in kdelibs/data/autocorrect
> >
> > And install them in ${DATA_INSTALL_DIR}/autocorrect
>
> Done.
>
> Albert
Thanks a lot :)
>
> >
> > Thanks a lot.
> > Regards
> >
> > > Cheers,
> > >
> > > Albert
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 --- plugins/textediting/autocorrection/Autocorrect.cpp <http://git.reviewboard.kde.org/r/107229/#comment16716> You never breaks here ? So you will read a lot of file no ? - Laurent Montel On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 6, 2012, 5:54 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wrote: > yes that is the point - I want to first read the general kde wide file > and then the calligra specific file. > > I could also revert your original patch and just read the calligra one > > the point is we need af file with the calligra specifics "The special tags in the calligra supplied config files where never found" which special tags? global file and calligra file is the same (installed from l10n) So What is the problem ? - Laurent --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 --- On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > ------- > > (Updated Nov. 6, 2012, 5:54 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wrote: > yes that is the point - I want to first read the general kde wide file > and then the calligra specific file. > > I could also revert your original patch and just read the calligra one > > the point is we need af file with the calligra specifics > > Laurent Montel wrote: > "The special tags in the calligra supplied config files where never > found" which special tags? > > global file and calligra file is the same (installed from l10n) So What > is the problem ? > > C. Boemann wrote: > Uhm it's not the same file. It may be so in kde 4.9 onwards or so but we > should be compatible with kde 4.5 > > but calligra needs special tags that I for one don't have in my > .kde/share/apps/autocorrect/* file I don't understand because it's installed from same file from l10n... So what is missing tag ? - Laurent --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 --- On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 6, 2012, 5:54 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wrote: > yes that is the point - I want to first read the general kde wide file > and then the calligra specific file. > > I could also revert your original patch and just read the calligra one > > the point is we need af file with the calligra specifics > > Laurent Montel wrote: > "The special tags in the calligra supplied config files where never > found" which special tags? > > global file and calligra file is the same (installed from l10n) So What > is the problem ? > > C. Boemann wrote: > Uhm it's not the same file. It may be so in kde 4.9 onwards or so but we > should be compatible with kde 4.5 > > but calligra needs special tags that I for one don't have in my > .kde/share/apps/autocorrect/* file > > Laurent Montel wrote: > I don't understand because it's installed from same file from l10n... > So what is missing tag ? > > C. Boemann wrote: > for example: > > > > > > > > > Error is not that file changed, it's that we don't store it. When I looked at calligra code there was not save code => you didn't save it. => I added it, and missing to add this part. I will create a patch for it. (it's right I don't use it in kmail => I didn't see that it was missing) Will fix it soon. When you added this plugins to calligra (don't know who) rewrite it and forgot to add write code... - Laurent --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 --- On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 6, 2012, 5:54 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wrote: > yes that is the point - I want to first read the general kde wide file > and then the calligra specific file. > > I could also revert your original patch and just read the calligra one > > the point is we need af file with the calligra specifics > > Laurent Montel wrote: > "The special tags in the calligra supplied config files where never > found" which special tags? > > global file and calligra file is the same (installed from l10n) So What > is the problem ? > > C. Boemann wrote: > Uhm it's not the same file. It may be so in kde 4.9 onwards or so but we > should be compatible with kde 4.5 > > but calligra needs special tags that I for one don't have in my > .kde/share/apps/autocorrect/* file > > Laurent Montel wrote: > I don't understand because it's installed from same file from l10n... > So what is missing tag ? > > C. Boemann wrote: > for example: > > > > > > > > > > > Laurent Montel wrote: > Error is not that file changed, it's that we don't store it. > When I looked at calligra code there was not save code => you didn't save > it. > => I added it, and missing to add this part. > > > I will create a patch for it. > (it's right I don't use it in kmail => I didn't see that it was missing) > > Will fix it soon. > > When you added this plugins to calligra (don't know who) rewrite it and > forgot to add write code... I fixed save superscript in kmail and calligra regards - Laurent --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 --- On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote: > > ------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 6, 2012, 5:54 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wrote: > yes that is the point - I want to first read the general kde wide file > and then the calligra specific file. > > I could also revert your original patch and just read the calligra one > > the point is we need af file with the calligra specifics > > Laurent Montel wrote: > "The special tags in the calligra supplied config files where never > found" which special tags? > > global file and calligra file is the same (installed from l10n) So What > is the problem ? > > C. Boemann wrote: > Uhm it's not the same file. It may be so in kde 4.9 onwards or so but we > should be compatible with kde 4.5 > > but calligra needs special tags that I for one don't have in my > .kde/share/apps/autocorrect/* file > > Laurent Montel wrote: > I don't understand because it's installed from same file from l10n... > So what is missing tag ? > > C. Boemann wrote: > for example: > > > > > > > > > > > Laurent Montel wrote: > Error is not that file changed, it's that we don't store it. > When I looked at calligra code there was not save code => you didn't save > it. > => I added it, and missing to add this part. > > > I will create a patch for it. > (it's right I don't use it in kmail => I didn't see that it was missing) > > Will fix it soon. > > When you added this plugins to calligra (don't know who) rewrite it and > forgot to add write code... > > Laurent Montel wrote: > I fixed save superscript in kmail and calligra > regards > > C. Boemann wrote: > Ok thanks for that, but it still leaves the problem that it's not loaded > in the first place > > There are more things here: > > 1) the folders << "/" > at the very least I think it should be "" For me the found filename > was "/autocorrect/en_US.xml" which is a file that doesn't even exist, yet > findResource returns as if it did. This may be due to a bug/difference in > older versions of findResource. > > 2) even if I fix the above then the file I do load > "/home/cbo/.kde/share/apps/autocorrect/autocorrect.xml" doesn't contain the > superscript part. This is probably a derivative problem of us not saving in > the past, but it also means that the file is still around and will be loaded. > 1) don't know but if it fixes for you loading change to "" 2) we can't real fix it without remove this "/home/cbo/.kde/share/apps/autocorrect/autocorrect.xml" in the past we didn't save it so it's not a real problem to remove it and recreate it locally now that save/load is ok. (I just added saving few weeks ago so it will not impact a lot of calligra release I think). - Laurent --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 --- On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 6, 2012, 5:54 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wrote: > yes that is the point - I want to first read the general kde wide file > and then the calligra specific file. > > I could also revert your original patch and just read the calligra one > > the point is we need af file with the calligra specifics > > Laurent Montel wrote: > "The special tags in the calligra supplied config files where never > found" which special tags? > > global file and calligra file is the same (installed from l10n) So What > is the problem ? > > C. Boemann wrote: > Uhm it's not the same file. It may be so in kde 4.9 onwards or so but we > should be compatible with kde 4.5 > > but calligra needs special tags that I for one don't have in my > .kde/share/apps/autocorrect/* file > > Laurent Montel wrote: > I don't understand because it's installed from same file from l10n... > So what is missing tag ? > > C. Boemann wrote: > for example: > > > > > > > > > > > Laurent Montel wrote: > Error is not that file changed, it's that we don't store it. > When I looked at calligra code there was not save code => you didn't save > it. > => I added it, and missing to add this part. > > > I will create a patch for it. > (it's right I don't use it in kmail => I didn't see that it was missing) > > Will fix it soon. > > When you added this plugins to calligra (don't know who) rewrite it and > forgot to add write code... > > Laurent Montel wrote: > I fixed save superscript in kmail and calligra > regards > > C. Boemann wrote: > Ok thanks for that, but it still leaves the problem that it's not loaded > in the first place > > There are more things here: > > 1) the folders << "/" > at the very least I think it should be "" For me the found filename > was "/autocorrect/en_US.xml" which is a file that doesn't even exist, yet > findResource returns as if it did. This may be due to a bug/difference in > older versions of findResource. > > 2) even if I fix the above then the file I do load > "/home/cbo/.kde/share/apps/autocorrect/autocorrect.xml" doesn't contain the > superscript part. This is probably a derivative problem of us not saving in > the past, but it also means that the file is still around and will be loaded. > > > Laurent Montel wrote: > 1) don't know but if it fixes for you loading change to "" > 2) we can't real fix it without remove this > "/home/cbo/.kde/share/apps/autocorrect/autocorrect.xml" in the past we didn't > save it so it's not a real problem to remove it and recreate it locally now > that save/load is ok. > (I just added saving few weeks ago so it will not impact a lot of > calligra release I think). > > C. Boemann wrote: > 1) ok > 2) ok that is good news > > But! we have a bigger problem too: If both apps save to > "/home/cbo/.kde/share/apps/autocorrect/autocorrect.xml" then we have a > problem if the set of tags doesn't correspond. what if in the future we want > to ad another tag, then if the user still uses an old kmail too, then the xml > file will be overwritten and the setting lost. > > Also if we ever want to add a new set of tags it will never be loaded > because "/home/cbo/.kde/share/apps/autocorrect/autocorrect.xml" will take > precedence Autocorrect.xml is for all kde so it's right if in calligra or kmail we add new tag it will not saved/loaded. But by default we mustn't add new tag without ask to kdepim or calligra dev :) For the moment we can't shared save/load code but perhaps for the future we can move it in kdelibs for example to fix it. Perhaps we can add version in xml file, but I think we will look at it when calligra dev or kdepim dev (me :) ) will want to add more tag. Not necessary for the moment to increase complexity of code I think. - Laurent ------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 --
Re: Review Request: autocorrect config file lookup change
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21569 --- plugins/textediting/autocorrection/Autocorrect.cpp <http://git.reviewboard.kde.org/r/107229/#comment16760> Simple and Double quote can customize (see UI) => we mustn't remove this code. - Laurent Montel On Nov. 7, 2012, 5:04 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 7, 2012, 5:04 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp b26df0b > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21571 --- plugins/textediting/autocorrection/Autocorrect.cpp <http://git.reviewboard.kde.org/r/107229/#comment16761> "custom" no ? - Laurent Montel On Nov. 7, 2012, 5:04 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 7, 2012, 5:04 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp b26df0b > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21572 --- plugins/textediting/autocorrection/Autocorrect.cpp <http://git.reviewboard.kde.org/r/107229/#comment16762> remove it plugins/textediting/autocorrection/Autocorrect.cpp <http://git.reviewboard.kde.org/r/107229/#comment16763> remove it - Laurent Montel On Nov. 7, 2012, 5:04 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 7, 2012, 5:04 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp b26df0b > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: autocorrect config file lookup change
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21573 --- Ship it! Seems good for me. Will adapt kmail soon. Regards - Laurent Montel On Nov. 7, 2012, 5:20 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107229/ > --- > > (Updated Nov. 7, 2012, 5:20 p.m.) > > > Review request for Calligra and Laurent Montel. > > > Description > --- > > The special tags in the calligra supplied config files where never found > > So I've changed it so we first look up the general files and then the > calligra specific files on top > > A problem I see is that the general contents is never really used with my > approach if we afterwards find a calligra special file > > So a better suggestion is appreciated > > > Diffs > - > > plugins/textediting/autocorrection/Autocorrect.h 5b76121 > plugins/textediting/autocorrection/Autocorrect.cpp b26df0b > > Diff: http://git.reviewboard.kde.org/r/107229/diff/ > > > Testing > --- > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
