D29542: Refactor canvas event handling
danders added a comment. This seems to work fine, I also tested with only pageapp changes. Imho I would prefer to separate the pageapp and KoMainWindow changes into separate commits, The pageapp changes should go into 3.2 branch followed by a swift release. I don't think the KoMainWindow changes should go into the branch as it only removes unused functionallity. I'm a bit in two minds if it should go in at all actually, so I'll leave it you or maybe somebody else has an opinion. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D29542: Refactor canvas event handling
anthonyfieroni added a comment. Seems fine, i'll push pageapp/flake changes as part of this review in 3.2 branch and master, refactoring main window in separate commit master only. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
Bugfix release 3.2.1 planned tomorrow Thursday 2020-05-14
Release needs to be tomorrow because of move to invent.kde.org -- Cheers, Dag
D29542: Refactor canvas event handling
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:2258d76ae064: Fix canvas event handling (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29542?vs=82646&id=82715#toc REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29542?vs=82646&id=82715 REVISION DETAIL https://phabricator.kde.org/D29542 AFFECTED FILES libs/flake/KoCanvasControllerWidget.cpp libs/pageapp/KoPAView.cpp To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D29542: Refactor canvas event handling
leinir added a comment. Incidentally, while this was committed before i could test it, i can confirm that it works fine with Calligra Gemini REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D29542: Refactor canvas event handling
anthonyfieroni added a comment. Thank you, i should wait ship it, but just got Dag comment as it is. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29542 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D15111: [KoUnit] Let's show pixel units
anthonyfieroni updated this revision to Diff 82815. anthonyfieroni added reviewers: ndavis, VDG. anthonyfieroni added a comment. Rebase on master REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15111?vs=41190&id=82815 REVISION DETAIL https://phabricator.kde.org/D15111 AFFECTED FILES filters/karbon/image/ImageExportOptionsWidget.cpp libs/main/KoView_p.h libs/main/config/KoConfigMiscPage.cpp libs/odf/KoUnit.cpp libs/odf/KoUnit.h libs/odf/tests/TestKoUnit.cpp libs/widgets/KoPageLayoutWidget.cpp sheets/part/Doc.cpp sheets/part/dialogs/PreferenceDialog.cpp To: anthonyfieroni, boemann, danders, #calligra:_3.0, ndavis, #vdg Cc: staniek, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
