D29242: WIP: redesign sidebar

2020-04-29 Thread Carl Schwan
ognarb updated this revision to Diff 81490.
ognarb added a comment.


  - More work in progress change
  
  TODO
  
  - don't make KoModeBox public
  - Implement add shapes action
  - Figure out how to draw line seperator
  - Fix some issues found when applying the Breeze ToolArea patch

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29242?vs=81390&id=81490

BRANCH
  redesign

REVISION DETAIL
  https://phabricator.kde.org/D29242

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoModeBox.cpp
  libs/widgets/KoModeBoxDocker.cpp
  libs/widgets/KoModeBoxFactory.cpp
  libs/widgets/KoModeBox_p.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/TextTool.h
  plugins/textshape/TextToolFactory.cpp
  plugins/textshape/dialogs/SimpleCharacterWidget.cpp
  plugins/textshape/dialogs/SimpleCharacterWidget.ui
  words/part/KWGui.cpp
  words/part/KWGui.h
  words/part/KWView.cpp
  words/part/calligrawords.rc

To: ognarb, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever


D29242: WIP: redesign sidebar

2020-04-29 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> calligrawords.rc:2
>  
>  
>  

Increase version.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever


D25714: [WIP]: Port away from deprecated KHtml

2020-04-29 Thread Carl Schwan
ognarb added a comment.


  I forgot about this diff. Now that I looked again I found a flaw in the 
migrations: QDomDocument only supports valid XML files but there are valid HTML 
files that aren't valid XML files. So probably QDomDocument is not a solution :(

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever