D25714: [WIP]: Port away from deprecated KHtml

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> htmlimport.h:58-59
>  KoFilter::ConversionStatus loadUrl(const QUrl &url);
> -void parseNode(DOM::Node n);
> -bool parseTag(DOM::Element e);
> +void parseNode(QDomNode n);
> +bool parseTag(QDomElement e);
>  bool createStyle();

const ref here?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Damien Caliste]

dcaliste added a comment.


  As a nobody, my opinion on the rightfullness to split or not the repository 
is of no interest. But what I like in the proposition of @leinir is the target 
to separate the "engine" from the UI (_i.e._ the widgetery). As an example 
(hopefully not outdated), the "find" classes, the one to search and replace, 
are deeply liked to the widgets that control them. It makes it impossible to 
reuse these class in a UI different from the original one.
  
  Separating the repositories is a way to enforce this engine _vs._ UI design. 
But it can also be achieved in the monolithic repo, by removing the 
dependencies to `kowidgets` in the CMakeLists for instance. I would be happy to 
join any task that would goes in that direction.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: dcaliste
Cc: dcaliste, boemann, pino, rjvbb, ngraham, ognarb, Calligra-Devel-list, 
#calligra:_3.0, leinir, davidllewellynjones, cochise, vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Anthony Fieroni]

anthonyfieroni added a comment.


  @leinir correct me if i'm wrong, but this can be beneficial if some of 
Calligra Suite want to have different release circle, like Krita before. Or you 
want Krita to returns back to Calligra framework?

TASK DETAIL
  https://phabricator.kde.org/T12815

To: anthonyfieroni
Cc: anthonyfieroni, dcaliste, boemann, pino, rjvbb, ngraham, ognarb, 
Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, cochise, 
vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Boudewijn Rempt]

rempt added a comment.


  In T12815#223424 , @anthonyfieroni 
wrote:
  
  > @leinir Or you want Krita to returns back to Calligra framework?
  
  
  That's not going to happen... We're happy hacking out all the flexibility 
from the libraries that was only needed to support so many different 
applications.
  
  As an aside, I think splitting up kdepim into so many repositories was a huge 
mistake. Listening to David Faure at the onboarding sprint only confirmed that 
opinion. Having to work on half a dozen repos to add a single feature to kmail 
sounds like hell to me. I think it would be a mistake for Calligra, too, but 
don't pay attention to me :-)

TASK DETAIL
  https://phabricator.kde.org/T12815

To: rempt
Cc: rempt, anthonyfieroni, dcaliste, boemann, pino, rjvbb, ngraham, ognarb, 
Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, cochise, 
vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[René J . V . Bertin]

rjvbb added a comment.


  >   As an aside, I think splitting up kdepim into so many repositories was a 
huge mistake.
  
  Ah yes, that was definitely one of the reasons why I never updated my kdepim4 
packaging. That said, I also appreciate the fact that the few apps I use that 
depend on kdepim features now require only to maintain packaging for smallish 
libraries (that often also don't evolve that quickly).
  
  But somehow I doubt that latter argument can be transferred to Calligra's 
libraries...

TASK DETAIL
  https://phabricator.kde.org/T12815

To: rjvbb
Cc: rempt, anthonyfieroni, dcaliste, boemann, pino, rjvbb, ngraham, ognarb, 
Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, cochise, 
vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Nathaniel Graham]

ngraham added a comment.


  In T12815#223428 , @rempt wrote:
  
  > As an aside, I think splitting up kdepim into so many repositories was a 
huge mistake. Listening to David Faure at the onboarding sprint only confirmed 
that opinion. Having to work on half a dozen repos to add a single feature to 
kmail sounds like hell to me. I think it would be a mistake for Calligra, too, 
but don't pay attention to me :-)
  
  
  I sometimes find myself feeling this way about Frameworks too. A recent 
experience at a hackathon where I helped 8 students set up complete development 
environments from scratch reinforced this viewpoint. Not that I'm seriously 
recommending re-merging the frameworks, but I would like to challenge the 
notion that splitting a monolithic codebase across multiple repos is a boon to 
onboarding; I don't think it is. It may have other benefits, but I don't think 
onboarding is one of them.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: ngraham
Cc: rempt, anthonyfieroni, dcaliste, boemann, pino, rjvbb, ngraham, ognarb, 
Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, cochise, 
vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[Jaime Torres Amate]

jtamate added a comment.


  As I have some free time due to the virus and I'm trying to get up to date.
  
  In the SQL word there is the notion of tables, queries and views, where a 
view can show de values of several tables (combined, filtered or raw).
  
  Do you know if there is something similar for the SCM world? If it exists, 
there could be several repositories splitted in tiny pieces and also global 
views composed of several of them (or pieces of several of them).

TASK DETAIL
  https://phabricator.kde.org/T12815

To: jtamate
Cc: jtamate, rempt, anthonyfieroni, dcaliste, boemann, pino, rjvbb, ngraham, 
ognarb, Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, 
cochise, vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

[René J . V . Bertin]

rjvbb added a comment.


  >   I sometimes find myself feeling this way about Frameworks too. A recent 
experience at a hackathon where I helped 8 students set up complete development 
environments from scratch reinforced this viewpoint. Not that I'm seriously 
recommending re-merging the frameworks, but I would like to challenge the 
notion that splitting a monolithic codebase across multiple repos is a boon to 
onboarding; I don't think it is. It may have other benefits, but I don't think 
onboarding is one of them.
  
  Apple were first to start calling their system libraries "frameworks" and 
they do have a nice feature that would address those issues. Something like the 
Accelerate framework is actually a collection of frameworks. You only specify 
the "interface" framework, and I *think* that "the system" figures out what to 
link. Of course they had to rewrite the linker driver (or linker itself) in 
order to understand how to deal with their framework bundles so they had every 
occasion to add some additional logic.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: rjvbb
Cc: jtamate, rempt, anthonyfieroni, dcaliste, boemann, pino, rjvbb, ngraham, 
ognarb, Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, 
cochise, vandenoever