D27694: Don't recreate ImageDataItem texture unless needed

2020-02-27 Thread David Llewellyn-Jones 
davidllewellynjones created this revision.
davidllewellynjones added reviewers: Calligra: 3.0, leinir, danders.
davidllewellynjones added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
davidllewellynjones requested review of this revision.

REVISION SUMMARY
  Submitting on behalf of Joona Petrell.
  
  This change improves performance by only updating the image texture if the 
image data changes.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D27694

AFFECTED FILES
  components/ImageDataItem.cpp

To: davidllewellynjones, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D27694: Don't recreate ImageDataItem texture unless needed

2020-02-27 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  That's a very good idea, yes, go for it! :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D27694

To: davidllewellynjones, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D27694: Don't recreate ImageDataItem texture unless needed

2020-02-27 Thread Pekka Vuorela 
pvuorela accepted this revision.
pvuorela added a comment.


  Looking good.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D27694

To: davidllewellynjones, #calligra:_3.0, leinir, danders, pvuorela
Cc: pvuorela, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D27694: Don't recreate ImageDataItem texture unless needed

2020-02-27 Thread Pekka Vuorela 
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:5a5f98658e7f: Don't recreate ImageDataItem texture 
unless needed (authored by pvuorela).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27694?vs=76520&id=76544

REVISION DETAIL
  https://phabricator.kde.org/D27694

AFFECTED FILES
  components/ImageDataItem.cpp

To: davidllewellynjones, #calligra:_3.0, leinir, danders, pvuorela
Cc: pvuorela, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever