D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.
pvuorela accepted this revision. pvuorela added a comment. This revision is now accepted and ready to land. Seems to work and big impact indeed. Approving already. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25779 To: denexter, pvuorela, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.
denexter updated this revision to Diff 72472. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25779?vs=71000&id=72472 REVISION DETAIL https://phabricator.kde.org/D25779 AFFECTED FILES components/Document.cpp components/Document.h components/impl/DocumentImpl.cpp components/impl/DocumentImpl.h To: denexter, pvuorela, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.
denexter marked an inline comment as done. denexter added inline comments. INLINE COMMENTS > pvuorela wrote in Document.cpp:57 > Looks like this is on top of Sailfish patched Calligra, upstream doesn't have > lastError. Could otherwise resolve that conflict myself, but the arc tool > doesn't seem to play along well, losing the metadata by doing the commit > myself. Updated relative to an unpatched Calligra, REVISION DETAIL https://phabricator.kde.org/D25779 To: denexter, pvuorela, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.
mphilippov created this revision. mphilippov added reviewers: pvuorela, denexter, dcaliste, davidllewellynjones. mphilippov added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. mphilippov requested review of this revision. REVISION SUMMARY In previous version headings or items started with lower level are displayed as 11, 22, 33; not 1.1, 1.2, 1.3. This diff calculates the numbers of headings or items which start with lower properlylevel. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26328 AFFECTED FILES filters/libmsooxml/MsooXmlUtils.cpp filters/libmsooxml/MsooXmlUtils.h filters/words/docx/import/DocxXmlNumberingReader.cpp libs/textlayout/ListItemsHelper.cpp To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones Cc: davidllewellynjones, dcaliste, denexter, pvuorela, Calligra-Devel-list, #calligra:_3.0, ognarb, cochise, vandenoever
D25715: Use RTF default color as default Qt format
davidllewellynjones added inline comments. INLINE COMMENTS > ColorTableDestination.cpp:44 > + handled = false; > qCDebug(lcRtf) << "unexpected control word in colortbl:" << > controlWord; > } It looks like there may be a distinction to be made between an empty control word and an unhandled control word. In the case of an unhandled control word, clearing the colour seems sensible, but then in the case of an empty control word, the debug output isn't needed. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25715 To: pvuorela, davidllewellynjones, dcaliste Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.
This revision was automatically updated to reflect the committed changes. Closed by commit R8:bcda431ed438: Add a readOnly property to the QtQuick2 Document type which disables the… (authored by denexter, committed by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25779?vs=72472&id=72479 REVISION DETAIL https://phabricator.kde.org/D25779 AFFECTED FILES components/Document.cpp components/Document.h components/impl/DocumentImpl.cpp components/impl/DocumentImpl.h To: denexter, pvuorela, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D25715: Use RTF default color as default Qt format
pvuorela added inline comments. INLINE COMMENTS > davidllewellynjones wrote in ColorTableDestination.cpp:44 > It looks like there may be a distinction to be made between an empty control > word and an unhandled control word. In the case of an unhandled control word, > clearing the colour seems sensible, but then in the case of an empty control > word, the debug output isn't needed. Empty control word? Don't think that should be happening? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25715 To: pvuorela, davidllewellynjones, dcaliste Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D25715: Use RTF default color as default Qt format
pvuorela added inline comments. INLINE COMMENTS > pvuorela wrote in ColorTableDestination.cpp:44 > Empty control word? Don't think that should be happening? Or well, the code might return such, but think the file in that case is broken and as such ok to complain about on debug. Also a bit separate from the changes here. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25715 To: pvuorela, davidllewellynjones, dcaliste Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D25715: Use RTF default color as default Qt format
davidllewellynjones accepted this revision. davidllewellynjones added a comment. This revision is now accepted and ready to land. This looks good to me, and certainly gave better results for me using files with the 'auto' colour. INLINE COMMENTS > pvuorela wrote in ColorTableDestination.cpp:44 > Or well, the code might return such, but think the file in that case is > broken and as such ok to complain about on debug. Also a bit separate from > the changes here. Yeah, this was my misunderstanding of the spec. I don't see a problem with what you're doing here. REPOSITORY R8 Calligra BRANCH rtf_default_color REVISION DETAIL https://phabricator.kde.org/D25715 To: pvuorela, davidllewellynjones, dcaliste Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
D25715: Use RTF default color as default Qt format
This revision was automatically updated to reflect the committed changes. Closed by commit R8:959027525581: Use RTF default color as default Qt format (authored by pvuorela). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25715?vs=70828&id=72487 REVISION DETAIL https://phabricator.kde.org/D25715 AFFECTED FILES filters/words/rtf/import/3rdparty/rtf-qt/src/ColorTableDestination.cpp filters/words/rtf/import/3rdparty/rtf-qt/src/ColorTableDestination.h filters/words/rtf/import/3rdparty/rtf-qt/src/TextDocumentRtfOutput.cpp To: pvuorela, davidllewellynjones, dcaliste Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
