D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Dag Andersen 
danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  There is a couple of failing tests now marked as XFAIL.
  I am afraid these are new bugs, but I may have missed something (I hope)

REPOSITORY
  R8 Calligra

BRANCH
  blocklayout_unittest_danders

REVISION DETAIL
  https://phabricator.kde.org/D14901

AFFECTED FILES
  libs/textlayout/tests/TestBlockLayout.cpp

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, cochise, vandenoever

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  Thanks, i really don't know how to change predefined values like 28.0 etc. i 
see you changed them i still not clear to me what are the new vales :)

INLINE COMMENTS

> TestBlockLayout.cpp:497
>  int lastLineNum = block1Layout->lineCount() - 1;
> -const qreal lineSpacing = 12.0 * 1.2;
> +const qreal lineSpacing = 12.0 * 1.16;
>  KoTextDocument(m_doc).setParaTableSpacingAtStart(false);

Can you use macro again?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D14901

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, cochise, vandenoever

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Dag Andersen 
danders marked an inline comment as done.
danders added a comment.


  What to change depends on what the number means ;)
  Well in general all numbers that depends on fontsize should be changed, the 
rest should stay the same, but yes it is a puzzle.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D14901

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, cochise, vandenoever

D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-17 Thread Anthony Fieroni 
anthonyfieroni created this revision.
anthonyfieroni added reviewers: boemann, danders, Calligra: 3.0.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
anthonyfieroni requested review of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D14916

AFFECTED FILES
  plugins/artistictextshape/ArtisticTextShape.cpp

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever