Question about ownership of KoShape
Hi, all! As some of you may already know, at the moment I'm working on adding support of SVG to Krita. Obviously enough I use Flake as a internal representation/rendering engine. And, yes, I base my work on SvgParser class started by Jan Hambrecht in 2011. Right now my main question is: who owns all the shapes in the document? As far as I could understand, group shapes do not own them. So the question seems to be a bit tough for me... My guess is that the shapes are owned by KoShapeManager... If so, how KoShapePainter should work? It has in internal shape manager that will delete all the shapes after each painting. How can it be solved? And the most interesting part: SVG standard supports / paradigm [1]. Which allows one shape to have multiple instances in different parts of the document. How can it be solved within KoFlake? Copy-constructors are not allowed in KoShape, the management is not reference counted. How can I solve the thing? [1] - https://www.w3.org/TR/SVG/struct.html#UseElement -- Dmitry Kazakov
Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129420/ --- Review request for Calligra and Friedrich W. H. Kossebau. Repository: calligra Description --- ^^ Diffs - braindump/plugins/stateshape/CategorizedItemDelegate.cpp ad661c2 libs/main/KoAutoSaveRecoveryDialog.cpp e543eaa libs/main/KoDocumentSectionDelegate.h ad4b9f1 libs/main/KoDocumentSectionDelegate.cpp bcd7628 libs/widgets/KoDockWidgetTitleBar.cpp 4d0d1aa plugins/textshape/dialogs/StylesCombo.cpp 9ca044b plugins/textshape/dialogs/StylesDelegate.cpp faa90fb Diff: https://git.reviewboard.kde.org/r/129420/diff/ Testing --- Build with Karbon. Thanks, Anthony Fieroni
Re: Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129420/#review100915 --- Ship it! Ship It! - Camilla Boemann On Nov. 17, 2016, 6:54 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129420/ > --- > > (Updated Nov. 17, 2016, 6:54 p.m.) > > > Review request for Calligra and Friedrich W. H. Kossebau. > > > Repository: calligra > > > Description > --- > > ^^ > > > Diffs > - > > braindump/plugins/stateshape/CategorizedItemDelegate.cpp ad661c2 > libs/main/KoAutoSaveRecoveryDialog.cpp e543eaa > libs/main/KoDocumentSectionDelegate.h ad4b9f1 > libs/main/KoDocumentSectionDelegate.cpp bcd7628 > libs/widgets/KoDockWidgetTitleBar.cpp 4d0d1aa > plugins/textshape/dialogs/StylesCombo.cpp 9ca044b > plugins/textshape/dialogs/StylesDelegate.cpp faa90fb > > Diff: https://git.reviewboard.kde.org/r/129420/diff/ > > > Testing > --- > > Build with Karbon. > > > Thanks, > > Anthony Fieroni > >
Re: Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129420/ --- (Updated Nov. 17, 2016, 7:34 p.m.) Status -- This change has been marked as submitted. Review request for Calligra and Friedrich W. H. Kossebau. Changes --- Submitted with commit 821f1048d5ff74d996dbb7cdcfca5405f5ab5b57 by Anthony Fieroni to branch master. Repository: calligra Description --- ^^ Diffs - braindump/plugins/stateshape/CategorizedItemDelegate.cpp ad661c2 libs/main/KoAutoSaveRecoveryDialog.cpp e543eaa libs/main/KoDocumentSectionDelegate.h ad4b9f1 libs/main/KoDocumentSectionDelegate.cpp bcd7628 libs/widgets/KoDockWidgetTitleBar.cpp 4d0d1aa plugins/textshape/dialogs/StylesCombo.cpp 9ca044b plugins/textshape/dialogs/StylesDelegate.cpp faa90fb Diff: https://git.reviewboard.kde.org/r/129420/diff/ Testing --- Build with Karbon. Thanks, Anthony Fieroni
Review Request 129421: [karbon] Returning of Karbon as maintained product
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129421/ --- Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau. Repository: calligra Description --- As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so i can be Co-Maintainer, i'm missing experience with graphics nor vector graphics software but i will try to help and fixing bugs. Diffs - CalligraProducts.cmake 965e9d8 karbon/CMakeLists.txt ba775ad karbon/main.cpp 2fa3f4d karbon/ui/KarbonAboutData.h aa96ee1 Diff: https://git.reviewboard.kde.org/r/129421/diff/ Testing --- Builds. Thanks, Anthony Fieroni
Jenkins-kde-ci: calligra master kf5-qt5 ยป Linux,gcc - Build # 128 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/128/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 17 Nov 2016 19:34:59 + Build duration: 1 hr 13 min CHANGE SET Revision 821f1048d5ff74d996dbb7cdcfca5405f5ab5b57 by bvbfan: (Remove obsolete typedefs, deprecated since Qt 5.7) change: edit plugins/textshape/dialogs/StylesCombo.cpp change: edit libs/main/KoDocumentSectionDelegate.h change: edit libs/main/KoAutoSaveRecoveryDialog.cpp change: edit braindump/plugins/stateshape/CategorizedItemDelegate.cpp change: edit plugins/textshape/dialogs/StylesDelegate.cpp change: edit libs/widgets/KoDockWidgetTitleBar.cpp change: edit libs/main/KoDocumentSectionDelegate.cpp JUNIT RESULTS Name: (root) Failed: 5 test(s), Passed: 134 test(s), Skipped: 0 test(s), Total: 139 test(s)Failed: TestSuite.libs-koodf-TestNumberStyleFailed: TestSuite.libs-pigment-TestColorConversionSystemFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-ValueConverterFailed: TestSuite.sheets-ValueParser COBERTURA RESULTS Cobertura Coverage Report PACKAGES 144/171 (84%)FILES 1202/2603 (46%)CLASSES 1202/2603 (46%)LINE 77549/258903 (30%)CONDITIONAL 51636/281836 (18%) By packages braindump.braindumpcore FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/134 (0%)CONDITIONAL 0/98 (0%) braindump.plugins.stateshape FILES 4/14 (29%)CLASSES 4/14 (29%)LINE 24/280 (9%)CONDITIONAL 3/140 (2%) braindump.plugins.webshape FILES 4/9 (44%)CLASSES 4/9 (44%)LINE 22/295 (7%)CONDITIONAL 1/114 (1%) braindump.src FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/3 (0%)CONDITIONAL 0/0 (100%) devtools.rng2cpp FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 600/693 (87%)CONDITIONAL 596/814 (73%) filters.libmso FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 880/7716 (11%)CONDITIONAL 2165/19897 (11%) filters.libmso.generated FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 4193/12624 (33%)CONDITIONAL 3969/23069 (17%) filters.libmsooxml FILES 2/35 (6%)CLASSES 2/35 (6%)LINE 3/8010 (0%)CONDITIONAL 2/24349 (0%) filters.libmsooxml.generated FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/743 (0%)CONDITIONAL 0/3336 (0%) filters.libodf2 FILES 6/29 (21%)CLASSES 6/29 (21%)LINE 97/1606 (6%)CONDITIONAL 82/2174 (4%) filters.libodf2.chart FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/582 (0%)CONDITIONAL 0/1321 (0%) filters.sheets.excel.sidewinder FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 654/685 (95%)CONDITIONAL 1918/3502 (55%) filters.sheets.xlsx FILES 4/5 (80%)CLASSES 4/5 (80%)LINE 111/281 (40%)CONDITIONAL 67/460 (15%) filters.stage.powerpoint FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 1651/2710 (61%)CONDITIONAL 1999/6134 (33%) filters.stage.powerpoint.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 56/58 (97%)CONDITIONAL 92/194 (47%) interfaces FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/61 (89%)CONDITIONAL 36/73 (49%) libs.basicflakes.plugin FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 23/31 (74%)CONDITIONAL 1/8 (13%) libs.basicflakes.tools FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/819 (0%)CONDITIONAL 0/413 (0%) libs.flake FILES 111/180 (62%)CLASSES 111/180 (62%)LINE 5273/13803 (38%)CONDITIONAL 2895/9878 (29%) libs.flake.commands FILES 19/49 (39%)CLASSES 19/49 (39%)LINE 805/2153 (37%)CONDITIONAL 410/1380 (30%) libs.flake.svg FILES 1/20 (5%)CLASSES 1/20 (5%)LINE 8/2456 (0%)CONDITIONAL 1/1698 (0%) libs.flake.tests FILES 49/49 (100%)CLASSES 49/49 (100%)LINE 3740/3773 (99%)CONDITIONAL 1718/3394 (51%) libs.flake.tools FILES 9/43 (21%)CLASSES 9/43 (21%)LINE 155/1625 (10%)CONDITIONAL 45/952 (5%) libs.kundo2 FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 205/730 (28%)CONDITIONAL 69/390 (18%) libs.main FILES 27/73 (37%)CLASSES 27/73 (37%)LINE 709/7138 (10%)CONDITIONAL 771/16833 (5%) libs.main.config FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/218 (0%)CONDITIONAL 0/478 (0%) libs.main.gemini FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 (100%) libs.main.tests FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 258/271 (95%)CONDITIONAL 138/236 (58%) libs.odf FILES 39/46 (85%)CLASSES 39/46 (85%)LINE 2087/5584 (37%)CONDITIONAL 1318/4284 (31%) libs.odf.tests FILES 17/17 (100%)CLASSES 17/17 (100%)LINE 4854/5100 (95%)CONDITIONAL 3516/7158 (49%) libs.odf.writeodf FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 77/106 (73%)
Re: Review Request 129421: [karbon] Returning of Karbon as maintained product
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129421/#review100920 --- It's great that you want to co maintain - i think you could even apply for maintaining without the "co-", but i also think it's a bit premature to remove that message. Maintain (be ambassador, fix bugs etc) for a month or so and if you are still warm about the idea we can remove the message.I mean the spot is yours if you want but make yourself a maintainer by deed before we make you one by name. Deal? And just to emphazise it would be really great to see you work on karbon - it deserves to come to full glory! - Camilla Boemann On Nov. 17, 2016, 8:09 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > --- > > (Updated Nov. 17, 2016, 8:09 p.m.) > > > Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau. > > > Repository: calligra > > > Description > --- > > As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so > i can be Co-Maintainer, i'm missing experience with graphics nor vector > graphics software but i will try to help and fixing bugs. > > > Diffs > - > > CalligraProducts.cmake 965e9d8 > karbon/CMakeLists.txt ba775ad > karbon/main.cpp 2fa3f4d > karbon/ui/KarbonAboutData.h aa96ee1 > > Diff: https://git.reviewboard.kde.org/r/129421/diff/ > > > Testing > --- > > Builds. > > > Thanks, > > Anthony Fieroni > >
