[krita] plugins/flake/textshape/kotext/styles: Fix memory leak
Git commit fbd916d2af9cc025f505117fd1da13a29e6e3030 by Boudewijn Rempt.
Committed on 13/09/2016 at 07:22.
Pushed by rempt into branch 'master'.
Fix memory leak
==10207== 424 (24 direct, 400 indirect) bytes in 1 blocks are definitely lost
in loss record 11,215 of 12,325
==10207==at 0x4C29670: operator new(unsigned long) (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==10207==by 0x321A1982: KoStyleManager::KoStyleManager(QObject*)
(KoStyleManager.cpp:152)
==10207==by 0x31B41D3F:
TextShapeFactory::newDocumentResourceManager(KoDocumentResourceManager*) const
(TextShapeFactory.cpp:158)
==10207==by 0x6D70D3F: KoShapeBasedDocumentBase::KoShapeBasedDocumentBase()
(KoShapeBasedDocumentBase.cpp:40)
==10207==by 0x50FB291: KisShapeController::KisShapeController(KisDocument*,
KisNameServer*) (kis_shape_controller.cpp:71)
==10207==by 0x5344AD8: KisDocument::init() (KisDocument.cpp:591)
==10207==by 0x534B5CC: KisDocument::KisDocument() (KisDocument.cpp:527)
==10207==by 0x538013A: KisPart::createDocument() const (KisPart.cpp:197)
==10207==by 0x5293D47: KisCustomImageWidget::createNewImage()
(kis_custom_image_widget.cc:273)
==10207==by 0x529503E: KisCustomImageWidget::createImage()
(kis_custom_image_widget.cc:232)
==10207==by 0xC344390: QMetaObject::activate(QObject*, int, int, void**)
(in /home/boud/dev/deps/lib/libQt5Core.so.5.6.1)
==10207==by 0xB2A6551: QAbstractButton::clicked(bool) (in
/home/boud/dev/deps/lib/libQt5Widgets.so.5.6.1)
==10207==
==10207== 430 (24 direct, 406 indirect) bytes in 1 blocks are definitely lost
in loss record 11,216 of 12,325
==10207==at 0x4C29670: operator new(unsigned long) (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==10207==by 0x321A1960: KoStyleManager::KoStyleManager(QObject*)
(KoStyleManager.cpp:151)
==10207==by 0x31B41D3F:
TextShapeFactory::newDocumentResourceManager(KoDocumentResourceManager*) const
(TextShapeFactory.cpp:158)
==10207==by 0x6D70D3F: KoShapeBasedDocumentBase::KoShapeBasedDocumentBase()
(KoShapeBasedDocumentBase.cpp:40)
==10207==by 0x50FB291: KisShapeController::KisShapeController(KisDocument*,
KisNameServer*) (kis_shape_controller.cpp:71)
==10207==by 0x5344AD8: KisDocument::init() (KisDocument.cpp:591)
==10207==by 0x534B5CC: KisDocument::KisDocument() (KisDocument.cpp:527)
==10207==by 0x538013A: KisPart::createDocument() const (KisPart.cpp:197)
==10207==by 0x5293D47: KisCustomImageWidget::createNewImage()
(kis_custom_image_widget.cc:273)
==10207==by 0x529503E: KisCustomImageWidget::createImage()
(kis_custom_image_widget.cc:232)
==10207==by 0xC344390: QMetaObject::activate(QObject*, int, int, void**)
(in /home/boud/dev/deps/lib/libQt5Core.so.5.6.1)
==10207==by 0xB2A6551: QAbstractButton::clicked(bool) (in
/home/boud/dev/deps/lib/libQt5Widgets.so.5.6.1)
==10207==
Probably also present in Calligra
CCMAIL:calligra-devel@kde.org
M +2-0plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
http://commits.kde.org/krita/fbd916d2af9cc025f505117fd1da13a29e6e3030
diff --git a/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
b/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
index 4dc0cbb..9544133 100644
--- a/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
+++ b/plugins/flake/textshape/kotext/styles/KoStyleManager.cpp
@@ -187,6 +187,8 @@ KoStyleManager::KoStyleManager(QObject *parent)
KoStyleManager::~KoStyleManager()
{
+delete d->footNotesConfiguration;
+delete d->endNotesConfiguration;
delete d;
}
Re: kexi, kdb, kproperty, kreport ready to translate
FWIW unrelated to this ... kexi at least doesn't seem to use the podir variable from https://websvn.kde.org/trunk/l10n-kf5/scripts/extract-messages.sh?revision=1463478&view=markup not sure if it should? On Tue, Sep 13, 2016 at 1:32 AM, Luigi Toscano wrote: > Il 13 settembre 2016 00:53:44 CEST, Jaroslaw Staniek ha > scritto: >>Hi Luigi, >>kexi, kdb, kproperty, kreport are ready to translate, string freeze is >>on. >> >> >>PS: The releaseme tool gives no translations for Kexi (so tarballs I'll >>upload soon won't include translation files). >>kdb, kproperty, kreport tarballs include them. > > I can only tell you again to talk with Harald; I could not check how > releaseme works. > Or please use create_tarball_kf5 (see the example config) in the meantime. > >>I am wondering if this is because >>repo-metadata/projects/calligra/kexi/metadata.yaml contains this: >> >>projectpath: calligra/kexi >> >>.. while the messages are still in calligra/? >>I am experiencing the same issue is with Krita but maybe that's not >>noticed >>only because the Krita Team does not seem to use releaseme for >>packaging. >> >>Another reason for having a kexi/ subdir would be: the .po files from >>various apps and plugins are too a bit too mixed within >>messages/calligra/ >>so maybe some hierarchy would be good? > > No, no, the structure of translation files has nothing to do with it. Proof: > the existing tarballs of other projects. > > -- > Luigi
Re: kexi, kdb, kproperty, kreport ready to translate
On Tuesday, 13 September 2016 10:40:35 CEST Harald Sitter wrote: > FWIW unrelated to this ... kexi at least doesn't seem to use the podir > variable from > https://websvn.kde.org/trunk/l10n-kf5/scripts/extract-messages.sh?revision=1463478&view=markup > not sure if it should? It does, see kexi_xgettext.sh. Please don't switch topic, and help debugging your own scripts. Thanks, -- Pino Toscano
Re: kexi, kdb, kproperty, kreport ready to translate
On Tue, Sep 13, 2016 at 10:53 AM, Pino Toscano wrote: > On Tuesday, 13 September 2016 10:40:35 CEST Harald Sitter wrote: >> FWIW unrelated to this ... kexi at least doesn't seem to use the podir >> variable from >> https://websvn.kde.org/trunk/l10n-kf5/scripts/extract-messages.sh?revision=1463478&view=markup >> not sure if it should? > > It does, see kexi_xgettext.sh. nevermind then > Please don't switch topic, and help debugging your own scripts. I can't help but find this passive aggressive.
Jenkins-kde-ci: calligra master kf5-qt5 » Linux,gcc - Build # 95 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Sep 2016 08:16:57 + Build duration: 1 hr 16 min CHANGE SET Revision bc3bb1844a8dbdeb7c4afdac64ba166dd72d4599 by Dag Andersen: (Plan: Update projects actual starttime) change: edit plan/libs/ui/kptganttview.cpp change: edit plan/libs/kernel/kptproject.cpp Revision a0c3fd94cd7535f94fc344f3dad53e1edf0bf93b by Dag Andersen: (Plan report: use future safe names for performance data) change: edit plan/libs/ui/reports/reportdata.cpp Revision 448d375033f2a8cc0db9af5b0f8b5820b117e903 by Dag Andersen: (Plan report: add tool tip for data elements) change: edit plan/libs/ui/reports/reportview.cpp Revision 829500113855571e1990f4c2a0bf8941250b1085 by Dag Andersen: (Plan report: Set initial state in section edit docker) change: edit plan/libs/ui/reports/reportview.h change: edit plan/libs/ui/reports/reportview.cpp Revision 37e83300b960cb35653c6df924dd50925e175548 by Dag Andersen: (Plan: fix unit test (due to proper update of project start time)) change: edit plan/libs/kernel/tests/ProjectTester.cpp Revision 3704bda8082adddb3c939ed24485ed0050ba22a0 by Dag Andersen: (Plan: Implement sort by wbs to sort by wbs structure and not by the wbs) change: edit plan/libs/ui/kptganttview.cpp change: edit plan/libs/kernel/kptnode.h change: edit plan/libs/models/kptnodeitemmodel.h change: edit plan/libs/models/kptnodeitemmodel.cpp change: edit plan/libs/kernel/kptnode.cpp change: edit plan/libs/kernel/kptproject.h change: edit plan/libs/kernel/kptproject.cpp Revision 09455435c21e964ffe07885e7e19fc729ba24552 by Dag Andersen: (Plan: ++unittests) change: edit plan/libs/models/tests/FlatProxyModelTester.h change: edit plan/libs/models/tests/FlatProxyModelTester.cpp Revision 0c4e5dabee7252d95c79be7ec9c7d37861f28b57 by Dag Andersen: (Plan: Usability: Never block save, add Milestone option to task dialog) change: edit plan/libs/ui/kpttaskgeneralpanelbase.ui change: edit plan/libs/ui/kptsummarytaskgeneralpanel.cpp change: edit plan/libs/ui/kptmainprojectpanel.cpp change: edit plan/libs/ui/kpttaskgeneralpanel.cpp Revision 9ba53fa3e3665586d5336d83616758f322edfbbf by Dag Andersen: (Plan: Add export report definition, fix bug in report import) change: edit plan/libs/ui/reports/reportview.cpp change: edit plan/libs/ui/reports/reportview.h JUNIT RESULTS Name: (root) Failed: 5 test(s), Passed: 153 test(s), Skipped: 0 test(s), Total: 158 test(s)Failed: TestSuite.libs-koodf-TestNumberStyleFailed: TestSuite.libs-pigment-TestColorConversionSystemFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-ValueConverterFailed: TestSuite.sheets-ValueParser COBERTURA RESULTS Cobertura Coverage Report PACKAGES 154/187 (82%)FILES 1343/2953 (45%)CLASSES 1343/2953 (45%)LINE 97440/319258 (31%)CONDITIONAL 63136/368923 (17%) By packages braindump.braindumpcore FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/134 (0%)CONDITIONAL 0/98 (0%) braindump.plugins.stateshape FILES 4/14 (29%)CLASSES 4/14 (29%)LINE 24/280 (9%)CONDITIONAL 3/140 (2%) braindump.plugins.webshape FILES 4/9 (44%)CLASSES 4/9 (44%)LINE 22/295 (7%)CONDITIONAL 1/114 (1%) braindump.src FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/3 (0%)CONDITIONAL 0/0 (100%) devtools.rng2cpp FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 600/693 (87%)CONDITIONAL 596/814 (73%) filters.libmso FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 880/7716 (11%)CONDITIONAL 2165/19897 (11%) filters.libmso.generated FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 4193/12624 (33%)CONDITIONAL 3969/23069 (17%) filters.libmsooxml FILES 2/35 (6%)CLASSES 2/35 (6%)LINE 3/8009 (0%)CONDITIONAL 2/24345 (0%) filters.libmsooxml.generated FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/743 (0%)CONDITIONAL 0/3336 (0%) filters.libodf2 FILES 6/29 (21%)CLASSES 6/29 (21%)LINE 97/1606 (6%)CONDITIONAL 82/2174 (4%) filters.libodf2.chart FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/582 (0%)CONDITIONAL 0/1321 (0%) filters.sheets.excel.sidewinder FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 654/685 (95%)CONDITIONAL 1918/3502 (55%) filters.sheets.xlsx FILES 4/5 (80%)CLASSES 4/5 (80%)LINE 111/281 (40%)CONDITIONAL 67/460 (15%) filters.stage.powerpoint FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 1651/2710 (61%)CONDITIONAL 1999/6134 (33%) filters.stage.powerpoint.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 56/58 (97%)CONDITIONAL 92/194 (47%) interfaces FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/61 (89%)CONDITIONAL 36/73 (49%) libs.basicflakes.plugin
Re: kexi, kdb, kproperty, kreport ready to translate
On 13 September 2016 at 00:53, Jaroslaw Staniek wrote: > > kexi, kdb, kproperty, kreport are ready to translate, string freeze is on. > Hi, A quick update for translators: There are some fixes needed in translation code of kdb and kreport so messages would change in a few places. (kexi and kproperty seem to be OK). I will let you know when scripty is OK with, hopefully within 10 hours. ( error log: ftp://l10n.kde.org/160913.trunk_l10n-kf5 ) > > PS: The releaseme tool gives no translations for Kexi (so tarballs I'll > upload soon won't include translation files). > kdb, kproperty, kreport tarballs include them. > I am wondering if this is because > repo-metadata/projects/calligra/kexi/metadata.yaml > contains this: > > projectpath: calligra/kexi > > .. while the messages are still in calligra/? > I am experiencing the same issue is with Krita but maybe that's not > noticed only because the Krita Team does not seem to use releaseme for > packaging. > > Another reason for having a kexi/ subdir would be: the .po files from > various apps and plugins are too a bit too mixed within messages/calligra/ > so maybe some hierarchy would be good? > > This is what happens with my command: > > % tarme.rb --version 2.99.90 --origin trunk kexi > > "No translations for..." does not explain what paths are expected. > Any help appreciated. > > THE OUTPUT: > > calligra > kexi > INFO -- Release: Getting source (git - g...@git.kde.org:kexi [master]) > INFO -- Release: Getting translations... > INFO -- L10n: Downloading translations for kexi-2.99.90 > INFO -- L10n: No translations for: ar, af, as, ast, be, bg, be@latin, bn, > bn_IN, br, bs, ca, ca@valencia, cs, crh, csb, da, cy, de, en_GB, el, eo, > es, et, fa, eu, fi, ga, fy, fr, gd, gu, he, ha, gl, hi, hr, hne, hsb, hy, > hu, ia, is, it, id, ja, ka, kk, km, kn, ko, ku, lt, lv, lb, mai, ml, mr, > ms, mt, mk, nds, ne, nl, nb, nn, oc, or, nso, pa, pl, pt, ps, pt_BR, ro, > ru, rw, si, sk, sl, se, sq, sr@ijekavian, sr, sr@ijekavianlatin, sv, ta, > sr@latin, te, tg, th, tr, tt, ug, uz, uk, uz@cyrillic, wa, vi, zh_CN, xh, > zh_HK, zh_TW > INFO -- Release: Getting documentation... > INFO -- DocumentationL10n: Downloading documentations for kexi-2.99.90 > INFO -- DocumentationL10n: No translations for: fa, fi, fr, fy, ga, gd, > gl, ha, gu, he, hi, hne, hsb, hr, hu, ia, hy, id, is, ka, km, ja, kk, kn, > ku, ko, lb, lt, mai, mk, lv, ml, nb, ms, mt, mr, nds, ne, oc, nn, nso, pa, > or, pl, ps, ro, ru, rw, se, si, sl, sq, sk, sr, sr@ijekavian, > sr@ijekavianlatin, sr@latin, ta, te, th, tg, tt, ug, tr, uz, uz@cyrillic, > vi, wa, xh, zh_CN, zh_TW, zh_HK > INFO -- Release: Archiving source (git - g...@git.kde.org:kexi [master]) > > -- > regards, Jaroslaw Staniek > > KDE: > : A world-wide network of software engineers, artists, writers, translators > : and facilitators committed to Free Software development - http://kde.org > Calligra Suite: > : A graphic art and office suite - http://calligra.org > Kexi: > : A visual database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek
