Re: Review Request 127338: Fix loading documents containing nested tables

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127338/#review93406
---



Again  - thanks but please close as discarded - I already have made a more 
correct fix - it's however not pushed to master yet - so please have some 
patience

- Camilla Boemann


On March 11, 2016, 12:08 a.m., Laszlo Pasztor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127338/
> ---
> 
> (Updated March 11, 2016, 12:08 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=359700
> 
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=359700
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> Fix: in Calligra Words inserting a table to the first cell of a table causes 
> inserting an extra table after saving and loading the document back.
> 
> Reproducible: Always
> 
> 
> Diffs
> -
> 
>   libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 
> 
> Diff: https://git.reviewboard.kde.org/r/127338/diff/
> 
> 
> Testing
> ---
> 
> Steps to Reproduce:
> 1. Create a table.
> 2. Insert a table to the first cell of the previously created table.
> 3. Save the document. 
> 4. Close Words. 
> 5. Open Words with saved document.
> 
> Actual Results:  
> An additional table is inserted before the first table.
> 
> Expected Results:  
> Number of tables should be the same after saving.
> 
> 
> File Attachments
> 
> 
> Before saving
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/10/86fb1940-c90c-4458-8f44-ddf726107f2d__beforesave.png
> After reopening
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/10/f740fe55-bece-4d15-87c7-0149c03940e1__afteropen.png
> 
> 
> Thanks,
> 
> Laszlo Pasztor
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 124641: Refactoring KoTextEditor::recursivelyVisitSelection() to make it cleaner and easier to understand

[Camilla Boemann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124641/#review93942
---



This rewrite fails as it doesn't check for cell1 == cell2 in which case it's 
not a complex selection

so it fails

please discard request

- Camilla Boemann


On Aug. 6, 2015, 11:48 a.m., Soma Schliszka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124641/
> ---
> 
> (Updated Aug. 6, 2015, 11:48 a.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> The KoTextEditor::recursivelyVisitSelection() function had a bit complex 
> conditional expression when there is a table inside the selection. 
> This change is following the previous behaviour but the expression is built 
> more logically. It isn't the shortest version, but it's much easier to 
> understand and simpler to use.
> There are several cases of selecting a table, and it's not trivial to say 
> whether entire or just a part is selected.
> 
> * The process has been divided into two section: first, the conditional 
> expression decides about the visiting mode (party or entirely), than just 
> 'visit' the objects in order.
> * I wasn't sure about why is it necessary to select the entire table in a 
> different way? If the entire table is selected, than selectedTableCells() 
> should do the same. That's why there is no different caret-selection-handling 
> right before the visit.
> * Other modification is the removed duplicate of cell-protection-check. If 
> only one cell is selected, the loop still can operate, just runs only once.
> * The patch contains many inline comments to cover all cases clearly.
> 
> *This patch is just a suggestion to make this snippet more cleaner.*
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoTextEditor.cpp 392f682 
> 
> Diff: https://git.reviewboard.kde.org/r/124641/diff/
> 
> 
> Testing
> ---
> 
> Builded successfully, table works the same as before.
> 
> 
> Thanks,
> 
> Soma Schliszka
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel