Review Request: Setting working environment on launching in Windows

2013-01-09 Thread Stuart Dickson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108295/
---

Review request for Calligra.


Description
---

In order to allow Calligra applications to be run as pre-built binaries on 
Windows operating system, some environment variables need to be set in order to 
allow plugins etc to be correctly found.

Previously, the packaged version of the applications used a combination of 
batch file and VBS script in order to set the environment invisibly to the user 
before launching the application.

The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, 
flow) to be launched directly.
This also resolves occasional issues where scripting was not correctly 
installed, or was not available to the user.
It also makes possible associating the Calligra applications against document 
file types.


Diffs
-

  flow/part/main.cpp 67d1926 
  karbon/main.cpp 4e90edb 
  plan/main.cpp 96f0b7a 
  sheets/part/Main.cpp facda77 
  stage/part/main.cpp 5ef9509 
  words/part/main.cpp 875eb5d 

Diff: http://git.reviewboard.kde.org/r/108295/diff/


Testing
---

Built and run on Windows system, demonstrated to work with existing packaging 
setup.
Modifications are wrapped in an OS-centric block (with the exception of the 
additional headers required), so this willl not affect Linux builds.


Thanks,

Stuart Dickson

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Setting working environment on launching in Windows

2013-01-09 Thread Boudewijn Rempt 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108295/#review25073
---



flow/part/main.cpp


I don't think this belongs here. Same in other places.


- Boudewijn Rempt


On Jan. 9, 2013, 3:27 p.m., Stuart Dickson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108295/
> ---
> 
> (Updated Jan. 9, 2013, 3:27 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> In order to allow Calligra applications to be run as pre-built binaries on 
> Windows operating system, some environment variables need to be set in order 
> to allow plugins etc to be correctly found.
> 
> Previously, the packaged version of the applications used a combination of 
> batch file and VBS script in order to set the environment invisibly to the 
> user before launching the application.
> 
> The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, 
> flow) to be launched directly.
> This also resolves occasional issues where scripting was not correctly 
> installed, or was not available to the user.
> It also makes possible associating the Calligra applications against document 
> file types.
> 
> 
> Diffs
> -
> 
>   flow/part/main.cpp 67d1926 
>   karbon/main.cpp 4e90edb 
>   plan/main.cpp 96f0b7a 
>   sheets/part/Main.cpp facda77 
>   stage/part/main.cpp 5ef9509 
>   words/part/main.cpp 875eb5d 
> 
> Diff: http://git.reviewboard.kde.org/r/108295/diff/
> 
> 
> Testing
> ---
> 
> Built and run on Windows system, demonstrated to work with existing packaging 
> setup.
> Modifications are wrapped in an OS-centric block (with the exception of the 
> additional headers required), so this willl not affect Linux builds.
> 
> 
> Thanks,
> 
> Stuart Dickson
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Setting working environment on launching in Windows

2013-01-09 Thread Jarosław Staniek 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108295/#review25074
---



flow/part/main.cpp


I think proper place for this code is KoApplication::start(). This way the 
code can be nicely shared and the main.cpp files can be kept unmodified. I 
would also like to have this code in Kexi but I can adapt to it on my own after 
you commit.



flow/part/main.cpp


- can we use qputenv() everywhere for convention (could be more 
mingw-compatible perhaps for free)?
- convention says: let's use QFile::encodeName() everywhere to properly 
convert paths from unicode to local 8-bit


- Jarosław Staniek


On Jan. 9, 2013, 3:27 p.m., Stuart Dickson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108295/
> ---
> 
> (Updated Jan. 9, 2013, 3:27 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> In order to allow Calligra applications to be run as pre-built binaries on 
> Windows operating system, some environment variables need to be set in order 
> to allow plugins etc to be correctly found.
> 
> Previously, the packaged version of the applications used a combination of 
> batch file and VBS script in order to set the environment invisibly to the 
> user before launching the application.
> 
> The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, 
> flow) to be launched directly.
> This also resolves occasional issues where scripting was not correctly 
> installed, or was not available to the user.
> It also makes possible associating the Calligra applications against document 
> file types.
> 
> 
> Diffs
> -
> 
>   flow/part/main.cpp 67d1926 
>   karbon/main.cpp 4e90edb 
>   plan/main.cpp 96f0b7a 
>   sheets/part/Main.cpp facda77 
>   stage/part/main.cpp 5ef9509 
>   words/part/main.cpp 875eb5d 
> 
> Diff: http://git.reviewboard.kde.org/r/108295/diff/
> 
> 
> Testing
> ---
> 
> Built and run on Windows system, demonstrated to work with existing packaging 
> setup.
> Modifications are wrapped in an OS-centric block (with the exception of the 
> additional headers required), so this willl not affect Linux builds.
> 
> 
> Thanks,
> 
> Stuart Dickson
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Turn off table and other text features in Krita

2013-01-09 Thread Sven Langkamp 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108298/
---

Review request for Calligra.


Description
---

Patch turn of some of the text features which are not needed in Krita like 
tables and pagebreaks. Add new resource were application can save special 
things like that.


This addresses bug 309504.
http://bugs.kde.org/show_bug.cgi?id=309504


Diffs
-

  krita/ui/kis_canvas_resource_provider.cpp 9fb8e11 
  libs/flake/KoCanvasResourceManager.h 1976bc7 
  libs/flake/KoCanvasResourceManager.cpp 4c240a2 
  plugins/textshape/TextTool.cpp e0b6f99 

Diff: http://git.reviewboard.kde.org/r/108298/diff/


Testing
---

Tested with Krita.


Thanks,

Sven Langkamp

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Turn off table and other text features in Krita

2013-01-09 Thread C. Boemann 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108298/#review25077
---

Ship it!


only one small nitpick


plugins/textshape/TextTool.cpp


spaces


- C. Boemann


On Jan. 9, 2013, 3:47 p.m., Sven Langkamp wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108298/
> ---
> 
> (Updated Jan. 9, 2013, 3:47 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Patch turn of some of the text features which are not needed in Krita like 
> tables and pagebreaks. Add new resource were application can save special 
> things like that.
> 
> 
> This addresses bug 309504.
> http://bugs.kde.org/show_bug.cgi?id=309504
> 
> 
> Diffs
> -
> 
>   krita/ui/kis_canvas_resource_provider.cpp 9fb8e11 
>   libs/flake/KoCanvasResourceManager.h 1976bc7 
>   libs/flake/KoCanvasResourceManager.cpp 4c240a2 
>   plugins/textshape/TextTool.cpp e0b6f99 
> 
> Diff: http://git.reviewboard.kde.org/r/108298/diff/
> 
> 
> Testing
> ---
> 
> Tested with Krita.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Turn off table and other text features in Krita

2013-01-09 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108298/#review25078
---


This review has been submitted with commit 
5d2f895413d6a64ce6f10675e6a95e2b8e78bf15 by Sven Langkamp to branch master.

- Commit Hook


On Jan. 9, 2013, 3:47 p.m., Sven Langkamp wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108298/
> ---
> 
> (Updated Jan. 9, 2013, 3:47 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Patch turn of some of the text features which are not needed in Krita like 
> tables and pagebreaks. Add new resource were application can save special 
> things like that.
> 
> 
> This addresses bug 309504.
> http://bugs.kde.org/show_bug.cgi?id=309504
> 
> 
> Diffs
> -
> 
>   krita/ui/kis_canvas_resource_provider.cpp 9fb8e11 
>   libs/flake/KoCanvasResourceManager.h 1976bc7 
>   libs/flake/KoCanvasResourceManager.cpp 4c240a2 
>   plugins/textshape/TextTool.cpp e0b6f99 
> 
> Diff: http://git.reviewboard.kde.org/r/108298/diff/
> 
> 
> Testing
> ---
> 
> Tested with Krita.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Readd formats menu (Select Masterpage, Edit Page layout) to Flow

2013-01-09 Thread Yue Liu 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108220/#review25116
---

Ship it!


- Yue Liu


On Jan. 6, 2013, 4:03 a.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108220/
> ---
> 
> (Updated Jan. 6, 2013, 4:03 a.m.)
> 
> 
> Review request for Calligra and Yue Liu.
> 
> 
> Description
> ---
> 
> KoPAView::initActions() is adding actions for selecting the "Master Page..." 
> and setting the "Page Layout...", but they do not make it into the menu of 
> Calligra Flow, because the flow.rc misses to have the proper entries 
> "format_masterpage" and "format_pagelayout" (and these are also not part of 
> "ui_standards.rc").
> 
> Attached patch adds a menu "Format" with the two entries, for consistency 
> like Stage has (though Stage adds own menu entries as well).
> 
> Okay to also backport to 2.6?
> 
> There is one flaw, but that also exist with Stage now: switching to another 
> format does not trigger a repaint. Has to be fixed separately.
> 
> 
> Diffs
> -
> 
>   flow/part/flow.rc 3e90a63 
> 
> Diff: http://git.reviewboard.kde.org/r/108220/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Readd formats menu (Select Masterpage, Edit Page layout) to Flow

2013-01-09 Thread Yue Liu 


> On Jan. 10, 2013, 1:25 a.m., Yue Liu wrote:
> >

please also backport to 2.6.


- Yue


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108220/#review25116
---


On Jan. 6, 2013, 4:03 a.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108220/
> ---
> 
> (Updated Jan. 6, 2013, 4:03 a.m.)
> 
> 
> Review request for Calligra and Yue Liu.
> 
> 
> Description
> ---
> 
> KoPAView::initActions() is adding actions for selecting the "Master Page..." 
> and setting the "Page Layout...", but they do not make it into the menu of 
> Calligra Flow, because the flow.rc misses to have the proper entries 
> "format_masterpage" and "format_pagelayout" (and these are also not part of 
> "ui_standards.rc").
> 
> Attached patch adds a menu "Format" with the two entries, for consistency 
> like Stage has (though Stage adds own menu entries as well).
> 
> Okay to also backport to 2.6?
> 
> There is one flaw, but that also exist with Stage now: switching to another 
> format does not trigger a repaint. Has to be fixed separately.
> 
> 
> Diffs
> -
> 
>   flow/part/flow.rc 3e90a63 
> 
> Diff: http://git.reviewboard.kde.org/r/108220/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix a number of Krazy issues: source files not ending in newline

2013-01-09 Thread Inge Wallin 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108317/
---

Review request for Calligra.


Description
---

This patch adds a final newline to some source files that don't have them. This 
is one of the issues that are flagged in the code checker at 
http://englishbreakfastnetwork.org/krazy/index.php?component=bundled-apps&module=calligra.
 

In all of Calligra there are lots of small issues like this, though this 
particular type is especially trivial. So I wrote a utility tools/fixsrc.py 
that is intended to find and fix things that are just too trivial to do 
manually. 

But how shall we handle it? I applied the script in a place that I thought 
would not be very controversial: the filters. But how to continue? I can see 
several choices we need to make:
 - Leave some of the issues be? In that case we should disable the check in EBN.
 - Apply them to all the sources in one big swoop? Or per module?
 - Backport or not? I would prefer to apply the same type of patch in at least 
master and 2.6 to maximize the backportability of other patches.


Diffs
-

  filters/words/msword-odf/wv2/src/olestream.cpp c778962 
  filters/words/rtf/import/rtf-qt/src/AbstractRtfOutput.h 00ba298 
  filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.h 855367b 
  filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.cpp edfad34 
  filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.h 45f233f 
  filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.cpp caf 
  filters/words/rtf/import/rtf-qt/src/ColorTableDestination.h 01d7abf 
  filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.h 683220f 
  filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.cpp 3db8c61 
  filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.h dc59149 
  filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.cpp 67fdaef 
  filters/words/rtf/import/rtf-qt/src/Destination.cpp faa3aa2 
  filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.h 
fdbc7e0 
  filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.cpp 
993cd42 
  filters/words/rtf/import/rtf-qt/src/DocumentDestination.cpp 3b278b3 
  filters/words/rtf/import/rtf-qt/src/FontTableDestination.cpp 2fda530 
  filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.h 87a7373 
  filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.cpp d51cc1c 
  filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.h f391cbd 
  filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.cpp 26a0646 
  filters/words/rtf/import/rtf-qt/src/IgnoredDestination.cpp d273880 
  filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.h 3134ef9 
  filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.cpp 9f0dbb0 
  filters/words/rtf/import/rtf-qt/src/InfoDestination.h 518fbbd 
  filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.h 3c835f4 
  filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.cpp 3fb1b8f 
  filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.h 106cb37 
  filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.cpp 62fbf7c 
  filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.h 03fb8cb 
  filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.cpp 3f5e27c 
  filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.h 41ac5b3 
  filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.cpp e843d9a 
  filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.h 0431a5f 
  filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.cpp b16f474 
  filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.h 7c7b074 
  filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.cpp 510db79 
  filters/words/rtf/import/rtf-qt/src/PcdataDestination.h edd0e89 
  filters/words/rtf/import/rtf-qt/src/PcdataDestination.cpp b266aec 
  filters/words/rtf/import/rtf-qt/src/StyleSheetDestination.cpp a5d4f86 
  filters/words/rtf/import/rtf-qt/src/SubjectPcdataDestination.h 508625a 
  filters/words/rtf/import/rtf-qt/src/SubjectPcdataDestination.cpp bdb51a0 
  filters/words/rtf/import/rtf-qt/src/TextDocumentRtfOutput.h 5184ae8 
  filters/words/rtf/import/rtf-qt/src/TitlePcdataDestination.h d80c751 
  filters/words/rtf/import/rtf-qt/src/TitlePcdataDestination.cpp 15abb42 
  filters/words/rtf/import/rtf-qt/src/Token.cpp 84a5b0a 
  filters/words/rtf/import/rtf-qt/src/Tokenizer.h 27a59bd 
  filters/words/rtf/import/rtf-qt/src/UserPropsDestination.h 846459a 

Diff: http://git.reviewboard.kde.org/r/108317/diff/


Testing
---


Thanks,

Inge Wallin

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix a number of Krazy issues: source files not ending in newline

2013-01-09 Thread Inge Wallin 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108317/#review25124
---


Interesting... Seems that the reviewboard cannot handle this type of patch. But 
take my word for that the patch contains a fix for all of 
http://englishbreakfastnetwork.org/krazy/reports/bundled-apps/calligra/filters/index.html,
 section 8: "Check that file ends with a newline [endswithnewline]...OOPS! 47 
issues found!"

- Inge Wallin


On Jan. 10, 2013, 6:41 a.m., Inge Wallin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108317/
> ---
> 
> (Updated Jan. 10, 2013, 6:41 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> This patch adds a final newline to some source files that don't have them. 
> This is one of the issues that are flagged in the code checker at 
> http://englishbreakfastnetwork.org/krazy/index.php?component=bundled-apps&module=calligra.
>  
> 
> In all of Calligra there are lots of small issues like this, though this 
> particular type is especially trivial. So I wrote a utility tools/fixsrc.py 
> that is intended to find and fix things that are just too trivial to do 
> manually. 
> 
> But how shall we handle it? I applied the script in a place that I thought 
> would not be very controversial: the filters. But how to continue? I can see 
> several choices we need to make:
>  - Leave some of the issues be? In that case we should disable the check in 
> EBN.
>  - Apply them to all the sources in one big swoop? Or per module?
>  - Backport or not? I would prefer to apply the same type of patch in at 
> least master and 2.6 to maximize the backportability of other patches.
> 
> 
> Diffs
> -
> 
>   filters/words/msword-odf/wv2/src/olestream.cpp c778962 
>   filters/words/rtf/import/rtf-qt/src/AbstractRtfOutput.h 00ba298 
>   filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.h 855367b 
>   filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.cpp edfad34 
>   filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.h 45f233f 
>   filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.cpp caf 
>   filters/words/rtf/import/rtf-qt/src/ColorTableDestination.h 01d7abf 
>   filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.h 683220f 
>   filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.cpp 3db8c61 
>   filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.h dc59149 
>   filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.cpp 67fdaef 
>   filters/words/rtf/import/rtf-qt/src/Destination.cpp faa3aa2 
>   filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.h 
> fdbc7e0 
>   filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.cpp 
> 993cd42 
>   filters/words/rtf/import/rtf-qt/src/DocumentDestination.cpp 3b278b3 
>   filters/words/rtf/import/rtf-qt/src/FontTableDestination.cpp 2fda530 
>   filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.h 87a7373 
>   filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.cpp d51cc1c 
>   filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.h f391cbd 
>   filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.cpp 26a0646 
>   filters/words/rtf/import/rtf-qt/src/IgnoredDestination.cpp d273880 
>   filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.h 3134ef9 
>   filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.cpp 9f0dbb0 
>   filters/words/rtf/import/rtf-qt/src/InfoDestination.h 518fbbd 
>   filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.h 3c835f4 
>   filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.cpp 3fb1b8f 
>   filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.h 106cb37 
>   filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.cpp 62fbf7c 
>   filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.h 03fb8cb 
>   filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.cpp 3f5e27c 
>   filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.h 41ac5b3 
>   filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.cpp e843d9a 
>   filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.h 0431a5f 
>   filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.cpp b16f474 
>   filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.h 7c7b074 
>   filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.cpp 510db79 
>   filters/words/rtf/import/rtf-qt/src/PcdataDestination.h edd0e89 
>   filters/words/rtf/import/rtf-qt/src/PcdataDestination.cpp b266aec 
>   filters/words/rtf/import/rtf-qt/src/StyleSheetDestination.cpp a5d4f86 
>   filters/words/rtf/import/rtf-qt/src/SubjectPcdataDest

Re: Review Request: Fix a number of Krazy issues: source files not ending in newline

2013-01-09 Thread Inge Wallin 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108317/#review25125
---


Interesting... Seems that the reviewboard cannot handle this type of patch. But 
take my word for that the patch contains a fix for all of 
http://englishbreakfastnetwork.org/krazy/reports/bundled-apps/calligra/filters/index.html,
 section 8: "Check that file ends with a newline [endswithnewline]...OOPS! 47 
issues found!"

- Inge Wallin


On Jan. 10, 2013, 6:41 a.m., Inge Wallin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108317/
> ---
> 
> (Updated Jan. 10, 2013, 6:41 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> This patch adds a final newline to some source files that don't have them. 
> This is one of the issues that are flagged in the code checker at 
> http://englishbreakfastnetwork.org/krazy/index.php?component=bundled-apps&module=calligra.
>  
> 
> In all of Calligra there are lots of small issues like this, though this 
> particular type is especially trivial. So I wrote a utility tools/fixsrc.py 
> that is intended to find and fix things that are just too trivial to do 
> manually. 
> 
> But how shall we handle it? I applied the script in a place that I thought 
> would not be very controversial: the filters. But how to continue? I can see 
> several choices we need to make:
>  - Leave some of the issues be? In that case we should disable the check in 
> EBN.
>  - Apply them to all the sources in one big swoop? Or per module?
>  - Backport or not? I would prefer to apply the same type of patch in at 
> least master and 2.6 to maximize the backportability of other patches.
> 
> 
> Diffs
> -
> 
>   filters/words/msword-odf/wv2/src/olestream.cpp c778962 
>   filters/words/rtf/import/rtf-qt/src/AbstractRtfOutput.h 00ba298 
>   filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.h 855367b 
>   filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.cpp edfad34 
>   filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.h 45f233f 
>   filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.cpp caf 
>   filters/words/rtf/import/rtf-qt/src/ColorTableDestination.h 01d7abf 
>   filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.h 683220f 
>   filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.cpp 3db8c61 
>   filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.h dc59149 
>   filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.cpp 67fdaef 
>   filters/words/rtf/import/rtf-qt/src/Destination.cpp faa3aa2 
>   filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.h 
> fdbc7e0 
>   filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.cpp 
> 993cd42 
>   filters/words/rtf/import/rtf-qt/src/DocumentDestination.cpp 3b278b3 
>   filters/words/rtf/import/rtf-qt/src/FontTableDestination.cpp 2fda530 
>   filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.h 87a7373 
>   filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.cpp d51cc1c 
>   filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.h f391cbd 
>   filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.cpp 26a0646 
>   filters/words/rtf/import/rtf-qt/src/IgnoredDestination.cpp d273880 
>   filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.h 3134ef9 
>   filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.cpp 9f0dbb0 
>   filters/words/rtf/import/rtf-qt/src/InfoDestination.h 518fbbd 
>   filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.h 3c835f4 
>   filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.cpp 3fb1b8f 
>   filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.h 106cb37 
>   filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.cpp 62fbf7c 
>   filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.h 03fb8cb 
>   filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.cpp 3f5e27c 
>   filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.h 41ac5b3 
>   filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.cpp e843d9a 
>   filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.h 0431a5f 
>   filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.cpp b16f474 
>   filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.h 7c7b074 
>   filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.cpp 510db79 
>   filters/words/rtf/import/rtf-qt/src/PcdataDestination.h edd0e89 
>   filters/words/rtf/import/rtf-qt/src/PcdataDestination.cpp b266aec 
>   filters/words/rtf/import/rtf-qt/src/StyleSheetDestination.cpp a5d4f86 
>   filters/words/rtf/import/rtf-qt/src/SubjectPcdataDest