Re: Review Request: Fix copy paste to include named styles

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107495/#review22860
---


This review has been submitted with commit 
7865b06f933908a4a4e024758508f3a2a47079f5 by C. Boemann to branch master.

- Commit Hook


On Nov. 29, 2012, 9:12 a.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107495/
> ---
> 
> (Updated Nov. 29, 2012, 9:12 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> This patch fixes copy/paste by
>  1) saving the used styles to clipboard as well
>  2) only add a style if another style named the same doesn't exist already
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoTextDrag.cpp 9f2d537 
>   libs/kotext/KoTextOdfSaveHelper.h 39107ef 
>   libs/kotext/KoTextOdfSaveHelper.cpp e01e651 
>   libs/kotext/opendocument/KoTextWriter.cpp 0d52062 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 4439769 
>   libs/kotext/styles/KoStyleManager.h ae2e720 
>   libs/kotext/styles/KoStyleManager.cpp 2aa74fe 
> 
> Diff: http://git.reviewboard.kde.org/r/107495/diff/
> 
> 
> Testing
> ---
> 
> Some basic cut and paste with variations of styles applied
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Make it possible to override info from author profile via dbus/c++

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107486/#review22861
---


This review has been submitted with commit 
244ef245ff8bf8a7c6dfde5e3534d3ad8fa11925 by C. Boemann to branch master.

- Commit Hook


On Nov. 27, 2012, 12:14 p.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107486/
> ---
> 
> (Updated Nov. 27, 2012, 12:14 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> It turns out we used to have a way for dbus to set author information.
> 
> This got broken by the author profile changes, so this patch fixes that, by 
> allowing to override the information fetched from author profiles
> 
> ok to backport as well?
> 
> 
> Diffs
> -
> 
>   libs/main/KoDocumentInfo.h d98cab4 
>   libs/main/KoDocumentInfo.cpp 89bcdbe 
> 
> Diff: http://git.reviewboard.kde.org/r/107486/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix copy paste to include named styles

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107495/#review22862
---


This review has been submitted with commit 
f5022f732054d80f45ff37c0a8b7b974f1242909 by C. Boemann to branch calligra/2.6.

- Commit Hook


On Nov. 29, 2012, 9:12 a.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107495/
> ---
> 
> (Updated Nov. 29, 2012, 9:12 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> This patch fixes copy/paste by
>  1) saving the used styles to clipboard as well
>  2) only add a style if another style named the same doesn't exist already
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoTextDrag.cpp 9f2d537 
>   libs/kotext/KoTextOdfSaveHelper.h 39107ef 
>   libs/kotext/KoTextOdfSaveHelper.cpp e01e651 
>   libs/kotext/opendocument/KoTextWriter.cpp 0d52062 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 4439769 
>   libs/kotext/styles/KoStyleManager.h ae2e720 
>   libs/kotext/styles/KoStyleManager.cpp 2aa74fe 
> 
> Diff: http://git.reviewboard.kde.org/r/107495/diff/
> 
> 
> Testing
> ---
> 
> Some basic cut and paste with variations of styles applied
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix next style appears as modified after new line on header style (bug 293378).

[Pierre Stirnweiss]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107540/
---

Review request for Calligra.


Description
---

After a list style defining a "next style" (like Head 1), the next style is 
marked as modified (shows a + button in the combo).
The problem comes from Qt defining an indent of 1 for list styles. This gets 
carried over to the block style. Since we do not use Qt's indentation, we need 
to clear that property.

Ok to backport to 2.6?


This addresses bug 293378.
http://bugs.kde.org/show_bug.cgi?id=293378


Diffs
-

  libs/kotext/KoList.cpp a9f582b 
  libs/kotext/styles/KoParagraphStyle.cpp 78f09f0 

Diff: http://git.reviewboard.kde.org/r/107540/diff/


Testing
---

Compiled and tried. Seems to work, and I have not spotted regressions.


Thanks,

Pierre Stirnweiss

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix next style appears as modified after new line on header style (bug 293378).

[C. Boemann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107540/#review22863
---

Ship it!


- C. Boemann


On Dec. 1, 2012, 1:29 p.m., Pierre Stirnweiss wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107540/
> ---
> 
> (Updated Dec. 1, 2012, 1:29 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> After a list style defining a "next style" (like Head 1), the next style is 
> marked as modified (shows a + button in the combo).
> The problem comes from Qt defining an indent of 1 for list styles. This gets 
> carried over to the block style. Since we do not use Qt's indentation, we 
> need to clear that property.
> 
> Ok to backport to 2.6?
> 
> 
> This addresses bug 293378.
> http://bugs.kde.org/show_bug.cgi?id=293378
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoList.cpp a9f582b 
>   libs/kotext/styles/KoParagraphStyle.cpp 78f09f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107540/diff/
> 
> 
> Testing
> ---
> 
> Compiled and tried. Seems to work, and I have not spotted regressions.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix next style appears as modified after new line on header style (bug 293378).

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107540/#review22871
---


This review has been submitted with commit 
6ca4bdf30bcf953ac3b13e0daeb35d3590332d0b by Pierre Stirnweiss to branch master.

- Commit Hook


On Dec. 1, 2012, 1:29 p.m., Pierre Stirnweiss wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107540/
> ---
> 
> (Updated Dec. 1, 2012, 1:29 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> After a list style defining a "next style" (like Head 1), the next style is 
> marked as modified (shows a + button in the combo).
> The problem comes from Qt defining an indent of 1 for list styles. This gets 
> carried over to the block style. Since we do not use Qt's indentation, we 
> need to clear that property.
> 
> Ok to backport to 2.6?
> 
> 
> This addresses bug 293378.
> http://bugs.kde.org/show_bug.cgi?id=293378
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoList.cpp a9f582b 
>   libs/kotext/styles/KoParagraphStyle.cpp 78f09f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107540/diff/
> 
> 
> Testing
> ---
> 
> Compiled and tried. Seems to work, and I have not spotted regressions.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix next style appears as modified after new line on header style (bug 293378).

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107540/#review22874
---


This review has been submitted with commit 
863f8e6c080131c34572e6a8ee293c8d19cd1f70 by Pierre Stirnweiss to branch 
calligra/2.6.

- Commit Hook


On Dec. 1, 2012, 1:29 p.m., Pierre Stirnweiss wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107540/
> ---
> 
> (Updated Dec. 1, 2012, 1:29 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> After a list style defining a "next style" (like Head 1), the next style is 
> marked as modified (shows a + button in the combo).
> The problem comes from Qt defining an indent of 1 for list styles. This gets 
> carried over to the block style. Since we do not use Qt's indentation, we 
> need to clear that property.
> 
> Ok to backport to 2.6?
> 
> 
> This addresses bug 293378.
> http://bugs.kde.org/show_bug.cgi?id=293378
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoList.cpp a9f582b 
>   libs/kotext/styles/KoParagraphStyle.cpp 78f09f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107540/diff/
> 
> 
> Testing
> ---
> 
> Compiled and tried. Seems to work, and I have not spotted regressions.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Oleg Kukharchuk]

> On Nov. 24, 2012, 11:10 p.m., Jarosław Staniek wrote:
> > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp, line 1802
> > 
> >
> > -> An error

using i18nc


- Oleg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22496
---


On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> ---
> 
> (Updated Nov. 23, 2012, 2:06 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
>   kexi/widget/fields/KexiFieldListModel.cpp 
> 91ed791065a34d8a137dc84997506bdd0643b231 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp 
> ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> ---
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Oleg Kukharchuk]

> On Nov. 25, 2012, 4:56 p.m., Jarosław Staniek wrote:
> > If I forget to select source filename, `Cannot open input file "".` error 
> > pops up. How about displaying dedicated error (we did that in 
> > migration/importwizard.cpp:868 too).

fixed


- Oleg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22511
---


On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> ---
> 
> (Updated Nov. 23, 2012, 2:06 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
>   kexi/widget/fields/KexiFieldListModel.cpp 
> 91ed791065a34d8a137dc84997506bdd0643b231 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp 
> ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> ---
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Oleg Kukharchuk]

> On Nov. 25, 2012, 4:59 p.m., Jarosław Staniek wrote:
> > Detection of import options does not work when I click Back and pick 
> > different file. For example if space delimiter was detected initially, and 
> > later comma-separated file is picked, this is not detected.

fixed


- Oleg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22514
---


On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> ---
> 
> (Updated Nov. 23, 2012, 2:06 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
>   kexi/widget/fields/KexiFieldListModel.cpp 
> 91ed791065a34d8a137dc84997506bdd0643b231 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp 
> ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> ---
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Oleg Kukharchuk]

> On Nov. 25, 2012, 5:14 p.m., Jarosław Staniek wrote:
> > Error encountered: 
> > Creating table failed. Error while executing SQL statement.
> > Message from server: duplicate column name: Text
> > SQL statement: CREATE TABLE votersbook_small2 (id INTEGER PRIMARY KEY, 
> > Text, a Text, Text, b Text)
> > 
> > Test data (autodetected separator is ','):
> > ,"a",,"b"
> > ,,,
> > ,,"c"
> > "d",
> >

fixed... it was realy ugly code :D.. sorry, my bad)


- Oleg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22519
---


On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> ---
> 
> (Updated Nov. 23, 2012, 2:06 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
>   kexi/widget/fields/KexiFieldListModel.cpp 
> 91ed791065a34d8a137dc84997506bdd0643b231 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp 
> ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> ---
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Oleg Kukharchuk]

> On Nov. 25, 2012, 6:15 p.m., Jarosław Staniek wrote:
> > "Fields count does not match" error is displayed on appending if the 
> > destination table is identical but contains extra primary-key column 
> > (generated by Kexi). I know this case is just not supported now. We would 
> > try to import if no primary key is defined for imported data but it is 
> > present in the destination table. This could happen silently.

I think this logic will be added in future with code for columns managment


- Oleg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22525
---


On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> ---
> 
> (Updated Nov. 23, 2012, 2:06 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
>   kexi/widget/fields/KexiFieldListModel.cpp 
> 91ed791065a34d8a137dc84997506bdd0643b231 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp 
> ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> ---
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Oleg Kukharchuk]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/
---

(Updated Dec. 1, 2012, 10:57 p.m.)


Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.


Description
---

* moved to a KAssistantDialog
* added ability to import into an existent table


Diffs (updated)
-

  kexi/plugins/importexport/csv/kexicsvimportdialog.h 
15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
  kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
5176299599ab034bf256f07ee2651d8a4babb3a0 

Diff: http://git.reviewboard.kde.org/r/107330/diff/


Testing
---

tested on local branch
and additional testing needed

(code was not cleaned up yet)


Thanks,

Oleg Kukharchuk

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Jarosław Staniek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22897
---



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp


-> "CSV import: data will be appended to a new table"


- Jarosław Staniek


On Dec. 1, 2012, 10:57 p.m., Oleg Kukharchuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> ---
> 
> (Updated Dec. 1, 2012, 10:57 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> ---
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: import csv-file into existing table

[Oleg Kukharchuk]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/
---

(Updated Dec. 1, 2012, 11:59 p.m.)


Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.


Description
---

* moved to a KAssistantDialog
* added ability to import into an existent table


Diffs (updated)
-

  kexi/plugins/importexport/csv/kexicsvimportdialog.h 
15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
  kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
5176299599ab034bf256f07ee2651d8a4babb3a0 

Diff: http://git.reviewboard.kde.org/r/107330/diff/


Testing
---

tested on local branch
and additional testing needed

(code was not cleaned up yet)


Thanks,

Oleg Kukharchuk

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Mobi format problems

[Inge Wallin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107526/#review22900
---


Ok, I have a number of comments.  This is a good start but not quiet ready for 
merge yet. See below.


filters/words/mobi/CMakeLists.txt


If you're really sure you won't need it anymore (which you should be at 
this stage) you should remove it rather than comment it out.



filters/words/mobi/MobiFile.cpp


Argh!  Magic numbers!

Please add some form of comment what these numbers are about.



filters/words/mobi/MobiHeaderGenerator.cpp


Without actually knowing what this number is about, it feels that it would 
be good to have a defined constant for it instead of just using the number 
directly.



filters/words/mobi/MobiHeaderGenerator.cpp


Our coding standar is to:
 - Have an empty line between methods
 - have the initializer colon on the next line.

Also look for other places where this happens.



filters/words/mobi/MobiHeaderGenerator.cpp


I think compressedTextSize would be more correct.



filters/words/mobi/MobiHeaderGenerator.cpp


Coding standard says "spaces around binary operators".



filters/words/mobi/MobiHeaderGenerator.cpp


If you comment out a larger piece of code it's better to do it with:
#if 0
#endif
than using comments on every line. It's very easy to miss one line either 
when commenting or uncommenting it back.

That said, if you're done with the code and won't need it anymore (as like 
when you're registering a review request) then it's better to remove it 
altogether.



filters/words/mobi/MobiHeaderGenerator.cpp


Remove code not needed anymore.



filters/words/mobi/MobiHeaderGenerator.cpp


calligra-suite.org is deprecated.  Use calligra.org instead.



filters/words/mobi/MobiHeaderGenerator.cpp


Hmm, what strange date format is this?  I know -MM-dd (the ISO format) 
and dd/MM/ (the US format).  I'd prefer the ISO format but in any case this 
is non-standard (or perhaps not in Iran?).



filters/words/mobi/OdtMobiHtmlConverter.cpp


Just a note in case somebody else comments on this...

This file contains a number of places where code is commented away. In this 
particular file I would prefer if it's actually *not* removed since I want to 
refactor the parsing of ODT and then bring it back into one parser. That would 
be simplified by having it all in place.


- Inge Wallin


On Nov. 30, 2012, 7:34 p.m., mojtaba shahi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107526/
> ---
> 
> (Updated Nov. 30, 2012, 7:34 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> This fixes are becuse that Kindle device couldn't open our Mobi format.
> The first problem was about html text content that i used for mobi, it was 
> not standard, sor for have a standard Mobi html i create OdtMobiHtmlConverter
> a copy of OdtHtmlConverter. I changed it t have a one, for that i neede 
> inline attributes in elements no CSS, and i think we can merge it to 
> OdtHtmlConverter.
> 
> Now with these fixes we support images, bookmarks (not very well), And Kindle 
> can open our mobi correct without any problem.
> 
> 
> Diffs
> -
> 
>   filters/words/mobi/CMakeLists.txt 88633a7 
>   filters/words/mobi/MobiFile.cpp 29c3551 
>   filters/words/mobi/MobiHeaderGenerator.h 7864620 
>   filters/words/mobi/MobiHeaderGenerator.cpp 378a01a 
>   filters/words/mobi/OdtMobiHtmlConverter.h PRE-CREATION 
>   filters/words/mobi/OdtMobiHtmlConverter.cpp PRE-CREATION 
>   filters/words/mobi/PalmDocCompression.h 2c7ed71 
>   filters/words/mobi/PalmDocCompression.cpp 4df0067 
>   filters/words/mobi/exportmobi.cpp 455b526 
> 
> Diff: http://git.reviewboard.kde.org/r/107526/diff/
> 
> 
> Testing
> ---
> 
> I have tested ebooks in Kidle Desktop Previewer for windows.
> And also tested on Kidle device too, no problem :)
> There is a mobi that i have converted in attach file, it is about mobi format 
> but is not completed yet. :) 
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

___

Re: Review Request: import csv-file into existing table

[Jarosław Staniek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22901
---




- Perhaps it's earlier bug but please look at numbers on the vertical header 
(it's "2, 2, 3", instead of "1, 2, 3"): 
http://wstaw.org/m/2012/12/02/plasma-desktoppx2099.png
Test data (autodetected separator is ','):
,"a",,"b"
,,,
,,"c"
"d",

- I am sorry for confusion, after further testing the assistant's buttons, I 
propose: in 'Importing...' page Next button should be hidden; on the first page 
Back button should be hidden; Import... button should be visible only when it's 
available

- On the 'Choose Name of Destination Table' page, if no destination table is 
selected, "Next" button should be disabled.

- If destination table T was opened prior to importing (appending to T) it 
could be best if we refresh its contents. For now we can do that by closing and 
opening the table's window.

- Later check: what to do if we have the destination table T opened in desingn 
mode and it's 'dirty' (changed)? We have to ask the user about confirmation of 
dropping the Design before we can continue.


kexi/plugins/importexport/csv/kexicsvimportdialog.cpp


-> (~res) 


- Jarosław Staniek


On Dec. 1, 2012, 11:59 p.m., Oleg Kukharchuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> ---
> 
> (Updated Dec. 1, 2012, 11:59 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> ---
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel