date:20120821

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-21 Thread Friedrich W. H. Kossebau

Am Donnerstag, 16. August 2012, 12:26:26 schrieb JL VT:
> On Thu, Aug 16, 2012 at 4:52 AM, Boudewijn Rempt  wrote:
> > On Thursday 16 August 2012 Aug, Friedrich W. H. Kossebau wrote:
> > > ./krita/pics/deletelayer.png
> > > ./krita/pics/raiselayer.png
> > > ./krita/pics/lowerlayer.png
> > 
> > Hm... I'm actually not sure _why_ we aren't using these icons but instead
> > the rather garish green up, down, right, left and minus icons. Does anyone
> > remember?
> > 
> > I was the last person who patched our Layer Docker. My memory is vague
> 
> since I did that over one year ago, but I recall I tried to reuse the icons
> we were already using. I did, however, add new ones, the left and right
> icons were selected by me; And I'm not sure if I used or not the delete
> layer icon.  I used the green left and right icons because I couldn't find
> any other icon to put there.
> 
> That's what I recall.

While I personally would prefer consistency over all programs in what 
icons/symbols they use for what operation, I also understand that 
aesthetically some less colorful icons are more appealing, especially with 
programs/tools for color-centric/full objects.

So seems these icons should not be removed but instead put back to use?
Just, if so, these icons still need some fixing, or rather need to be redone 
completely anyway:
These icons are used in the code with a hardcoded size of 22x22 
(setIconSize(QSize(22, 22)), But the actual icon sizes of the files are 
smaller, seems they were done for 16x16 icon display:
raiselayer:  16x16
lowerlayer:  22x18 (bigger margins, actual content like others)
deletelayer: 16x16

So I would propose to still remove the existing icons raiselayer, lowerlayer, 
deletelayer from the repo, because they are too small if used as they are (by 
adding margins until 22x22 to the files) or look ugly if scaled to 22x22.

Reminder: When creating your custom versions of these icons, do not forget 
that they need to be square (by the xdg icon spec), otherwise they will be 
scaled. So always pad with transparent pixels to reach a square size :)

Cheers
Friedrich
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: rename "import" action to "open as new"

2012-08-21 Thread Thomas Pfeiffer


Hello Boud,

On 21.08.2012 08:58, Boudewijn Rempt wrote:

Yeah, you didn't, and I did... Anyway, I'll drop the patch for komain and just 
fix it for Krita myself.


wait, can we please not sacrifice a bit of Calligra's overall usability over a 
dispute between two developers?
The rename is definitely useful for all applications. It turns a feature of 
disputed usefulness which nobody understands into a feature of disputed 
usefulness that many more users will probably understand. That is a good thing 
and I haven't seen Jaroslaw explicitly object to the rename either.
Whether the feature should be removed altogether is still an open discussion, 
but unless someone actually removes it, it stays anyway. And I'd much rather 
have a usable feature which I personally don't find all that useful than an 
unusable feature. If we clutter the menu, we should at least clutter it with 
features that users understand.
And please also remove the icon from the menu entry (unless you find a better 
one), because it fits the feature as badly as the label "import".


Again, please do not drop the patch. You already have an okay from boemann and 
you have my okay as well.


Thank you,
Thomas
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-21 Thread Friedrich W. H. Kossebau

Hi,

Am Donnerstag, 16. August 2012, 07:59:07 schrieb Friedrich W. H. Kossebau:
> looking for icons which are not needed in the current Calligra codebase I
> collected quite a few. So below find a list of icon files in Calligra which
> are either duplicates of icons in Oxygen (as part of KDE 4.3.5) or not used
> by any code, as far as I can tell. I skipped a few icon files, as I am not
> too sure about Kexi and Krita code (and possible hidden icon references),
> but these here should be safe, and are a good start.
> 
> I guess putting this on review board does not work nicely (or?), so please
> review the list of icons to remove here and give an okay to commit to
> master.

So any more comments on this list, or can I go and make these icons just 
history?

> DUPLICATED ICONS (Oxygen 4.3.5)
> 
> pics/hicolor/hi*-action-format-font-size-{less,more}.png
> used by sheets/ui/CellToolBase.cpp
> 
> pics/hicolor/hi*-action-format-line-spacing-{normal,double,triple}.png
> not used by anything
> 
> there is libs/koreport/pics/hicolor/hi*-action-checkbox.png
> used in libs/koreport/items/check/KoReportCheckPlugin.cpp
> 
> libs/flake/pics/ox*-action-snap-{extension,intersection,guideline,node,orto}
> . {png,svg}
> only the new boundingbox is needed, because not part of Oxygen set
> 
> pics/hicolor/hi*-action-view-sort-{ascending,descending}.png
> used in sheets/ui/CellToolBase.cpp, sheets/dialogs/SortDialog.cpp,
> kexi/core/KexiStandardAction.cpp
> 
> plan/toolbar/hi32-action-view{,-add}.png
> used in plan/kptview.cpp, plan/libs/ui/kptdependencyeditor.cpp,
> plan/libs/ui/kpttaskeditor.cpp
> not present in Oxygen is view-child-add, instead there is view-child

As discussed with Dag (s/view/view-task/ above): 
will remove plan/toolbar/hi32-action-view-task{,-add}.png
and keep view-task-child-add.png

> plan/toolbar/hi32-action-resource-calendar-(child-)insert.png
> used in plan/libs/ui/kptcalendareditor.cpp
> 
> plan/toolbar/hi22-action-resource-group-new.png
> used in plan/libs/ui/kptresourceeditor.cpp
> 
> plan/toolbar/hi22-action-view-time-schedule-{edit,calculus,child-
> insert,baselined,baselined-add,baselined-remove}.png
> used in plan/kptview.cpp, plan/libs/ui/kptscheduleeditor.cpp,
> plan/libs/models/kptschedulemodel.cpp
> 
> 
> NOT USED AT ALL:
> 
> ./pics/hicolor/hi*-action-borderoutline.png
> ./pics/hicolor/hi22-action-borderbottom.png
> ./pics/hicolor/hi22-action-bordertop.png
> ./pics/hicolor/hi22-action-borderright.png
> ./pics/hicolor/hi22-action-borderleft.png
> ./pics/hicolor/hi*-action-bring_forward.*
> ./pics/hicolor/hi*-action-send_backward.png
> ./pics/hicolor/hi22-action-delslide.png
> ./pics/hicolor/hi22-action-slide-new.png
> ./pics/hicolor/hi22-action-slide.png
> ./pics/hicolor/hi16-action-tab_*.png
> ./pics/hicolor/hi*-app-go.png
> ./pics/hicolor/hi22-action-group.png
> ./pics/hicolor/hi22-action-ungroup.png
> ./pics/hicolor/hi16-action-view_split.png
> ./pics/hicolor/hi16-action-view_orientation.png
> ./pics/hicolor/hi16-action-textcolor.png
> ./pics/hicolor/hi22-action-aocenterh.png
> ./pics/hicolor/hi22-action-aocenterv.png
> ./pics/hicolor/hi22-action-clipart.png
> ./pics/hicolor/hi22-action-clipart_from_file.png
> ./pics/hicolor/hi*-action-color_fill.png
> ./pics/hicolor/hi*-action-color_line.png
> 
> ./pics/oxygen/ox32-mimetype-x-shape-chart.png (chart(-tool) factories use
> kchart)
> ./pics/hicolor/hi*-action-delete_table_row.png (kexi has its own special
> delete_table_row)
> ./pics/hicolor/hi*-action-delete_table_col.png
> ./pics/hicolor/hi*-action-insert_table_col.png
> 
> ./libs/widgets/pics/hi22-action-zoom-width.png
> ./libs/widgets/pics/hi22-action-zoom-page.png
> 
> ./plugins/textshape/pics/hi22-action-kotext-character.png
> ./plugins/textshape/pics/hi22-action-kotext-paragraph.png
> ./plugins/defaultTools/pics/rotate.png
> ./plugins/defaultTools/pics/shear.png
> ./plugins/textshape/pics/hi16-action-tool-paragraph.png
> 
> ./braindump/data/import/zoom-page.png
> ./braindump/data/import/zoom-width.png
> 
> ./krita/pics/deletelayer.png
> ./krita/pics/raiselayer.png
> ./krita/pics/lowerlayer.png

It was discussed to put them back to use, but they are too small and need to 
be redone anyway (IMHO, confirmation still needed)

> ./plan/workpackage/pics/hi45-mimetypes-application-x-vnd.kde.plan.work.png
> ./plan/toolbar/hi22-action-accounts.png
> 
> ./karbon/pics/action/hi22-action-style_*.png
> 
> ./kexi/pics/hi16-action-select_item.png
> 
> ./sheets/data/toolbar/hicolor/hi16-action-inserttable.png
> ./sheets/data/toolbar/hicolor/hi*-action-sort_decrease.png
> ./sheets/data/toolbar/hicolor/hi*-action-sort_incr.png
> 
> ./words/toolbar/hi22-action-sl_*.png

Cheers
Friedrich
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Animation Tool Docker

2012-08-21 Thread Paul Mendez



> On Aug. 20, 2012, 5:55 p.m., Thorsten Zachmann wrote:
> > stage/part/KPrShapeApplicationData.cpp, line 31
> > 
> >
> > This seems to be a memory leak.
> 
> Paul Mendez wrote:
> Animations are deleted in KPrAnimationCreateCommand and 
> KPrAnimationRemoveCommand
> 
> Thorsten Zachmann wrote:
> I think this needs to come back. The KPrAnimationCreateCommand and the 
> KPrAnimationRemoveCommand only delete the animations when the animation is 
> removed or when adding is undone. However all animations that are loaded from 
> the file or not removed until the end of the document also need to be deleted.

Other animations are children of substeps and are deleted when the steps, 
substeps structure is deleted.


- Paul


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106093/#review17762
---


On Aug. 21, 2012, 2:26 a.m., Paul Mendez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106093/
> ---
> 
> (Updated Aug. 21, 2012, 2:26 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> GSoC work on Animation Tool Docker:
> - List to display current animations, change order, duration and type of 
> animation
>   - Time line view for advanced edition of start time and duration
>   - Live preview of animations
> - Widget to add new animations
>   - Automatic preview of animations (Can be disabled and Stage remembers your 
> preference)
>   - Alternative animation preview using hover buttons.
>   - Automatic drawing of motion path icons using shape stored on xml 
> description
>   - Automatic loading of predefined animations from a xml file (I have added 
> some predefined animations).
> - Basic edition of motion path animations (Some predefined motion path 
> animations have been added on the xml file).
> - Refactor of KPrAnimateMotion class (class that loads and saves motion paths)
> - Data model to store and edit animations of a document.
> - Unit test for the animations data model.
> 
> 
> Diffs
> -
> 
>   libs/flake/tools/KoPathTool.h a4bcb5047cce5f817fb68d3ab35da38cca93cc54 
>   libs/flake/tools/KoPathTool.cpp 8ad20a6eee4f02a00bd9d15509a777e4c3c8b000 
>   libs/widgets/KoViewItemContextBar.h 
> c8a7017ccabdcb09fd3a7edfdb6697a932e0974e 
>   libs/widgets/KoViewItemContextBar.cpp 
> 163155605f690ed5c754bb04f78d53edb696 
>   stage/part/CMakeLists.txt 77497a71bf60a703f996442e5a8795a62986f582 
>   stage/part/KPrDocument.h a9c7c3b2414172218b268fb95c96d39dd1f1ec9e 
>   stage/part/KPrDocument.cpp de18a8f080c76aeebeaad557c00b3f1d9ab062ed 
>   stage/part/KPrEndOfSlideShowPage.cpp 
> 78907aa1a379f336f3c68ea0690d0c8741219bfd 
>   stage/part/KPrMasterPage.h 29190e33d910f1c2dd339d39c585cbfba6fb9b5c 
>   stage/part/KPrMasterPage.cpp d75b6af8a17dcf2e594c6f3597ab805a63fe77cf 
>   stage/part/KPrPage.cpp ad4af851ae2a1eb8d7681a80f4336c9e43856a0b 
>   stage/part/KPrPageData.h 88ee96680c165da54f8d7c270a1dc4961ffdd5a7 
>   stage/part/KPrPageData.cpp 970fb6e7e791bbffc4e49561e276ce5e86185b32 
>   stage/part/KPrShapeAnimations.h 7558efa420be30ebf975945fcbdec3a1c72d1311 
>   stage/part/KPrShapeAnimations.cpp b479ed79560e51e69d06adfe3b02ed50f600928e 
>   stage/part/KPrShapeApplicationData.h 
> ae8d685a61625625d8d2ff61b2986c05b918e855 
>   stage/part/KPrShapeApplicationData.cpp 
> 691446d01381d4eff701d84ce4bf9dc12149cdce 
>   stage/part/KPrViewModePreviewShapeAnimations.h PRE-CREATION 
>   stage/part/KPrViewModePreviewShapeAnimations.cpp PRE-CREATION 
>   stage/part/animations/KPrAnimateMotion.h 
> 29cdd3f0453e0e0d7e50025699f354357967d2c5 
>   stage/part/animations/KPrAnimateMotion.cpp 
> 575cef1daa769e770b9f678f4cf9c7b424153f8a 
>   stage/part/animations/KPrAnimationBase.h 
> 066974efdf11d0f13f37d0b4854d49bfb2079e5d 
>   stage/part/animations/KPrAnimationBase.cpp 
> 57861e1c4af4fb9218b45f88a6c9dda0f5f0af80 
>   stage/part/animations/KPrAnimationFactory.h 
> b0e7a8db480e713a75427460c3bc1521d06f37a3 
>   stage/part/animations/KPrAnimationLoader.cpp 
> 24cc17b01ac2c7a45edbb78c6adfaa31fac47abd 
>   stage/part/animations/KPrAnimationStep.h 
> 26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64 
>   stage/part/animations/KPrAnimationSubStep.h 
> 83cab65ab078675c380ccbf4b60dab99e83619f1 
>   stage/part/animations/KPrShapeAnimation.h 
> f5d9ac3b796e75f16970f80245e1fbb6673fe1b9 
>   stage/part/animations/KPrShapeAnimation.cpp 
> 988cd14098d8ac1f9290b858540215d75d97f9f3 
>   stage/part/animations/animations.xml PRE-CREATION 
>   stage/part/commands/KPrAnimationCreateCommand.h 
> 831317e9a386e7da4100d27dfbf5aab5b382b28d 
>   stage/part/commands/KPrAnimationCreateCommand.cpp 
> 3c06155bbb6afd6668bef6998bd1fd4c20534

Re: Review Request: Animation Tool Docker

2012-08-21 Thread Paul Mendez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106093/
---

(Updated Aug. 21, 2012, 2:38 p.m.)


Review request for Calligra.


Changes
---

Fix the issues outlined in the comments


Description
---

GSoC work on Animation Tool Docker:
- List to display current animations, change order, duration and type of 
animation
  - Time line view for advanced edition of start time and duration
  - Live preview of animations
- Widget to add new animations
  - Automatic preview of animations (Can be disabled and Stage remembers your 
preference)
  - Alternative animation preview using hover buttons.
  - Automatic drawing of motion path icons using shape stored on xml description
  - Automatic loading of predefined animations from a xml file (I have added 
some predefined animations).
- Basic edition of motion path animations (Some predefined motion path 
animations have been added on the xml file).
- Refactor of KPrAnimateMotion class (class that loads and saves motion paths)
- Data model to store and edit animations of a document.
- Unit test for the animations data model.


Diffs (updated)
-

  libs/flake/tools/KoPathTool.h a4bcb5047cce5f817fb68d3ab35da38cca93cc54 
  libs/flake/tools/KoPathTool.cpp 8ad20a6eee4f02a00bd9d15509a777e4c3c8b000 
  libs/widgets/KoViewItemContextBar.h c8a7017ccabdcb09fd3a7edfdb6697a932e0974e 
  libs/widgets/KoViewItemContextBar.cpp 
163155605f690ed5c754bb04f78d53edb696 
  stage/part/CMakeLists.txt 77497a71bf60a703f996442e5a8795a62986f582 
  stage/part/KPrDocument.h a9c7c3b2414172218b268fb95c96d39dd1f1ec9e 
  stage/part/KPrDocument.cpp de18a8f080c76aeebeaad557c00b3f1d9ab062ed 
  stage/part/KPrEndOfSlideShowPage.cpp 78907aa1a379f336f3c68ea0690d0c8741219bfd 
  stage/part/KPrMasterPage.h 29190e33d910f1c2dd339d39c585cbfba6fb9b5c 
  stage/part/KPrMasterPage.cpp d75b6af8a17dcf2e594c6f3597ab805a63fe77cf 
  stage/part/KPrPage.cpp ad4af851ae2a1eb8d7681a80f4336c9e43856a0b 
  stage/part/KPrPageData.h 88ee96680c165da54f8d7c270a1dc4961ffdd5a7 
  stage/part/KPrPageData.cpp 970fb6e7e791bbffc4e49561e276ce5e86185b32 
  stage/part/KPrShapeAnimations.h 7558efa420be30ebf975945fcbdec3a1c72d1311 
  stage/part/KPrShapeAnimations.cpp b479ed79560e51e69d06adfe3b02ed50f600928e 
  stage/part/KPrShapeApplicationData.h ae8d685a61625625d8d2ff61b2986c05b918e855 
  stage/part/KPrShapeApplicationData.cpp 
691446d01381d4eff701d84ce4bf9dc12149cdce 
  stage/part/KPrViewModePreviewShapeAnimations.h PRE-CREATION 
  stage/part/KPrViewModePreviewShapeAnimations.cpp PRE-CREATION 
  stage/part/animations/KPrAnimateMotion.h 
29cdd3f0453e0e0d7e50025699f354357967d2c5 
  stage/part/animations/KPrAnimateMotion.cpp 
575cef1daa769e770b9f678f4cf9c7b424153f8a 
  stage/part/animations/KPrAnimationBase.h 
066974efdf11d0f13f37d0b4854d49bfb2079e5d 
  stage/part/animations/KPrAnimationBase.cpp 
57861e1c4af4fb9218b45f88a6c9dda0f5f0af80 
  stage/part/animations/KPrAnimationFactory.h 
b0e7a8db480e713a75427460c3bc1521d06f37a3 
  stage/part/animations/KPrAnimationLoader.cpp 
24cc17b01ac2c7a45edbb78c6adfaa31fac47abd 
  stage/part/animations/KPrAnimationStep.h 
26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64 
  stage/part/animations/KPrAnimationSubStep.h 
83cab65ab078675c380ccbf4b60dab99e83619f1 
  stage/part/animations/KPrShapeAnimation.h 
f5d9ac3b796e75f16970f80245e1fbb6673fe1b9 
  stage/part/animations/KPrShapeAnimation.cpp 
988cd14098d8ac1f9290b858540215d75d97f9f3 
  stage/part/animations/animations.xml PRE-CREATION 
  stage/part/commands/KPrAnimationCreateCommand.h 
831317e9a386e7da4100d27dfbf5aab5b382b28d 
  stage/part/commands/KPrAnimationCreateCommand.cpp 
3c06155bbb6afd6668bef6998bd1fd4c20534b8b 
  stage/part/commands/KPrAnimationEditNodeTypeCommand.h PRE-CREATION 
  stage/part/commands/KPrAnimationEditNodeTypeCommand.cpp PRE-CREATION 
  stage/part/commands/KPrAnimationRemoveCommand.h PRE-CREATION 
  stage/part/commands/KPrAnimationRemoveCommand.cpp PRE-CREATION 
  stage/part/commands/KPrEditAnimationTimeLineCommand.h PRE-CREATION 
  stage/part/commands/KPrEditAnimationTimeLineCommand.cpp PRE-CREATION 
  stage/part/commands/KPrReorderAnimationCommand.h PRE-CREATION 
  stage/part/commands/KPrReorderAnimationCommand.cpp PRE-CREATION 
  stage/part/commands/KPrReplaceAnimationCommand.h PRE-CREATION 
  stage/part/commands/KPrReplaceAnimationCommand.cpp PRE-CREATION 
  stage/part/tests/CMakeLists.txt bac9354b91bafcd38303267ad5759749b38b9c2c 
  stage/part/tests/MockShapeAnimation.h PRE-CREATION 
  stage/part/tests/PAMock.h d05c38920e074092d4ab47f8f5dc66b7dda51a5b 
  stage/part/tests/TestShapeAnimations.h 
045bc2e9f20d9fce69cc1deb2f8fd462e47f64ea 
  stage/part/tests/TestShapeAnimations.cpp 
b077a550417f3b4f3dd17105b29d455992d67c56 
  stage/part/tests/modeltest.h PRE-CREATION 
  stage/part/tests/modeltest.cpp PRE-CREATION 
  stage/part/tools/animationtool/CMakeLists.txt 
5f5cb93f681ab9

Re: Review Request: Animation Tool Docker

2012-08-21 Thread Paul Mendez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106093/
---

(Updated Aug. 21, 2012, 3:17 p.m.)


Review request for Calligra.


Changes
---

Correct some mistakes regarding the use of koIcon as pointed Friedrich in his 
comments.


Description
---

GSoC work on Animation Tool Docker:
- List to display current animations, change order, duration and type of 
animation
  - Time line view for advanced edition of start time and duration
  - Live preview of animations
- Widget to add new animations
  - Automatic preview of animations (Can be disabled and Stage remembers your 
preference)
  - Alternative animation preview using hover buttons.
  - Automatic drawing of motion path icons using shape stored on xml description
  - Automatic loading of predefined animations from a xml file (I have added 
some predefined animations).
- Basic edition of motion path animations (Some predefined motion path 
animations have been added on the xml file).
- Refactor of KPrAnimateMotion class (class that loads and saves motion paths)
- Data model to store and edit animations of a document.
- Unit test for the animations data model.


Diffs (updated)
-

  libs/flake/tools/KoPathTool.h a4bcb5047cce5f817fb68d3ab35da38cca93cc54 
  libs/flake/tools/KoPathTool.cpp 8ad20a6eee4f02a00bd9d15509a777e4c3c8b000 
  libs/widgets/KoViewItemContextBar.h c8a7017ccabdcb09fd3a7edfdb6697a932e0974e 
  libs/widgets/KoViewItemContextBar.cpp 
163155605f690ed5c754bb04f78d53edb696 
  stage/part/CMakeLists.txt 77497a71bf60a703f996442e5a8795a62986f582 
  stage/part/KPrDocument.h a9c7c3b2414172218b268fb95c96d39dd1f1ec9e 
  stage/part/KPrDocument.cpp de18a8f080c76aeebeaad557c00b3f1d9ab062ed 
  stage/part/KPrEndOfSlideShowPage.cpp 78907aa1a379f336f3c68ea0690d0c8741219bfd 
  stage/part/KPrMasterPage.h 29190e33d910f1c2dd339d39c585cbfba6fb9b5c 
  stage/part/KPrMasterPage.cpp d75b6af8a17dcf2e594c6f3597ab805a63fe77cf 
  stage/part/KPrPage.cpp ad4af851ae2a1eb8d7681a80f4336c9e43856a0b 
  stage/part/KPrPageData.h 88ee96680c165da54f8d7c270a1dc4961ffdd5a7 
  stage/part/KPrPageData.cpp 970fb6e7e791bbffc4e49561e276ce5e86185b32 
  stage/part/KPrShapeAnimations.h 7558efa420be30ebf975945fcbdec3a1c72d1311 
  stage/part/KPrShapeAnimations.cpp b479ed79560e51e69d06adfe3b02ed50f600928e 
  stage/part/KPrShapeApplicationData.h ae8d685a61625625d8d2ff61b2986c05b918e855 
  stage/part/KPrShapeApplicationData.cpp 
691446d01381d4eff701d84ce4bf9dc12149cdce 
  stage/part/KPrViewModePreviewShapeAnimations.h PRE-CREATION 
  stage/part/KPrViewModePreviewShapeAnimations.cpp PRE-CREATION 
  stage/part/animations/KPrAnimateMotion.h 
29cdd3f0453e0e0d7e50025699f354357967d2c5 
  stage/part/animations/KPrAnimateMotion.cpp 
575cef1daa769e770b9f678f4cf9c7b424153f8a 
  stage/part/animations/KPrAnimationBase.h 
066974efdf11d0f13f37d0b4854d49bfb2079e5d 
  stage/part/animations/KPrAnimationBase.cpp 
57861e1c4af4fb9218b45f88a6c9dda0f5f0af80 
  stage/part/animations/KPrAnimationFactory.h 
b0e7a8db480e713a75427460c3bc1521d06f37a3 
  stage/part/animations/KPrAnimationLoader.cpp 
24cc17b01ac2c7a45edbb78c6adfaa31fac47abd 
  stage/part/animations/KPrAnimationStep.h 
26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64 
  stage/part/animations/KPrAnimationSubStep.h 
83cab65ab078675c380ccbf4b60dab99e83619f1 
  stage/part/animations/KPrShapeAnimation.h 
f5d9ac3b796e75f16970f80245e1fbb6673fe1b9 
  stage/part/animations/KPrShapeAnimation.cpp 
988cd14098d8ac1f9290b858540215d75d97f9f3 
  stage/part/animations/animations.xml PRE-CREATION 
  stage/part/commands/KPrAnimationCreateCommand.h 
831317e9a386e7da4100d27dfbf5aab5b382b28d 
  stage/part/commands/KPrAnimationCreateCommand.cpp 
3c06155bbb6afd6668bef6998bd1fd4c20534b8b 
  stage/part/commands/KPrAnimationEditNodeTypeCommand.h PRE-CREATION 
  stage/part/commands/KPrAnimationEditNodeTypeCommand.cpp PRE-CREATION 
  stage/part/commands/KPrAnimationRemoveCommand.h PRE-CREATION 
  stage/part/commands/KPrAnimationRemoveCommand.cpp PRE-CREATION 
  stage/part/commands/KPrEditAnimationTimeLineCommand.h PRE-CREATION 
  stage/part/commands/KPrEditAnimationTimeLineCommand.cpp PRE-CREATION 
  stage/part/commands/KPrReorderAnimationCommand.h PRE-CREATION 
  stage/part/commands/KPrReorderAnimationCommand.cpp PRE-CREATION 
  stage/part/commands/KPrReplaceAnimationCommand.h PRE-CREATION 
  stage/part/commands/KPrReplaceAnimationCommand.cpp PRE-CREATION 
  stage/part/tests/CMakeLists.txt bac9354b91bafcd38303267ad5759749b38b9c2c 
  stage/part/tests/MockShapeAnimation.h PRE-CREATION 
  stage/part/tests/PAMock.h d05c38920e074092d4ab47f8f5dc66b7dda51a5b 
  stage/part/tests/TestShapeAnimations.h 
045bc2e9f20d9fce69cc1deb2f8fd462e47f64ea 
  stage/part/tests/TestShapeAnimations.cpp 
b077a550417f3b4f3dd17105b29d455992d67c56 
  stage/part/tests/modeltest.h PRE-CREATION 
  stage/part/tests/modeltest.cpp PRE-CREATION 
  stage/part/t

Review Request: Better support for hatch background

2012-08-21 Thread Thorsten Zachmann


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106115/
---

Review request for Calligra and Jan Hambrecht.


Description
---

Implement correct support for hatch background as defined in odf. With this 
patch the different styles, freely defined angles and distance between the 
lines of the hatch is supported.

This patch also changes the KoColorBackground to also use the d pointer of the 
parent which reduces the memory needed for a KoColorBackground.


This addresses bugs 260534 and 298708.
http://bugs.kde.org/show_bug.cgi?id=260534
http://bugs.kde.org/show_bug.cgi?id=298708


Diffs
-

  libs/flake/CMakeLists.txt 15b6e6c 
  libs/flake/KoColorBackground.h 88b61bd 
  libs/flake/KoColorBackground.cpp 66d7ffc 
  libs/flake/KoColorBackground_p.h PRE-CREATION 
  libs/flake/KoHatchBackground.h PRE-CREATION 
  libs/flake/KoHatchBackground.cpp PRE-CREATION 
  libs/flake/KoShape.cpp 3a32e9f 

Diff: http://git.reviewboard.kde.org/r/106115/diff/


Testing
---

Tested with cstester and the documents of the bug reports.


Thanks,

Thorsten Zachmann

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

calligrawords crashes when building from current git

2012-08-21 Thread Michael Giesler

Hi, 

I just built the calligra suite as described in 
http://community.kde.org/Calligra/Building/Building_Calligra from up-to-date 
git. I still could select a template but the application crashed when clicking 
"use this template" ("Diese Vorlage verwenden" in German).

Well, is it a current problem in git? How can I find out if this is a problem 
with my own build configuration? Dr. Konqui says the collected crash info 
would be very useful, but I somehow hesitate to file a bug in this case (self 
built, not very familiar with kde compiling).

Thank you for your opinion on this!

Best regards
Michael - attracted by the author announcement, aiming to improve his Qt 
skills in this OS project...___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: calligrawords crashes when building from current git

2012-08-21 Thread C. Boemann

On Tuesday 21 August 2012 20:38:16 Michael Giesler wrote:
> Hi,
> 
> I just built the calligra suite as described in
> http://community.kde.org/Calligra/Building/Building_Calligra from
> up-to-date git. I still could select a template but the application
> crashed when clicking "use this template" ("Diese Vorlage verwenden" in
> German).
> 
> Well, is it a current problem in git? How can I find out if this is a
> problem with my own build configuration? Dr. Konqui says the collected
> crash info would be very useful, but I somehow hesitate to file a bug in
> this case (self built, not very familiar with kde compiling).
> 
> Thank you for your opinion on this!
> 
> Best regards
> Michael - attracted by the author announcement, aiming to improve his Qt
> skills in this OS project...
hi could you mail me the crash info to me? then i can better tell
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: calligrawords crashes when building from current git

2012-08-21 Thread Boudewijn Rempt

On Tuesday 21 August 2012 Aug, Michael Giesler wrote:
> Hi, 
> 
> I just built the calligra suite as described in 
> http://community.kde.org/Calligra/Building/Building_Calligra from up-to-date 
> git. I still could select a template but the application crashed when 
> clicking 
> "use this template" ("Diese Vorlage verwenden" in German).
> 
> Well, is it a current problem in git? How can I find out if this is a problem 
> with my own build configuration? Dr. Konqui says the collected crash info 
> would be very useful, but I somehow hesitate to file a bug in this case (self 
> built, not very familiar with kde compiling).
> 
> Thank you for your opinion on this!
> 
> Best regards
> Michael - attracted by the author announcement, aiming to improve his Qt 
> skills in this OS project...

One commn problem is having calligra from git and a distributions version of 
calligra installed at the same time, so that;s worth checking first.


-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Re: calligrawords crashes when building from current git

2012-08-21 Thread Michael Giesler

Am Dienstag, 21. August 2012, 20:43:54 schrieb C. Boemann:
> On Tuesday 21 August 2012 20:38:16 Michael Giesler wrote:
> > Hi,
> > 
> > I just built the calligra suite as described in
> > http://community.kde.org/Calligra/Building/Building_Calligra from
> > up-to-date git. I still could select a template but the application
> > crashed when clicking "use this template" ("Diese Vorlage verwenden" in
> > German).
> > 
> > Well, is it a current problem in git? How can I find out if this is a
> > problem with my own build configuration? Dr. Konqui says the collected
> > crash info would be very useful, but I somehow hesitate to file a bug in
> > this case (self built, not very familiar with kde compiling).
> > 
> > Thank you for your opinion on this!
> > 
> > Best regards
> > Michael - attracted by the author announcement, aiming to improve his Qt
> > skills in this OS project...
> 
> hi could you mail me the crash info to me? then i can better tell

Yes, of course: http://pastebin.com/v0EXbeJP
It's not just words, but also several other applications: sheets, author, ...

thanks for the quick response.___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[solved] Re: Re: calligrawords crashes when building from current git

2012-08-21 Thread Michael Giesler

Am Dienstag, 21. August 2012, 20:45:30 schrieb Boudewijn Rempt:
> On Tuesday 21 August 2012 Aug, Michael Giesler wrote:
> > Hi,
> > 
> > I just built the calligra suite as described in
> > http://community.kde.org/Calligra/Building/Building_Calligra from
> > up-to-date git. I still could select a template but the application
> > crashed when clicking "use this template" ("Diese Vorlage verwenden" in
> > German).
> > 
> > Well, is it a current problem in git? How can I find out if this is a
> > problem with my own build configuration? Dr. Konqui says the collected
> > crash info would be very useful, but I somehow hesitate to file a bug in
> > this case (self built, not very familiar with kde compiling).
> > 
> > Thank you for your opinion on this!
> > 
> > Best regards
> > Michael - attracted by the author announcement, aiming to improve his Qt
> > skills in this OS project...
> 
> One commn problem is having calligra from git and a distributions version of
> calligra installed at the same time, so that;s worth checking first.

Thank you very much! I still had installed the calligra base package of 
OpenSuse, removed it, added my new share directory to XDG_DATA_DIRS (don't 
know if really needed), run kbuildsycoca4 and now it works!___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: calligrawords crashes when building from current git

2012-08-21 Thread C. Boemann

On Tuesday 21 August 2012 20:46:28 Michael Giesler wrote:
> Am Dienstag, 21. August 2012, 20:43:54 schrieb C. Boemann:
> > On Tuesday 21 August 2012 20:38:16 Michael Giesler wrote:
> > > Hi,
> > > 
> > > I just built the calligra suite as described in
> > > http://community.kde.org/Calligra/Building/Building_Calligra from
> > > up-to-date git. I still could select a template but the application
> > > crashed when clicking "use this template" ("Diese Vorlage verwenden" in
> > > German).
> > > 
> > > Well, is it a current problem in git? How can I find out if this is a
> > > problem with my own build configuration? Dr. Konqui says the collected
> > > crash info would be very useful, but I somehow hesitate to file a bug
> > > in this case (self built, not very familiar with kde compiling).
> > > 
> > > Thank you for your opinion on this!
> > > 
> > > Best regards
> > > Michael - attracted by the author announcement, aiming to improve his
> > > Qt skills in this OS project...
> > 
> > hi could you mail me the crash info to me? then i can better tell
> 
> Yes, of course: http://pastebin.com/v0EXbeJP
> It's not just words, but also several other applications: sheets, author,
> ...
> 
> thanks for the quick response.
hmm treeshape being involved in the crash does sound like you have some old 
installation that messes up for you

so it's indeed a local issue for you

try and clean all you old installation
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Better support for hatch background

2012-08-21 Thread Friedrich W. H. Kossebau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106115/#review17814
---


Quick first review...


libs/flake/KoColorBackground_p.h


Perhaps could be done with member initialization list, like also done in 
KoHatchBackgroundPrivate, to save a few cycles.



libs/flake/KoHatchBackground.cpp


Perhaps QVector::reserve(int) could be used for a minimal improvement, both 
here and above.



libs/flake/KoHatchBackground.cpp


Misses to deal with any units deg, grad, rad, no?



libs/flake/KoHatchBackground.cpp


Any reason? Compatibility with LO/AOO?


- Friedrich W. H. Kossebau


On Aug. 21, 2012, 6:07 p.m., Thorsten Zachmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106115/
> ---
> 
> (Updated Aug. 21, 2012, 6:07 p.m.)
> 
> 
> Review request for Calligra and Jan Hambrecht.
> 
> 
> Description
> ---
> 
> Implement correct support for hatch background as defined in odf. With this 
> patch the different styles, freely defined angles and distance between the 
> lines of the hatch is supported.
> 
> This patch also changes the KoColorBackground to also use the d pointer of 
> the parent which reduces the memory needed for a KoColorBackground.
> 
> 
> This addresses bugs 260534 and 298708.
> http://bugs.kde.org/show_bug.cgi?id=260534
> http://bugs.kde.org/show_bug.cgi?id=298708
> 
> 
> Diffs
> -
> 
>   libs/flake/CMakeLists.txt 15b6e6c 
>   libs/flake/KoColorBackground.h 88b61bd 
>   libs/flake/KoColorBackground.cpp 66d7ffc 
>   libs/flake/KoColorBackground_p.h PRE-CREATION 
>   libs/flake/KoHatchBackground.h PRE-CREATION 
>   libs/flake/KoHatchBackground.cpp PRE-CREATION 
>   libs/flake/KoShape.cpp 3a32e9f 
> 
> Diff: http://git.reviewboard.kde.org/r/106115/diff/
> 
> 
> Testing
> ---
> 
> Tested with cstester and the documents of the bug reports.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [solved] Re: Re: calligrawords crashes when building from current git

2012-08-21 Thread Boudewijn Rempt

On Tuesday 21 August 2012 Aug, Michael Giesler wrote:

> Thank you very much! I still had installed the calligra base package of 
> OpenSuse, removed it, added my new share directory to XDG_DATA_DIRS (don't 
> know if really needed), run kbuildsycoca4 and now it works!

Great! Have fun :-)

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

Re: Review Request: rename "import" action to "open as new"

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

Re: Review Request: Animation Tool Docker

Re: Review Request: Animation Tool Docker

Re: Review Request: Animation Tool Docker

Review Request: Better support for hatch background

calligrawords crashes when building from current git

Re: calligrawords crashes when building from current git

Re: calligrawords crashes when building from current git

Re: Re: calligrawords crashes when building from current git

[solved] Re: Re: calligrawords crashes when building from current git

Re: calligrawords crashes when building from current git

Re: Review Request: Better support for hatch background

Re: [solved] Re: Re: calligrawords crashes when building from current git

15 matches

Site Navigation

Mail list logo

Footer information