Re: Review Request: Make Author information configurable on a settings level

[C. Boemann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104843/
---

(Updated May 6, 2012, 12:32 p.m.)


Review request for Calligra.


Changes
---

Improved it so the user now can define any number of author profiles. Say the 
user wants to sometimes write/paint for a company and sometimes on a private 
basis. There are also predefined options for anonymous editing, and a default 
profilethat picks the name from KUser.

Read the review descriptio for the details


Description (updated)
---

   Make author information configurable on a settings level.

The Document Information dialog's Author tab becomes read only and just 
shows who
last saved the document.

The author information is shared across all calligra apps, and can hold any 
number of
author profiles. The user creates and deletes author profiles through the 
settings dialog.

The profiles are stored in the calligra wide config.

In the settings menu a submenu should be added where you can choose the 
active profile.

The active profile is stored in the application's config.

BUG:260469
BUG:260478
It also solves the bug (no number) that save cycles number was never 
incremented


Diffs (updated)
-

  filters/karbon/xfig/XFigOdgWriter.cpp 299378f 
  filters/stage/kpr2odf/Filterkpr2odf.cpp b0b4858 
  flow/part/flow.rc d574de5 
  karbon/data/karbon.rc 92a8ebd 
  karbon/ui/dialogs/KarbonConfigureDialog.h 9a591d7 
  karbon/ui/dialogs/KarbonConfigureDialog.cpp b7a45b1 
  krita/krita.rc 86b65fe 
  krita/ui/dialogs/kis_dlg_preferences.cc 8cbcddf 
  libs/kopageapp/dialogs/KoPAConfigureDialog.h 0cd71f5 
  libs/kopageapp/dialogs/KoPAConfigureDialog.cpp b7f577c 
  libs/main/CMakeLists.txt 2eb3681 
  libs/main/KoDocumentInfo.h 5fe8e21 
  libs/main/KoDocumentInfo.cpp dff3255 
  libs/main/KoDocumentInfoDlg.h cf619a2 
  libs/main/KoDocumentInfoDlg.cpp 4073a8c 
  libs/main/KoView.h 5f22ba5 
  libs/main/KoView.cpp 4de2298 
  libs/main/calligra_shell.rc 6227580 
  libs/main/config/KoConfigAuthorPage.h PRE-CREATION 
  libs/main/config/KoConfigAuthorPage.cpp PRE-CREATION 
  libs/main/config/KoConfigAuthorPage.ui PRE-CREATION 
  libs/main/koDocumentInfoAuthorWidget.ui c9137b2 
  sheets/part/dialogs/PreferenceDialog.cpp 2bf53c4 
  sheets/sheets.rc c002193 
  stage/stage.rc cc513eb 
  words/part/KWView.cpp 53f7da5 
  words/part/words.rc c7a5f90 

Diff: http://git.reviewboard.kde.org/r/104843/diff/


Testing (updated)
---

tried loading and saving, checking the information inbetween, and also checking 
the cycle numbers increasing correctly on each save.

Only thing not working is active profile being updated across views or if the 
available profiles is changed the menu item to select active profile is not 
updated to reflect the ist of possible profiles until the app is restarted

tested that if the active profile has been deleted it will default to save 
using the default profile


Thanks,

C. Boemann

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Please update http://kde.org/applications/office/

[Burkhard Lück]

Hi,

the Office page on kde.org has KSpread, KWord, KPlato, Kivio, Kexi, KPresenter, 
no Calligra Sheets, Words, Stage etc.

KSpread, KWord, KPlato, Kivio, Kexi, KPresenter development pages have wrong 
links to http://websvn.kde.org/trunk/koffice/ and more wrong infos.

Broken or dead handbook links to docs.kde.org are fixed by me, but I did not 
touch the other outdated infos.

Pages are generated from *json in trunk/www/sites/www/applications/apps/

Thanks.

-- 
Burkhard Lück
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

[Thorsten Zachmann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104813/#review13511
---

Ship it!


Ship It!

- Thorsten Zachmann


On May 5, 2012, 6:39 a.m., Gopalakrishna Bhat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104813/
> ---
> 
> (Updated May 5, 2012, 6:39 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> We used to ignore the vertical and horizontal alignment for Enhanced path 
> shape. This patch fixes that issue.
> 
> 
> This addresses bugs 284260 and 288047.
> http://bugs.kde.org/show_bug.cgi?id=284260
> http://bugs.kde.org/show_bug.cgi?id=288047
> 
> 
> Diffs
> -
> 
>   libs/flake/KoPathShape.cpp 83eb24f 
>   libs/flake/KoTosContainer.h 93d7493 
>   libs/flake/KoTosContainer.cpp e6a3539 
>   libs/flake/KoTosContainer_p.h 48fff5d 
>   plugins/pictureshape/PictureShape.cpp e7fcd39 
> 
> Diff: http://git.reviewboard.kde.org/r/104813/diff/
> 
> 
> Testing
> ---
> 
> Loaded the document in the bug report and checked
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104813/#review13514
---


This review has been submitted with commit 
26092c58f9e3d7180048286af9c6186b2e1fdbae by Gopalakrishna Bhat A to branch 
master.

- Commit Hook


On May 5, 2012, 6:39 a.m., Gopalakrishna Bhat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104813/
> ---
> 
> (Updated May 5, 2012, 6:39 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> We used to ignore the vertical and horizontal alignment for Enhanced path 
> shape. This patch fixes that issue.
> 
> 
> This addresses bugs 284260 and 288047.
> http://bugs.kde.org/show_bug.cgi?id=284260
> http://bugs.kde.org/show_bug.cgi?id=288047
> 
> 
> Diffs
> -
> 
>   libs/flake/KoPathShape.cpp 83eb24f 
>   libs/flake/KoTosContainer.h 93d7493 
>   libs/flake/KoTosContainer.cpp e6a3539 
>   libs/flake/KoTosContainer_p.h 48fff5d 
>   plugins/pictureshape/PictureShape.cpp e7fcd39 
> 
> Diff: http://git.reviewboard.kde.org/r/104813/diff/
> 
> 
> Testing
> ---
> 
> Loaded the document in the bug report and checked
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Load and save contour-polygon, and wrapping around it in Words

[C. Boemann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104873/
---

Review request for Calligra.


Description
---

Load and save the contour-polygon and contour-path elements.
They are stored as KoClipPath in the engine. Previously the engine only
had support for loading and saving KoClipPath in svg

Load and save the style frame style attributes that turn contoured text run 
around
(wrapping) on and off. wrap-contour and wrap-contour-mode

Use this new technology to do tight run around (simple change only requesting 
what we already had)

This commit also adds a method to pictureshape to create a tightfitting outline 
path of the image.
It's tested and works, but is not used yet to create a KoClipPath out of it.


Diffs
-

  libs/flake/KoPathShape.h d6e7cf1 
  libs/flake/KoPathShape.cpp 1196a0b 
  libs/flake/KoShape.h 3b2ee21 
  libs/flake/KoShape.cpp 40c2be2 
  libs/flake/KoShape_p.h a8ef367 
  libs/textlayout/KoTextLayoutObstruction.cpp 9711578 
  plugins/pictureshape/PictureShape.h 54cc813 
  plugins/pictureshape/PictureShape.cpp e7fcd39 

Diff: http://git.reviewboard.kde.org/r/104873/diff/


Testing
---

I've created such contour clipping in LO

loaded and seen it work in Words, and saved it back to LO where it works 
(though we need to work around a bug in LO, workaround is there but not enabled 
in this diff)

For the unused method in the pictre shape I had hardwired it during 
development. I will put up a new review when I actually use the method so you 
may ignore it for now.


Thanks,

C. Boemann

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Load and save contour-polygon, and wrapping around it in Words

[C. Boemann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104873/
---

(Updated May 6, 2012, 5:35 p.m.)


Review request for Calligra.


Description
---

Load and save the contour-polygon and contour-path elements.
They are stored as KoClipPath in the engine. Previously the engine only
had support for loading and saving KoClipPath in svg

Load and save the style frame style attributes that turn contoured text run 
around
(wrapping) on and off. wrap-contour and wrap-contour-mode

Use this new technology to do tight run around (simple change only requesting 
what we already had)

This commit also adds a method to pictureshape to create a tightfitting outline 
path of the image.
It's tested and works, but is not used yet to create a KoClipPath out of it.


Diffs
-

  libs/flake/KoPathShape.h d6e7cf1 
  libs/flake/KoPathShape.cpp 1196a0b 
  libs/flake/KoShape.h 3b2ee21 
  libs/flake/KoShape.cpp 40c2be2 
  libs/flake/KoShape_p.h a8ef367 
  libs/textlayout/KoTextLayoutObstruction.cpp 9711578 
  plugins/pictureshape/PictureShape.h 54cc813 
  plugins/pictureshape/PictureShape.cpp e7fcd39 

Diff: http://git.reviewboard.kde.org/r/104873/diff/


Testing
---

I've created such contour clipping in LO

loaded and seen it work in Words, and saved it back to LO where it works 
(though we need to work around a bug in LO, workaround is there but not enabled 
in this diff)

For the unused method in the pictre shape I had hardwired it during 
development. I will put up a new review when I actually use the method so you 
may ignore it for now.


Thanks,

C. Boemann

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Make Author information configurable on a settings level

[C. Boemann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104843/#review13517
---

Ship it!


boud was happy enough, and i fixed the few issues he found

- C. Boemann


On May 6, 2012, 12:32 p.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104843/
> ---
> 
> (Updated May 6, 2012, 12:32 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
>Make author information configurable on a settings level.
> 
> The Document Information dialog's Author tab becomes read only and just 
> shows who
> last saved the document.
> 
> The author information is shared across all calligra apps, and can hold 
> any number of
> author profiles. The user creates and deletes author profiles through the 
> settings dialog.
> 
> The profiles are stored in the calligra wide config.
> 
> In the settings menu a submenu should be added where you can choose the 
> active profile.
> 
> The active profile is stored in the application's config.
> 
> BUG:260469
> BUG:260478
> It also solves the bug (no number) that save cycles number was never 
> incremented
> 
> 
> Diffs
> -
> 
>   filters/karbon/xfig/XFigOdgWriter.cpp 299378f 
>   filters/stage/kpr2odf/Filterkpr2odf.cpp b0b4858 
>   flow/part/flow.rc d574de5 
>   karbon/data/karbon.rc 92a8ebd 
>   karbon/ui/dialogs/KarbonConfigureDialog.h 9a591d7 
>   karbon/ui/dialogs/KarbonConfigureDialog.cpp b7a45b1 
>   krita/krita.rc 86b65fe 
>   krita/ui/dialogs/kis_dlg_preferences.cc 8cbcddf 
>   libs/kopageapp/dialogs/KoPAConfigureDialog.h 0cd71f5 
>   libs/kopageapp/dialogs/KoPAConfigureDialog.cpp b7f577c 
>   libs/main/CMakeLists.txt 2eb3681 
>   libs/main/KoDocumentInfo.h 5fe8e21 
>   libs/main/KoDocumentInfo.cpp dff3255 
>   libs/main/KoDocumentInfoDlg.h cf619a2 
>   libs/main/KoDocumentInfoDlg.cpp 4073a8c 
>   libs/main/KoView.h 5f22ba5 
>   libs/main/KoView.cpp 4de2298 
>   libs/main/calligra_shell.rc 6227580 
>   libs/main/config/KoConfigAuthorPage.h PRE-CREATION 
>   libs/main/config/KoConfigAuthorPage.cpp PRE-CREATION 
>   libs/main/config/KoConfigAuthorPage.ui PRE-CREATION 
>   libs/main/koDocumentInfoAuthorWidget.ui c9137b2 
>   sheets/part/dialogs/PreferenceDialog.cpp 2bf53c4 
>   sheets/sheets.rc c002193 
>   stage/stage.rc cc513eb 
>   words/part/KWView.cpp 53f7da5 
>   words/part/words.rc c7a5f90 
> 
> Diff: http://git.reviewboard.kde.org/r/104843/diff/
> 
> 
> Testing
> ---
> 
> tried loading and saving, checking the information inbetween, and also 
> checking the cycle numbers increasing correctly on each save.
> 
> Only thing not working is active profile being updated across views or if the 
> available profiles is changed the menu item to select active profile is not 
> updated to reflect the ist of possible profiles until the app is restarted
> 
> tested that if the active profile has been deleted it will default to save 
> using the default profile
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: KexiDB: fix crashes when saving query design

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104833/#review13519
---


This review has been submitted with commit 
0fefd8dbbe333000ab27dcf91c345863a39751d9 by Jaroslaw Staniek to branch master.

- Commit Hook


On May 2, 2012, 10:18 p.m., Jarosław Staniek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104833/
> ---
> 
> (Updated May 2, 2012, 10:18 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> KexiDB: fix crashed when saving query design
> 
> *put DESC/ASC after COLLATE section, not before (needed at least for sqlite 
> driver)
> *fixed crash because of invalid deletion order of query structures
> *fixed crash because of invalid deletion relationship structures
> BUG:298197
> 
> 
> Diffs
> -
> 
>   kexi/doc/dev/CHANGELOG-Kexi-js 3ce83b19d9143f0d23dbe969f1345e296759f351 
>   kexi/kexidb/queryschema.cpp 4b325a7cec89eca5d0a8842f21041a07bd05c98f 
>   kexi/kexidb/relationship.h e6077c81e07d7d6e09311ae299cb6c5e3a918f72 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp 
> a38576ca0001a29117c081be7a1c45f23166929d 
> 
> Diff: http://git.reviewboard.kde.org/r/104833/diff/
> 
> 
> Testing
> ---
> 
> Test db works now
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Calligracommon bug week was a huge success

[C. Boemann]

Hi

Thank you all who contributed fixes.

The count was 192 bugs when I announced the sprint. The count is now an 
amazingly low 95 bugs.

Let's keep it like that, and preferably getting lower with every new release. 
So don't forget to take a look now and then.

Thanks
C. Boemann
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligracommon bug week was a huge success

[Boudewijn Rempt]

On Sunday 06 May 2012 May, C. Boemann wrote:
> Hi
> 
> Thank you all who contributed fixes.
> 
> The count was 192 bugs when I announced the sprint. The count is now an 
> amazingly low 95 bugs.
> 
> Let's keep it like that, and preferably getting lower with every new release. 
> So don't forget to take a look now and then.

Yay!

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: KexiDB: fix crashes when saving query design

[Jaroslaw Staniek]

Hi, answering via email below since RB returned server error when tried to
publich my post :)

On 4 May 2012 12:48, Adam Pigg  wrote:

>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104833/
>
> kexi/kexidb/relationship.h
>  (Diff
> revision 1)
>
> class IndexSchema;
>
>   81
>
> typedef KexiUtils::AutodeletedList List;
>
>  81
>
> typedef QList List;
>
>   is KexiAutoDeletedList unsafe?  Could it be removed?
>
>
KexiAutoDeletedList was convenient replacement for Qt3 containers with
autodelete option set on. But in this case cross-depemndencies between the
instances lead to double deletion, so normal list is needed. BTW,
autodeleted lists are gone in predicate (and in many cases structures are
implicitly/explicitly shared classes).



>
>
> kexi/plugins/queries/kexiquerydesignerguieditor.cpp
>  (Diff
> revision 1)
>
> void KexiQueryDesignerGuiEditor::showFieldsOrRelationsForQueryInternal(
>
>   949
>
> const KexiDB::OrderByColumnList 
> orderByColumns(query->orderByColumnList());
>
>  954
>
> KexiDB::OrderByColumnList& orderByColumns = query->orderByColumnList();
>
>   is there a problem with the copy constructor?
>
>
>
yes, we did not want to copy here.



-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Move plans odt export into libs/koreport.

[Jarosław Staniek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104797/#review13520
---



libs/koreport/renderer/KoReportRendererBase.cpp


Since it's a new code, I propose to get the habit of using 
QString::compare(..., ..., Qt::CaseInsensitive)



libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp


Is't 0.0pt enough?



libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp


isn't 0.0pt better?



libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp


how about using kWarning()? there are more such cases...



libs/koreport/renderer/odt/KoSimpleOdtLine.cpp


isn't 0.0pt better?



libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp


Let's keep such notes as @note in the header's doxygen comments for this 
method.



libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp


isn't 0.0pt better?



libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp


isn't 0.0pt better?


- Jarosław Staniek


On April 30, 2012, 4:31 p.m., Dag Andersen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104797/
> ---
> 
> (Updated April 30, 2012, 4:31 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> ---
> 
> Changes is in branch: report_odt_danders
> 
> Move plans odt export into libs/koreport.
> 
> Retains the current odt export in koreport (as odttables) and
> adds the new as odtframes.
> 
> Patch includes modifications to Plan to enable use of both formats.
> 
> 
> Diffs
> -
> 
>   libs/koreport/CMakeLists.txt d0737c9 
>   libs/koreport/renderer/KoReportODTRenderer2.h PRE-CREATION 
>   libs/koreport/renderer/KoReportODTRenderer2.cpp PRE-CREATION 
>   libs/koreport/renderer/KoReportRendererBase.cpp 497177d 
>   libs/koreport/renderer/odt/KoSimpleOdtCheckBox.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtDocument.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtImage.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtImage.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtLine.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtLine.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPicture.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPicture.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPrimitive.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtTextBox.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtTextBox.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/ReportODTRenderer.h PRE-CREATION 
>   plan/libs/ui/CMakeLists.txt 4948bd3 
>   plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.h 94123e2 
>   plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.cpp 9a94f5b 
>   plan/libs/ui/reports/odt/KoSimpleOdtDocument.h 65bbbee 
>   plan/libs/ui/reports/odt/KoSimpleOdtDocument.cpp 7d917ef 
>   plan/libs/ui/reports/odt/KoSimpleOdtImage.h 3c40922 
>   plan/libs/ui/reports/odt/KoSimpleOdtImage.cpp 1061664 
>   plan/libs/ui/reports/odt/KoSimpleOdtLine.h 6ea097b 
>   plan/libs/ui/reports/odt/KoSimpleOdtLine.cpp 2347117 
>   plan/libs/ui/reports/odt/KoSimpleOdtPicture.h 10c3b85 
>   plan/libs/ui/reports/odt/KoSimpleOdtPicture.cpp e0df27f 
>   plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.h 7cff1c7 
>   plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.cpp ddea498 
>   plan/libs/ui/reports/odt/KoSimpleOdtTextBox.h 428dff7 
>   plan/libs/ui/reports/odt/KoSimpleOdtTextBox.cpp d775689 
>   plan/libs/ui/reports/odt/ReportODTRenderer.h 3c9f149 
>   plan/libs/ui/reports/odt/ReportODTRenderer.cpp 2c95ed2 
>   plan/libs/ui/reports/report.h 8cef5be 
>   plan/libs/ui/reports/reportexportpanel.cpp 973078d 
>   plan/libs/ui/reports/reportview.h 265080a 
>   plan/libs/ui/reports/reportview.cpp dea21a6 
> 
> Diff: http://git.reviewboard.kde.org/r/104797/diff/
> 
> 
> Testing
> ---
> 
> Tested with Plan, resulting files opened with Words.
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

[Gopalakrishna Bhat]

Should this be backported to calligra/2.4?

On 5/6/12, Commit Hook  wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104813/#review13514
> ---
>
>
> This review has been submitted with commit
> 26092c58f9e3d7180048286af9c6186b2e1fdbae by Gopalakrishna Bhat A to branch
> master.
>
> - Commit Hook
>
>
> On May 5, 2012, 6:39 a.m., Gopalakrishna Bhat wrote:
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/104813/
>> ---
>>
>> (Updated May 5, 2012, 6:39 a.m.)
>>
>>
>> Review request for Calligra.
>>
>>
>> Description
>> ---
>>
>> We used to ignore the vertical and horizontal alignment for Enhanced path
>> shape. This patch fixes that issue.
>>
>>
>> This addresses bugs 284260 and 288047.
>> http://bugs.kde.org/show_bug.cgi?id=284260
>> http://bugs.kde.org/show_bug.cgi?id=288047
>>
>>
>> Diffs
>> -
>>
>>   libs/flake/KoPathShape.cpp 83eb24f
>>   libs/flake/KoTosContainer.h 93d7493
>>   libs/flake/KoTosContainer.cpp e6a3539
>>   libs/flake/KoTosContainer_p.h 48fff5d
>>   plugins/pictureshape/PictureShape.cpp e7fcd39
>>
>> Diff: http://git.reviewboard.kde.org/r/104813/diff/
>>
>>
>> Testing
>> ---
>>
>> Loaded the document in the bug report and checked
>>
>>
>> Thanks,
>>
>> Gopalakrishna Bhat
>>
>>
>
>


-- 
My blog http://gkbhat.blogspot.com
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra review by distrowatch - not ready for Ubuntu?

[Jaroslaw Staniek]

Update: I contacted the author and he was helpful in what he said: he
plans update for the review. This time stable Calligra 2.4.0 or later
will be reviewed; at least Kexi but maybe also other apps.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: KexiDB: fix crashes when saving query design

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104833/#review13524
---


This review has been submitted with commit 
85790700a0ab6cc15cea2dc9a09d23594f2f4ee4 by Jaroslaw Staniek to branch 
calligra/2.4.

- Commit Hook


On May 2, 2012, 10:18 p.m., Jarosław Staniek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104833/
> ---
> 
> (Updated May 2, 2012, 10:18 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> KexiDB: fix crashed when saving query design
> 
> *put DESC/ASC after COLLATE section, not before (needed at least for sqlite 
> driver)
> *fixed crash because of invalid deletion order of query structures
> *fixed crash because of invalid deletion relationship structures
> BUG:298197
> 
> 
> Diffs
> -
> 
>   kexi/doc/dev/CHANGELOG-Kexi-js 3ce83b19d9143f0d23dbe969f1345e296759f351 
>   kexi/kexidb/queryschema.cpp 4b325a7cec89eca5d0a8842f21041a07bd05c98f 
>   kexi/kexidb/relationship.h e6077c81e07d7d6e09311ae299cb6c5e3a918f72 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp 
> a38576ca0001a29117c081be7a1c45f23166929d 
> 
> Diff: http://git.reviewboard.kde.org/r/104833/diff/
> 
> 
> Testing
> ---
> 
> Test db works now
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Calligra code download page

[Jaroslaw Staniek]

Hi,
I am updating http://community.kde.org/Calligra/Building for info on
how to get the code.
Any idea why we (unlike other KDE apps) have all these calligra-x.y.z
dirs at download.kde.org instead of just calligra/ dir and files
inside?
E.g. http://download.kde.org/calligra-2.4.1/

(another story is that browsing download.kde.org is broken today,
gives 404 for dirs)

-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel