Re: Review Request: KexiDB: fix crashes when saving query design

[Adam Pigg]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104833/#review13411
---



kexi/kexidb/relationship.h


is KexiAutoDeletedList unsafe?  Could it be removed?



kexi/plugins/queries/kexiquerydesignerguieditor.cpp


is there a problem with the copy constructor?


- Adam Pigg


On May 2, 2012, 10:18 p.m., Jarosław Staniek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104833/
> ---
> 
> (Updated May 2, 2012, 10:18 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> ---
> 
> KexiDB: fix crashed when saving query design
> 
> *put DESC/ASC after COLLATE section, not before (needed at least for sqlite 
> driver)
> *fixed crash because of invalid deletion order of query structures
> *fixed crash because of invalid deletion relationship structures
> BUG:298197
> 
> 
> Diffs
> -
> 
>   kexi/doc/dev/CHANGELOG-Kexi-js 3ce83b19d9143f0d23dbe969f1345e296759f351 
>   kexi/kexidb/queryschema.cpp 4b325a7cec89eca5d0a8842f21041a07bd05c98f 
>   kexi/kexidb/relationship.h e6077c81e07d7d6e09311ae299cb6c5e3a918f72 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp 
> a38576ca0001a29117c081be7a1c45f23166929d 
> 
> Diff: http://git.reviewboard.kde.org/r/104833/diff/
> 
> 
> Testing
> ---
> 
> Test db works now
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

[Gopalakrishna Bhat]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104813/
---

(Updated May 4, 2012, 8:08 p.m.)


Review request for Calligra.


Changes
---

Incorporated the review comments and also fixed saving of the shape.


Description
---

We used to ignore the vertical and horizontal alignment for Enhanced path 
shape. This patch fixes that issue.


This addresses bug 284260.
http://bugs.kde.org/show_bug.cgi?id=284260


Diffs (updated)
-

  libs/flake/KoPathShape.cpp 4eb1881 
  libs/flake/KoTosContainer.h 93d7493 
  libs/flake/KoTosContainer.cpp e6a3539 
  libs/flake/KoTosContainer_p.h 48fff5d 

Diff: http://git.reviewboard.kde.org/r/104813/diff/


Testing
---

Loaded the document in the bug report and checked


Thanks,

Gopalakrishna Bhat

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: missing cursor after inserting ToC

[Smit Patel]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104862/
---

Review request for Calligra.


Description
---

Cursor was lost on left-right key events from keyboard and delete ToC didn't 
work after inserting table of contents.


Diffs
-

  libs/kotext/KoTextEditor.cpp 6fe0d0d 

Diff: http://git.reviewboard.kde.org/r/104862/diff/


Testing
---

After inserting ToC, cursor works fine on left-right keypress and delete ToC 
block also works fine.


Thanks,

Smit Patel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: missing cursor after inserting ToC

[Smit Patel]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104862/
---

(Updated May 4, 2012, 9:56 p.m.)


Review request for Calligra.


Description
---

Cursor was lost on left-right key events from keyboard and delete ToC didn't 
work after inserting table of contents.


Diffs
-

  libs/kotext/KoTextEditor.cpp 6fe0d0d 

Diff: http://git.reviewboard.kde.org/r/104862/diff/


Testing (updated)
---

After inserting ToC, cursor works fine on left-right keypress and delete ToC 
block also works fine. Same patch works fine for bibliography too.


Thanks,

Smit Patel

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: missing cursor after inserting ToC

[C. Boemann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104862/#review13444
---

Ship it!


nice and for bibliograhy too, if you think it's needed

- C. Boemann


On May 4, 2012, 9:56 p.m., Smit Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104862/
> ---
> 
> (Updated May 4, 2012, 9:56 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> Cursor was lost on left-right key events from keyboard and delete ToC didn't 
> work after inserting table of contents.
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoTextEditor.cpp 6fe0d0d 
> 
> Diff: http://git.reviewboard.kde.org/r/104862/diff/
> 
> 
> Testing
> ---
> 
> After inserting ToC, cursor works fine on left-right keypress and delete ToC 
> block also works fine. Same patch works fine for bibliography too.
> 
> 
> Thanks,
> 
> Smit Patel
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [KDE/Mac] Working kde apps on kde?

[Marijn Kruisselbrink]

I have no idea what is going on there, but I have seen similar errors/warnings 
when running calligra applications on Android. In that case it seems loading 
libwordsprivate.so is what triggers similar warnings (of course for different 
files, since obviously /mach_kernel doesn't exist on android; instead I get the 
warnings for various *.rc files that exist in /). I haven't manage to figure 
out 
yet what static initializers or similar are responsible for reading files they 
shouldn't be reading though.

Marijn

On Saturday, May 05, 2012 12:21:45 AM Joan wrote:
> Hi all,
> 
> I've been playing with brew trying to compile and use krita on mac, and
> after a few patches for some formulas (and some help of krita devs) I've
> been able to compile it properly.
> The problem is that I'm getting a ton of errors similar to this
> 
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 1: " Invalid entry (missing '=')
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 2: " Invalid entry (missing '=')
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 3: " Invalid entry (missing '=')
> 05/05/12 0:16:52,079 [0x0-0x70070].org.calligra.krita: "KConfigIni: In file
> /mach_kernel, line 4: " Invalid entry (missing '=')
> 
> Do you know of an application that has fixed this problems? Any application
> that works properly?
> 
> For the interested, the modified formulas are here pending to be
> accepted/rejected:
> https://github.com/Homebrew/homebrew-boneyard/pulls
> Also you need to follow the instructions on setting dbus daemon at
> http://community.kde.org/index.php?title=Mac&action=historysubmit&diff=1429
> 0&oldid=14088#Running_KDE_Applications
> 
> Also the calligra formula I am using at the moment is this
> https://github.com/aseques/homebrew/blob/calligra/Library/Formula/calligra.
> rb
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Text dragging in the textshapes

[C. Boemann]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104773/#review13447
---


Done. I'm going to commit around noon saturday if I hear no objections.

- C. Boemann


On April 29, 2012, 8:27 p.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104773/
> ---
> 
> (Updated April 29, 2012, 8:27 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> I've implemented so you can drag text around in the text shape. It uses drag 
> and drop so you can drag to and from other applications too
> 
> 
> Diffs
> -
> 
>   libs/flake/KoCanvasControllerWidgetViewport_p.cpp fab7c5c 
>   libs/flake/KoToolBase.h 0c0a9e4 
>   libs/flake/KoToolBase.cpp ae3482d 
>   libs/flake/KoToolProxy.h 8273980 
>   libs/flake/KoToolProxy.cpp 1e61e5c 
>   libs/kotext/KoTextDrag.h 9ad8560 
>   libs/kotext/KoTextDrag.cpp 5140785 
>   libs/kotext/KoTextEditor.h 616b320 
>   libs/kotext/KoTextEditor.cpp 60cff14 
>   libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 562b726 
>   plugins/textshape/TextTool.h 5b42bb6 
>   plugins/textshape/TextTool.cpp 4078e72 
> 
> Diff: http://git.reviewboard.kde.org/r/104773/diff/
> 
> 
> Testing
> ---
> 
> Tried it as best I could to and from kate and internally in Words.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

[Gopalakrishna Bhat]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104813/
---

(Updated May 5, 2012, 3:24 a.m.)


Review request for Calligra.


Changes
---

Added a bug number that this patch fixes


Description
---

We used to ignore the vertical and horizontal alignment for Enhanced path 
shape. This patch fixes that issue.


This addresses bugs 284260 and 288047.
http://bugs.kde.org/show_bug.cgi?id=284260
http://bugs.kde.org/show_bug.cgi?id=288047


Diffs
-

  libs/flake/KoPathShape.cpp 4eb1881 
  libs/flake/KoTosContainer.h 93d7493 
  libs/flake/KoTosContainer.cpp e6a3539 
  libs/flake/KoTosContainer_p.h 48fff5d 

Diff: http://git.reviewboard.kde.org/r/104813/diff/


Testing
---

Loaded the document in the bug report and checked


Thanks,

Gopalakrishna Bhat

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

[Gopalakrishna Bhat]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104813/
---

(Updated May 5, 2012, 6:39 a.m.)


Review request for Calligra.


Changes
---

Fixed the comments mentioned by Zagge on IRC. 
1) While saving, use the the alignment that is stored in the document instead 
of reading from the variable
2) Update the patch to affect the changes to all classes that derive from 
KoTosContainer i.e KoPathShape and PictureShape


Description
---

We used to ignore the vertical and horizontal alignment for Enhanced path 
shape. This patch fixes that issue.


This addresses bugs 284260 and 288047.
http://bugs.kde.org/show_bug.cgi?id=284260
http://bugs.kde.org/show_bug.cgi?id=288047


Diffs (updated)
-

  libs/flake/KoPathShape.cpp 83eb24f 
  libs/flake/KoTosContainer.h 93d7493 
  libs/flake/KoTosContainer.cpp e6a3539 
  libs/flake/KoTosContainer_p.h 48fff5d 
  plugins/pictureshape/PictureShape.cpp e7fcd39 

Diff: http://git.reviewboard.kde.org/r/104813/diff/


Testing
---

Loaded the document in the bug report and checked


Thanks,

Gopalakrishna Bhat

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel