change to product names in bugzilla
Hi I've changed all those calligra-product to calligraproduct in bugzilla so they match our application names. And calligra-karbon product is now just karbon This was needed as dr.konqi uses the application name to find the product This however means that you need to update any saved bugzilla queries you have to reflect the new product names sorry for the inconvenience ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: change to product names in bugzilla
You also need to grep for setProductName and make sure they are accurate (I only checked for words, and it is set to calligra-words), otherwise "Help -> report bugs" is broken. Ideally drkonqi would also use productName from KAboutData, but that might not be that easy... On Monday 31 October 2011, C. Boemann wrote: > Hi > > I've changed all those calligra-product to calligraproduct in bugzilla so > they match our application names. And calligra-karbon product is now just > karbon > > This was needed as dr.konqi uses the application name to find the product > > This however means that you need to update any saved bugzilla queries you > have to reflect the new product names > > sorry for the inconvenience > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel -- Cyrille Berger Skott ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: change to product names in bugzilla
On 10/31/2011 11:26 AM, Cyrille Berger Skott wrote: You also need to grep for setProductName and make sure they are accurate (I only checked for words, and it is set to calligra-words), otherwise "Help -> report bugs" is broken. Ideally drkonqi would also use productName from KAboutData, but that might not be that easy... Looks as DrKonqi has an own mapping-file (see my commit 345511b886f24 in kde-runtime/drkonqi). What would be ideal is to extend KCrash (kcrash.cpp in kdelibs/kdeui/util) to also pass on the KAboutData::productName to drkonqi. Then use that in drkonqi to fill the productName and remove those dirty mappings from drkonqi cause it's not needed to maintain an additional file for all KDE applications and there product-names inside drkonqi. On Monday 31 October 2011, C. Boemann wrote: Hi I've changed all those calligra-product to calligraproduct in bugzilla so they match our application names. And calligra-karbon product is now just karbon This was needed as dr.konqi uses the application name to find the product This however means that you need to update any saved bugzilla queries you have to reflect the new product names sorry for the inconvenience ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Fix crashing when using tools on empty image
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/ --- Review request for Calligra. Summary (updated) - Fix crashing when using tools on empty image Description (updated) --- When image is empty (has no layers), color picker & move tools caused crashes when using. This patch adds checking if currentNode() returns 0. If so, no action is done. Diffs (updated) - krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc 006aa78 krita/plugins/tools/defaulttools/kis_tool_move.cc 1ee0baa Diff: http://git.reviewboard.kde.org/r/103003/diff/diff Testing --- Thanks, Torio Mlshi ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Fix crashing when using tools on empty image
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/#review7782 --- Ship it! Thanks for the fix! =) Just two small things: 1) I think it would be logical to reset the stroke id right after endStroke(m_strokeId) in mouseReleaseEvent() function. Like: image->endStroke(m_strokeId); m_strokeId.clear(); 2) And we are using kde coding style for positioning braces around 'if's ;) [1] [1] - http://techbase.kde.org/Policies/Kdelibs_Coding_Style - Dmitry Kazakov On Oct. 31, 2011, 7:26 p.m., Torio Mlshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103003/ > --- > > (Updated Oct. 31, 2011, 7:26 p.m.) > > > Review request for Calligra. > > > Description > --- > > When image is empty (has no layers), color picker & move tools caused crashes > when using. This patch adds checking if currentNode() returns 0. If so, no > action is done. > > > Diffs > - > > krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc 006aa78 > krita/plugins/tools/defaulttools/kis_tool_move.cc 1ee0baa > > Diff: http://git.reviewboard.kde.org/r/103003/diff/diff > > > Testing > --- > > > Thanks, > > Torio Mlshi > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Fix crashing when using tools on empty image
> On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > Thanks for the fix! =) > > Just two small things: > > 1) I think it would be logical to reset the stroke id right after > > endStroke(m_strokeId) in mouseReleaseEvent() function. Like: > >image->endStroke(m_strokeId); > >m_strokeId.clear(); > > 2) And we are using kde coding style for positioning braces around 'if's ;) > > [1] > > > > > > [1] - http://techbase.kde.org/Policies/Kdelibs_Coding_Style Fixed & pushed. And thanks for the link: I was really confused about format rules as there are different pieces with different style (probably old code) =) - Torio --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103003/#review7782 --- On Oct. 31, 2011, 7:26 p.m., Torio Mlshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103003/ > --- > > (Updated Oct. 31, 2011, 7:26 p.m.) > > > Review request for Calligra. > > > Description > --- > > When image is empty (has no layers), color picker & move tools caused crashes > when using. This patch adds checking if currentNode() returns 0. If so, no > action is done. > > > Diffs > - > > krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc 006aa78 > krita/plugins/tools/defaulttools/kis_tool_move.cc 1ee0baa > > Diff: http://git.reviewboard.kde.org/r/103003/diff/diff > > > Testing > --- > > > Thanks, > > Torio Mlshi > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Fix saving of hyperlink formating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103008/ --- Review request for Calligra. Description --- When saving a hyperlink the format of the hyperlink is lost. This patch fixes the problem. Due to the code being very inderdepended on change tracking I'm posting the patch here to get feedback if I fixed the bug correctly. This addresses bug 285424. http://bugs.kde.org/show_bug.cgi?id=285424 Diffs - libs/kotext/opendocument/KoTextWriter_p.cpp 7b92403 Diff: http://git.reviewboard.kde.org/r/103008/diff/diff Testing --- Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Fix crashing when using tools on empty image
On Monday 31 October 2011 Oct, Torio Mlshi wrote: > > > On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote: > > > Thanks for the fix! =) > > > Just two small things: > > > 1) I think it would be logical to reset the stroke id right after > > > endStroke(m_strokeId) in mouseReleaseEvent() function. Like: > > >image->endStroke(m_strokeId); > > >m_strokeId.clear(); > > > 2) And we are using kde coding style for positioning braces around 'if's > > > ;) [1] > > > > > > > > > [1] - http://techbase.kde.org/Policies/Kdelibs_Coding_Style > > Fixed & pushed. And thanks for the link: I was really confused about format > rules as there are different pieces with different style (probably old code) > =) > Oh, yes, there's so much old code around... We try to make sure the new style is used in all new code, though. -- Boudewijn Rempt http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Show/Hide Tabs when project is opened/closed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102993/ --- (Updated Oct. 31, 2011, 10:40 p.m.) Review request for Calligra and Jarosław Staniek. Changes --- Corrected tabs order calculation algorithm. Now works when hiding/showing non sequential tabs. Description --- Show/Hide Tabs when project is opened/closed Diffs (updated) - kexi/main/KexiMainWindow.cpp f54e761 kexi/main/KexiMainWindow_p.h 32d45f5 Diff: http://git.reviewboard.kde.org/r/102993/diff/diff Testing --- compiled and run. Works OK. Thanks, Dimitrios Tanis ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
