problem with a unittest

2011-09-08 Thread Boudewijn Rempt 
When I run my TestKoBookmark unittest manually, it's fine. If I run it as part 
of make test, it segfaults after executing all tests succesfully. I tried 
running it under gdb and got this:



-- QDEBUG : TestKoBookmark::testRoundtrip() (Soprano::Redland::BackendPlugin) 
creating model of type "hashes" with options 
"hash-type='memory',contexts='yes'" 
QDEBUG : TestKoBookmark::testRoundtrip() qttest(32268)/kotext 
TextShapeFactory::newDocumentResourceManager: No KUndo2Stack found in the 
document resource manager, creating a new one 
QSYSTEM: TestKoBookmark::testRoundtrip() qttest(32268): Cannot open  
"/tmp/kde-boud/qttestRk2zYl/Europe/Berlin" 

QSYSTEM: TestKoBookmark::testRoundtrip() qttest(32268): Cannot open  
"/tmp/kde-boud/qttestRk2zYl/Europe/Berlin" 

PASS   : TestKoBookmark::testRoundtrip()
PASS   : TestKoBookmark::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
* Finished testing of TestKoBookmark *

Program received signal SIGSEGV, Segmentation fault.
0x in ?? ()
(gdb) bt
#0  0x in ?? ()
#1  0x724993b3 in QObject::~QObject (this=0x745d40, 
__in_chrg=) at kernel/qobject.cpp:861
#2  0x724999a9 in QObject::~QObject (this=0x745d40, 
__in_chrg=) at kernel/qobject.cpp:964
#3  0x71ec0940 in ~QDBusAbstractInterfacePrivate (this=0x755830, 
__in_chrg=) at qdbusabstractinterface_p.h:87
#4  QDBusAbstractInterfacePrivate::~QDBusAbstractInterfacePrivate 
(this=0x755830, __in_chrg=) at qdbusabstractinterface_p.h:87
#5  0x724997f3 in cleanup (pointer=) at 
../../src/corelib/tools/qscopedpointer.h:62
#6  ~QScopedPointer (this=0x6f4e88, __in_chrg=) at 
../../src/corelib/tools/qscopedpointer.h:100
#7  QObject::~QObject (this=0x6f4e80, __in_chrg=) at 
kernel/qobject.cpp:818
#8  0x71ea2bc9 in QDBusConnectionInterface::~QDBusConnectionInterface 
(this=0x6f4e80, __in_chrg=) at qdbusconnectioninterface.cpp:179
#9  0x72494a54 in QObjectPrivate::deleteChildren (this=0x745e40) at 
kernel/qobject.cpp:1955
#10 0x724997a2 in QObject::~QObject (this=0x745d40, 
__in_chrg=) at kernel/qobject.cpp:946
#11 0x71eaaabb in QDBusConnectionPrivate::~QDBusConnectionPrivate 
(this=0x745d40, __in_chrg=) at qdbusintegrator.cpp:998
#12 0x71eaadf9 in QDBusConnectionPrivate::~QDBusConnectionPrivate 
(this=0x745d40, __in_chrg=) at qdbusintegrator.cpp:1016
#13 0x71ea23b0 in ~QDBusDefaultConnection (this=0x71e600, 
__in_chrg=) at qdbusconnection.cpp:978
#14 QGlobalStaticDeleter::~QGlobalStaticDeleter 
(this=0x72101c38, __in_chrg=) at 
../../src/corelib/global/qglobal.h:1824
#15 0x713dd5a1 in __run_exit_handlers () from /lib64/libc.so.6
#16 0x713dd5f5 in exit () from /lib64/libc.so.6
#17 0x713c6c04 in __libc_start_main () from /lib64/libc.so.6
#18 0x004034f9 in _start () at ../sysdeps/x86_64/elf/start.S:113
(gdb) 


And now I'm puzzled... What's going on here? Does anyone have an idea?
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: problem with a unittest

2011-09-08 Thread Gopalakrishna Bhat 
I see this backtrace similar to your comment on

https://bugs.kde.org/show_bug.cgi?id=274868#c3

On Thu, Sep 8, 2011 at 1:14 PM, Boudewijn Rempt  wrote:

> When I run my TestKoBookmark unittest manually, it's fine. If I run it as
> part of make test, it segfaults after executing all tests succesfully. I
> tried running it under gdb and got this:
>
>
>
> -- QDEBUG : TestKoBookmark::testRoundtrip()
> (Soprano::Redland::BackendPlugin) creating model of type "hashes" with
> options "hash-type='memory',contexts='yes'"
> QDEBUG : TestKoBookmark::testRoundtrip() qttest(32268)/kotext
> TextShapeFactory::newDocumentResourceManager: No KUndo2Stack found in the
> document resource manager, creating a new one
> QSYSTEM: TestKoBookmark::testRoundtrip() qttest(32268): Cannot open
>  "/tmp/kde-boud/qttestRk2zYl/Europe/Berlin"
>
> QSYSTEM: TestKoBookmark::testRoundtrip() qttest(32268): Cannot open
>  "/tmp/kde-boud/qttestRk2zYl/Europe/Berlin"
>
> PASS   : TestKoBookmark::testRoundtrip()
> PASS   : TestKoBookmark::cleanupTestCase()
> Totals: 4 passed, 0 failed, 0 skipped
> * Finished testing of TestKoBookmark *
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x in ?? ()
> (gdb) bt
> #0  0x in ?? ()
> #1  0x724993b3 in QObject::~QObject (this=0x745d40,
> __in_chrg=) at kernel/qobject.cpp:861
> #2  0x724999a9 in QObject::~QObject (this=0x745d40,
> __in_chrg=) at kernel/qobject.cpp:964
> #3  0x71ec0940 in ~QDBusAbstractInterfacePrivate (this=0x755830,
> __in_chrg=) at qdbusabstractinterface_p.h:87
> #4  QDBusAbstractInterfacePrivate::~QDBusAbstractInterfacePrivate
> (this=0x755830, __in_chrg=) at qdbusabstractinterface_p.h:87
> #5  0x724997f3 in cleanup (pointer=) at
> ../../src/corelib/tools/qscopedpointer.h:62
> #6  ~QScopedPointer (this=0x6f4e88, __in_chrg=) at
> ../../src/corelib/tools/qscopedpointer.h:100
> #7  QObject::~QObject (this=0x6f4e80, __in_chrg=) at
> kernel/qobject.cpp:818
> #8  0x71ea2bc9 in
> QDBusConnectionInterface::~QDBusConnectionInterface (this=0x6f4e80,
> __in_chrg=) at qdbusconnectioninterface.cpp:179
> #9  0x72494a54 in QObjectPrivate::deleteChildren (this=0x745e40) at
> kernel/qobject.cpp:1955
> #10 0x724997a2 in QObject::~QObject (this=0x745d40,
> __in_chrg=) at kernel/qobject.cpp:946
> #11 0x71eaaabb in QDBusConnectionPrivate::~QDBusConnectionPrivate
> (this=0x745d40, __in_chrg=) at qdbusintegrator.cpp:998
> #12 0x71eaadf9 in QDBusConnectionPrivate::~QDBusConnectionPrivate
> (this=0x745d40, __in_chrg=) at qdbusintegrator.cpp:1016
> #13 0x71ea23b0 in ~QDBusDefaultConnection (this=0x71e600,
> __in_chrg=) at qdbusconnection.cpp:978
> #14 QGlobalStaticDeleter::~QGlobalStaticDeleter
> (this=0x72101c38, __in_chrg=) at
> ../../src/corelib/global/qglobal.h:1824
> #15 0x713dd5a1 in __run_exit_handlers () from /lib64/libc.so.6
> #16 0x713dd5f5 in exit () from /lib64/libc.so.6
> #17 0x713c6c04 in __libc_start_main () from /lib64/libc.so.6
> #18 0x004034f9 in _start () at ../sysdeps/x86_64/elf/start.S:113
> (gdb)
>
>
> And now I'm puzzled... What's going on here? Does anyone have an idea?
> Boudewijn Rempt
> http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
> ___
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>



-- 
My blog http://gkbhat.blogspot.com
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: problem with a unittest

2011-09-08 Thread Boudewijn Rempt 
On Thursday 08 September 2011 Sep, Gopalakrishna Bhat wrote:
> I see this backtrace similar to your comment on
> 
> https://bugs.kde.org/show_bug.cgi?id=274868#c3
> 

Hmm Right. Well, at least now we've got a unittest to reproduce the issue.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread Thorsten Zachmann 
On Saturday, September 03, 2011 10:04:36 Thorsten Zachmann wrote:
> Hello all,
> 
> I finally have set up the doodle for the 2. Calligra Sprint most likely
> sponsored by Nokia and held in Helsinki.
> 
> Please fill out the doodle at so we can start planning.
> 
> http://www.doodle.com/r5tb9kqaq8be3gnt
> 
> The earlier we can have the sprint the more likely it is there is no snow
> yet in Helsinki.

At the moment it looks like the weekend 11.11.-13.11.  For all who have not 
yet filled out the above doodle please do so. until the end of the week.

For everybody how might be able to join the sprint at 11.11. please go to 
https://sprints.kde.org and add yourself as participant and provide the 
estimated cost for the travel. Don't estimate any costs for hotel.

That is needed for me to see how big the estimated costs will be.
Don't do any booking yet as we first need the approval that the costs are 
covered before those are done. Don't estimate any costs for hotel. 

Thorsten
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: problem with a unittest

2011-09-08 Thread Cyrille Berger Skott 
On Thursday 08 September 2011, Boudewijn Rempt wrote:
> . I tried running it under gdb and got this:
And did you try with valgrind ?

-- 
Cyrille Berger Skott
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread Cyrille Berger Skott 
On Thursday 08 September 2011, Thorsten Zachmann wrote:
> For everybody how might be able to join the sprint at 11.11. please go to
> https://sprints.kde.org and add yourself as participant and provide the
> estimated cost for the travel. Don't estimate any costs for hotel.

I guess we need to be validated to appear on the list ? 

-- 
Cyrille Berger Skott
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: problem with a unittest

2011-09-08 Thread Boudewijn Rempt 
On Thursday 08 September 2011 Sep, Cyrille Berger Skott wrote:
> On Thursday 08 September 2011, Boudewijn Rempt wrote:
> > . I tried running it under gdb and got this:
> And did you try with valgrind ?

Yes -- and the output is quite weird:


boud@talnus:~/kde/build/calligra/words/part/tests> valgrind ./TestKoBookmark
==30852== Memcheck, a memory error detector
==30852== Copyright (C) 2002-2010, and GNU GPL'd, by Julian Seward et al.
==30852== Using Valgrind-3.6.1 and LibVEX; rerun with -h for copyright info
==30852== Command: ./TestKoBookmark
==30852== 
KGlobal::locale::Warning your global KLocale is being recreated with a valid 
main component instead of a fake component, this usually means you tried to 
call i18n related functions before your main component was created. You should 
not do that since it most likely will not work 
* Start testing of TestKoBookmark *
Config: Using QTest library 4.7.4, Qt 4.7.4
PASS   : TestKoBookmark::initTestCase()
PASS   : TestKoBookmark::testInsertion()
QDEBUG : TestKoBookmark::testRoundtrip() (Soprano::Redland::BackendPlugin) 
creating model of type "hashes" with options 
"hash-type='memory',contexts='yes'" 
QDEBUG : TestKoBookmark::testRoundtrip() qttest(30852)/kotext 
TextShapeFactory::newDocumentResourceManager: No KUndo2Stack found in the 
document resource manager, creating a new one 
QDEBUG : TestKoBookmark::testRoundtrip() (Soprano::Redland::BackendPlugin) 
creating model of type "hashes" with options 
"hash-type='memory',contexts='yes'" 
QDEBUG : TestKoBookmark::testRoundtrip() qttest(30852)/kotext 
TextShapeFactory::newDocumentResourceManager: No KUndo2Stack found in the 
document resource manager, creating a new one 
QSYSTEM: TestKoBookmark::testRoundtrip() qttest(30852): Cannot open  
"/tmp/kde-boud/qttestRk2zYl/Europe/Berlin" 

QSYSTEM: TestKoBookmark::testRoundtrip() qttest(30852): Cannot open  
"/tmp/kde-boud/qttestRk2zYl/Europe/Berlin" 

PASS   : TestKoBookmark::testRoundtrip()
PASS   : TestKoBookmark::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
* Finished testing of TestKoBookmark *
==30852== Jump to the invalid address stated on the next line
==30852==at 0x0: ???
==30852==by 0xA62E3B2: QObject::~QObject() (qobject.cpp:861)
==30852==by 0xA62E9A8: QObject::~QObject() (qobject.cpp:964)
==30852==by 0xAB9E93F: 
QDBusAbstractInterfacePrivate::~QDBusAbstractInterfacePrivate() 
(qdbusabstractinterface_p.h:87)
==30852==by 0xA62E7F2: QObject::~QObject() (qscopedpointer.h:62)
==30852==by 0xAB80BC8: 
QDBusConnectionInterface::~QDBusConnectionInterface() 
(qdbusconnectioninterface.cpp:179)
==30852==by 0xA629A53: QObjectPrivate::deleteChildren() (qobject.cpp:1955)
==30852==by 0xA62E7A1: QObject::~QObject() (qobject.cpp:946)
==30852==by 0xAB88ABA: QDBusConnectionPrivate::~QDBusConnectionPrivate() 
(qdbusintegrator.cpp:998)
==30852==by 0xAB88DF8: QDBusConnectionPrivate::~QDBusConnectionPrivate() 
(qdbusintegrator.cpp:1016)
==30852==by 0xAB803AF: 
QGlobalStaticDeleter::~QGlobalStaticDeleter() 
(qdbusconnection.cpp:978)   
  
==30852==by 0xB58B5A0: __run_exit_handlers (in /lib64/libc-2.11.3.so)   

   
==30852==  Address 0x0 is not stack'd, malloc'd or (recently) free'd

   
==30852==   

   
==30852==   

   
==30852== Process terminating with default action of signal 11 (SIGSEGV)

   
==30852==  Bad permissions for mapped region at address 0x0 

   
==30852==at 0x0: ???

   
==30852==by 0xA62E3B2: QObject::~QObject() (qobject.cpp:861)

   
==30852==by 0xA62E9A8: QObject::~QObject() (qobject.cpp:964)

   
==30852==by 0xAB9E93F: 
QDBusAbstractInterfacePrivate::~QDBusAbstractInterfacePr

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-08 Thread Brijesh Patel 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/
---

(Updated Sept. 8, 2011, 3:28 p.m.)


Review request for Calligra.


Changes
---

i have updated the patch with cosmetic fixes,but still need to work problems 
you showed


Summary
---

I worked on implementation of Footnotes and Endnotes in Calligra Words as part 
of my SoK project.
Footnotes/Endnotes can now be inserted,saved,loaded and also be configured too.
Can somebody review my work and notify me about bugs/crashes?


Diffs (updated)
-

  libs/kotext/KoInlineNote.h 515a2f3 
  libs/kotext/KoInlineNote.cpp 89200fd 
  libs/kotext/KoInlineTextObjectManager.h 44990e9 
  libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
  libs/kotext/KoTextEditor.h ba28354 
  libs/kotext/KoTextEditor.cpp 4d3e5b18 
  libs/kotext/opendocument/KoTextLoader.cpp e9d47da 
  libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad 
  libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
  libs/odf/KoOdfNumberDefinition.cpp d35a07f 
  libs/odf/KoOdfStylesReader.cpp 5a8324e 
  libs/textlayout/KoTextLayoutArea.h ea7fd8e 
  libs/textlayout/KoTextLayoutArea.cpp 504de0c 
  libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
  libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
  plugins/textshape/CMakeLists.txt 3df7aa5 
  plugins/textshape/ReferencesTool.h 40676b2 
  plugins/textshape/ReferencesTool.cpp 0bbd38d 
  plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
  plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
  plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
  plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
  plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
  plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
  plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102552/diff


Testing
---


Thanks,

Brijesh

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: problem with a unittest

2011-09-08 Thread Jaime 
Do you run the tests in 64 or 32 bits? Qt with glib or without?

I have a bug that only happens in 64 bits.. And like this one,
disappears when dolphin is running under valgrind.
https://bugs.kde.org/show_bug.cgi?id=278366


2011/9/8 Boudewijn Rempt :
> On Thursday 08 September 2011 Sep, Cyrille Berger Skott wrote:
>> On Thursday 08 September 2011, Boudewijn Rempt wrote:
>> > . I tried running it under gdb and got this:
>> And did you try with valgrind ?
>
> Yes -- and the output is quite weird:
>
>
> boud@talnus:~/kde/build/calligra/words/part/tests> valgrind ./TestKoBookmark
> ==30852== Memcheck, a memory error detector
> ==30852== Copyright (C) 2002-2010, and GNU GPL'd, by Julian Seward et al.
> ==30852== Using Valgrind-3.6.1 and LibVEX; rerun with -h for copyright info
> ==30852== Command: ./TestKoBookmark
> ==30852==
> KGlobal::locale::Warning your global KLocale is being recreated with a valid 
> main component instead of a fake component, this usually means you tried to 
> call i18n related functions before your main component was created. You 
> should not do that since it most likely will not work
> * Start testing of TestKoBookmark *
> Config: Using QTest library 4.7.4, Qt 4.7.4
> PASS   : TestKoBookmark::initTestCase()
> PASS   : TestKoBookmark::testInsertion()
> QDEBUG : TestKoBookmark::testRoundtrip() (Soprano::Redland::BackendPlugin) 
> creating model of type "hashes" with options 
> "hash-type='memory',contexts='yes'"
> QDEBUG : TestKoBookmark::testRoundtrip() qttest(30852)/kotext 
> TextShapeFactory::newDocumentResourceManager: No KUndo2Stack found in the 
> document resource manager, creating a new one
> QDEBUG : TestKoBookmark::testRoundtrip() (Soprano::Redland::BackendPlugin) 
> creating model of type "hashes" with options 
> "hash-type='memory',contexts='yes'"
> QDEBUG : TestKoBookmark::testRoundtrip() qttest(30852)/kotext 
> TextShapeFactory::newDocumentResourceManager: No KUndo2Stack found in the 
> document resource manager, creating a new one
> QSYSTEM: TestKoBookmark::testRoundtrip() qttest(30852): Cannot open  
> "/tmp/kde-boud/qttestRk2zYl/Europe/Berlin"
>
> QSYSTEM: TestKoBookmark::testRoundtrip() qttest(30852): Cannot open  
> "/tmp/kde-boud/qttestRk2zYl/Europe/Berlin"
>
> PASS   : TestKoBookmark::testRoundtrip()
> PASS   : TestKoBookmark::cleanupTestCase()
> Totals: 4 passed, 0 failed, 0 skipped
> * Finished testing of TestKoBookmark *
> ==30852== Jump to the invalid address stated on the next line
> ==30852==    at 0x0: ???
> ==30852==    by 0xA62E3B2: QObject::~QObject() (qobject.cpp:861)
> ==30852==    by 0xA62E9A8: QObject::~QObject() (qobject.cpp:964)
> ==30852==    by 0xAB9E93F: 
> QDBusAbstractInterfacePrivate::~QDBusAbstractInterfacePrivate() 
> (qdbusabstractinterface_p.h:87)
> ==30852==    by 0xA62E7F2: QObject::~QObject() (qscopedpointer.h:62)
> ==30852==    by 0xAB80BC8: 
> QDBusConnectionInterface::~QDBusConnectionInterface() 
> (qdbusconnectioninterface.cpp:179)
> ==30852==    by 0xA629A53: QObjectPrivate::deleteChildren() (qobject.cpp:1955)
> ==30852==    by 0xA62E7A1: QObject::~QObject() (qobject.cpp:946)
> ==30852==    by 0xAB88ABA: QDBusConnectionPrivate::~QDBusConnectionPrivate() 
> (qdbusintegrator.cpp:998)
> ==30852==    by 0xAB88DF8: QDBusConnectionPrivate::~QDBusConnectionPrivate() 
> (qdbusintegrator.cpp:1016)
> ==30852==    by 0xAB803AF: 
> QGlobalStaticDeleter::~QGlobalStaticDeleter() 
> (qdbusconnection.cpp:978)
> ==30852==    by 0xB58B5A0: __run_exit_handlers (in /lib64/libc-2.11.3.so)
> ==30852==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
> ==30852==
> ==30852==
> ==30852== Process terminating with default action of signal 11 (SIGSEGV)
> ==30852==  Bad permissions for mapped region at address 0x0
> ==30852==    at 0x0: ???
> ==30852==    by 0xA62E3B2: QObject::~QObject() (qobject.cpp:861)
> ==30852==    by 0xA62E9A8: QObject::~QObject() (qobject.cpp:964)
> ==30852==    by 0xAB9E93F: 
> QDBusAbstractInterfacePrivate::~QDBusAbstractInterfacePrivate() 
> (qdbusabstractinterface_p.h:87)
> ==30852==    by 0xA62E7F2: QObject::~QObject() (qscopedpointer.h:62)
> ==30852==    by 0xAB80BC8: 
> QDBusConnectionInterface::~QDBusConnectionInterface() 
> (qdbusconnectioninterface.cpp:179)
> ==30852==    by 0xA629A53: QObjectPrivate::deleteChildren() (qobject.cpp:1955)
> ==30852==    by 0xA62E7A1: QObject::~QObject() (qobject.cpp:946)
> ==30852==    by 0xAB88ABA: QDBusConnectionPrivate::~QDBusConnectionPrivate() 
> (qdbusintegrator.cpp:998)
> ==30852==    by 0xAB88DF8: QDBusConnectionPrivate::~QDBusConnectionPrivate() 
> (qdbusintegrator.cpp:1016)
> ==30852==    by 0xAB803AF: 
> QGlobalStaticDeleter::~QGlobalStaticDeleter() 
> (qdbusconnection.cpp:978)
> ==30852==    by 0xB58B5A0: __run_exit_handlers (in /lib64/libc-2.11.3.so)
> ==30852==
> ==30852== HEAP SUMMARY:
> ==30852==     in use at exit: 2,352,914 bytes in 21,995 blocks
> ==30852==   total heap usage: 271,524 allocs, 249,529 frees, 65,508,421 bytes 
> allocat

Re: problem with a unittest

2011-09-08 Thread Boudewijn Rempt 
On Thursday 08 September 2011 Sep, Jaime wrote:
> Do you run the tests in 64 or 32 bits? Qt with glib or without?
> 
> I have a bug that only happens in 64 bits.. And like this one,
> disappears when dolphin is running under valgrind.
> https://bugs.kde.org/show_bug.cgi?id=278366
> 

64-bits, default Qt from OpenSUSE, so I would assume with glib.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread Thorsten Zachmann 
On Thursday, September 08, 2011 16:20:12 Cyrille Berger Skott wrote:
> On Thursday 08 September 2011, Thorsten Zachmann wrote:
> > For everybody how might be able to join the sprint at 11.11. please go to
> > https://sprints.kde.org and add yourself as participant and provide the
> > estimated cost for the travel. Don't estimate any costs for hotel.
> 
> I guess we need to be validated to appear on the list ?

As there is no date set it can only be seen in the all sprints view.

Thorsten
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread Boudewijn Rempt 
On Thursday 08 September 2011 Sep, Thorsten Zachmann wrote:
> On Thursday, September 08, 2011 16:20:12 Cyrille Berger Skott wrote:
> > On Thursday 08 September 2011, Thorsten Zachmann wrote:
> > > For everybody how might be able to join the sprint at 11.11. please go to
> > > https://sprints.kde.org and add yourself as participant and provide the
> > > estimated cost for the travel. Don't estimate any costs for hotel.
> > 
> > I guess we need to be validated to appear on the list ?
> 
> As there is no date set it can only be seen in the all sprints view.

This is actually complicated:

* You need to go to the all-sprints view
* then click on the magnify icon in the last column to select the sprint
* then it's possible to add yourself, if you're logged in on your 
identity.kde.org account.


-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread C. Boemann 
On Thursday 08 September 2011 18:42:12 Boudewijn Rempt wrote:
> On Thursday 08 September 2011 Sep, Thorsten Zachmann wrote:
> > On Thursday, September 08, 2011 16:20:12 Cyrille Berger Skott wrote:
> > > On Thursday 08 September 2011, Thorsten Zachmann wrote:
> > > > For everybody how might be able to join the sprint at 11.11. please
> > > > go to https://sprints.kde.org and add yourself as participant and
> > > > provide the estimated cost for the travel. Don't estimate any costs
> > > > for hotel.
> > > 
> > > I guess we need to be validated to appear on the list ?
> > 
> > As there is no date set it can only be seen in the all sprints view.
> 
> This is actually complicated:
> 
> * You need to go to the all-sprints view
> * then click on the magnify icon in the last column to select the sprint
> * then it's possible to add yourself, if you're logged in on your
> identity.kde.org account.
That wasn't what cyrille meant

I'm added to the sprint to but because my account is not validated either 
neithe me nor cyrille shows up in the list of participants
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread Dmitry Kazakov 
On Thu, Sep 8, 2011 at 8:43 PM, C. Boemann  wrote:

> On Thursday 08 September 2011 18:42:12 Boudewijn Rempt wrote:
> > On Thursday 08 September 2011 Sep, Thorsten Zachmann wrote:
> > > On Thursday, September 08, 2011 16:20:12 Cyrille Berger Skott wrote:
> > > > On Thursday 08 September 2011, Thorsten Zachmann wrote:
> > > > > For everybody how might be able to join the sprint at 11.11. please
> > > > > go to https://sprints.kde.org and add yourself as participant and
> > > > > provide the estimated cost for the travel. Don't estimate any costs
> > > > > for hotel.
> > > >
> > > > I guess we need to be validated to appear on the list ?
> > >
> > > As there is no date set it can only be seen in the all sprints view.
> >
> > This is actually complicated:
> >
> > * You need to go to the all-sprints view
> > * then click on the magnify icon in the last column to select the sprint
> > * then it's possible to add yourself, if you're logged in on your
> > identity.kde.org account.
> That wasn't what cyrille meant
>
> I'm added to the sprint to but because my account is not validated either
> neithe me nor cyrille shows up in the list of participants
>

Your accounts are shown, but only if you click on some switches like "Name",
"Food", "Sponsorship". I guess it is a bug of sprints.kde.org. ;)


-- 
Dmitry Kazakov
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread Boudewijn Rempt 
On Thursday 08 September 2011 Sep, C. Boemann wrote:
> On Thursday 08 September 2011 18:42:12 Boudewijn Rempt wrote:
> > On Thursday 08 September 2011 Sep, Thorsten Zachmann wrote:
> > > On Thursday, September 08, 2011 16:20:12 Cyrille Berger Skott wrote:
> > > > On Thursday 08 September 2011, Thorsten Zachmann wrote:
> > > > > For everybody how might be able to join the sprint at 11.11. please
> > > > > go to https://sprints.kde.org and add yourself as participant and
> > > > > provide the estimated cost for the travel. Don't estimate any costs
> > > > > for hotel.
> > > > 
> > > > I guess we need to be validated to appear on the list ?
> > > 
> > > As there is no date set it can only be seen in the all sprints view.
> > 
> > This is actually complicated:
> > 
> > * You need to go to the all-sprints view
> > * then click on the magnify icon in the last column to select the sprint
> > * then it's possible to add yourself, if you're logged in on your
> > identity.kde.org account.
> That wasn't what cyrille meant
> 
> I'm added to the sprint to but because my account is not validated either 
> neithe me nor cyrille shows up in the list of participants

Weird... I cannot actually remember going through a validation step with my 
account.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2. Calligra Sprint

2011-09-08 Thread C. Boemann 
On Thursday 08 September 2011 18:56:33 Boudewijn Rempt wrote:
> On Thursday 08 September 2011 Sep, C. Boemann wrote:
> > On Thursday 08 September 2011 18:42:12 Boudewijn Rempt wrote:
> > > On Thursday 08 September 2011 Sep, Thorsten Zachmann wrote:
> > > > On Thursday, September 08, 2011 16:20:12 Cyrille Berger Skott wrote:
> > > > > On Thursday 08 September 2011, Thorsten Zachmann wrote:
> > > > > > For everybody how might be able to join the sprint at 11.11.
> > > > > > please go to https://sprints.kde.org and add yourself as
> > > > > > participant and provide the estimated cost for the travel. Don't
> > > > > > estimate any costs for hotel.
> > > > > 
> > > > > I guess we need to be validated to appear on the list ?
> > > > 
> > > > As there is no date set it can only be seen in the all sprints view.
> > > 
> > > This is actually complicated:
> > > 
> > > * You need to go to the all-sprints view
> > > * then click on the magnify icon in the last column to select the
> > > sprint * then it's possible to add yourself, if you're logged in on
> > > your identity.kde.org account.
> > 
> > That wasn't what cyrille meant
> > 
> > I'm added to the sprint to but because my account is not validated either
> > neithe me nor cyrille shows up in the list of participants
> 
> Weird... I cannot actually remember going through a validation step with my
> account.
I don't think that is irrelevant after all

i think the website is just buggy
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-08 Thread Thorsten Zachmann 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6344
---



libs/odf/KoOdfStylesReader.cpp


That part is only called when a style is added which only happens a 
notes-configuration is found. The code is not executed when there is no 
notes-configuration. Is that what you want?


- Thorsten


On Sept. 8, 2011, 3:28 p.m., Brijesh Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> ---
> 
> (Updated Sept. 8, 2011, 3:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> ---
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as 
> part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured 
> too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextEditor.h ba28354 
>   libs/kotext/KoTextEditor.cpp 4d3e5b18 
>   libs/kotext/opendocument/KoTextLoader.cpp e9d47da 
>   libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 5a8324e 
>   libs/textlayout/KoTextLayoutArea.h ea7fd8e 
>   libs/textlayout/KoTextLayoutArea.cpp 504de0c 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h 40676b2 
>   plugins/textshape/ReferencesTool.cpp 0bbd38d 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brijesh
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-08 Thread Thorsten Zachmann 


> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/kotext/KoInlineNote.cpp, lines 164-165
> > 
> >
> > Maybe you can remove the count variable and do the renumbering where a 
> > new footnote is added to the inline object manager. Then you will be sure 
> > it works correctly also when there are more then one document.
> 
> Brijesh Patel wrote:
> that poses a problem when the footnotes are deleted...

I had a look at the KoInlineTextObjectManager and I think this code belongs to 
be in there. There is also a function that gets called when an inline object 
gets deleted so I think that should work. Doing the whole stuff at painting 
time is not the right thing to do


> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/kotext/KoInlineNote.cpp, line 233
> > 
> >
> > Is there a reason to remove this line here. I think it only makes sure 
> > that the initial value of the variable is set correctly.
> 
> Brijesh Patel wrote:
> I dont remember the reason exactly why i removed,
> but it was something like this
> the notes which are inserted in this session only get the autonumbering 
> tag while loading,but previously inserted notes don't.
> so counting begins from 1 in each session.
>

Can you please check if the line is realy needed.


> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/kotext/KoInlineNote.cpp, lines 286-290
> > 
> >
> > The notes configuration should be saved only once and not with each 
> > footnote. Please ping me on IRC if you have a question on how that can be 
> > done.
> 
> Brijesh Patel wrote:
> I am doing a check for that only,
> see line 283: if 
> (KoTextDocument(d->textFrame->document()).inlineTextObjectManager()->getFirstNote(d->textFrame->document()->begin())->id()
>  == this-   
>   >id()) {
> 
> it will go inside "if" only if it is the first visible note of the 
> document otherwise it wont go

As the KoOdfNotesConfiguration is used as a style and handled like that in 
loading I think it would be better if the KoStyleManager would be resposible 
about it. But maybe others see it differently. If it would be part of the 
KoStyleManager it could be loaded and saved like all othere styles in one.


- Thorsten


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6323
---


On Sept. 8, 2011, 3:28 p.m., Brijesh Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> ---
> 
> (Updated Sept. 8, 2011, 3:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> ---
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as 
> part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured 
> too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextEditor.h ba28354 
>   libs/kotext/KoTextEditor.cpp 4d3e5b18 
>   libs/kotext/opendocument/KoTextLoader.cpp e9d47da 
>   libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 5a8324e 
>   libs/textlayout/KoTextLayoutArea.h ea7fd8e 
>   libs/textlayout/KoTextLayoutArea.cpp 504de0c 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h 40676b2 
>   plugins/textshape/ReferencesTool.cpp 0bbd38d 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brijesh
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.o

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-08 Thread Thorsten Zachmann 


> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote:
> > libs/textlayout/KoTextLayoutEndNotesArea.cpp, line 128
> > 
> >
> > Maybe you can somewhere define what all these numbers are for
> 
> Brijesh Patel wrote:
> when we were doing  painter->drawLine(left(), top(), right(), top());
> the divider line was not looking elegant since it covers the whole space 
> from left to right in the doc and also very much sticking to the normal text 
> of the document above the line.
> 
> so give proper spacing and increase the elegance,i reduced the width of 
> the line and shifted it somewhat below than it was before.

What I meant by to comment is that the numbers are not clear for the reader of 
the code to see what they are doing. If you have some consts with a clear name 
which define them it is much easier for the reader to understand what is going 
one.


- Thorsten


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6323
---


On Sept. 8, 2011, 3:28 p.m., Brijesh Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> ---
> 
> (Updated Sept. 8, 2011, 3:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> ---
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as 
> part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured 
> too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextEditor.h ba28354 
>   libs/kotext/KoTextEditor.cpp 4d3e5b18 
>   libs/kotext/opendocument/KoTextLoader.cpp e9d47da 
>   libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 5a8324e 
>   libs/textlayout/KoTextLayoutArea.h ea7fd8e 
>   libs/textlayout/KoTextLayoutArea.cpp 504de0c 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h 40676b2 
>   plugins/textshape/ReferencesTool.cpp 0bbd38d 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brijesh
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel