Review Request: load missing translation catalog for thesaurus plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101435/ --- Review request for Calligra. Summary --- load translation catalog to make the dialog fully translated Diffs - plugins/textediting/thesaurus/ThesaurusPlugin.cpp c8d8a98 Diff: http://git.reviewboard.kde.org/r/101435/diff Testing --- Thanks, Burkhard ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: load missing translation catalog for thesaurus plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101435/#review3504 --- No idea wat it does, but I say ship it - Casper On May 25, 2011, 7:46 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101435/ > --- > > (Updated May 25, 2011, 7:46 a.m.) > > > Review request for Calligra. > > > Summary > --- > > load translation catalog to make the dialog fully translated > > > Diffs > - > > plugins/textediting/thesaurus/ThesaurusPlugin.cpp c8d8a98 > > Diff: http://git.reviewboard.kde.org/r/101435/diff > > > Testing > --- > > > Thanks, > > Burkhard > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: load missing translation catalog for thesaurus plugin
> On May 25, 2011, 9:58 a.m., Casper Boemann wrote:
> > No idea wat it does, but I say ship it
Whith K_EXPORT_PLUGIN( ThesaurusPluginFactory("ThesaurusPlugin") ) the plugin
tries to load the translation catalog "ThesaurusPlugin", but this fails cause
the strings are extracted to a catalog named thesaurus_tool in Messages.sh.
Plugin is always untranslated (apart from strings in the system catalogs and
strings from desktop files), even if the catalog "thesaurus_tool" is translated
and installed :(
With K_EXPORT_PLUGIN( ThesaurusPluginFactory("ThesaurusPlugin",
"thesaurus_tool") ) the plugin tries to load the catalog "thesaurus_tool" ->
success, plugin is translated :)
- Burkhard
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101435/#review3504
---
On May 25, 2011, 7:46 a.m., Burkhard Lück wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101435/
> ---
>
> (Updated May 25, 2011, 7:46 a.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> ---
>
> load translation catalog to make the dialog fully translated
>
>
> Diffs
> -
>
> plugins/textediting/thesaurus/ThesaurusPlugin.cpp c8d8a98
>
> Diff: http://git.reviewboard.kde.org/r/101435/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Burkhard
>
>
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: load missing translation catalog for thesaurus plugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101435/#review3509 --- This review has been submitted with commit 14c5bab51941a0eb697a468dd42472806d38fc88 by Burkhard Lück. - Commit On May 25, 2011, 7:46 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101435/ > --- > > (Updated May 25, 2011, 7:46 a.m.) > > > Review request for Calligra. > > > Summary > --- > > load translation catalog to make the dialog fully translated > > > Diffs > - > > plugins/textediting/thesaurus/ThesaurusPlugin.cpp c8d8a98 > > Diff: http://git.reviewboard.kde.org/r/101435/diff > > > Testing > --- > > > Thanks, > > Burkhard > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Random failures in the test kotext-odf-TestChangeTracking
Hi is this still an issue and, Ganesh have you had a chance to look. best regards Casper On Monday 16 May 2011 18:50:45 Ganesh Paramasivam wrote: > Hi, > > Looks like saving of delete changes in broken ( and probably not > related to the random failures ). Will take a look at it. > Can this wait till the weekend for a fix ? > > Thanks, > Ganesh > > On Mon, May 16, 2011 at 2:04 PM, Cyrille Berger Skott > > wrote: > > Hi, > > > > I now get "permanent" failure in the unit test: > > http://my.cdash.org/testDetails.php?test=6063659&build=187759 > > > > It seems it happened after the merge of the new text layout. > > > > -- > > Cyrille Berger Skott > > ___ > > calligra-devel mailing list > > calligra-devel@kde.org > > https://mail.kde.org/mailman/listinfo/calligra-devel > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Random failures in the test kotext-odf-TestChangeTracking
Casper, I have been on travel on haven't had a chance to look ( also the situation is going to be same for the next 10 days ). If you could give me a target date by when you would like to see this fixed, I will squeeze some time to fix this. Thanks, Ganesh On Wed, May 25, 2011 at 9:03 PM, C. Boemann wrote: > Hi > > is this still an issue and, Ganesh have you had a chance to look. > > best regards > Casper > > On Monday 16 May 2011 18:50:45 Ganesh Paramasivam wrote: >> Hi, >> >> Looks like saving of delete changes in broken ( and probably not >> related to the random failures ). Will take a look at it. >> Can this wait till the weekend for a fix ? >> >> Thanks, >> Ganesh >> >> On Mon, May 16, 2011 at 2:04 PM, Cyrille Berger Skott >> >> wrote: >> > Hi, >> > >> > I now get "permanent" failure in the unit test: >> > http://my.cdash.org/testDetails.php?test=6063659&build=187759 >> > >> > It seems it happened after the merge of the new text layout. >> > >> > -- >> > Cyrille Berger Skott >> > ___ >> > calligra-devel mailing list >> > calligra-devel@kde.org >> > https://mail.kde.org/mailman/listinfo/calligra-devel >> >> ___ >> calligra-devel mailing list >> calligra-devel@kde.org >> https://mail.kde.org/mailman/listinfo/calligra-devel > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Random failures in the test kotext-odf-TestChangeTracking
Hi Ganesh As soon as possible. We have seen a lot of issues with the changetracking to the point of us regretting that we have merged it into master. It's too late to revert it now, but getting things fixed has a very high priority. best regards Casper On Wednesday 25 May 2011 17:38:20 Ganesh Paramasivam wrote: > Casper, > > I have been on travel on haven't had a chance to look ( also the > situation is going to be same for the next 10 days ). If you could > give me a target date by when you would like to see this fixed, I will > squeeze some time to fix this. > > Thanks, > Ganesh > > On Wed, May 25, 2011 at 9:03 PM, C. Boemann wrote: > > Hi > > > > is this still an issue and, Ganesh have you had a chance to look. > > > > best regards > > Casper > > > > On Monday 16 May 2011 18:50:45 Ganesh Paramasivam wrote: > >> Hi, > >> > >> Looks like saving of delete changes in broken ( and probably not > >> related to the random failures ). Will take a look at it. > >> Can this wait till the weekend for a fix ? > >> > >> Thanks, > >> Ganesh > >> > >> On Mon, May 16, 2011 at 2:04 PM, Cyrille Berger Skott > >> > >> wrote: > >> > Hi, > >> > > >> > I now get "permanent" failure in the unit test: > >> > http://my.cdash.org/testDetails.php?test=6063659&build=187759 > >> > > >> > It seems it happened after the merge of the new text layout. > >> > > >> > -- > >> > Cyrille Berger Skott > >> > ___ > >> > calligra-devel mailing list > >> > calligra-devel@kde.org > >> > https://mail.kde.org/mailman/listinfo/calligra-devel > >> > >> ___ > >> calligra-devel mailing list > >> calligra-devel@kde.org > >> https://mail.kde.org/mailman/listinfo/calligra-devel > > > > ___ > > calligra-devel mailing list > > calligra-devel@kde.org > > https://mail.kde.org/mailman/listinfo/calligra-devel > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Random failures in the test kotext-odf-TestChangeTracking
Casper, I just took a quick look at this and here is the analysis - A vast majority ( all ? ) of the test failures are due to failures in saving delete changes. - According to the original code, deleted fragments are inserted into the document before a save and removed after a save. - The code to do the above step was available in the saveOdf() function of libs/kotext/KoTextShapeData.cpp - I see that this file has been removed and on examining the git logs, I see that this file has been moved to libs/textlayout - Also looks like saveOdf() of KoTextShapeData() is never called ( >From the fact that TestChangeTracking does not link to this library) - So delete changes are not inserted into the document before a save and hence all the test failures. So, for change tracking to be restored, the functionality that is available in saveOdf of KoTextShapeData ( i.e. inserting delete changes before a save and removing them after a save) should be moved to the appropriate place in the new design. Also, if the above analysis is correct, the right people to fix this issue really fast are the developers working on the textlayout library. I do not know anything about the new design to be able to fix this problem in a short time. Thanks, Ganesh On Wed, May 25, 2011 at 9:14 PM, C. Boemann wrote: > Hi Ganesh > > As soon as possible. We have seen a lot of issues with the changetracking to > the point of us regretting that we have merged it into master. It's too late > to revert it now, but getting things fixed has a very high priority. > > best regards > Casper > > On Wednesday 25 May 2011 17:38:20 Ganesh Paramasivam wrote: >> Casper, >> >> I have been on travel on haven't had a chance to look ( also the >> situation is going to be same for the next 10 days ). If you could >> give me a target date by when you would like to see this fixed, I will >> squeeze some time to fix this. >> >> Thanks, >> Ganesh >> >> On Wed, May 25, 2011 at 9:03 PM, C. Boemann wrote: >> > Hi >> > >> > is this still an issue and, Ganesh have you had a chance to look. >> > >> > best regards >> > Casper >> > >> > On Monday 16 May 2011 18:50:45 Ganesh Paramasivam wrote: >> >> Hi, >> >> >> >> Looks like saving of delete changes in broken ( and probably not >> >> related to the random failures ). Will take a look at it. >> >> Can this wait till the weekend for a fix ? >> >> >> >> Thanks, >> >> Ganesh >> >> >> >> On Mon, May 16, 2011 at 2:04 PM, Cyrille Berger Skott >> >> >> >> wrote: >> >> > Hi, >> >> > >> >> > I now get "permanent" failure in the unit test: >> >> > http://my.cdash.org/testDetails.php?test=6063659&build=187759 >> >> > >> >> > It seems it happened after the merge of the new text layout. >> >> > >> >> > -- >> >> > Cyrille Berger Skott >> >> > ___ >> >> > calligra-devel mailing list >> >> > calligra-devel@kde.org >> >> > https://mail.kde.org/mailman/listinfo/calligra-devel >> >> >> >> ___ >> >> calligra-devel mailing list >> >> calligra-devel@kde.org >> >> https://mail.kde.org/mailman/listinfo/calligra-devel >> > >> > ___ >> > calligra-devel mailing list >> > calligra-devel@kde.org >> > https://mail.kde.org/mailman/listinfo/calligra-devel >> >> ___ >> calligra-devel mailing list >> calligra-devel@kde.org >> https://mail.kde.org/mailman/listinfo/calligra-devel > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Random failures in the test kotext-odf-TestChangeTracking
Hi Ganesh thanks for the analysis. I guess I'm partly at fault then. I blame git too ;) I'll try and see if i can restore it to working order big thanks Casper On Wednesday 25 May 2011 19:10:03 Ganesh Paramasivam wrote: > Casper, > > I just took a quick look at this and here is the analysis > > - A vast majority ( all ? ) of the test failures are due to failures > in saving delete changes. > - According to the original code, deleted fragments are inserted into > the document before a save and removed after a save. > - The code to do the above step was available in the saveOdf() > function of libs/kotext/KoTextShapeData.cpp > - I see that this file has been removed and on examining the git logs, > I see that this file has been moved to libs/textlayout > - Also looks like saveOdf() of KoTextShapeData() is never called ( > From the fact that TestChangeTracking does not link to this library) > - So delete changes are not inserted into the document before a save > and hence all the test failures. > > So, for change tracking to be restored, the functionality that is > available in saveOdf of KoTextShapeData ( i.e. inserting delete > changes before a save and removing them after a save) should be moved > to the appropriate place in the new design. > > Also, if the above analysis is correct, the right people to fix this > issue really fast are the developers working on the textlayout > library. I do not know anything about the new design to be able to fix > this problem in a short time. > > Thanks, > Ganesh > > On Wed, May 25, 2011 at 9:14 PM, C. Boemann wrote: > > Hi Ganesh > > > > As soon as possible. We have seen a lot of issues with the changetracking > > to the point of us regretting that we have merged it into master. It's > > too late to revert it now, but getting things fixed has a very high > > priority. > > > > best regards > > Casper > > > > On Wednesday 25 May 2011 17:38:20 Ganesh Paramasivam wrote: > >> Casper, > >> > >> I have been on travel on haven't had a chance to look ( also the > >> situation is going to be same for the next 10 days ). If you could > >> give me a target date by when you would like to see this fixed, I will > >> squeeze some time to fix this. > >> > >> Thanks, > >> Ganesh > >> > >> On Wed, May 25, 2011 at 9:03 PM, C. Boemann wrote: > >> > Hi > >> > > >> > is this still an issue and, Ganesh have you had a chance to look. > >> > > >> > best regards > >> > Casper > >> > > >> > On Monday 16 May 2011 18:50:45 Ganesh Paramasivam wrote: > >> >> Hi, > >> >> > >> >> Looks like saving of delete changes in broken ( and probably not > >> >> related to the random failures ). Will take a look at it. > >> >> Can this wait till the weekend for a fix ? > >> >> > >> >> Thanks, > >> >> Ganesh > >> >> > >> >> On Mon, May 16, 2011 at 2:04 PM, Cyrille Berger Skott > >> >> > >> >> wrote: > >> >> > Hi, > >> >> > > >> >> > I now get "permanent" failure in the unit test: > >> >> > http://my.cdash.org/testDetails.php?test=6063659&build=187759 > >> >> > > >> >> > It seems it happened after the merge of the new text layout. > >> >> > > >> >> > -- > >> >> > Cyrille Berger Skott > >> >> > ___ > >> >> > calligra-devel mailing list > >> >> > calligra-devel@kde.org > >> >> > https://mail.kde.org/mailman/listinfo/calligra-devel > >> >> > >> >> ___ > >> >> calligra-devel mailing list > >> >> calligra-devel@kde.org > >> >> https://mail.kde.org/mailman/listinfo/calligra-devel > >> > > >> > ___ > >> > calligra-devel mailing list > >> > calligra-devel@kde.org > >> > https://mail.kde.org/mailman/listinfo/calligra-devel > >> > >> ___ > >> calligra-devel mailing list > >> calligra-devel@kde.org > >> https://mail.kde.org/mailman/listinfo/calligra-devel > > > > ___ > > calligra-devel mailing list > > calligra-devel@kde.org > > https://mail.kde.org/mailman/listinfo/calligra-devel > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review-request: Fix copy+paste sections (bug 271029)
The problem is that on copy+paste text in Words we create ODF ouf of a
fragment. That fragment can contains SectionEnd's without SectionStart's (or
the other way around which would probably produce invalid XML? That case is
not handled with this patch :-/ ). That results then in an assert. See bug
271029 for more details.
Attached patch fixes the assert with the document attached to the bugreport.
But I am not sure if it's complete cause, as I wrote above, we need to take
also the inverse case into account somehow and I am atm not sure how. Maybe we
can just write endElement()'s till the styleStack isEmpty or so?
diff --git a/libs/kotext/opendocument/KoTextWriter.cpp
b/libs/kotext/opendocument/KoTextWriter.cpp
index a938aa0..b61e0d5 100644
--- a/libs/kotext/opendocument/KoTextWriter.cpp
+++ b/libs/kotext/opendocument/KoTextWriter.cpp
@@ -135,6 +135,7 @@ public:
, splitEndBlockNumber(-1)
, splitRegionOpened(false)
, splitIdCounter(1)
+, sectionLevel(0)
, deleteMergeRegionOpened(false)
, deleteMergeEndBlockNumber(-1)
{
@@ -208,6 +209,7 @@ public:
int splitEndBlockNumber;
bool splitRegionOpened;
bool splitIdCounter;
+int sectionLevel;
//For saving of delete-changes that result in a merge between two
elements
bool deleteMergeRegionOpened;
@@ -1676,6 +1678,7 @@ void KoTextWriter::Private::writeBlocks(QTextDocument
*document, int from, int t
QVariant v = format.property(KoParagraphStyle::SectionStart);
KoSection* section = (KoSection*)(v.value());
if (section) {
+sectionLevel++;
section->saveOdf(context);
}
}
@@ -1731,7 +1734,8 @@ void KoTextWriter::Private::writeBlocks(QTextDocument
*document, int from, int t
if (format.hasProperty(KoParagraphStyle::SectionEnd)) {
QVariant v = format.property(KoParagraphStyle::SectionEnd);
KoSectionEnd* section = (KoSectionEnd*)(v.value());
-if (section) {
+if (section && sectionLevel >= 1) {
+--sectionLevel;
section->saveOdf(context);
}
}
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Remove Zoom-submenu from mainmenu?
Hi, please see attached patch which removes the zoom-submenu from all Calligra applications. The reason is that it's redundant with the zoom-menu we have in the statusbar. Good idea or not? diff --git a/braindump/data/braindumpview.rc b/braindump/data/braindumpview.rc index 999c949..2f6f59c 100644 --- a/braindump/data/braindumpview.rc +++ b/braindump/data/braindumpview.rc @@ -1,6 +1,6 @@ - + &Edit @@ -30,7 +30,6 @@ &View - diff --git a/flow/part/flow.rc b/flow/part/flow.rc index bd2913a..2798cd6 100644 --- a/flow/part/flow.rc +++ b/flow/part/flow.rc @@ -1,6 +1,6 @@ - + &Edit @@ -29,7 +29,6 @@ - diff --git a/karbon/data/karbon.rc b/karbon/data/karbon.rc index 24dd007..819c7bf 100644 --- a/karbon/data/karbon.rc +++ b/karbon/data/karbon.rc @@ -1,6 +1,6 @@ http://www.kde.org/standards/kxmlgui/1.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://www.kde.org/standards/kxmlgui/1.0 @@ -56,7 +56,6 @@ - diff --git a/kpresenter/part/stage.rc b/kpresenter/part/stage.rc index d48fd3c..7e06da6 100644 --- a/kpresenter/part/stage.rc +++ b/kpresenter/part/stage.rc @@ -1,6 +1,6 @@ - + @@ -43,7 +43,6 @@ - &Insert diff --git a/krita/krita.rc b/krita/krita.rc index 4f1e6d1..96c987e 100644 --- a/krita/krita.rc +++ b/krita/krita.rc @@ -1,4 +1,4 @@ - + &File @@ -37,7 +37,6 @@ - diff --git a/tables/tables.rc b/tables/tables.rc index 0fde1b6..5e0a68e 100644 --- a/tables/tables.rc +++ b/tables/tables.rc @@ -1,5 +1,5 @@ - + &File @@ -58,7 +58,6 @@ - diff --git a/words/part/words.rc b/words/part/words.rc index c4aa3f7..35ced73 100644 --- a/words/part/words.rc +++ b/words/part/words.rc @@ -1,4 +1,4 @@ - + &File @@ -47,7 +47,6 @@ - &Insert ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Remove Zoom-submenu from mainmenu?
On Thursday 26 May 2011 02:56:54 Sebastian Sauer wrote: > Hi, > > please see attached patch which removes the zoom-submenu from all Calligra > applications. The reason is that it's redundant with the zoom-menu we have > in the statusbar. > > Good idea or not? I think https://git.reviewboard.kde.org/r/101022/ is a better solution ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
