Re: Review Request: Changing from QMaps to QLists in createOptionWidgets()

2011-05-22 Thread Casper Boemann 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101384/#review3450
---


You are getting there :)



now pull the latest change and update your patch accordingly


libs/main/KoToolDocker.cpp


fix indentation



libs/main/KoToolDocker.cpp


fix indentation



libs/main/KoToolDocker.cpp


remove completely



plugins/artistictextshape/ArtisticTextTool.cpp


Please remove these spaces while you are touching the file anyway



plugins/defaultTools/connectionTool/ConnectionTool.cpp


fix indentation



plugins/defaultTools/guidestool/GuidesTool.cpp


fix indentation



plugins/defaultTools/guidestool/GuidesTool.cpp


no tabs please



plugins/defaultTools/guidestool/GuidesTool.cpp


fix indentation


- Casper


On May 21, 2011, 1:45 p.m., Samuel Buttigieg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101384/
> ---
> 
> (Updated May 21, 2011, 1:45 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> ---
> 
> As requested by boemann, this patch replaces all instances of QMaps used to 
> represent Widgets with QLists. Using QLists allows the widgets to be 
> displayed in the order you like them to.
> 
> 
> Diffs
> -
> 
>   braindump/plugins/stateshape/StateTool.h 7ab14cb 
>   braindump/plugins/stateshape/StateTool.cpp 79d7927 
>   braindump/plugins/webshape/WebTool.h 2998d09 
>   braindump/plugins/webshape/WebTool.cpp 44901ae 
>   karbon/plugins/tools/KarbonGradientTool.h bb87f8f 
>   karbon/plugins/tools/KarbonGradientTool.cpp 02718b0 
>   karbon/plugins/tools/KarbonPatternTool.h f9792a0 
>   karbon/plugins/tools/KarbonPatternTool.cpp 51e57dd 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.h a25b54e 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp 1d02cca 
>   karbon/ui/KarbonView.cpp 090490ea 
>   kpresenter/part/tools/animationtool/KPrAnimationTool.h 117bc61 
>   kpresenter/part/tools/animationtool/KPrAnimationTool.cpp 0a1b997 
>   krita/plugins/tools/defaulttools/kis_tool_path.h f57a1fa 
>   krita/plugins/tools/defaulttools/kis_tool_path.cc 80a31cf 
>   krita/plugins/tools/selectiontools/kis_tool_select_path.h 7bb8a14 
>   krita/plugins/tools/selectiontools/kis_tool_select_path.cc cd4c40d 
>   krita/ui/kis_view2.cpp 31d6d8f 
>   libs/flake/KoCanvasControllerWidget.h 384c928 
>   libs/flake/KoCanvasControllerWidget.cpp 47c4afb 
>   libs/flake/KoToolBase.h 860a77c 
>   libs/flake/KoToolBase.cpp 456587d 
>   libs/flake/KoToolBase_p.h 49bc2f9 
>   libs/flake/KoToolManager.cpp 3b6554a 
>   libs/flake/tools/KoCreatePathTool.h 325af3b 
>   libs/flake/tools/KoCreatePathTool.cpp ca8f373 
>   libs/flake/tools/KoPathTool.h bcd6d95 
>   libs/flake/tools/KoPathTool.cpp 7f94ce1 
>   libs/kopageapp/KoPAView.cpp c53edec 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h 17a83b2 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 0b16048 
>   libs/main/KoDockerManager.h 3ec84b9 
>   libs/main/KoDockerManager.cpp 93f1b3e 
>   libs/main/KoToolDocker.cpp c9aacce 
>   libs/main/KoToolDocker_p.h 3f965dd 
>   plugins/artistictextshape/ArtisticTextTool.h 0c5bc6b 
>   plugins/artistictextshape/ArtisticTextTool.cpp beb53f4 
>   plugins/defaultTools/connectionTool/ConnectionTool.h 09ece57 
>   plugins/defaultTools/connectionTool/ConnectionTool.cpp e0d4594 
>   plugins/defaultTools/defaulttool/DefaultTool.h 724798f 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp c9fb9ab 
>   plugins/defaultTools/guidestool/GuidesTool.h d8e2bf7 
>   plugins/defaultTools/guidestool/GuidesTool.cpp 2983562 
>   plugins/textshape/ReferencesTool.h cee93be 
>   plugins/textshape/ReferencesTool.cpp 11b2fa8 
>   plugins/textshape/ReviewTool.h c25d9aa 
>   plugins/textshape/ReviewTool.cpp d35cf18 
>   plugins/textshape/TextTool.h 8753e06 
>   plugins/textshape/TextTool.cpp 0a76eaf 
>   plugins/treeshape/TreeTool.h 0c8733c 
>   plugins/treeshape/TreeTool.cpp 5c26dc9 
>   tables/CMakeLists.txt b37f21c 
>   tables/part/View.cpp 82bbcbf 
>   tables/shape/TableTool.h 45a9ab1 
>   tables/shape/TableTool.cpp 1d54e92 
>   tables/ui/CellToolBase.h 1e85233 
>   tables/ui/CellToolBase.cpp 3557fb1 
>   words/part/KWGui.cpp 7ec4d16 
> 
> Diff: http://git.reviewboard.kde.org/r/101384/diff
> 
> 
> Testin

Review Request: Add libkundo2 to Calligra

2011-05-22 Thread Alexander Potashev 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101414/
---

Review request for Calligra.


Summary
---

kundo2 is a fork of Qt's Undo Framework (QUndoStack, QUndoView, ...).
It contains two bugfixes the are going to be available only in Qt 4.8:
https://qt.gitorious.org/qt/qt/merge_requests/1212
https://qt.gitorious.org/qt/qt/merge_requests/2610

To start using kundo2, one should port Calligra to it. This can be done
by adding target_link_libraries(... kundo2) into CMakeLists.txt files
for all modules from Calligra that use Qt Undo Framework, and by
switching from QUndo classes to KUndo2 classes.
(switching to KUndo2 classes can easily be done by using a script)
Script for forward and backward porting: 
https://github.com/aspotashev/libkundo2/blob/master/port-kundo2.sh

After Calligra starts requiring Qt 4.8+, this library can be removed,
because it has no advantages over Qt's Undo Framework 4.8.


Diffs
-

  libs/CMakeLists.txt 6179f0a 
  libs/kundo2/CMakeLists.txt PRE-CREATION 
  libs/kundo2/kundo2_export.h PRE-CREATION 
  libs/kundo2/kundo2command.h PRE-CREATION 
  libs/kundo2/kundo2group.h PRE-CREATION 
  libs/kundo2/kundo2group.cpp PRE-CREATION 
  libs/kundo2/kundo2model.h PRE-CREATION 
  libs/kundo2/kundo2model.cpp PRE-CREATION 
  libs/kundo2/kundo2qstack.h PRE-CREATION 
  libs/kundo2/kundo2stack.h PRE-CREATION 
  libs/kundo2/kundo2stack.cpp PRE-CREATION 
  libs/kundo2/kundo2stack_p.h PRE-CREATION 
  libs/kundo2/kundo2view.h PRE-CREATION 
  libs/kundo2/kundo2view.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101414/diff


Testing
---

It compiles.


Thanks,

Alexander

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Add target_link_libraries(... kundo2) to CMakeLists.txt files

2011-05-22 Thread Alexander Potashev 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101415/
---

Review request for Calligra.


Summary
---

Add target_link_libraries(... kundo2) to CMakeLists.txt files of all
modules of Calligra that use Qt's Undo Framework.


Requires https://git.reviewboard.kde.org/r/101414/


Diffs
-

  braindump/plugins/stateshape/CMakeLists.txt 72c38eb 
  braindump/plugins/webshape/CMakeLists.txt 5234f63 
  karbon/common/CMakeLists.txt e940d9f 
  karbon/plugins/flattenpath/CMakeLists.txt f83620b 
  karbon/plugins/refinepath/CMakeLists.txt caf6aa7 
  karbon/plugins/roundcorners/CMakeLists.txt 82b7159 
  karbon/plugins/tools/CMakeLists.txt 7e4aeb6 
  karbon/plugins/whirlpinch/CMakeLists.txt 2e920e2 
  karbon/ui/CMakeLists.txt 0773216 
  kexi/formeditor/CMakeLists.txt 0f48560 
  kexi/plugins/forms/CMakeLists.txt 8d9c2d8 
  kformula/CMakeLists.txt 8f46594 
  kformula/flake/CMakeLists.txt 5b3b7bc 
  kplato/CMakeLists.txt 605535f 
  kplato/libs/kernel/CMakeLists.txt 6dc30b1 
  kplato/libs/models/CMakeLists.txt ad9f50c 
  kplato/libs/ui/CMakeLists.txt 6d64c1c 
  kplato/workpackage/CMakeLists.txt b9ef576 
  kpresenter/part/CMakeLists.txt a2b01ee 
  kpresenter/plugins/eventactions/CMakeLists.txt e4810cd 
  krita/image/CMakeLists.txt 47d13c3 
  krita/plugins/extensions/dockers/historydocker/CMakeLists.txt 513dae3 
  krita/plugins/tools/tool_transform2/CMakeLists.txt fe93230 
  krita/ui/CMakeLists.txt 517adb6 
  libs/flake/CMakeLists.txt c2164b7 
  libs/kopageapp/CMakeLists.txt 4cdf024 
  libs/kopageapp/tools/backgroundTool/CMakeLists.txt ba1ddc3 
  libs/kotext/CMakeLists.txt bacba79 
  libs/main/CMakeLists.txt 55a71a3 
  libs/textlayout/CMakeLists.txt 4fb35c5 
  plugins/artistictextshape/CMakeLists.txt 638edac 
  plugins/chartshape/CMakeLists.txt 2daccfc 
  plugins/defaultTools/CMakeLists.txt 6c7f138 
  plugins/musicshape/CMakeLists.txt 3fa3d87 
  plugins/pathshapes/CMakeLists.txt e773367 
  plugins/pictureshape/CMakeLists.txt 373c589 
  plugins/textshape/CMakeLists.txt a583a2a 
  plugins/treeshape/CMakeLists.txt da0917d 
  plugins/vectorshape/CMakeLists.txt b629e7f 
  plugins/videoshape/CMakeLists.txt 697ed5b 
  tables/CMakeLists.txt a6445ba 
  tools/koabstraction/CMakeLists.txt f9b3882 
  words/part/CMakeLists.txt dd3b917 

Diff: http://git.reviewboard.kde.org/r/101415/diff


Testing
---

This cannot possibly break anything. Of course, if you have already applied 
https://git.reviewboard.kde.org/r/101414/


Thanks,

Alexander

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Usage of libkundo2 in Calligra (Qt's maximal dependency)

2011-05-22 Thread Alexander Potashev 
2011/5/16 Alexander Potashev :
> 2011/5/16 Boudewijn Rempt :
>> Yes, I agree that that is the way to go. We want nicely translatable undo 
>> messages.
>
> Ok, now I'm going to clean things up and create a review request.

Done.
1. https://git.reviewboard.kde.org/r/101414/
2. https://git.reviewboard.kde.org/r/101415/
3. https://git.reviewboard.kde.org/r/101416/


-- 
Alexander Potashev
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Season of KDE

2011-05-22 Thread Cyrille Berger Skott 
Hi Arunangshu,

>From the calligra side, I am affraid we have exhausted our mentoring 
possibility, and we could not provide you with adequate level of mentoring :(

On Saturday 21 May 2011, Arunangshu Bhakta wrote:
> Hi
> I would like to work for developing Amarok, DigiKam, CALLIGRA, SIMON and
> other KDE projects. I am having a hard time finding a mentor. Can somebody
> be my mentor for KDE project in the Season of KDE please?
> 
> Thanks
> Arunangshu
> freenode nick: xendras


-- 
Cyrille Berger Skott
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Windows compilation error

2011-05-22 Thread Pierre Stirnweiss 
While compiling on windows, i get the following error:


[  9%] Building CXX object
libs/main/CMakeFiles/komain.dir/KoRecentDocumentsPane.obj
KoRecentDocumentsPane.cpp
C:\Users\pierre\shared\Hacking\calligra\libs\main\KoRecentDocumentsPane.cpp(125)
: error C2665: 'KIO::filePreview' : none of the 2 overloads could convert
all the argument types
c:\kde\include\kio/previewjob.h(165): could be 'KIO::PreviewJob
*KIO::filePreview(const KFileItemList &,int,int,int,int,bool,bool,const
QStringList *)'
c:\kde\include\kio/previewjob.h(187): or   'KIO::PreviewJob
*KIO::filePreview(const KUrl::List &,int,int,int,int,bool,bool,const
QStringList *)'
while trying to match the argument list '(KFileItemList, QSize)'
NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~1.0\VC\bin\cl.exe' : return
code
'0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
10.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio
10.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.


I won't have much time to fix this before mid next week. And i'd like to
nail down the styles widget stuff in the little time i'll have then. So if
the corresponding author could look into this one, i'd be much gratefull.

Pierre
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel