Merge request of text layout restructuring
Hi Last week I worked on the text layout, and I'm now requesting a merge of the branch I worked in: text-layoutrestructure-boemann What I've done is moving the text runaround properties from the KWFrame class to KoShape Secondly I moved the runaround code from KWord to the TextShape. However it is still the responsibility of the application to supply the textshape with the relevant shapes. This was stepd 2-4 in my big 7 step master plan that I've talked to all words developers about. Please take a look, and comment. I've made basic testing and I'm rather confident that there are no regressions. Many unit test might be broken, and should be disabled for now. Review mainly requested from hanzes,pierreSt ,pinaraf, sebsauer, but also anyone else who think they have something to contribute. best regards Casper Best regards ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Rename the "table" shape to spreadsheet shape
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100299/ --- Review request for Calligra and Marijn Kruisselbrink. Summary --- As you can see in http://forum.kde.org/viewtopic.php?f=96&t=92343 the table shape is confused for a text table shape, while it is really a spreadsheet shape. I am suggesting we make it clear to the user that it is a spreadsheet shape. Diffs - tables/shape/TableShapeFactory.cpp 84b3901e76678f61483a5d7800a4d69889418835 Diff: http://git.reviewboard.kde.org/r/100299/diff Testing --- Thanks, Cyrille ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Rename the "table" shape to spreadsheet shape
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100299/#review721 --- Ship it! Agree - Marijn On 2011-01-03 21:04:36, Cyrille Berger Skott wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100299/ > --- > > (Updated 2011-01-03 21:04:36) > > > Review request for Calligra and Marijn Kruisselbrink. > > > Summary > --- > > As you can see in http://forum.kde.org/viewtopic.php?f=96&t=92343 the table > shape is confused for a text table shape, while it is really a spreadsheet > shape. I am suggesting we make it clear to the user that it is a spreadsheet > shape. > > > Diffs > - > > tables/shape/TableShapeFactory.cpp 84b3901e76678f61483a5d7800a4d69889418835 > > Diff: http://git.reviewboard.kde.org/r/100299/diff > > > Testing > --- > > > Thanks, > > Cyrille > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
