GNU make 3.80 build failure on FreeBSD 5

2003-01-28 Thread Gerald Pfeifer
GNU make 3.80 fails to build on FreeBSD 5:

  In file included from glob.c:282:
  glob.h:51: redefinition of `__size_t'
  /usr/include/machine/_types.h:86: `__size_t' previously declared here

This can be fixed by the patch below which Mike Barcroft
<[EMAIL PROTECTED]> contributed to the FreeBSD ports collection.

I would appreciate could you roll a new release of GNU make with
this (or a similar) fix rather sooner than later; thanks.

Gerald ([EMAIL PROTECTED][EMAIL PROTECTED])

--- glob/glob.h.origSat Jan 22 00:43:03 2000
+++ glob/glob.h Fri Aug 23 02:37:03 2002
@@ -47,6 +47,9 @@

 /* We need `size_t' for the following definitions.  */
 #ifndef __size_t
+#if defined __FreeBSD__
+#define __size_t size_t
+#else
 # if defined __GNUC__ && __GNUC__ >= 2
 typedef __SIZE_TYPE__ __size_t;
 # else
@@ -59,6 +62,7 @@
  */
 #if !(defined __DECC && defined __SIZE_T)
 typedef unsigned long int __size_t;
+#endif
 #endif
 # endif
 #else


___
Bug-make mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-make



Re: GNU make 3.80 build failure on FreeBSD 5

2003-01-28 Thread Paul D. Smith
%% Gerald Pfeifer <[EMAIL PROTECTED]> writes:

  gp> GNU make 3.80 fails to build on FreeBSD 5:
  gp>   In file included from glob.c:282:
  gp>   glob.h:51: redefinition of `__size_t'
  gp>   /usr/include/machine/_types.h:86: `__size_t' previously declared here

  gp> This can be fixed by the patch below which Mike Barcroft
  gp> <[EMAIL PROTECTED]> contributed to the FreeBSD ports collection.

  gp> I would appreciate could you roll a new release of GNU make with
  gp> this (or a similar) fix rather sooner than later; thanks.

I don't think there's any way that a GNU make release can be done for at
least another month or so: the CVS code is sort of in the middle of
things.

It would be good, when you find things like this, if you could file a
bug on the Savannah site (I get bugs from Debian, etc. that way too).

Question: is this change portable to previous versions of FreeBSD as
well?  You test just __FreeBSD__, which I assume is defined for 4.x,
etc.  versions as well, so I want to make sure that this section won't
cause breakage on older versions.

Thanks!

-- 
---
 Paul D. Smith <[EMAIL PROTECTED]>  Find some GNU make tips at:
 http://www.gnu.org  http://make.paulandlesley.org
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist


___
Bug-make mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-make



Re: GNU make 3.80 build failure on FreeBSD 5

2003-01-28 Thread Gerald Pfeifer
On Tue, 28 Jan 2003, Paul D. Smith wrote:
> I don't think there's any way that a GNU make release can be done for at
> least another month or so:

Well, that should be fine, thanks!  (I was more afraid that it might
take a year or so, more like to what we do in GCC-land. ;-) )

> It would be good, when you find things like this, if you could file a
> bug on the Savannah site (I get bugs from Debian, etc. that way too).

I will do that next time, thanks for the hint!

> Question: is this change portable to previous versions of FreeBSD as
> well?  You test just __FreeBSD__, which I assume is defined for 4.x,
> etc.  versions as well, so I want to make sure that this section won't
> cause breakage on older versions.

The patch is part of the FreeBSD ports tree, which means it is regularily
tested both on the latest version as well as 4.x; to be sure I just built
GNU make 3.80 plus this patch on FreeBSD 4.7 and everything worked fine.

Thanks again!
Gerald
-- 
Gerald "Jerry"   [EMAIL PROTECTED]   http://www.pfeifer.com/gerald/


___
Bug-make mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-make