Re: init patch

2003-01-22 Thread Alfred M. Szmidt
   >This patch allows the computer to reboot if the user does not enter
   >a value for the path to a server.
   > 
   > Didn't I post something similar a while back?

Humm, if you did I did find it in the archives.

Looks like something ate my mail.  This is what I posted:

2003-01-10  Alfred M. Szmidt  <[EMAIL PROTECTED]>

* init.c (start_child): Issue an error message (and loop forever)
if creating a console fails.

--- init.c.~1.129.~ 2002-05-08 16:02:18.0 +0200
+++ init.c  2003-01-10 23:20:57.0 +0100
@@ -1028,7 +1028,14 @@
err = argz_create ((char **) argv, &args, &arglen);
   }
 }
-  assert_perror (err);
+
+  if (err)
+{
+  error (0, err, "could not create a console");
+  /* Loop forever or untill someone presses the reboot button. */
+  for (;;)
+   ;
+}
 
   file = file_name_lookup (args, O_EXEC, 0);
   if (file == MACH_PORT_NULL)





___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: init: cannot reboot

2003-01-22 Thread Alfred M. Szmidt
I havn't followed this thread so I'm just shooting in the dark.  But
did you add the correct entries to /etc/ttys?



___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: init patch

2003-01-22 Thread James A Morrison

 These patches are unrelated.  One has to do with finding the initial
translators: proc, auth; the other, yours, has to do with initialization of
the system: runsystem.

 Make sense?

However, here is probably a better version of your patch, since it
uses crash_system().  Returning err, causes launch_something () to retry
start_child as it needs to and crashes the system if nothing works.

James A. Morrison

2003-01-22  James A. Morrison  <[EMAIL PROTECTED]>

* init.c (start_child): Return err on error.

Index: init.c
===
RCS file: /cvsroot/hurd/hurd/init/init.c,v
retrieving revision 1.129
diff -u -r1.129 init.c
--- init.c  8 May 2002 09:20:38 -   1.129
+++ init.c  22 Jan 2003 15:37:14 -
@@ -1,6 +1,6 @@
 /* Start and maintain hurd core servers and system run state
 
-   Copyright (C) 1993,94,95,96,97,98,99,2000,01,02
+   Copyright (C) 1993,94,95,96,97,98,99,2000,01,02,03
Free Software Foundation, Inc.
This file is part of the GNU Hurd.
 
@@ -1028,7 +1029,8 @@
err = argz_create ((char **) argv, &args, &arglen);
   }
 }
-  assert_perror (err);
+  if (err)
+return err;
 
   file = file_name_lookup (args, O_EXEC, 0);
   if (file == MACH_PORT_NULL)


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: init: cannot reboot

2003-01-22 Thread Lionel Elie Mamane
On Wed, Jan 22, 2003 at 03:35:31PM +0100, Alfred M. Szmidt wrote:

> I havn't followed this thread so I'm just shooting in the dark.  But
> did you add the correct entries to /etc/ttys?

tty1"/libexec/getty 38400"  hurdon  secure trusted console

and similar lines for tty2 to tty6.

Thanks for trying.

-- 
Lionel


msg06296/pgp0.pgp
Description: PGP signature
___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



oskit mach needs patch?

2003-01-22 Thread Derek L Davies

Hi,

I find I have have to apply the following patch to get the oskit mach
branch from the gnumach cvs module on subversions:

diff -u -r1.22.2.20 Makefile.in
--- Makefile.in 23 May 2002 06:36:21 -  1.22.2.20
+++ Makefile.in 22 Jan 2003 19:51:48 -
@@ -329,7 +329,7 @@

 kernel-%.o: $(OSKIT_LIBDIR)/multiboot.o $(objfiles) init-%.o
$(CC) $(CFLAGS) -nostdlib -nostartfiles $(LDFLAGS) -r -o $@ \
- -Wl,-\( $^ $(OSKIT_LIBS) -Wl,-\) -lgcc
+ -Wl,-\( $^ -L$(OSKIT_LIBDIR)/.. $(OSKIT_LIBS) -Wl,-\)
-lgcc
 ^L
 #
 # Installation


This seems like a resonable bug fix to me.  Do others need to to this
too?  Should I commit this fix?

Thanks,
Derek



___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



oskit mach needs patch?

2003-01-22 Thread Derek L Davies

Hi,

I find I have have to apply the following patch to get the oskit mach
branch from the gnumach cvs module on subversions:

diff -u -r1.22.2.20 Makefile.in
--- Makefile.in 23 May 2002 06:36:21 -  1.22.2.20
+++ Makefile.in 22 Jan 2003 19:51:48 -
@@ -329,7 +329,7 @@

 kernel-%.o: $(OSKIT_LIBDIR)/multiboot.o $(objfiles) init-%.o
$(CC) $(CFLAGS) -nostdlib -nostartfiles $(LDFLAGS) -r -o $@ \
- -Wl,-\( $^ $(OSKIT_LIBS) -Wl,-\) -lgcc
+ -Wl,-\( $^ -L$(OSKIT_LIBDIR)/.. $(OSKIT_LIBS) -Wl,-\)
-lgcc
 ^L
 #
 # Installation


This seems like a resonable bug fix to me.  Do others need to to this
too?  Should I commit this fix?

Thanks,
Derek



___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd



Re: oskit mach needs patch?

2003-01-22 Thread James Morrison

--- Derek L Davies <[EMAIL PROTECTED]> wrote:
> 
> Hi,
> 
> I find I have have to apply the following patch to get the oskit mach
> branch from the gnumach cvs module on subversions:
> 
> diff -u -r1.22.2.20 Makefile.in
> --- Makefile.in 23 May 2002 06:36:21 -  1.22.2.20
> +++ Makefile.in 22 Jan 2003 19:51:48 -
> @@ -329,7 +329,7 @@
> 
>  kernel-%.o: $(OSKIT_LIBDIR)/multiboot.o $(objfiles) init-%.o
> $(CC) $(CFLAGS) -nostdlib -nostartfiles $(LDFLAGS) -r -o $@ \
> - -Wl,-\( $^ $(OSKIT_LIBS) -Wl,-\) -lgcc
> + -Wl,-\( $^ -L$(OSKIT_LIBDIR)/.. $(OSKIT_LIBS) -Wl,-\)
> -lgcc
>  ^L
>  #
>  # Installation
> 
> 
> This seems like a resonable bug fix to me.  Do others need to to this
> too?  Should I commit this fix?
> 
> Thanks,
> Derek

 Why are you using version 1.22.2.20 whereas the version from head is 1.36.
jim@hurdtest:~/cvs/gnumach$ cvs status Makefile.in 
===
File: Makefile.in   Status: Up-to-date

   Working revision:1.36
   Repository revision: 1.36/cvsroot/hurd/gnumach/Makefile.in,v
   Sticky Tag:  (none)
   Sticky Date: (none)
   Sticky Options:  (none)

 Here is what the my Makefile.in looks like around line 329
kernel-%.o: $(OSKIT_LIBDIR)/multiboot.o $(objfiles) init-%.o
$(CC) $(CFLAGS) -nostdlib -nostartfiles $(LDFLAGS) -r -o $@ \
  -Wl,-\( $^ -L$(OSKIT_LIBDIR)/.. $(OSKIT_LIBS) -Wl,-\) -lgcc




=
James Morrison
   University of Waterloo
   Computer Science - Digital Hardware
   2B co-op
http://hurd.dyndns.org

Anyone referring to this as 'Open Source' shall be eaten by a GNU

__
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com


___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd