[Bug ld/32671] Default to erroring out on executable stacks

2025-02-10 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32671

--- Comment #4 from Nick Clifton  ---
I have no objections to changing the linker's default behaviour - as long as
the choice can be overridden by a configure time option so that distributions
that want the old behaviour can still obtain it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32671] Default to erroring out on executable stacks

2025-02-10 Thread freswa at archlinux dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32671

Frederik Schwan  changed:

   What|Removed |Added

 CC||freswa at archlinux dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread lh_mouse at 126 dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #3 from LIU Hao  ---
MSYS2 has upgraded their binutils since some days ago:
https://github.com/msys2/MINGW-packages/commit/830d2ccff7811106a3c4254599737c957f688b06

I haven't heard of such issues. It looks like that Wine requires .CRT to be
writeable, then how could MSVC executables start properly?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread mike at fireburn dot co.uk
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #5 from Mike Lothian  ---
Created attachment 15943
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15943&action=edit
64bit working regedit

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread mike at fireburn dot co.uk
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #4 from Mike Lothian  ---
Some do, some don't

Regedit for example doesn't

I'm attaching the 64bit binaries that work and don't work, it's the same with
the 32bit binaries

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread mike at fireburn dot co.uk
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #6 from Mike Lothian  ---
Created attachment 15944
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15944&action=edit
64bit broken regedit

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread lh_mouse at 126 dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #8 from LIU Hao  ---
After a glance at Wine RegEdit source, I feel that this is caused by delayimp.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread lh_mouse at 126 dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #9 from LIU Hao  ---
Yeah the MSVC delayimp facilities have code to temporarily unprotect the import
table before filling in those pointers; see 'C:\Program Files\Microsoft Visual
Studio\2022\Community\VC\Tools\MSVC\14.43.34808\include\delayhlp.cpp'.

So this should be a mingw-w64 bug. We have to do the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] New: Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread mike at fireburn dot co.uk
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

Bug ID: 32675
   Summary: Wine binaries built with binutils 2.44 no longer run
   Product: binutils
   Version: 2.44
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: ld
  Assignee: unassigned at sourceware dot org
  Reporter: mike at fireburn dot co.uk
  Target Milestone: ---

Removing ~/.wine and running winecfg
002c:fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"Microsoft.Windows.Common-Controls" (6.0.0.0)
002c:fixme:winediag:loader_init wine-staging 10.0 is a testing version
containing experimental patches.
002c:fixme:winediag:loader_init Please mention your exact version when filing
bug reports on winehq.org.
0044:fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"Microsoft.Windows.Common-Controls" (6.0.0.0)
wine: Unhandled page fault on write access to 000140021B30 at address
6FF36730 (thread 0044), starting debugger...
0044:err:seh:start_debugger Couldn't start debugger L"winedbg --auto 64 168"
(2)
Read the Wine Developers Guide on how to set up winedbg or another debugger
wine: Unhandled page fault on write access to 000140021940 at address
6FF36730 (thread 002c), starting debugger...
002c:err:seh:start_debugger Couldn't start debugger L"winedbg --auto 40 160"
(2)
Read the Wine Developers Guide on how to set up winedbg or another debugger
wine: could not load kernel32.dll, status c135

I bisected this back to:

ommit db00f6c3aceabbf03acdb69e74b59b2d2b043cd7
Author: Liu Hao 
Date:   Wed Nov 27 14:27:53 2024 +

PE LD: Merge .CRT .ctors and .dtors into .rdata

PR 32264

 bfd/peXXigen.c|   3 ++-
 ld/scripttempl/pe.sc  | 112
+++-
 ld/scripttempl/pep.sc | 111
+++
 ld/testsuite/ld-pe/aarch64.d  |  35
+--
 ld/testsuite/ld-pe/longsecn-1.d   |   7 +--
 ld/testsuite/ld-pe/longsecn-2.d   |   7 +--
 ld/testsuite/ld-pe/longsecn.d |   7 +--
 ld/testsuite/ld-pe/orphan.d   |   9 +
 ld/testsuite/ld-pe/orphan_nu.d|   9 +
 ld/testsuite/ld-pe/pdb2-section-contrib.d |   2 +-
 ld/testsuite/ld-pe/pe-aarch64.d   |  13 ++---
 ld/testsuite/ld-pe/secidx.d   |   6 +++---
 ld/testsuite/ld-pe/secidx_64.d|   4 ++--
 ld/testsuite/ld-pe/secidx_aarch64.d   |   4 ++--
 ld/testsuite/ld-pe/secrel.d   |   2 +-
 ld/testsuite/ld-pe/secrel_64.d|   4 ++--
 ld/testsuite/ld-pe/tlssec64.d |   2 +-
 17 files changed, 172 insertions(+), 165 deletions(-)

Reverting it and rebuilding wine fixes the issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread mike at fireburn dot co.uk
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

Mike Lothian  changed:

   What|Removed |Added

URL||https://bugs.winehq.org/sho
   ||w_bug.cgi?id=57819

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32264] For Windows,`.CRT` section should be merged into `.rdata`

2025-02-10 Thread mike at fireburn dot co.uk
https://sourceware.org/bugzilla/show_bug.cgi?id=32264

Mike Lothian  changed:

   What|Removed |Added

 CC||mike at fireburn dot co.uk

--- Comment #11 from Mike Lothian  ---
Hi

This patch has broken wine for me

https://sourceware.org/bugzilla/show_bug.cgi?id=32675
https://bugs.winehq.org/show_bug.cgi?id=57819

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread lh_mouse at 126 dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

LIU Hao  changed:

   What|Removed |Added

 CC||lh_mouse at 126 dot com

--- Comment #1 from LIU Hao  ---
Does the problematic program start properly on Windows?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32264] For Windows,`.CRT` section should be merged into `.rdata`

2025-02-10 Thread lh_mouse at 126 dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32264

--- Comment #12 from LIU Hao  ---
(In reply to Mike Lothian from comment #11)
> Hi
> 
> This patch has broken wine for me
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=32675
> https://bugs.winehq.org/show_bug.cgi?id=57819

I have commented on that PR:
https://sourceware.org/bugzilla/show_bug.cgi?id=32675#c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread mike at fireburn dot co.uk
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #2 from Mike Lothian  ---
No wine programs start, I can try and see if the internal programs from wine
start under windows

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread lh_mouse at 126 dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #7 from LIU Hao  ---
```
7FFA9AF3C81C 

[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread sam at gentoo dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

Sam James  changed:

   What|Removed |Added

URL|https://bugs.winehq.org/sho |
   |w_bug.cgi?id=57819  |
   See Also||https://bugs.winehq.org/sho
   ||w_bug.cgi?id=57819
 CC||sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread jacek at codeweavers dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

Jacek Caban  changed:

   What|Removed |Added

 CC||jacek at codeweavers dot com

--- Comment #10 from Jacek Caban  ---
There is likely a bug in Wine too. Wine generates delay-load importlibs on its
own using winebuild. Those importlibs use .idata$5, like regular IATs, but it
probably should use something like .didat$5, which would hopefully avoid the
merge.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread lh_mouse at 126 dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

--- Comment #11 from LIU Hao  ---
Please see the patch attached in
https://sourceforge.net/p/mingw-w64/mailman/message/59129001/

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32264] For Windows,`.CRT` section should be merged into `.rdata`

2025-02-10 Thread sam at gentoo dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32264

Sam James  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=32675

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/32675] Wine binaries built with binutils 2.44 no longer run

2025-02-10 Thread sam at gentoo dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32675

Sam James  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=32264

-- 
You are receiving this mail because:
You are on the CC list for the bug.