[Bug binutils/31735] [binutils, readelf] debug_str_offsets used, should use debug_str_offsets.dwo

2024-05-14 Thread vries at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31735

--- Comment #4 from Tom de Vries  ---
(In reply to Alan Modra from comment #3)
> Please apply your fix.

Thanks for the review.

I've also added a test-case, which made me realize I needed an additional fix
for readelf -wm (instead of readelf -w).

Submitted here: https://sourceware.org/pipermail/binutils/2024-May/134049.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/31734] [binutils, readelf] dwarf4 .debug_str_offsets section printed incorrectly

2024-05-14 Thread vries at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31734

--- Comment #4 from Tom de Vries  ---
(In reply to Alan Modra from comment #3)
> (In reply to Tom de Vries from comment #1)
> Please apply.

Thanks for the review.

Submitted with test-case here (
https://sourceware.org/pipermail/binutils/2024-May/134050.html ).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/31738] Improve objdump -p output of PE Import and Export Tables

2024-05-14 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31738

--- Comment #1 from Sourceware Commits  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4ac16d6607c045d2c4fa4b3712eb8f617af09e1b

commit 4ac16d6607c045d2c4fa4b3712eb8f617af09e1b
Author: Pali Roh?r 
Date:   Tue May 14 16:50:32 2024 +0100

Improve objdump -p output of PE Import and Export Tables

  PR 31738

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/31738] Improve objdump -p output of PE Import and Export Tables

2024-05-14 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=31738

Nick Clifton  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Nick Clifton  ---
Hi Pali,

  Thanks for the patch.  I agree that the output is better, so I have gone
  ahead and applied the change, although I did have to fix a couple of minor
  issues: 1) the patch would not build on 32-bit targets because there were
  a couple of places where it was trying to print out a 'long long' value
  using %lx and 2) the linker tests that use objdump -p on PE format files
  broke because of the new text.  I have corrected both of these issues in
  the version of the patch that was checked in.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/31738] Improve objdump -p output of PE Import and Export Tables

2024-05-14 Thread pali at kernel dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=31738

--- Comment #3 from Pali Rohár  ---
Ok, feel free to modify it. I used it for debugging bug #31728, bug #20814 and
bug #20880.

Anyway, how to run that one exclude-symbols-def-i386.d test case?
I can try to improve it, to validate both hint number and ordinal number.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/30139] Incorrect ordinal numbers for aliased symbols in DEF file

2024-05-14 Thread pali at kernel dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30139

Pali Rohár  changed:

   What|Removed |Added

 CC||nickc at redhat dot com

--- Comment #2 from Pali Rohár  ---
Some corrections.

By default (unless NONAME is not specified in def file), import library imports
symbol by name+hint (not by ordinal), .exe file imports by what is in import
library, hence in this case by name+hint too.

With recent changes in objdump (from bug #31738) to correctly shows ordinals
and hints, now for the example from the description it shows:

$ objdump -p test-ordinal.exe | grep -A 4 library.dll
DLL Name: library.dll
vma: Ordinal  Hint  Member-Name  Bound-To
83880002  function
83900001  function


So in the description of the bug report for provided example should have been
written that incorrect HINT number was generated.


Anyway, the problem is also for the exports by ordinals. Example is with the
same commands and files as in the bug description, just the symbol "function"
in the def file has "NONAME" keyword specified.

$ cat library.def
LIBRARY "library.dll"
EXPORTS
function @1 NONAME
alias NONAME == function

For this example the objdump prints:

objdump -p test-ordinal.exe | grep -A 4 library.dll
DLL Name: library.dll
vma: Ordinal  Hint  Member-Name  Bound-To
8388  2   
8390  1   


And this is a bug as in the def file there is no symbol with ordinal 2
specified. The application call / reference just the symbol "function" which
has ordinal number 1.

Wrong hint number is not a big issue (it just cause slower loading of
application as the PE loader has to scan whole export table). But wrong ordinal
number is a serious bug as it cause that application calls different function
than it should.

-- 
You are receiving this mail because:
You are on the CC list for the bug.