[Bug ld/31179] RISC-V: The SET/ADD/SUB fix breaks ABI compatibility with 2.41 objects

2023-12-25 Thread nelsonc1225 at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=31179

--- Comment #11 from Nelson Chu  ---

> So I think this is a roughly workable solution (maybe we should cache those
> tag lookups for performance, not sure if it matters).  It's going to be hard
> to tell for sure without some distro testing, though.
> 
> Does this pass the toolchain regressions?  If so, I think we should poke the
> distro folks (many of whom I guess who are here) to see if it's actually
> resolving their issues.

I get segment fault since forgot to define obj_attrs_handle_unknown.  But that
causes another problem for the tag - when we archiving multiple objects into
one by -r, then how to deal with that if some of them with the tag, and others
without the tag?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Issue 65018 in oss-fuzz: binutils:fuzz_objdump: Heap-buffer-overflow in loongarch_split_args_by_comma

2023-12-25 Thread sheriffbot via monorail
Updates:
Labels: -restrict-view-commit

Comment #3 on issue 65018 by sheriffbot: binutils:fuzz_objdump: 
Heap-buffer-overflow in loongarch_split_args_by_comma
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65018#c3

This bug has been fixed. It has been opened to the public.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

[Bug binutils/31191] New: objcopy leaves temporary files (and directories) in case of error

2023-12-25 Thread mooodyhunter at outlook dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=31191

Bug ID: 31191
   Summary: objcopy leaves temporary files (and directories) in
case of error
   Product: binutils
   Version: 2.42 (HEAD)
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: binutils
  Assignee: unassigned at sourceware dot org
  Reporter: mooodyhunter at outlook dot com
  Target Milestone: ---

In case of objdump errors with "symbol `.debug_info' required but not present"
when running "objcopy -R .debug_info ./libsomething.a", it leaves temporary
files in the folder.

---
$ objcopy -R .debug_info ./libgfortran.a
objcopy: ./stftlphn/unix.o: symbol `.debug_info' required but not present
objcopy: ./stftlphn/unix.o: no symbols
---

OBSERVED: ./stftlphn/unix.o exists.
EXPECTED: no left-over temporary files.

reading the source code reveals: 

1. objcopy.c, in copy_archive() around L3765, bfd_close is called but errored.
2. bfd_nonfatal_message is called and status set to 1
3. L3778, 3779: the bfd_close branch is taken, leaving l->obfd as NULL.
4. in cleanup_and_exit, if l->obfd is NULL, rmdir is called

(however l->name is a file, which leads to an ENOTDIR and the file is not
removed)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/31191] objcopy leaves temporary files (and directories) in case of error

2023-12-25 Thread mooodyhunter at outlook dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=31191

--- Comment #1 from Moody Liu  ---
the following patch fixes the issue, but I'm not sure what implication (or
side-effect) it has.


diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index b3c8d0f81ac8..c2f1b9421e4c 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3766,7 +3766,7 @@ copy_archive (bfd *ibfd, bfd *obfd, const char
*output_target,
{
  bfd_nonfatal_message (output_name, NULL, NULL, NULL);
  /* Error in new object file. Don't change archive.  */
- status = 1;
+ del = 1;
}

   if (del)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/31191] objcopy leaves temporary files (and directories) in case of error

2023-12-25 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=31191

Alan Modra  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|unassigned at sourceware dot org   |amodra at gmail dot com
   Last reconfirmed||2023-12-26
 Ever confirmed|0   |1

--- Comment #2 from Alan Modra  ---
Yes, that change looks good.  I'll fix the rmdir problem too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.