[Bug binutils/28917] ar: r does not replace objects specified multiple times on the command line

2022-03-16 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28917

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com

--- Comment #2 from Nick Clifton  ---
(In reply to Mike Frysinger from comment #1)
> ugh, this appears to be undocumented behavior.  i can't find anything in the
> man page or manual discussing this, and the commit history predates git.

Agreed.

Patch approved - please apply.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Re: ld-arm bug in encoding of blx calls jumping from thumb to arm instructions

2022-03-16 Thread Nick Clifton

Hi Jori,


We encountered a linking error in 11.1 and 11.2 of the ARM GNU Toolchain.


If this is a toolchain produced by ARM, then you really need to contact them,
not us.  If you can reproduce the problem using the GNU Binutils sources
directly, then please feel free to report the bug here:

 https://sourceware.org/bugzilla/enter_bug.cgi?product=binutils

Cheers
  Nick





[Bug ld/28924] ld-arm bug in encoding of blx calls jumping from thumb to arm instructions

2022-03-16 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28924

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com

--- Comment #1 from Nick Clifton  ---
(In reply to Jori Bomanson from comment #0)
Hi Jori,

> A small example for triggering this bug for the above toolchain is attached
> as "test.cpp".

Would it be possible for you to create a test case using assembler
source files, rather than C source files ?  The output from gcc tends
to be very sensitive to the version of the compiler being used, so 
attempts to reproduce the problem may not always work.  (Especially
if the reproducer does not wish to download and install the ARM GNU
Toolchain).


Also - have you tested this problem using the newly released 2.38
version of the binutils sources ?  It may be possible that this bug
has already been fixed...

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprof/28969] gprofng failed to build with GCC 6

2022-03-16 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28969

--- Comment #1 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by H.J. Lu :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c5edd3b8847f118bd022c473b126695fb39f6412

commit c5edd3b8847f118bd022c473b126695fb39f6412
Author: H.J. Lu 
Date:   Tue Mar 15 08:49:01 2022 -0700

gprofng: Define ATTRIBUTE_FALLTHROUGH

Define ATTRIBUTE_FALLTHROUGH to __attribute__ ((fallthrough)) only for
GCC 7 or above.

PR gprof/28969
* common/gp-defs.h (ATTRIBUTE_FALLTHROUGH): New.
* src/gp-collect-app.cc (collect::check_args): Replace
/* FALLTHROUGH */ with ATTRIBUTE_FALLTHROUGH.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprof/28969] gprofng failed to build with GCC 6

2022-03-16 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28969

--- Comment #3 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by H.J. Lu :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=61a1f2e71118206dd700fc1ddf244b2178bf6610

commit 61a1f2e71118206dd700fc1ddf244b2178bf6610
Author: H.J. Lu 
Date:   Tue Mar 15 08:56:39 2022 -0700

gprofng: Don't hardcode -Wno-format-truncation/-Wno-switch

Use -Wno-format-truncation and -Wno-switch only if they are supported.

PR gprof/28969
* configure.ac (GPROFNG_NO_FORMAT_TRUNCATION_CFLAGS): New
AC_SUBST for -Wno-format-truncation.
(GPROFNG_NO_SWITCH_CFLAGS): New AC_SUBST for -Wno-switch.
* Makefile.in: Regenerate.
* configure: Likewise.
* src/Makefile.am (AM_CFLAGS): Replace -Wno-format-truncation
and -Wno-switch with GPROFNG_NO_FORMAT_TRUNCATION_CFLAGS and
GPROFNG_NO_SWITCH_CFLAGS.
* src/Makefile.in: Regenerate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Re: size.exe

2022-03-16 Thread Nick Clifton

Hi Zane,

  Please could you file a bug report about this problem here:

https://sourceware.org/bugzilla/enter_bug.cgi?product=binutils

  When you do, please could answer the following questions as well:


Hi. I'm building binutils 2.38. When installing, it complains about being 
unable to find size.exe.


  Were there any error or warning messages when configuring
  or compiling the sources ?

  What is your target configuration ?
  Which other configuration options did you use (if any) ?
  What is your host system ?

  Is this a regression from compiling the binutils 2.37 sources ?



When I remove it from the Makefile, it just loops.


  How did you remove it from the Makefile ?

Cheers
  Nick




[Bug gprof/28969] gprofng failed to build with GCC 6

2022-03-16 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28969

H.J. Lu  changed:

   What|Removed |Added

   Target Milestone|--- |2.39
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from H.J. Lu  ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprof/28962] libcollector: Error: invalid attempt to declare external version name as default in symbol `posix_spawn@@GLIBC_2.15

2022-03-16 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28962

H.J. Lu  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from H.J. Lu  ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprof/28969] gprofng failed to build with GCC 6

2022-03-16 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28969

--- Comment #2 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by H.J. Lu :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a8b34706ef017a2032a78892a8595d36029f85a3

commit a8b34706ef017a2032a78892a8595d36029f85a3
Author: H.J. Lu 
Date:   Tue Mar 15 08:52:30 2022 -0700

gprofng: Don't hardcode -Wno-nonnull-compare

Use -Wno-nonnull-compare only if it is supported.

PR gprof/28969
* libcollector/Makefile.am (AM_CFLAGS): Replace
-Wno-nonnull-compare with GPROFNG_NO_NONNULL_COMPARE_CFLAGS.
* libcollector/configure.ac (GPROFNG_NO_NONNULL_COMPARE_CFLAGS):
New AC_SUBST for -Wno-nonnull-compare.
* libcollector/Makefile.in: Regenerate.
* libcollector/aclocal.m4: Likewise.
* libcollector/configure: Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28902] ld: `not found for insert` error has a weird ordering

2022-03-16 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28902

--- Comment #4 from Nick Clifton  ---
(In reply to Fangrui Song from comment #3)
Hi Fangrui,


> The order issue can be fixed by postponing the effects of INSERT after
> regular SECTIONS. Is it feasible?

Hmmm, maybe, but I would be very reluctant to try.  This feels like it
would create lots of new problems.  Given that one way works - even if
it is not the intuitive way - I would prefer to leave things as they
are and just document the behaviour.

If you want to create a patch to change the behaviour then please go
ahead, but I have said before, I think that updating the documentation
would be the safest way to go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprofng/28965] jsynprog tests failed on CET enabled x86-64 machines

2022-03-16 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28965

Nick Clifton  changed:

   What|Removed |Added

  Component|gprof   |gprofng
 CC||nickc at redhat dot com
   Assignee|unassigned at sourceware dot org   |vladimir.mezentsev at 
oracle dot c
   ||om

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprof/28962] libcollector: Error: invalid attempt to declare external version name as default in symbol `posix_spawn@@GLIBC_2.15

2022-03-16 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28962

--- Comment #3 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by H.J. Lu :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f4be26838dc9937a4ae3e9cf4fbec50efd7786a2

commit f4be26838dc9937a4ae3e9cf4fbec50efd7786a2
Author: H.J. Lu 
Date:   Mon Mar 14 14:46:25 2022 -0700

gprofng: Use symver attribute if available

Use symver attribute if available, instead of asm statement, to support
LTO build.

PR gprof/28962
* libcollector/dispatcher.c (timer_create@@GLIBC_2.3.3): Use
SYMVER_ATTRIBUTE.
(timer_create@GLIBC_2.2): Likewise.
(timer_create@GLIBC_2.2.5): Likewise.
(pthread_create@@GLIBC_2.1): Likewise.
(pthread_create@GLIBC_2.0): Likewise.
* libcollector/iotrace.c (open64@@GLIBC_2.2): Likewise.
(open64@GLIBC_2.1): Likewise.
(fopen@@GLIBC_2.1): Likewise.
(fopen@GLIBC_2.0): Likewise.
(fclose@@GLIBC_2.1): Likewise.
(fclose@GLIBC_2.0): Likewise.
(fdopen@@GLIBC_2.1): Likewise.
(fdopen@GLIBC_2.0): Likewise.
(pread@@GLIBC_2.2): Likewise.
(pread@GLIBC_2.1): Likewise.
(pwrite@@GLIBC_2.2): Likewise.
(pwrite@GLIBC_2.1): Likewise.
(pwrite64@@GLIBC_2.2): Likewise.
(pwrite64@GLIBC_2.1): Likewise.
(fgetpos@@GLIBC_2.2): Likewise.
(fgetpos@GLIBC_2.0): Likewise.
(fgetpos64@@GLIBC_2.2): Likewise.
(fgetpos64@GLIBC_2.1): Likewise.
(fsetpos@@GLIBC_2.2): Likewise.
(fsetpos@GLIBC_2.0): Likewise.
(fsetpos64@@GLIBC_2.2): Likewise.
(fsetpos64@GLIBC_2.1): Likewise.
* libcollector/linetrace.c (posix_spawn@@GLIBC_2.15): Likewise.
(posix_spawn@GLIBC_2.2): Likewise.
(posix_spawn@GLIBC_2.2.5): Likewise.
(posix_spawnp@@GLIBC_2.15): Likewise.
(posix_spawnp@GLIBC_2.2): Likewise.
(posix_spawnp@GLIBC_2.2.5): Likewise.
(popen@@GLIBC_2.1): Likewise.
(popen@GLIBC_2.0): Likewise.
(_popen@@GLIBC_2.1): Likewise.
(_popen@GLIBC_2.0): Likewise.
* libcollector/mmaptrace.c (dlopen@@GLIBC_2.1): Likewise.
(dlopen@GLIBC_2.0): Likewise.
* libcollector/synctrace.c (pthread_cond_wait@@GLIBC_2.3.2):
Likewise.
(pthread_cond_wait@GLIBC_2.0): Likewise.
(pthread_cond_wait@GLIBC_2.2.5): Likewise.
(pthread_cond_wait@GLIBC_2.2): Likewise.
(pthread_cond_timedwait@@GLIBC_2.3.2): Likewise.
(pthread_cond_timedwait@GLIBC_2.0): Likewise.
(pthread_cond_timedwait@GLIBC_2.2.5): Likewise.
(pthread_cond_timedwait@GLIBC_2.2): Likewise.
(sem_wait@@GLIBC_2.1): Likewise.
(sem_wait@GLIBC_2.0): Likewise.
* src/collector_module.h (SYMVER_ATTRIBUTE): New.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprofng/28968] gprofng doesn't build with -Werror=format-security

2022-03-16 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28968

Nick Clifton  changed:

   What|Removed |Added

  Component|gprof   |gprofng
 CC||nickc at redhat dot com
   Assignee|unassigned at sourceware dot org   |vladimir.mezentsev at 
oracle dot c
   ||om

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprofng/28966] gprofng test failures on Fedora 35

2022-03-16 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28966

Nick Clifton  changed:

   What|Removed |Added

   Assignee|unassigned at sourceware dot org   |vladimir.mezentsev at 
oracle dot c
   ||om
  Component|gprof   |gprofng
 CC||nickc at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28867] Mingw to generate bogus.o on French locale

2022-03-16 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28867

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com
   Last reconfirmed||2022-03-16
 Status|UNCONFIRMED |ASSIGNED
   Assignee|unassigned at sourceware dot org   |nickc at redhat dot com
 Ever confirmed|0   |1

--- Comment #1 from Nick Clifton  ---
(In reply to Eric Pouech from comment #0)
Hi Eric,


> after adding one letter to a string inside a .c program, compilation and
> link fails with:
> 
> /usr/lib/gcc/i686-w64-mingw32/11.2.1/../../../../i686-w64-mingw32/bin/ld:
> warning: dlls/dxdiagn/provider.cross.o: local symbol `�' has no section

Hmm, this looks like a buffer overrun problem to me...



> (the two first are generated with French locale)

I suspect that this problem is not specific to the French locale, it may
also happen with other locales too.  Not sure how significant this is at
the moment.


> - while fail.o generates the errors above

Please could you upload the fail.s and fail.o files ?


> (for the record the compiler invocation)
> 
> i686-w64-mingw32-gcc -c -o dlls/dxdiagn/container.cross.o
> /home/eric/work/wine-format/dlls/dxdiagn/container.c -Idlls/dxdiagn \
>   -I/home/eric/work/wine-format/dlls/dxdiagn -Iinclude
> -I/home/eric/work/wine-format/include \
>   -I/home/eric/work/wine-format/include/msvcrt -D__WINESRC__ -D_UCRT
> -D__WINE_PE_BUILD -Wall \
>   -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body
> -Wignored-qualifiers -Winit-self \
>   -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes
> -Wtype-limits \
>   -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith
> -Wlogical-op -Wabsolute-value \
>   -fno-omit-frame-pointer -gdwarf-4 -g -O2

Are you able to capture the linker command line that gcc invokes ?
If you can tell us that as well, it might help.


> binutils.x86_64   2.37-10.fc35  

Are you able to test with binutils 2.38 (available in rawhide) ?

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28885] dlltool broke in 2.38

2022-03-16 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28885

--- Comment #7 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d65c0d85645cab6f11fd711d21638a74489f

commit d65c0d85645cab6f11fd711d21638a74489f
Author: Martin Storsj? 
Date:   Wed Mar 16 15:01:30 2022 +

dlltool: Use the output name as basis for deterministic temp prefixes

PR 28885
* dlltool.c (main): use imp_name rather than dll_name when
generating a temporary file name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28867] Mingw to generate bogus.o on French locale

2022-03-16 Thread eric.pouech at orange dot fr
https://sourceware.org/bugzilla/show_bug.cgi?id=28867

--- Comment #2 from Eric Pouech  ---
Created attachment 14015
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14015&action=edit
fail.s file

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28867] Mingw to generate bogus.o on French locale

2022-03-16 Thread eric.pouech at orange dot fr
https://sourceware.org/bugzilla/show_bug.cgi?id=28867

--- Comment #3 from Eric Pouech  ---
Created attachment 14016
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14016&action=edit
fail.o file

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28867] Mingw to generate bogus.o on French locale

2022-03-16 Thread eric.pouech at orange dot fr
https://sourceware.org/bugzilla/show_bug.cgi?id=28867

--- Comment #4 from Eric Pouech  ---
Created attachment 14017
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14017&action=edit
good.s file

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28867] Mingw to generate bogus.o on French locale

2022-03-16 Thread eric.pouech at orange dot fr
https://sourceware.org/bugzilla/show_bug.cgi?id=28867

--- Comment #5 from Eric Pouech  ---
Created attachment 14018
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14018&action=edit
good.o file

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28924] ld-arm bug in encoding of blx calls jumping from thumb to arm instructions

2022-03-16 Thread viorel.preoteasa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28924

Viorel Preoteasa  changed:

   What|Removed |Added

 CC||viorel.preoteasa at gmail dot 
com

--- Comment #2 from Viorel Preoteasa  ---
Created attachment 14019
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14019&action=edit
Binary object file that reveals the bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28924] ld-arm bug in encoding of blx calls jumping from thumb to arm instructions

2022-03-16 Thread viorel.preoteasa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28924

--- Comment #3 from Viorel Preoteasa  ---
Created attachment 14020
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14020&action=edit
Disassembled erroneous file after linking the object file

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28924] ld-arm bug in encoding of blx calls jumping from thumb to arm instructions

2022-03-16 Thread viorel.preoteasa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28924

--- Comment #4 from Viorel Preoteasa  ---
Created attachment 14021
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14021&action=edit
Disassembled correct file after using the fixed ld

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28926] objcopy --weaken-symbol does not weaken STB_GNU_UNIQUE symbols

2022-03-16 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28926

--- Comment #2 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Fangrui Song :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=260ecdcec427146f760836092a040f957427760b

commit 260ecdcec427146f760836092a040f957427760b
Author: Fangrui Song 
Date:   Wed Mar 16 09:38:37 2022 -0700

objcopy --weaken-symbol: apply to STB_GNU_UNIQUE symbols

PR binutils/28926
* objcopy.c (filter_symbols): Apply weaken to STB_GNU_UNIQUE symbols
* NEWS: Mention feature.
* testsuite/binutils-all/objcopy.exp
(objcopy_test_symbol_manipulation): New test.
* testsuite/binutils-all/weaken-gnu-unique.s: New.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28926] objcopy --weaken-symbol does not weaken STB_GNU_UNIQUE symbols

2022-03-16 Thread i at maskray dot me
https://sourceware.org/bugzilla/show_bug.cgi?id=28926

Fangrui Song  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Fangrui Song  ---
Fixed for 2.39

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28924] ld-arm bug in encoding of blx calls jumping from thumb to arm instructions

2022-03-16 Thread viorel.preoteasa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28924

--- Comment #5 from Viorel Preoteasa  ---
The error occurs also in the master branch of binutils. The bug can be
reproduced applying ld 
compiled for arm using the following configuration:

export
CPPFLAGS=-I/home/viorel/arm-none-eabi-original/buildNative/prerequisites/zlib-1.2.11/include
-pipe
export
LDFLAGS=-L/home/viorel/arm-none-eabi-original/buildNative/prerequisites/zlib-1.2.11/lib

/home/viorel/arm-none-eabi-original/sources/binutils-master/configure \
  --build=x86_64-pc-linux-gnu \
  --host=x86_64-pc-linux-gnu \
  --with-python=yes \
  --target=arm-none-eabi \
  --prefix=/home/viorel/arm-none-eabi-original/installNative \
  --docdir=/home/viorel/arm-none-eabi-original/installNative/share/doc \
  --enable-lto \
  --enable-gold \
  --disable-werror CPPFLAGS=-UFORTIFY_SOURCE \
  --disable-gdb \
  --disable-sim \
  --disable-libdecnumber \
  --disable-readline \
  --disable-nls \
  --enable-plugins \
  --with-system-zlib \
  "--with-pkgversion=none-GCC-11.2.1-2022-03"

This assumes that zlib is compiled appropriately.

The binary object file (attached in zip format) must be linked using:

arm-none-eabi-ld test-ld.o -o test-ld.bin

And the result can be explored using:

arm-none-eabi-objdump -d test-ld.bin > test-ld.s

When using the unmodified master branch
(22546800ad34a5ac6bc90e6701de3e74bad75551), 
the resulting file test-ld.s contains on line 9 the following assembly
instruction:

8002:   f000 e800   blx 8004 

This is obviously a wrong jump, as it is in the middle of the current
instruction. 
The address 8004 is in the middle of current instruction "blx 8004".

The corrected ld applied to the same object file results in:

8002:   f000 e810   blx 8024 <___Z1fv_from_thumb>

The bug is in the file bfd/elf32-arm.c at lines:
#define THM_MAX_FWD_BRANCH_OFFSET  ((1 << 22) -2 + 4)
#define THM2_MAX_FWD_BRANCH_OFFSET (((1 << 24) - 2) + 4)

These must be replaced by:
#define THM_MAX_FWD_BRANCH_OFFSET  ((1 << 22) -4 + 4)
#define THM2_MAX_FWD_BRANCH_OFFSET (((1 << 24) - 4) + 4)

Next there is a diff file with these changes as well as with some explanations.

diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 616efe60..109c919d 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -2536,11 +2536,22 @@ static const bfd_vma elf32_arm_nacl_plt_entry [] =
   0xea00,  /* b.Lplt_tail  */
 };

+/* There was a bug due to too high values of THM_MAX_FWD_BRANCH_OFFSET and
+   THM2_MAX_FWD_BRANCH_OFFSET. The first macro concerns the case when Thumb-2
is
+   not available, and secod macro when Thumb-2 is available. Among other
things, they affect the range
+   of branches represented as blx instructions in Encoding T2 defined in
Section
+   A8.8.25 of the ARM Architecture Reference Manual ARMv7-A and ARMv7-R
+   edition issue C.d. Such branches are specified there to have a maximum
+   forward offset that is a multiple of 4. Previously, the respective values
+   defined here were multiples of 2 but not 4 and they are included in
comments
+   for reference. */
 #define ARM_MAX_FWD_BRANCH_OFFSET  1 << 23) - 1) << 2) + 8)
 #define ARM_MAX_BWD_BRANCH_OFFSET  ((-((1 << 23) << 2)) + 8)
-#define THM_MAX_FWD_BRANCH_OFFSET  ((1 << 22) -2 + 4)
+#define THM_MAX_FWD_BRANCH_OFFSET  ((1 << 22) - 4 + 4)
+/* #define THM_MAX_FWD_BRANCH_OFFSET  ((1 << 22) -2 + 4) */
 #define THM_MAX_BWD_BRANCH_OFFSET  (-(1 << 22) + 4)
-#define THM2_MAX_FWD_BRANCH_OFFSET (((1 << 24) - 2) + 4)
+#define THM2_MAX_FWD_BRANCH_OFFSET (((1 << 24) - 4) + 4)
+/* #define THM2_MAX_FWD_BRANCH_OFFSET (((1 << 24) - 2) + 4) */
 #define THM2_MAX_BWD_BRANCH_OFFSET (-(1 << 24) + 4)
 #define THM2_MAX_FWD_COND_BRANCH_OFFSET (((1 << 20) -2) + 4)
 #define THM2_MAX_BWD_COND_BRANCH_OFFSET (-(1 << 20) + 4)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gprofng/28972] New: gprofng libraries should be installed under $(pkglibdir)

2022-03-16 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28972

Bug ID: 28972
   Summary: gprofng libraries should be installed under
$(pkglibdir)
   Product: binutils
   Version: 2.39 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: gprofng
  Assignee: vladimir.mezentsev at oracle dot com
  Reporter: hjl.tools at gmail dot com
  Target Milestone: ---

Currently gprofng libraries are installed under $(libdir).  I
believe that they should be installed under $(pkglibdir).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28867] Mingw to generate bogus.o on French locale

2022-03-16 Thread eric.pouech at orange dot fr
https://sourceware.org/bugzilla/show_bug.cgi?id=28867

--- Comment #6 from Eric Pouech  ---
command line for linking:

Note1: winegcc is Wine's gcc wrapper for generating the compilation/build
operations. Here it's use is for linking a DLL, we need to generate some PE
fields (like export table...). Using -v -v to winegcc will pass -v to other
tools)
Note2: trace below regenerated today by replacing the container.cross.o file
with the fail.o (and which still generates the problem; same output as before)
(hoping that options didn't change in between)

[eric:~/work/wine-format/build32 dlls-user32-tests-win.c-enable]$
/home/eric/work/wine-format/build64/tools/winegcc/winegcc -v -v -o
dlls/dxdiagn/dxdiagn.dll --wine-objdir . --winebuild \
  /home/eric/work/wine-format/build64/tools/winebuild/winebuild -b
i686-w64-mingw32 \
  --lib-suffix=.cross.a -Wl,--wine-builtin -shared \
  /home/eric/work/wine-format/dlls/dxdiagn/dxdiagn.spec -mno-cygwin
dlls/dxdiagn/container.cross.o \
  dlls/dxdiagn/dxdiag_main.cross.o dlls/dxdiagn/provider.cross.o
dlls/dxdiagn/dxdiagn.res \
  dlls/dxdiagn/dxdiagn_r.res libs/strmiids/libstrmiids.cross.a
libs/dxguid/libdxguid.cross.a \
  libs/uuid/libuuid.cross.a dlls/d3d9/libd3d9.cross.a
dlls/ddraw/libddraw.cross.a \
  dlls/dsound/libdsound.cross.a dlls/version/libversion.cross.a
dlls/ole32/libole32.cross.a \
  dlls/oleaut32/liboleaut32.cross.a dlls/user32/libuser32.cross.a
dlls/advapi32/libadvapi32.cross.a \
  dlls/winecrt0/libwinecrt0.cross.a dlls/ucrtbase/libucrtbase.cross.a \
  dlls/kernel32/libkernel32.cross.a dlls/ntdll/libntdll.cross.a
/home/eric/work/wine-format/build64/tools/winebuild/winebuild -v --target
i686-w64-mingw32 -mno-cygwin -fno-asynchronous-unwind-tables
--cc-cmd=/usr/bin/i686-w64-mingw32-gcc --dll -o dxdiagn.dll-62327dc4.spec.o -E
/home/eric/work/wine-format/dlls/dxdiagn/dxdiagn.spec -L./dlls
-rdlls/dxdiagn/dxdiagn.res -rdlls/dxdiagn/dxdiagn_r.res --
dlls/dxdiagn/container.cross.o dlls/dxdiagn/dxdiag_main.cross.o
dlls/dxdiagn/provider.cross.o libs/strmiids/libstrmiids.cross.a
libs/dxguid/libdxguid.cross.a libs/uuid/libuuid.cross.a
dlls/d3d9/libd3d9.cross.a dlls/ddraw/libddraw.cross.a
dlls/dsound/libdsound.cross.a dlls/version/libversion.cross.a
dlls/ole32/libole32.cross.a dlls/oleaut32/liboleaut32.cross.a
dlls/user32/libuser32.cross.a dlls/advapi32/libadvapi32.cross.a
dlls/winecrt0/libwinecrt0.cross.a dlls/ucrtbase/libucrtbase.cross.a
dlls/kernel32/libkernel32.cross.a dlls/ntdll/libntdll.cross.a
/usr/bin/i686-w64-mingw32-gcc -xassembler -c -o dxdiagn.dll-62327dc4.spec.o
dxdiagn.dll-62327dc4.spec-62327dc5.s
Creating file try_link-c464fb88.c
/usr/bin/i686-w64-mingw32-gcc -o try_link-2697794c.out
-Wl,--file-alignment,0x1000 try_link-c464fb88.c
Using built-in specs.
COLLECT_GCC=/usr/bin/i686-w64-mingw32-gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/i686-w64-mingw32/11.2.1/lto-wrapper
Target: i686-w64-mingw32
Configured with: ../configure --prefix=/usr --bindir=/usr/bin
--includedir=/usr/include --mandir=/usr/share/man --infodir=/usr/share/info
--datadir=/usr/share --build=x86_64-redhat-linux-gnu
--host=x86_64-redhat-linux-gnu --with-gnu-as --with-gnu-ld --verbose
--without-newlib --disable-multilib --disable-plugin --with-system-zlib
--disable-nls --without-included-gettext --disable-win32-registry
--enable-languages=c,c++,objc,obj-c++,fortran
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-threads=posix
--with-isl --enable-libgomp --target=i686-w64-mingw32
--with-sysroot=/usr/i686-w64-mingw32/sys-root
--with-gxx-include-dir=/usr/i686-w64-mingw32/sys-root/mingw/include/c++
--disable-sjlj-exceptions --with-dwarf2
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.2.1 20210728 (Fedora MinGW 11.2.1-3.fc35) (GCC) 
COMPILER_PATH=/usr/libexec/gcc/i686-w64-mingw32/11.2.1/:/usr/libexec/gcc/i686-w64-mingw32/11.2.1/:/usr/libexec/gcc/i686-w64-mingw32/:/usr/lib/gcc/i686-w64-mingw32/11.2.1/:/usr/lib/gcc/i686-w64-mingw32/:/usr/lib/gcc/i686-w64-mingw32/11.2.1/../../../../i686-w64-mingw32/bin/
LIBRARY_PATH=/usr/lib/gcc/i686-w64-mingw32/11.2.1/:/usr/lib/gcc/i686-w64-mingw32/11.2.1/../../../../i686-w64-mingw32/lib/../lib/:/usr/i686-w64-mingw32/sys-root/mingw/lib/../lib/:/usr/lib/gcc/i686-w64-mingw32/11.2.1/../../../../i686-w64-mingw32/lib/:/usr/i686-w64-mingw32/sys-root/mingw/lib/
COLLECT_GCC_OPTIONS='-v' '-shared' '-nodefaultlibs' '-nostartfiles' '-o'
'dlls/dxdiagn/dxdiagn.dll' '-L./dlls' '-mtune=generic' '-march=pentiumpro'
'-dumpdir' 'dlls/dxdiagn/dxdiagn.dll.'
 /usr/libexec/gcc/i686-w64-mingw32/11.2.1/collect2 -plugin
/usr/libexec/gcc/i686-w64-mingw32/11.2.1/liblto_plugin.so
-plugin-opt=/usr/libexec/gcc/i686-w64-mingw32/11.2.1/lto-wrapper
-plugin-opt=-fresolution=/tmp/cclbDUZD.res
--sysroot=/usr/i686-w64-mingw32/sys-root -m i386pe --shared -Bdynamic -e
_DllMainCRTStartup@12 --enable-auto-image-base -o dlls/dxdiagn/dxdiagn.dll
-L./dlls -L/usr/lib/gcc/i686-w64-mingw32/11.2.1
-L/usr/lib/gcc/i686-w64-mingw32/11.2.1/../../../../i686-w64-mingw32/lib/../lib
-

Issue 42662 in oss-fuzz: binutils:fuzz_disas_ext-bfd_arch_arm: Index-out-of-bounds in print_insn_thumb32

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 42662 by sheriffbot: binutils:fuzz_disas_ext-bfd_arch_arm: 
Index-out-of-bounds in print_insn_thumb32
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42662#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 42630 in oss-fuzz: binutils:fuzz_objdump_safe: Out-of-memory in fuzz_objdump_safe

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 42630 by sheriffbot: binutils:fuzz_objdump_safe: 
Out-of-memory in fuzz_objdump_safe
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42630#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 42817 in oss-fuzz: binutils:fuzz_as: Stack-overflow in expr

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 42817 by sheriffbot: binutils:fuzz_as: Stack-overflow in 
expr
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42817#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 42740 in oss-fuzz: binutils:fuzz_addr2line: Heap-buffer-overflow in bfd_getl16

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 42740 by sheriffbot: binutils:fuzz_addr2line: 
Heap-buffer-overflow in bfd_getl16
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42740#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 42639 in oss-fuzz: binutils:fuzz_bfd: Heap-buffer-overflow in bfd_getl32

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 42639 by sheriffbot: binutils:fuzz_bfd: 
Heap-buffer-overflow in bfd_getl32
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42639#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

[Bug binutils/28791] [z80-unknown-elf-as]: new unexpected overflow warning in v2.37

2022-03-16 Thread petemoore at gmx dot net
https://sourceware.org/bugzilla/show_bug.cgi?id=28791

Pete Moore  changed:

   What|Removed |Added

 CC||nickc at redhat dot com

--- Comment #5 from Pete Moore  ---
Since the commit above is the one that introduced the bug - should it be
reverted?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Issue 42254 in oss-fuzz: binutils:fuzz_bfd: Out-of-memory in fuzz_bfd

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: -restrict-view-commit -deadline-approaching Deadline-Exceeded

Comment #3 on issue 42254 by sheriffbot: binutils:fuzz_bfd: Out-of-memory in 
fuzz_bfd
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42254#c3

This bug has exceeded our disclosure deadline. It has been opened to the public.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 42311 in oss-fuzz: binutils:fuzz_as: Abrt in _obstack_free

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: -restrict-view-commit -deadline-approaching Deadline-Exceeded

Comment #3 on issue 42311 by sheriffbot: binutils:fuzz_as: Abrt in _obstack_free
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42311#c3

This bug has exceeded our disclosure deadline. It has been opened to the public.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 42739 in oss-fuzz: binutils:fuzz_dwarf: Indirect-leak in _objalloc_alloc

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 42739 by sheriffbot: binutils:fuzz_dwarf: Indirect-leak in 
_objalloc_alloc
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42739#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 42668 in oss-fuzz: binutils:fuzz_addr2line: Heap-buffer-overflow in bfd_getl32

2022-03-16 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 42668 by sheriffbot: binutils:fuzz_addr2line: 
Heap-buffer-overflow in bfd_getl32
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42668#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

[Bug ld/28973] New: Improve error message for missing vtable

2022-03-16 Thread eyalroz1 at gmx dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=28973

Bug ID: 28973
   Summary: Improve error message for missing vtable
   Product: binutils
   Version: 2.35.2
Status: UNCONFIRMED
  Severity: minor
  Priority: P2
 Component: ld
  Assignee: unassigned at sourceware dot org
  Reporter: eyalroz1 at gmx dot com
  Target Milestone: ---

Related GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42540

If we write the following program:
```
struct A {
virtual void foo() { }
};

struct B : A {
void foo() override;
};

int main() {
B b;
}
```
it compiles, but fails to link:
```
:10: undefined reference to `vtable for B'
```
(see https://godbolt.org/z/Mzx3c7354)

Now, the reason the vtable is missing is that the C++ ABI (for x86_64?)
dictates that the vtable be defined in the object file which defines the "key
function" - the first non-pure, non-inline virtual member function of the
class. In this case, it's `B::foo()`.

The error message GNU ld emits is not useful enough. It should let the user
know _why_ the vtable is undefined - as the user her/himself is not supposed to
have provided a vtable; it's something else that's the problem with what they
wrote. So the message should be something like:

"undefined reference to the virtual method table for class `B`. This is due to
no object having defined the first virtual method in class `B` which isn't
inline nor pure-virtual".

or if somehow the linker can figure it out:

"undefined reference to the virtual method table for class `B`, due to
`B::foo()` being undefined"

(Obviously, the suggested wording is just a suggestion, the point is to impart
the relevant information.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.