[Bug binutils/27672] Fix quirky size output in readelf symbol tables

2021-04-08 Thread nick.lott at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=27672

--- Comment #5 from Nick Lott  ---
(In reply to Nick Clifton from comment #4)

> If you do not have an assignment, but are willing to create one, then
> please copy the email template here, fill it out and send it off:
> 
Done. Will let you know when I have an assignment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27551] The default encoding of the strings utility does not conform to POSIX: should honor the current locale.

2021-04-08 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=27551

--- Comment #5 from Nick Clifton  ---
(In reply to Vincent Lefèvre from comment #2)

> "-e S" does not work with UTF-8, where I get a lot of binary data.

Strange - it worked for me.

> I think that the correct solution is to use isprint(), which automatically
> honors the current locale if

I tried changing the STRING_ISGRAPHIC macro definition in strings.c to:

  #define STRING_ISGRAPHIC(c) \
   (iswspace (c) ? include_all_whitespace : iswprint (c))

But this fails to work in my test environment.  I have no idea why though.

Do you have a suggested patch which would fix the problem ?

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27551] The default encoding of the strings utility does not conform to POSIX: should honor the current locale.

2021-04-08 Thread sch...@linux-m68k.org
https://sourceware.org/bugzilla/show_bug.cgi?id=27551

--- Comment #6 from Andreas Schwab  ---
The isw* functions work on wide characters, not multi-byte characters.  You
first have to convert the string of multi-byte characters to wide characters.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27708] strip mishandles padding between notes

2021-04-08 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=27708

H.J. Lu  changed:

   What|Removed |Added

 CC||hjl.tools at gmail dot com

--- Comment #1 from H.J. Lu  ---
A patch is posted at

https://sourceware.org/pipermail/binutils/2021-April/116068.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27551] The default encoding of the strings utility does not conform to POSIX: should honor the current locale.

2021-04-08 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=27551

Nick Clifton  changed:

   What|Removed |Added

  Attachment #13356|0   |1
is obsolete||

--- Comment #7 from Nick Clifton  ---
Created attachment 13357
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13357&action=edit
Proposed patch

Hi Guys,

  Ah - thanks for the hint.  OK, please can somebody try out this patch and see
if it works any better.  It does cause a regression in the binutils testsuite,
which I have yet to investigate, but I think that it is heading in the right
direction.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27551] The default encoding of the strings utility does not conform to POSIX: should honor the current locale.

2021-04-08 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=27551

--- Comment #8 from Nick Clifton  ---
Created attachment 13358
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13358&action=edit
Proposed patch

Found the cause of the testsuite failure, so here is a revised (version 3)
patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27551] The default encoding of the strings utility does not conform to POSIX: should honor the current locale.

2021-04-08 Thread vincent-srcware at vinc17 dot net
https://sourceware.org/bugzilla/show_bug.cgi?id=27551

--- Comment #9 from Vincent Lefèvre  ---
(In reply to Nick Clifton from comment #8)
> Found the cause of the testsuite failure, so here is a revised (version 3)
> patch.

Like with "-e S", I get binary data:

zira% echo $LC_CTYPE
C.UTF-8
zira% printf "\300\300\300\300" | ./strings | hd
  c0 c0 c0 c0 0a|.|
0005
zira% printf "\300\300\300\300" | ./strings | iconv
iconv: illegal input sequence at position 0

On this example, the output of "strings" should be empty.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27551] The default encoding of the strings utility does not conform to POSIX: should honor the current locale.

2021-04-08 Thread vincent-srcware at vinc17 dot net
https://sourceware.org/bugzilla/show_bug.cgi?id=27551

--- Comment #10 from Vincent Lefèvre  ---
The bug is that:

  if (encoding == 's')
buf[0] = c & 0x7f;

So the byte 0xc0 gets changed to 0x40, which is printable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27551] The default encoding of the strings utility does not conform to POSIX: should honor the current locale.

2021-04-08 Thread vincent-srcware at vinc17 dot net
https://sourceware.org/bugzilla/show_bug.cgi?id=27551

--- Comment #11 from Vincent Lefèvre  ---
But even when removing this test, keeping the "else", c is always 1-byte long,
so that non-ASCII characters are always regarded as non-printable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug libctf/27360] libctf.so.0: undefined symbol: bsearch_r

2021-04-08 Thread toolybird at tuta dot io
https://sourceware.org/bugzilla/show_bug.cgi?id=27360

Toolybird  changed:

   What|Removed |Added

 CC||toolybird at tuta dot io

--- Comment #10 from Toolybird  ---
Not the OP, but this is still failing on current trunk.

Observation:
After the offending commit, libtool now wants to relink during install. This
never happened previously.

Therefore the bug is tickled only during a libtool relink and only when libctf
is compiled with -fno-plt (or linked with -Wl,-z,now).

-- 
You are receiving this mail because:
You are on the CC list for the bug.