[Bug binutils/26595] objdump/readelf debuginfod client not invoked for altdebug dwz file

2020-09-11 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=26595

--- Comment #6 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ce139cd560dcb85b09d4d257ac67ebffdf215859

commit ce139cd560dcb85b09d4d257ac67ebffdf215859
Author: Nick Clifton 
Date:   Fri Sep 11 13:30:38 2020 +0100

Fix the debuglink following code to recursively load links found in the
newly loaded debug info.

PR 26595
* dwarf.c (load_separate_debug_info): Return NULL rather than
FALSE in error situations.
(load_separate_debug_file): Move code to load debug links to ...
(check_for_and_load_links): ... here.  New function.  Load
separate debug information pointed to by debuglink and
debugaltlink sections.  Recursively scan newly loaded debug
information for more links and load them too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/26595] objdump/readelf debuginfod client not invoked for altdebug dwz file

2020-09-11 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=26595

Nick Clifton  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #7 from Nick Clifton  ---
Hi Ben, Hi Frank,

  Right - I have applied the patch to the mainline sources.

  I should note that there is still a case that fails.  If the newly
  loaded debug information contains a .debug_info section with a 
  DW_AT-dwo_name tag, that file will not be loaded.  Ie the patched
  code only recurses through .gnu_debuglink and .gnu_debugaltlink 
  sections.

  Handling a second level DWO_name tag would mean a lot more reworking of
  the code in dwarf.c, so I have left it for now.  If it turns out
  that this situation can arise in real life then please let me know
  (and provide an example) so that I can investigate further.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/26378] [2.35 regression] incorrect WAX section flags in linker output

2020-09-11 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=26378

--- Comment #7 from Alan Modra  ---
Your script made it NOLOAD, which for ELF means a bss style section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/26378] [2.35 regression] incorrect WAX section flags in linker output

2020-09-11 Thread i at maskray dot me
https://sourceware.org/bugzilla/show_bug.cgi?id=26378

--- Comment #8 from Fangrui Song  ---
(In reply to Alan Modra from comment #7)
> Your script made it NOLOAD, which for ELF means a bss style section.

I think the only hard requirement is the section type: SHT_NOBITS, not the
section flag: SHF_WRITE.

The documentation raises an example with a section named 'ROM':
https://sourceware.org/binutils/docs/ld/Output-Section-Type.html
One would not consider 'ROM' writable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/26588] enable-reloc-section on .exe with no exported symbols causes segfault if requested to create implib

2020-09-11 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=26588

--- Comment #3 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9cdc5bacddc3776a455cc918e034b01dfb31c75b

commit 9cdc5bacddc3776a455cc918e034b01dfb31c75b
Author: Jeremy Drake 
Date:   Fri Sep 11 17:51:16 2020 +0100

Fix a segfault when creating an import library with 0 exports.

PR 26588
* emultempl/pe.em (_finish): Only generate a import library if not
exporting relocs.
* emultempl/pep.em: Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/26588] enable-reloc-section on .exe with no exported symbols causes segfault if requested to create implib

2020-09-11 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=26588

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Nick Clifton  ---
Hi Jeremy,

  Thanks for reporting this problem, and providing a patch to fix.
  (Also please accept my apologies for not repsonding sooner).

  Anyway I have now checked in your patch, so this issue should be resolved.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/17321] add --enable-reloc-section option to generate proper relocation sections to .exes

2020-09-11 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=17321
Bug 17321 depends on bug 26588, which changed state.

Bug 26588 Summary: enable-reloc-section on .exe with no exported symbols causes 
segfault if requested to create implib
https://sourceware.org/bugzilla/show_bug.cgi?id=26588

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/19011] Issues with ld on mingw-w64 and bad defaults

2020-09-11 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=19011
Bug 19011 depends on bug 26588, which changed state.

Bug 26588 Summary: enable-reloc-section on .exe with no exported symbols causes 
segfault if requested to create implib
https://sourceware.org/bugzilla/show_bug.cgi?id=26588

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/26588] enable-reloc-section on .exe with no exported symbols causes segfault if requested to create implib

2020-09-11 Thread sourceware-bugzilla at jdrake dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=26588

--- Comment #5 from sourceware-bugzilla at jdrake dot com ---
Thanks.

I am confused by your ChangeLog text: "Only generate a import library if not
exporting relocs."  Perhaps should be more like "Only generate an import
library if exporting symbols."

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/26378] [2.35 regression] incorrect WAX section flags in linker output

2020-09-11 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=26378

--- Comment #9 from Alan Modra  ---
Yes, noload behaviour does not match the documentation.  Worse, noload has
evolved to mean different things depending on object file format.  See
https://sourceware.org/pipermail/binutils/2010-September/068723.html and other
messages in that and following months with the subject "SEC_NEVER_LOAD
cleanup".

As far as the SHF_WRITE flag goes, that is of course the normal thing for bss
style sections.  I do understand why you might want a bss style .plt read-only
(with ld.so flipping page protection bits to write and initialise the contents)
so I'm not saying ld can't change, just explaining the current situation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/26378] sections initialised only by linker scripts are always read/write

2020-09-11 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=26378

Alan Modra  changed:

   What|Removed |Added

Summary|[2.35 regression] incorrect |sections initialised only
   |WAX section flags in linker |by linker scripts are
   |output  |always read/write

-- 
You are receiving this mail because:
You are on the CC list for the bug.