[Bug gas/25633] New: z80: [PATCH] Fix unsupported register registration

2020-03-05 Thread sergey.belyashov at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25633

Bug ID: 25633
   Summary: z80: [PATCH] Fix unsupported register registration
   Product: binutils
   Version: unspecified
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: gas
  Assignee: unassigned at sourceware dot org
  Reporter: sergey.belyashov at gmail dot com
  Target Milestone: ---

Created attachment 12349
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12349&action=edit
Fix unsupported register registration

Fix registration of unsupported by target CPU registers.
Simplify z80.exp testsuit file. Now test are globbered by mask *.d.
Remove invalid information about Z80 CPU features in built-in help.

GBZ80 have no support for registers I, IX*, IY*, R, and MB; Z180 have no
support for IXL, IXH, IYL, IYH, and MB... Now all these names can be used for
generic symbols.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25570] [ld] Duplicate "warning: changing start of section"

2020-03-05 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25570

--- Comment #8 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Alan Modra :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=92d4b13bf378f575cdc796ec9340c12267b7eff1

commit 92d4b13bf378f575cdc796ec9340c12267b7eff1
Author: Alan Modra 
Date:   Thu Mar 5 21:34:23 2020 +1030

Reduce --warn-section-align output

PR 25570
* ldlang.c (lang_size_sections_1): Don't report changes on
second and subsequent iterations that make no change in
alignment from that already reported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gold/25636] New: gold generates unnecessary PLT entries for C++ virtual functions in shared libraries

2020-03-05 Thread jchl at arista dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25636

Bug ID: 25636
   Summary: gold generates unnecessary PLT entries for C++ virtual
functions in shared libraries
   Product: binutils
   Version: 2.27
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: gold
  Assignee: ccoutant at gmail dot com
  Reporter: jchl at arista dot com
CC: ian at airs dot com
  Target Milestone: ---

For a C++ virtual function defined in a shared library, but not called from
within that shared library, gold generates a unnecessary PLT entry.  This PLT
entry is not generated by ld.bfd.

Here's a minimal repro scenario.

$ cat test.cpp
class Test {
   virtual void f();
};

void Test::f() {}

$ g++ -fuse-ld=bfd -shared -fPIC -o libTest.so.bfd test.cpp
$ g++ -fuse-ld=gold -shared -fPIC -o libTest.so.gold test.cpp
$ objdump -R --demangle libTest.so.bfd

libTest.so.bfd: file format elf32-i386

DYNAMIC RELOCATION RECORDS
OFFSET   TYPE  VALUE
1eec R_386_RELATIVE*ABS*
1ef0 R_386_RELATIVE*ABS*
200c R_386_RELATIVE*ABS*
1efc R_386_32  typeinfo for Test@@Base
1f00 R_386_32  Test::f()@@Base
1f04 R_386_32  vtable for __cxxabiv1::__class_type_info@CXXABI_1.3
1f08 R_386_32  typeinfo name for Test@@Base
1fec R_386_GLOB_DAT__gmon_start__
1ff0 R_386_GLOB_DAT_Jv_RegisterClasses
1ff4 R_386_GLOB_DAT_ITM_deregisterTMCloneTable
1ff8 R_386_GLOB_DAT_ITM_registerTMCloneTable
1ffc R_386_GLOB_DAT__cxa_finalize@GLIBC_2.1.3


$ objdump -R --demangle libTest.so.gold

libTest.so.gold: file format elf32-i386

DYNAMIC RELOCATION RECORDS
OFFSET   TYPE  VALUE
1eb4 R_386_RELATIVE*ABS*
1eb8 R_386_RELATIVE*ABS*
200c R_386_RELATIVE*ABS*
1fe0 R_386_GLOB_DAT__gmon_start__
1fe4 R_386_GLOB_DAT_ITM_deregisterTMCloneTable
1fe8 R_386_GLOB_DAT_ITM_registerTMCloneTable
1fec R_386_GLOB_DAT__cxa_finalize@GLIBC_2.1.3
1ff0 R_386_GLOB_DAT_Jv_RegisterClasses
1ec8 R_386_32  vtable for __cxxabiv1::__class_type_info@CXXABI_1.3
1ec4 R_386_32  Test::f()@@Base
1ec0 R_386_32  typeinfo for Test@@Base
1ecc R_386_32  typeinfo name for Test@@Base
2000 R_386_JUMP_SLOT   __gmon_start__
2004 R_386_JUMP_SLOT   __cxa_finalize@GLIBC_2.1.3
2008 R_386_JUMP_SLOT   Test::f()@@Base


Note the additional R_386_JUMP_SLOT relocation for Test::f() in the library
generated by gold.

Tested with gold from binutils version 2.27, on i386.

$ ld.gold -v
GNU gold (version 2.27-41.base.el7_7.1) 1.12

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25637] New: objcopy : SIGSEGV in copy_object ( objcopy.c:3219 )

2020-03-05 Thread fdgkhdkgh at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25637

Bug ID: 25637
   Summary: objcopy : SIGSEGV in copy_object ( objcopy.c:3219 )
   Product: binutils
   Version: 2.35 (HEAD)
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: binutils
  Assignee: unassigned at sourceware dot org
  Reporter: fdgkhdkgh at gmail dot com
  Target Milestone: ---

Created attachment 12350
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12350&action=edit
file that reproduces this problem

binutils Version : HEAD
git clone git://sourceware.org/git/binutils-gdb.git

OS : ubuntu 18.04.3
kernel : gnu/linux 5.0.0-32-generic
processor : Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
compiler : gcc 7.4.0


Steps to Reproduce :
download the sample from attachment

objcopy -O  pei-i386  --change-leading-char ./sample 

Try to mov a byte to .text section, and trigger SIGSEGV.
Probably the similar bug in
https://sourceware.org/bugzilla/show_bug.cgi?id=25629


gdb backtrace : 

#0  copy_object (ibfd=0x558ac3c0, obfd=,
input_arch=) at objcopy.c:3219
#1  0x5558e159 in copy_file (input_filename=0x7fff2a40 "./sample", 
output_filename=0x7fff2a49 "./objoutput", input_target=,
output_target=, 
input_arch=0x0) at objcopy.c:3810
#2  0x55588210 in copy_main (argv=, argc=) at objcopy.c:5860
#3  main (argc=, argc@entry=0x6, argv=,
argv@entry=0x7fff2718) at objcopy.c:5986
#4  0x77801b97 in __libc_start_main (main=0x555865c0 ,
argc=0x6, argv=0x7fff2718, 
init=, fini=, rtld_fini=,
stack_end=0x7fff2708)
at ../csu/libc-start.c:310
#5  0x555890ba in _start ()



gdb peda report : 


Program received signal SIGSEGV, Segmentation fault.

[--registers---]
RAX: 0x5f ('_')
RBX: 0x558c1e40 --> 0x558ac3c0 --> 0x558ae740 ("./sample")
RCX: 0x558c7e90 --> 0x558c0ee0 --> 0x558ac3c0 --> 0x558ae740
("./sample")
RDX: 0x1 
RSI: 0x1f 
RDI: 0x558ac0c0 --> 0x55589320 (:  mov   
rdi,QWORD PTR [rdi])
RBP: 0x0 
RSP: 0x7fff2340 --> 0x558b68e8 --> 0x558c1e40 --> 0x558ac3c0
--> 0x558ae740 ("./sample")
RIP: 0x5558c1b1 (:movBYTE PTR [r12],al)
R8 : 0x558abcc0 --> 0x0 
R9 : 0x55673dc0 --> 0x249249250007 
R10: 0x6652751a 
R11: 0x2 
R12: 0x5565cfb0 --> 0x64697374756f2800 ('')
R13: 0xf 
R14: 0x0 
R15: 0x558b74d0 --> 0x558b7600 ("./objoutput")
EFLAGS: 0x10246 (carry PARITY adjust ZERO sign trap INTERRUPT direction
overflow)
[-code-]
   0x5558c1a5 :   xoreax,eax
   0x5558c1a7 :   call   0x5559f150

   0x5558c1ac :   jmp0x5558c122

=> 0x5558c1b1 :   movBYTE PTR [r12],al
   0x5558c1b5 :   movrbp,r12
   0x5558c1b8 :   movQWORD PTR [rbx+0x8],r12
   0x5558c1bc :   jmp0x5558bb37

   0x5558c1c1 :   movr13,QWORD PTR [r14+0x90]
[stack-]
| 0x7fff2340 --> 0x558b68e8 --> 0x558c1e40 --> 0x558ac3c0
--> 0x558ae740 ("./sample")
0008| 0x7fff2348 --> 0x3b62f6a54005 
0016| 0x7fff2350 --> 0x29 (')')
0024| 0x7fff2358 --> 0x558a0360 --> 0x55654c7a -->
0x432a002a5342412a ('*ABS*')
0032| 0x7fff2360 --> 0x558ac3c0 --> 0x558ae740 ("./sample")
0040| 0x7fff2368 --> 0x558b74d0 --> 0x558b7600 ("./objoutput")
0048| 0x7fff2370 --> 0x558b6a10 --> 0x0 
0056| 0x7fff2378 --> 0x558c7e90 --> 0x558c0ee0 --> 0x558ac3c0
--> 0x558ae740 ("./sample")
[--]
Legend: code, data, rodata, value
Stopped reason: SIGSEGV
copy_object (ibfd=0x558ac3c0, obfd=, input_arch=) at objcopy.c:3219

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-05 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

H.J. Lu  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #17 from H.J. Lu  ---
(In reply to Kaylee from comment #16)
> Created attachment 12348 [details]
> patch to add test for -z nosectionheader
> 
> This patch adds the test for it, based against your branch.

Please give my branch a try.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Issue 20451 in oss-fuzz: binutils:fuzz_disassemble: Undefined-shift in frv_cgen_extract_operand

2020-03-05 Thread sheriffbot via monorail
Updates:
Labels: -restrict-view-commit

Comment #3 on issue 20451 by sheriffbot: binutils:fuzz_disassemble: 
Undefined-shift in frv_cgen_extract_operand
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20451#c3

This bug has been fixed for 30 days. It has been opened to the public.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-05 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #18 from Kaylee  ---
I get uninitialised variable usage errors when I try to build it, in this
section of elf_link_is_defined_archive_symbol():

>   if (elf_bad_symtab (abfd))
> {
>   extsymcount = symcount;
>   extsymoff = 0;
> }
>   else
> {
>   extsymcount = symcount - hdr->sh_info;
>   extsymoff = hdr->sh_info;
> }

Looks like symcount and hdr aren't initialized if extsymcount was nonzero in
the previous conditional?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/22263] -fpie -pie generates dynamic relocations in text section

2020-03-05 Thread mforney at mforney dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=22263

Michael Forney  changed:

   What|Removed |Added

 CC||mforney at mforney dot org

--- Comment #22 from Michael Forney  ---
I believe riscv64 might have the same issue. I get the same error for the
example in the description, and the pr22263-1 test is failing (on current
master).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25637] objcopy : SIGSEGV in copy_object ( objcopy.c:3219 )

2020-03-05 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25637

--- Comment #1 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Alan Modra :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a9b90127e864d0cac1b7b803cb2af4eab01dbdab

commit a9b90127e864d0cac1b7b803cb2af4eab01dbdab
Author: Alan Modra 
Date:   Fri Mar 6 10:33:10 2020 +1030

PR25637, objcopy : SIGSEGV in copy_object

PR 25637
* objcopy.c (filter_symbols): Correct rem_leading_char logic.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25637] objcopy : SIGSEGV in copy_object ( objcopy.c:3219 )

2020-03-05 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25637

Alan Modra  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
   Assignee|unassigned at sourceware dot org   |amodra at gmail dot com

--- Comment #2 from Alan Modra  ---
A different cause to pr25629.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/23350] multiple prevailing defs for unused variable in lto mode

2020-03-05 Thread dobonachea at lbl dot gov
https://sourceware.org/bugzilla/show_bug.cgi?id=23350

Dan Bonachea  changed:

   What|Removed |Added

 CC||dobonachea at lbl dot gov

--- Comment #9 from Dan Bonachea  ---
We recently hit what appears to be this same problem with our software.

I stumbled upon a workaround, which is to declare one of the tentative
definitions as extern. Here's a demonstration applied to the code from comment
#6:

$ gcc --version
gcc (GCC) 9.2.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ tail *.c
==> lib.c <==
int wrl;
extern int a() { return 0; }


==> main.c <==
#ifdef WORKAROUND
extern int wrl;
#else
int wrl;
#endif

int main () { return 0; }

$ gcc -c -flto main.c && gcc -c -flto lib.c && gcc-ar rusc lib.a lib.o && gcc
-flto main.o lib.a lib.a 
lto1: fatal error: multiple prevailing defs for 'a'
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status

$ gcc -DWORKAROUND -c -flto main.c && gcc -c -flto lib.c && gcc-ar rusc lib.a
lib.o && gcc -flto main.o lib.a lib.a

In our case we are always providing a common-block definition from inside the
library, so the workaround just meant declaring as extern in the library header
file which is the declaration client objects see. Probably not applicable to
all situations, but good enough to solve our problem.

Hope this helps..

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25491] binutils 2.34 tarball requires makeinfo

2020-03-05 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25491

Alan Modra  changed:

   What|Removed |Added

 CC||amodra at gmail dot com,
   ||simon.marchi at polymtl dot ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-05 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #19 from H.J. Lu  ---
(In reply to Kaylee from comment #18)
> I get uninitialised variable usage errors when I try to build it, in this
> section of elf_link_is_defined_archive_symbol():
> 
> >   if (elf_bad_symtab (abfd))
> > {
> >   extsymcount = symcount;
> >   extsymoff = 0;
> > }
> >   else
> > {
> >   extsymcount = symcount - hdr->sh_info;
> >   extsymoff = hdr->sh_info;
> > }
> 
> Looks like symcount and hdr aren't initialized if extsymcount was nonzero in
> the previous conditional?

Please try again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gold/25617] Gold looks up shared object information in section headers instead of the dynamic array

2020-03-05 Thread klkblake at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25617

--- Comment #20 from Kaylee  ---
Works for me now!

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25630] BFD assertion failure at elf32-xtensa.c:3288 in elf_xtensa_finish_dynamic_sections

2020-03-05 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25630

--- Comment #1 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Max Filippov :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e15a8da9c71336b06cb5f2706c3f6b7e6ddd95a3

commit e15a8da9c71336b06cb5f2706c3f6b7e6ddd95a3
Author: Max Filippov 
Date:   Wed Mar 4 14:54:27 2020 -0800

bfd: xtensa: fix PR ld/25630

bfd/
2020-03-05  Max Filippov  

* elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
relocation sections for any removed reference to a dynamic symbol.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25630] BFD assertion failure at elf32-xtensa.c:3288 in elf_xtensa_finish_dynamic_sections

2020-03-05 Thread jcmvbkbc at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25630

jcmvbkbc at gcc dot gnu.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from jcmvbkbc at gcc dot gnu.org ---
Fixed in the master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25572] /dev/null should be excluded from 'files are the same' check

2020-03-05 Thread masahiroy at kernel dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=25572

--- Comment #3 from Masahiro Yamada  ---
Hi Nick,

Worked for me.

Tested-by: Masahiro Yamada 

-- 
You are receiving this mail because:
You are on the CC list for the bug.