Proposed patch to release 2.29.1 regarding --localedir configure option
Hello, Basically if you configure && make && make install with --localedir option set installer does not copy some share/locale files in the requested tree. Attached, you can find out my proposal for fixing that issue. Best regards, Ștefan diff -crB binutils-2.29.1/bfd/po/Make-in binutils_patched/bfd/po/Make-in *** binutils-2.29.1/bfd/po/Make-in 2017-07-10 12:54:41.0 +0300 --- binutils_patched/bfd/po/Make-in 2017-11-08 14:38:26.0 +0200 *** *** 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = $(prefix)/@DATADIRNAME@ ! localedir = $(datadir)/locale ! gnulocaledir = $(prefix)/share/locale ! gettextsrcdir = $(prefix)/share/gettext/po subdir = po DESTDIR = --- 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = @datadir@ ! localedir = @localedir@ ! gnulocaledir = @datarootdir@/locale ! gettextsrcdir = @datarootdir@/gettext/po subdir = po DESTDIR = diff -crB binutils-2.29.1/binutils/po/Make-in binutils_patched/binutils/po/Make-in *** binutils-2.29.1/binutils/po/Make-in 2017-07-10 12:54:41.0 +0300 --- binutils_patched/binutils/po/Make-in 2017-11-08 14:38:14.0 +0200 *** *** 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = $(prefix)/@DATADIRNAME@ ! localedir = $(datadir)/locale ! gnulocaledir = $(prefix)/share/locale ! gettextsrcdir = $(prefix)/share/gettext/po subdir = po DESTDIR = --- 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = @datadir@ ! localedir = @localedir@ ! gnulocaledir = @datarootdir@/locale ! gettextsrcdir = @datarootdir@/gettext/po subdir = po DESTDIR = diff -crB binutils-2.29.1/gas/po/Make-in binutils_patched/gas/po/Make-in *** binutils-2.29.1/gas/po/Make-in 2017-07-10 12:54:41.0 +0300 --- binutils_patched/gas/po/Make-in 2017-11-08 14:37:48.0 +0200 *** *** 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = $(prefix)/@DATADIRNAME@ ! localedir = $(datadir)/locale ! gnulocaledir = $(prefix)/share/locale ! gettextsrcdir = $(prefix)/share/gettext/po subdir = po DESTDIR = --- 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = @datadir@ ! localedir = @localedir@ ! gnulocaledir = @datarootdir@/locale ! gettextsrcdir = @datarootdir@/gettext/po subdir = po DESTDIR = diff -crB binutils-2.29.1/gold/po/Make-in binutils_patched/gold/po/Make-in *** binutils-2.29.1/gold/po/Make-in 2017-07-10 12:54:42.0 +0300 --- binutils_patched/gold/po/Make-in 2017-11-08 14:39:59.0 +0200 *** *** 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = $(prefix)/@DATADIRNAME@ ! localedir = $(datadir)/locale ! gnulocaledir = $(prefix)/share/locale ! gettextsrcdir = $(prefix)/share/gettext/po subdir = po DESTDIR = --- 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = @datadir@ ! localedir = @localedir@ ! gnulocaledir = @datarootdir@/locale ! gettextsrcdir = @datarootdir@/gettext/po subdir = po DESTDIR = diff -crB binutils-2.29.1/gprof/po/Make-in binutils_patched/gprof/po/Make-in *** binutils-2.29.1/gprof/po/Make-in 2017-07-10 12:54:42.0 +0300 --- binutils_patched/gprof/po/Make-in 2017-11-08 14:40:11.0 +0200 *** *** 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = $(prefix)/@DATADIRNAME@ ! localedir = $(datadir)/locale ! gnulocaledir = $(prefix)/share/locale ! gettextsrcdir = $(prefix)/share/gettext/po subdir = po DESTDIR = --- 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = @datadir@ ! localedir = @localedir@ ! gnulocaledir = @datarootdir@/locale ! gettextsrcdir = @datarootdir@/gettext/po subdir = po DESTDIR = diff -crB binutils-2.29.1/ld/po/Make-in binutils_patched/ld/po/Make-in *** binutils-2.29.1/ld/po/Make-in 2017-07-10 12:54:42.0 +0300 --- binutils_patched/ld/po/Make-in 2017-11-08 14:40:25.0 +0200 *** *** 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = $(prefix)/@DATADIRNAME@ ! localedir = $(datadir)/locale ! gnulocaledir = $(prefix)/share/locale ! gettextsrcdir = $(prefix)/share/gettext/po subdir = po DESTDIR = --- 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = @datadir@ ! localedir = @localedir@ ! gnulocaledir = @datarootdir@/locale ! gettextsrcdir = @datarootdir@/gettext/po subdir = po DESTDIR = diff -crB binutils-2.29.1/opcodes/po/Make-in binutils_patched/opcodes/po/Make-in *** binutils-2.29.1/opcodes/po/Make-in 2017-07-10 12:54:42.0 +0300 --- binutils_patched/opcodes/po/Make-in 2017-11-08 14:38:00.0 +0200 *** *** 20,29 prefix = @prefix@ exec_prefix = @exec_prefix@ ! datadir = $(prefix)/@DATADIRNAME@ ! localedir = $(datadir)/locale ! gnulocaledir = $(prefix)/share/locale ! gettextsrcdir = $(prefix)/share/gettext/po subdir =
[Bug gold/19291] constant strings still don't always get relocated properly in a relocatable built with gold --script
https://sourceware.org/bugzilla/show_bug.cgi?id=19291 --- Comment #4 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Cary Coutant : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=333d0055f6f162c334c36f1946b6fcdb5c92b681 commit 333d0055f6f162c334c36f1946b6fcdb5c92b681 Author: James Clarke Date: Wed Nov 8 15:13:53 2017 -0800 Fix problems with -r. The fix committed for PR gold/19291 ended up breaking other cases. The commit added adjustment code to write_local_symbols, but in many cases compute_final_local_value_internal had already subtracted the output section's address. To fix this, all other adjustments are now removed, so only the one in write_local_symbols is left. gold/ PR gold/22266 * object.cc (Sized_relobj_file::compute_final_local_value_internal): Drop relocatable parameter and stop adjusting output value based on it. (Sized_relobj_file::compute_final_local_value): Stop passing relocatable to compute_final_local_value_internal. (Sized_relobj_file::do_finalize_local_symbols): Ditto. * object.h (Sized_relobj_file::compute_final_local_value_internal): Drop relocatable parameter. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/22266] ld.gold produces invalid output when linking with --relocatable
https://sourceware.org/bugzilla/show_bug.cgi?id=22266 --- Comment #3 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Cary Coutant : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=333d0055f6f162c334c36f1946b6fcdb5c92b681 commit 333d0055f6f162c334c36f1946b6fcdb5c92b681 Author: James Clarke Date: Wed Nov 8 15:13:53 2017 -0800 Fix problems with -r. The fix committed for PR gold/19291 ended up breaking other cases. The commit added adjustment code to write_local_symbols, but in many cases compute_final_local_value_internal had already subtracted the output section's address. To fix this, all other adjustments are now removed, so only the one in write_local_symbols is left. gold/ PR gold/22266 * object.cc (Sized_relobj_file::compute_final_local_value_internal): Drop relocatable parameter and stop adjusting output value based on it. (Sized_relobj_file::compute_final_local_value): Stop passing relocatable to compute_final_local_value_internal. (Sized_relobj_file::do_finalize_local_symbols): Ditto. * object.h (Sized_relobj_file::compute_final_local_value_internal): Drop relocatable parameter. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/22266] ld.gold produces invalid output when linking with --relocatable
https://sourceware.org/bugzilla/show_bug.cgi?id=22266 Cary Coutant changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Cary Coutant --- Fixed on master branch. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/22291] GOLD silently produces an nonworking dynamic executable
https://sourceware.org/bugzilla/show_bug.cgi?id=22291 --- Comment #4 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by H.J. Lu : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dc8d2d90da3f191ae0461900ab98e3b29cc2b280 commit dc8d2d90da3f191ae0461900ab98e3b29cc2b280 Author: H.J. Lu Date: Wed Nov 8 15:56:54 2017 -0800 gold: Ignore def/ref from a dynamic object for special symbols Since special symbol must be defined in a regular object, definition from a dynamic object should be ignored. If special symbol has the hidden or internal visibility, reference from a dynamic object should also be ignored. Also __start and __stop symbols in a dynamic object shouldn't be preempted. PR gold/22291 * layout.cc (Layout::define_section_symbols): Use STV_PROTECTED for __start and __stop symbols. * symtab.cc (Symbol_table::define_special_symbol): Add an argument, visibility. Ignore definition and reference from a dynamic object, depending on visibility. (Symbol_table::do_define_in_output_data): Pass visibility to define_special_symbol. (Symbol_table::do_define_in_output_segment): Likewise. (Symbol_table::do_define_as_constant): Likewise. (Symbol_table::add_undefined_symbol_from_command_line): Pass STV_DEFAULT to define_special_symbol. * symtab.h (Symbol_table::define_special_symbol): Add an argument, visibility. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/22291] GOLD silently produces an nonworking dynamic executable
https://sourceware.org/bugzilla/show_bug.cgi?id=22291 H.J. Lu changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Target Milestone|--- |2.30 --- Comment #5 from H.J. Lu --- Fixed for 2.30. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
